[PATCH] D114312: libfuzzer: Disable broken tests for arm

manojgupta created this revision. manojgupta added reviewers: morehouse, metzman. Herald added a subscriber: kristof.beyls. manojgupta requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. libfuzzer was recently enabled for Arm32 in D112091

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

davrec added a comment. Looks good, a few notes. Comment at: clang/include/clang/AST/ASTContext.h:1559 + QualType getUsingType(const NamedDecl *Found, QualType Underlying) const; + I believe you mentioned ObjC considerations might require expanding beyond

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

flx added a comment. Thank you for catching and fixing this! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:97 + cxxOperatorCallExpr(callee(MethodDecl), hasArgument(0, ReceiverExpr), + hasArgument(0,

[PATCH] D107944: [hmaptool] Port to python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd4dc4f2854: [hmaptool] Port to python3 (authored by lanza). Changed prior to commit: https://reviews.llvm.org/D107944?vs=388568=388668#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1bd4dc4 - [hmaptool] Port to python3

Author: Nathan Lanza Date: 2021-11-19T19:25:31-05:00 New Revision: 1bd4dc4f2854edf3035732416ec7e4adbddaf982 URL: https://github.com/llvm/llvm-project/commit/1bd4dc4f2854edf3035732416ec7e4adbddaf982 DIFF: https://github.com/llvm/llvm-project/commit/1bd4dc4f2854edf3035732416ec7e4adbddaf982.diff

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff created this revision. fwolff added reviewers: Eugene.Zelenko, alexfh, Szelethus. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#48086

[clang-tools-extra] f764a1a - [clangd] Avoid possible crash: apply configuration after binding methods

Author: Sam McCall Date: 2021-11-20T01:13:38+01:00 New Revision: f764a1a5bd7c281d3d7cc3c6d7f1430711176762 URL: https://github.com/llvm/llvm-project/commit/f764a1a5bd7c281d3d7cc3c6d7f1430711176762 DIFF: https://github.com/llvm/llvm-project/commit/f764a1a5bd7c281d3d7cc3c6d7f1430711176762.diff

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde11de308b64: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment (authored by ellis, committed by kyulee). Repository: rG

[clang] de11de3 - [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

Author: Ellis Hoag Date: 2021-11-19T15:45:14-08:00 New Revision: de11de308b6480fc35d901c7104f46918674418c URL: https://github.com/llvm/llvm-project/commit/de11de308b6480fc35d901c7104f46918674418c DIFF: https://github.com/llvm/llvm-project/commit/de11de308b6480fc35d901c7104f46918674418c.diff

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis updated this revision to Diff 388652. ellis added a comment. Remove register names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114268/new/ https://reviews.llvm.org/D114268 Files: clang/test/CodeGen/profile-filter.c

[PATCH] D107944: [hmaptool] Port to python3

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107944/new/ https://reviews.llvm.org/D107944 ___ cfe-commits mailing list

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff created this revision. fwolff added reviewers: alexfh, whisperity, hokein. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51620

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis added a comment. In D114268#3143976 , @MaskRay wrote: >> Add names to pgo registers for clarity. > > This may increase memory usage, especially for large LTO applications. Unless > this is very helpful I might omit it. I'll omit it. Thanks for

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > Add names to pgo registers for clarity. This may increase memory usage. Unless this is very helpful I might omit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the fix! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:108 + // Some expressions might be not resolved yet due to ADL: conservatively mark +

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG

[clang] a075d67 - [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

Author: Wei Wang Date: 2021-11-19T13:22:07-08:00 New Revision: a075d67222832c234296ffd605f19e33023e6060 URL: https://github.com/llvm/llvm-project/commit/a075d67222832c234296ffd605f19e33023e6060 DIFF: https://github.com/llvm/llvm-project/commit/a075d67222832c234296ffd605f19e33023e6060.diff

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

This revision was automatically updated to reflect the committed changes. Closed by commit rGa075d6722283: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType (authored by weiwang). Changed prior to commit: https://reviews.llvm.org/D112481?vs=382375=388616#toc

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

dexonsmith added a reviewer: arphaman. dexonsmith added a subscriber: arphaman. dexonsmith added a comment. This revision now requires review to proceed. @arphaman , can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/

[clang] 290cddc - Allow __attribute__((swift_attr)) in attribute push pragmas

Author: Becca Royal-Gordon Date: 2021-11-19T13:00:26-08:00 New Revision: 290cddcd139d668251821f11426f37481faf6d7f URL: https://github.com/llvm/llvm-project/commit/290cddcd139d668251821f11426f37481faf6d7f DIFF:

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax, committed by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman added a comment. I will commit this on behalf of @beccadax as she doesn't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 ___

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 388588. michaelrj marked 3 inline comments as done. michaelrj added a comment. address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e5a0c42bd8: [clang][NFC] Inclusive terms: replace some uses of sanity in clang (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D114025?vs=388550=388587#toc Repository: rG

[clang] d8e5a0c - [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Author: Zarko Todorovski Date: 2021-11-19T14:58:35-05:00 New Revision: d8e5a0c42bd8796cce9caa53aacab88c7cb2a3eb URL: https://github.com/llvm/llvm-project/commit/d8e5a0c42bd8796cce9caa53aacab88c7cb2a3eb DIFF:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Thanks @aaron.ballman and @Quuxplusone for the constructive reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

HazardyKnusperkeks added a comment. In D114142#3142122 , @MyDeveloperDay wrote: >> I only now this from the tests with `-debug`. Is there a way to get "normal" >> clang-format to print these? Or did you write a test for that to print the >>

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: Does the `Dynamic` in the

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added inline comments. Comment at: clang/include/clang/AST/Type.h:4372 +class UsingType : public Type, public llvm::FoldingSetNode { + QualType UnderlyingTy; + NamedDecl *Found; Hmm, maybe I should be getting this from Found, rather than storing it.

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

xazax.hun added a comment. Thanks for working on this! Publishing documentation alongside the feature is a great practice. I liked this documentation a lot. I have strong opinion about the ambiguous use of `path condition` in this document, otherwise I was only nitpicking.

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

zahiraam added a comment. Added in the sycl_special_class attribute. This is still work in progress as I still have a few LIT tests failing and didn't address the issue of the separating sema from codegen work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:873 RECORD(PP_TOKEN); + RECORD(PP_INCLUDED_FILES); I believe `PP_INCLUDED_FILES` is located in `AST_BLOCK`. Yes, you write it in `ASTWriter::WritePreprocessor` but after

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis created this revision. Herald added subscribers: wenlei, arphaman, hiraditya. ellis updated this revision to Diff 388564. ellis added a comment. ellis edited the summary of this revision. ellis added a reviewer: MaskRay. ellis retitled this revision from "[InstrProf] Use i32 for GEP index"

[PATCH] D107944: [hmaptool] Port to python3

lanza updated this revision to Diff 388568. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107944/new/ https://reviews.llvm.org/D107944 Files: clang/utils/hmaptool/hmaptool Index: clang/utils/hmaptool/hmaptool === ---

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov added a comment. In D114006#3142313 , @martong wrote: > LGTM! Thanks, guys! I'll load it as soon as D110927 also be ready for load(I'm working on it), as this patch is just a preparatory one. CHANGES

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov updated this revision to Diff 388552. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validation

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388550. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. - Address latest round of comments - Fix unrelated formatting to stop distracting clang-format linter complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay added inline comments. Comment at: clang/docs/ClangPlugins.rst:131 + +The clang compiler driver accepts the `fplugin` option to load a plugin. +Clang plugins can receive arguments from the compiler driver command Comment at:

[clang] d5de568 - [analyzer][NFC] MaybeUInt -> MaybeCount

Author: Balazs Benics Date: 2021-11-19T18:36:55+01:00 New Revision: d5de568cc7375281b14bd2632576bff7f4afabc3 URL: https://github.com/llvm/llvm-project/commit/d5de568cc7375281b14bd2632576bff7f4afabc3 DIFF: https://github.com/llvm/llvm-project/commit/d5de568cc7375281b14bd2632576bff7f4afabc3.diff

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

bgraur added a comment. Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing seeing an almost 20x increase in compilation times for some files (from 42s to 728s). I'm working on a reproducer which I'm going to

[PATCH] D113595: [analyzer][NFC] Use enum for CallDescription flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ef134f3c77: [analyzer][NFC] Use enum for CallDescription flags (authored by steakhal). Herald added a project: clang. Herald added a subscriber:

[PATCH] D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97f1bf15b154: [analyzer][NFC] Consolidate the inner representation of CallDescriptions (authored by steakhal). Herald added a project: clang. Herald

[PATCH] D113593: [analyzer][NFC] CallDescription should own the qualified name parts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde9d7e42aca2: [analyzer][NFC] CallDescription should own the qualified name parts (authored by steakhal). Herald added a project: clang. Herald

[PATCH] D113592: [analyzer][NFC] Demonstrate the use of CallDescriptionSet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad0a90baa8c: [analyzer][NFC] Demonstrate the use of CallDescriptionSet (authored by steakhal). Herald added a project: clang. Herald added a

[PATCH] D113591: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf18da190b0db: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled() (authored by steakhal). Herald added a project:

[PATCH] D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c512703a9e6: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled() (authored by steakhal). Herald added a project: clang.

[PATCH] D113589: [analyzer][NFC] Introduce CallDescriptionSets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd448fcd9b223: [analyzer][NFC] Introduce CallDescriptionSets (authored by steakhal). Herald added a project: clang. Herald added a subscriber:

[clang] e6ef134 - [analyzer][NFC] Use enum for CallDescription flags

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: e6ef134f3c77005438f9fb7c1d17d3c30747844e URL: https://github.com/llvm/llvm-project/commit/e6ef134f3c77005438f9fb7c1d17d3c30747844e DIFF: https://github.com/llvm/llvm-project/commit/e6ef134f3c77005438f9fb7c1d17d3c30747844e.diff

[clang] 97f1bf1 - [analyzer][NFC] Consolidate the inner representation of CallDescriptions

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 97f1bf15b154ef32608fe17b82f2f312401d150c URL: https://github.com/llvm/llvm-project/commit/97f1bf15b154ef32608fe17b82f2f312401d150c DIFF: https://github.com/llvm/llvm-project/commit/97f1bf15b154ef32608fe17b82f2f312401d150c.diff

[clang] de9d7e4 - [analyzer][NFC] CallDescription should own the qualified name parts

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: de9d7e42aca29920e9918ecaed4ad9c45fa673f1 URL: https://github.com/llvm/llvm-project/commit/de9d7e42aca29920e9918ecaed4ad9c45fa673f1 DIFF: https://github.com/llvm/llvm-project/commit/de9d7e42aca29920e9918ecaed4ad9c45fa673f1.diff

[clang] 9ad0a90 - [analyzer][NFC] Demonstrate the use of CallDescriptionSet

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 9ad0a90baa8ca8067fe65086056fffd083c86796 URL: https://github.com/llvm/llvm-project/commit/9ad0a90baa8ca8067fe65086056fffd083c86796 DIFF: https://github.com/llvm/llvm-project/commit/9ad0a90baa8ca8067fe65086056fffd083c86796.diff

[clang] f18da19 - [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled()

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: f18da190b0dba817d33ccd7727537f12304d8125 URL: https://github.com/llvm/llvm-project/commit/f18da190b0dba817d33ccd7727537f12304d8125 DIFF: https://github.com/llvm/llvm-project/commit/f18da190b0dba817d33ccd7727537f12304d8125.diff

[clang] 6c51270 - [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled()

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 6c512703a9e6e495afa0f44528821c27f28db795 URL: https://github.com/llvm/llvm-project/commit/6c512703a9e6e495afa0f44528821c27f28db795 DIFF: https://github.com/llvm/llvm-project/commit/6c512703a9e6e495afa0f44528821c27f28db795.diff

[clang] d448fcd - [analyzer][NFC] Introduce CallDescriptionSets

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: d448fcd9b2238377dd8832ce9e35a37b59ef5aeb URL: https://github.com/llvm/llvm-project/commit/d448fcd9b2238377dd8832ce9e35a37b59ef5aeb DIFF: https://github.com/llvm/llvm-project/commit/d448fcd9b2238377dd8832ce9e35a37b59ef5aeb.diff

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal created this revision. steakhal added reviewers: ffrankies, aaron.ballman, alexfh, njames93. Herald added subscribers: carlosgalvezp, martong, xazax.hun. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

steakhal created this revision. steakhal added reviewers: aaron.ballman, njames93, klimek, alexfh. Herald added subscribers: carlosgalvezp, martong, xazax.hun. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Invalid

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

alexfh added subscribers: cfe-commits, alexfh, bgraur. BRANCHES main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 388512. ASDenysPetrov added a comment. Fixed missed part during rebasing in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files:

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

peter.smith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); + return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 || + (Ver == 6 && Triple.isARM());

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info-block-helper.m

quinnp updated this revision to Diff 388511. quinnp added a comment. Changing master to controller in another testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114108/new/ https://reviews.llvm.org/D114108 Files:

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, martong. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. WIP: - needs tests of new functionality - doesn't

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added a comment. (Re repeated thanks: You're welcome. :) For the record, I personally see nothing wrong with the phrase "sanity-check" either; but given that it's gonna happen, and we're re-wording comments on by definition the subtlest and most confusing parts of the code, I'm

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

steakhal added a comment. Great news, thanks. Comment at: clang/test/Analysis/svalbuilder-simplify-intsym.cpp:18 +return; + clang_analyzer_eval(x == 77); // expected-warning{{TRUE}} + (void)(x * y); extra spaces? Repository: rG LLVM Github

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet created this revision. courbet added reviewers: flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. courbet requested review of this revision. Herald added a project: clang-tools-extra. `isConstRefReturningMethodCall` should be considering `CXXOperatorCallExpr` in

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tejohnson added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:558 assert(!Inputs.empty() && "Must have at least one input."); addLTOOptions(ToolChain, Args, CmdArgs, Output, Inputs[0], D.getLTOMode() == LTOK_Thin);

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Quuxplusone added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3235 +if (Left.is(TT_ModulePartitionColon) && +Right.isOneOf(tok::identifier, tok::kw_public, tok::kw_private)) + return false; owenpan wrote: > Is `module

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3226 +// No space between module :. +if (Left.isOneOf(Keywords.kw_module, tok::kw_export, Keywords.kw_import) && +Right.is(TT_ModulePartitionColon)) You can remove

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

martong added a comment. In D113754#3127245 , @steakhal wrote: > Great stuff. Have you checked the coverage? Thanks for the review! So, here are the coverage results for the new test file: 1186 2 : SVal VisitIntSymExpr(const IntSymExpr

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388494. ZarkoCA added a comment. - Add FIXME to comments and fix grammar on one comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. In D114025#3142565 , @aaron.ballman wrote: > In D114025#3141414 , @keryell wrote: > >> In D114025#3140192

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388490. sgatev added a comment. Add using namespace declarations in the cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D113540: [OpenMP] support depend clause for taskwait directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80256605f8c6: [OpenMP] support depend clause for taskwait directive, by Deepak (authored by ABataev). Herald added projects: clang, OpenMP. Herald

[clang] 8025660 - [OpenMP] support depend clause for taskwait directive, by Deepak

Author: Alexey Bataev Date: 2021-11-19T06:30:17-08:00 New Revision: 80256605f8c6aab8cb33ac3a3784aacd005087a3 URL: https://github.com/llvm/llvm-project/commit/80256605f8c6aab8cb33ac3a3784aacd005087a3 DIFF: https://github.com/llvm/llvm-project/commit/80256605f8c6aab8cb33ac3a3784aacd005087a3.diff

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tbaeder added a comment. The test failures are pretty obvious about when this fails. All affected builds have an implicit dependency on the `LLVMgold.so` like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114229/new/

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysis.cpp:21-22 + +namespace clang { +namespace dataflow { + It's more common in .cpp files to use using declarations instead: ``` using clang; using dataflow; ```

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. rG6623c02d70c3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the Windows crash gets resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 388481. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h

[clang] 6623c02 - The _Float16 type is supported on x86 systems with SSE2 enabled.

Author: Zahira Ammarguellat Date: 2021-11-19T08:59:50-05:00 New Revision: 6623c02d70c3732dbea59c6d79c69501baf9627b URL: https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b DIFF:

[clang] c227192 - Make clang-format fuzz through Lexing with asserts enabled.

Author: Manuel Klimek Date: 2021-11-19T14:44:06+01:00 New Revision: c2271926a4fc395e05cf75a8e57c2dfab1f02d3d URL: https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d DIFF: https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d.diff

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. In D114025#3141414 , @keryell wrote: > In D114025#3140192 , @Quuxplusone > wrote: > >> I think "sanity-check" could be reasonably replaced

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388469. sgatev added a comment. Use triple slash at the start of declaration comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388465. sgatev added a comment. Fix ifndefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme created this revision. mboehme added a reviewer: aaron.ballman. mboehme added a project: clang. mboehme requested review of this revision. Herald added a subscriber: cfe-commits. A typical use case would be to allow custom attributes for pointer types. See

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 388461. kbobyrev added a comment. Add improvements for identifier trigram generation and make query & id generators consistent with each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev created this revision. sgatev added reviewers: ymandel, NoQ, xazax.hun, gribozavr. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113401: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf55b9f0d0e9: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] bf55b9f - [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker

Author: Balazs Benics Date: 2021-11-19T11:59:46+01:00 New Revision: bf55b9f0d0e938def5d24629325b271cbfc3b04a URL: https://github.com/llvm/llvm-project/commit/bf55b9f0d0e938def5d24629325b271cbfc3b04a DIFF: https://github.com/llvm/llvm-project/commit/bf55b9f0d0e938def5d24629325b271cbfc3b04a.diff

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

martong added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:102 } - } else if (isa(Parent)) { + } else if (isa(Parent) || isa(Parent)) { +if (!Cast->IgnoreParenImpCasts()->isEvaluatable(C.getASTContext())) { CHANGES

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

martong added a comment. @whisperity Thank you for pinging! This seems still feasible. Besides, this is valuable for us, as it could pass some SEI CERT test cases, notably from INT31

[PATCH] D113668: [ASTImporter][NFC] Dump decl name at assertion violation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3753ad77450: [ASTImporter][NFC] Dump decl name at assertion violation (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] f3753ad - [ASTImporter][NFC] Dump decl name at assertion violation

Author: Balazs Benics Date: 2021-11-19T11:31:01+01:00 New Revision: f3753ad774506804ef5df065b48268712bdaa554 URL: https://github.com/llvm/llvm-project/commit/f3753ad774506804ef5df065b48268712bdaa554 DIFF: https://github.com/llvm/llvm-project/commit/f3753ad774506804ef5df065b48268712bdaa554.diff

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

steakhal added a comment. ping Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:288 +protected: + virtual CONCAT(~Foo, Bar2()); // no-fixit +}; whisperity wrote: > whisperity wrote: > > It is strange that

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks @balazske for updating the tests, I think this addresses @shafik 's questions. LGTM! Ping @shafik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

martong accepted this revision. martong added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tbaeder created this revision. tbaeder added reviewers: MaskRay, fhahn, tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is what the GCC driver does

  1   2   >