[PATCH] D114505: [clang][unittests]Fix a clang unittest linking issue

SixWeining created this revision. SixWeining added reviewers: cfe-commits, dexonsmith. Herald added a subscriber: mgorny. SixWeining requested review of this revision. Herald added a project: clang. Currently the clang/unittests/Basic/CMakeLists.txt links LLVMTestingSupport in an incorrect way

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. > it is likely that the options were tuned, but most likely only for a single > check. Yes, if the alias check has a different configuration than the primary check then they are considered as "different" checks (as they should be, since they produce potentially

[clang-tools-extra] ba4411e - [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

Author: Clement Courbet Date: 2021-11-24T08:07:21+01:00 New Revision: ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b URL: https://github.com/llvm/llvm-project/commit/ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b DIFF:

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4411e7c6a5: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative. (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know of your email address (for commit attribution) if you want me to land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok created this revision. alok added reviewers: aprantl, djtodoro. alok added a project: debug-info. Herald added subscribers: pengfei, guansong, yaxunl. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D114497: [Driver] Stop adding stdlib paths in -ffreestanding

lichray updated this revision to Diff 389391. lichray added a comment. Herald added subscribers: kbarton, nemanjai. - Adapt tests instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114497/new/ https://reviews.llvm.org/D114497 Files:

[PATCH] D114394: Compile-time computation of string attribute hashes

mehdi_amini added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:125 FoldingSetNodeID ID; - ID.AddString(Kind); + ID.AddString(Kind.value()); if (!Val.empty()) ID.AddString(Val); Carrying over my comment from the original revision: it seem that

[PATCH] D114497: [Driver] Stop adding stdlib paths in -ffreestanding

MaskRay added a comment. GCC -ffreestanding doesn't change libstdc++ search paths. Clang's behavior matches GCC. To drop /usr/include/c++/v1, you need -nostdinc++. If you want to drop /usr/include etc, you need to specify --sysroot= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114497: [Driver] Stop adding stdlib paths in -ffreestanding

lichray created this revision. Herald added subscribers: krytarowski, arichardson, emaste. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting FreeBSD on a Linux host with a copy of system libc++, Clang prepends

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai updated this revision to Diff 389379. vsapsai added a comment. Mark identifiers as out-of-date not only on loading a new module but on making a (sub)module visible too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114411/new/

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114394: Compile-time computation of string attribute hashes

MaskRay added inline comments. Comment at: llvm/lib/IR/AttributeImpl.h:214 - DenseMap StringAttrs; + std::unordered_map StringAttrs; std::unordered_map is inefficient. Why is this change? Comment at: llvm/lib/IR/Attributes.cpp:862 +

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai updated this revision to Diff 389374. vsapsai added a comment. Fix some failing tests to demonstrate the magnitued of changes better. In some places check if a decl is deserialized successfully as it's not guaranteed. Also tried to make sure a module is marked as visible *before* we try

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1057 + nextToken(); + do { +if (FormatTok->is(tok::colon)) { A `while (!eof())` or `while (FormatTok->isNot(tok::eof)` would be safer here just in case the last line is

[PATCH] D112913: Misleading bidirectional detection

MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:49 + if (C == '\n' || C == '\r' || C == '\f' || C == '\v' || + C == 0x85 /*next line*/) +EmbeddingOverride = Isolate = 0; `/*next

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

junparser added a reverting change: rG07333810caee: Revert "Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default…. BRANCHES EmptyLineAfterFunctionDefinition, fix_asan, main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. Your builtin is using custom type-checking (`t`), which suppresses all the normal conversions that happen on expressions. Specifically, it skips lvalue-to-rvalue conversion, so in this example the argument ends up being an l-value reference to a variable rather than

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

junparser added a comment. In rGc93f93b2e3f28997f794265089fb8138dd5b5f13#1040054 , @lkail wrote: > Looks a more general way should be implemented in tailduplicator to avoid > adding quadratic edges in CFGs. yep，

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 389355. mbenfield added a comment. Error on member function. Test case for this. Test case for attribute applied to a non-function declaration. Handle variadic functions. Document this. Test case for variadic functions. Remove const from some local

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:208 +if (UnaryOp->getOpcode() == UnaryOperator::Opcode::UO_AddrOf) + E = UnaryOp->getSubExpr(); + rjmccall wrote: > samitolvanen wrote: > > rjmccall wrote: > > >

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen updated this revision to Diff 389346. samitolvanen added a comment. Changed the code to evaluate the argument as a constant expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/ https://reviews.llvm.org/D108479 Files:

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

stevewan created this revision. Herald added a subscriber: yaxunl. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX doesn't support GPU. There is no point testing HIP on it. Repository: rG LLVM Github Monorepo

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc added a comment. Made suggested changes, ready for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 ___ cfe-commits mailing

[PATCH] D114483: Add support for sycl_special_class attribute

zahiraam created this revision. zahiraam added reviewers: bader, Naghasan, keryell, Fznamznon, aaron.ballman, erichkeane. Herald added subscribers: jdoerfert, Anastasia, ebevhan, yaxunl. zahiraam requested review of this revision. Herald added a project: clang. Special classes such as accessor,

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389334. sheldonneuberger-sc added a comment. - revert whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files:

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389333. sheldonneuberger-sc added a comment. - inline test helper for readability - fix indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The PCH reader looks for `__clangast` section in the precompiled module file, which is not present in the file on AIX, and we don't support writing

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

lebedev.ri added a comment. Thank you for looking into it! In D114317#3149693 , @carlosgalvezp wrote: > In D114317#3149504 , > @salman-javed-nz wrote: > >> What would you say are the key differences between

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3128840 , @rsmith wrote: > I also wonder whether we should accept `decltype(auto)(x)` as an extension, > but we can discuss that separately. Implemented. To produce a reference rather than a temporary, I had to

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3128835 , @rsmith wrote: > It looks like we'll need some additional work on disambiguation to handle > cases like: > > struct A { int n; } a; > void f() { auto()->n = 0; } > > I think that's valid, but right now

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

martong edited reviewers, added: steakhal; removed: vsavchenko. martong added a comment. vsavchenko is inactive, presumably he is no longer working with CSA Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 389305. MaskRay added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 389304. lichray added a comment. - Implement decltype(auto)(x) as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. In D114317#3149504 , @salman-javed-nz wrote: > What would you say are the key differences between this patch differ and > previous attempts, e.g. https://reviews.llvm.org/D72566? How does this patch > address the

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:208 +if (UnaryOp->getOpcode() == UnaryOperator::Opcode::UO_AddrOf) + E = UnaryOp->getSubExpr(); + samitolvanen wrote: > rjmccall wrote: > > samitolvanen wrote: > > > rjmccall

[PATCH] D114082: [WIP] Normalize String Attributes

rnk added subscribers: void, rnk. rnk added a comment. > it is possible to list all internal keys in one place I think one of the original goals of adding support for string attributes (maybe @void will give some input) was specifically to avoid having one giant list with all the attributes

[PATCH] D114394: Compile-time computation of string attribute hashes

rnk added subscribers: aeubanks, rnk. rnk added a comment. I think @aeubanks might be a good reviewer for this. I like the performance wins here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

salman-javed-nz added a comment. What would you say are the key differences between this patch differ and previous attempts, e.g. https://reviews.llvm.org/D72566? How does this patch address the concerns raised in the previous reviews? CHANGES SINCE LAST ACTION

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3149389 , @lebedev.ri wrote: > Were you able to actually reproduce the problem that lead to revert of > D107799 , or is this based on blind guesses? The patch will fix the

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

lebedev.ri added a comment. Were you able to actually reproduce the problem that lead to revert of D107799 , or is this based on blind guesses? In D110663#3149364 , @MaskRay wrote: > In D110663#3148690

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3148690 , @sylvestre.ledru wrote: > I am not sure why you are pinging this review often?! Maybe chat with people > who gave you feedback before directly?! https://llvm.org/docs/CodeReview.html "If it is not urgent,

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3149297 , @rjmccall wrote: > In D108479#3149228 , @samitolvanen > wrote: > >> I worked around this for now by explicitly

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3149228 , @samitolvanen wrote: > I worked around this for now by explicitly allowing > `__builtin_function_start` in `CheckLValueConstantExpression`, but this seems > terribly hacky. What would be the correct way

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. Temporary suspended this revision in favor of making a new checker //StrictAliasingChecker//, which would define an access to values through unpermited types as Unefined Behavior according to certain statements of the

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen added a comment. In D108479#3140688 , @rjmccall wrote: > In D108479#3140638 , @samitolvanen > wrote: > >> Sure, I can take a look at how that would work. Basically, in >>

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen updated this revision to Diff 389242. samitolvanen marked an inline comment as done. samitolvanen added a comment. Refactored to avoid evaluating the expression into an l-value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSA uses bitwidth to infer the integer value type. In the ILP32 model, for example 32-bit AIX, any 32-bit integer type will be considerred as `int`,

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc933c2eb3346: [PowerPC] Add BCD add/sub/cmp builtins (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D114088?vs=387933=389238#toc Repository: rG LLVM Github Monorepo

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

Tyker added a comment. This seems like a good change to me. but i don't think my approval is enough Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 ___

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54 +void verifyIncomingMultiFile(std::string SourceExt, std::string HeaderExt, + Annotations , Annotations , nridge wrote: > nit:

[PATCH] D113491: [HIP] Fix device stub name for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG38211bbab1d9: [HIP] Fix device stub name for Windows (authored by yaxunl). Herald added a project: clang.

[clang] 38211bb - [HIP] Fix device stub name for Windows

Author: Yaxun (Sam) Liu Date: 2021-11-23T12:03:49-05:00 New Revision: 38211bbab1d949f682271abba0171424a5a335ab URL: https://github.com/llvm/llvm-project/commit/38211bbab1d949f682271abba0171424a5a335ab DIFF:

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal added a comment. In D114256#3149009 , @martong wrote: > What happens if this checker runs on a forward declared class? The matcher `recordDecl(isStruct(), **isDefinition()**, unless(isExpansionInSystemHeader()))` filters that case. Thanks for

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal updated this revision to Diff 389225. steakhal marked an inline comment as done. steakhal added a comment. - update comments - move `no-crash` comment inline to the class member declaration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; martong wrote: > steakhal wrote: > > Where did you address this FIXME? > I didn't, but this `FIXME`

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

martong added a comment. What happens if this checker runs on a forward declared class? struct Foo; I'd expect the pack/alignment info is missing also in that case. Comment at: clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp:54 + // Ignore invalid decls to

[PATCH] D114446: [clang] Fix wrong -Wunused-local-typedef warning if use is a dependent qialified identifier

krisb created this revision. krisb added reviewers: thakis, rtrieu, rsmith. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attempt to fix Tom Smeding's example from https://bugs.llvm.org/show_bug.cgi?id=24883. Given the case like

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; steakhal wrote: > Where did you address this FIXME? I

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGb472bd855ed8: [NFC] Let Microsoft mangler accept GlobalDecl (authored by yaxunl). Herald added a project:

[clang] b472bd8 - [NFC] Let Microsoft mangler accept GlobalDecl

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:59:26-05:00 New Revision: b472bd855ed85691d0d03ef1808c82b780d23721 URL: https://github.com/llvm/llvm-project/commit/b472bd855ed85691d0d03ef1808c82b780d23721 DIFF:

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

martong accepted this revision. martong added a comment. Still LGTM! Let's land it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 ___ cfe-commits mailing

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6081 + // FunctionTemplateDecl objects are created, but in different order. In this + // way DeclContext of these template parameters may change relative to the + // "from" context. Because these

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added a comment. In D103317#3148868 , @martong wrote: > In D103317#3127318 , @steakhal > wrote: > >> To me at least, the patch looks good. >> Please post some comparative measurements to demonstrate it

[clang] aa9b90c - Fix warning due to default switch label

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:52:51-05:00 New Revision: aa9b90ca441d09969cab158f1db6341de3c1 URL: https://github.com/llvm/llvm-project/commit/aa9b90ca441d09969cab158f1db6341de3c1 DIFF:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong added a comment. I'm attaching the coverage of the new test file for the related change: 375 : // Constraints may have changed since the creation of a bound SVal. Check if 376 : // the values can be simplified based on those new constraints. 377

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12887a202404: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN (authored by martong). Repository: rG LLVM Github Monorepo

[clang] 12887a2 - [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

Author: Gabor Marton Date: 2021-11-23T16:38:01+01:00 New Revision: 12887a202404471ddf77f9fae658700573cbebe8 URL: https://github.com/llvm/llvm-project/commit/12887a202404471ddf77f9fae658700573cbebe8 DIFF: https://github.com/llvm/llvm-project/commit/12887a202404471ddf77f9fae658700573cbebe8.diff

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added inline comments. Comment at: clang/test/Analysis/svalbuilder-simplify-compound-svals.cpp:32 + clang_analyzer_eval(x + y * z == 0); // expected-warning{{TRUE}} + clang_analyzer_eval(y * z == 0); // expected-warning{{TRUE}} + clang_analyzer_eval(x == 0);

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Thanks, looks much better now. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir there is no `fmodule-format=obj` here, why are we failing here?

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added a comment. In D103317#3127318 , @steakhal wrote: > To me at least, the patch looks good. > Please post some comparative measurements to demonstrate it won't introduce > runtime regression. Sure! F20586670: stats.html

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1144 + : (SVal)SVB.makeIntVal(*Const); + return SVal(); +} steakhal wrote: > Let's be explicit about it. Good

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 389198. martong marked 6 inline comments as done. martong added a comment. - Return explicitly with UndefinedVal - Unify test cases (return 0 -> return) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet updated this revision to Diff 389197. courbet added a comment. add container exclusion tests for operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114249/new/ https://reviews.llvm.org/D114249 Files:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113753/new/ https://reviews.llvm.org/D113753

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389196. Jake-Egan added a comment. Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL.

[PATCH] D113925: [HIP] Add HIP scope atomic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe13246a2ec3d: [HIP] Add HIP scope atomic operations (authored by yaxunl). Changed prior to commit:

[clang] e13246a - [HIP] Add HIP scope atomic operations

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:13:37-05:00 New Revision: e13246a2ec3dfc13838d43099ca9111c780d2c5e URL: https://github.com/llvm/llvm-project/commit/e13246a2ec3dfc13838d43099ca9111c780d2c5e DIFF:

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added a comment. In D113451#3148815 , @kamaub wrote: > Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots > with this changeset > https://lab.llvm.org/buildbot/#/builders/93/builds/6031 >

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

kamaub added a comment. Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots with this changeset https://lab.llvm.org/buildbot/#/builders/93/builds/6031 https://lab.llvm.org/buildbot/#/builders/100/builds/10836 https://lab.llvm.org/buildbot/#/builders/52/builds/12719

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen created this revision. steffenlarsen added reviewers: erichkeane, aaron.ballman, Tyker, Naghasan. Herald added a subscriber: jdoerfert. steffenlarsen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These changes make the

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

flx accepted this revision. flx added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:228-232 +void PositiveOperatorCallConstValueParam(const Container* C)

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:262 + ID != SM.getMainFileID() && FE && + !isSelfContainedHeader(PP, ID, FE);) { + ID = SM.getFileID(SM.getIncludeLoc(ID)); kbobyrev wrote: > sammccall

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389189. sgatev marked an inline comment as done. sgatev added a comment. Add a note about asserting the requirements of the CFG object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389187. serge-sans-paille added a comment. Remove static Dict and replace it by a dict attached to LLVMContext. Some early benchmarks, on the SQLite amalgamation, through ` valgrind --tool=callgrind ./bin/clang -c -o/dev/null sqlite3.c`

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong updated this revision to Diff 389186. martong marked an inline comment as done. martong added a comment. - Add new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113753/new/ https://reviews.llvm.org/D113753 Files:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong marked 2 inline comments as done. martong added a comment. I'm attaching the coverage of the new test file for the related change: 375 : // Constraints may have changed since the creation of a bound SVal. Check if 376 : // the values can be simplified

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet updated this revision to Diff 389184. courbet added a comment. Canonicalize more types and add more container tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114249/new/ https://reviews.llvm.org/D114249 Files:

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:262 + ID != SM.getMainFileID() && FE && + !isSelfContainedHeader(PP, ID, FE);) { + ID = SM.getFileID(SM.getIncludeLoc(ID)); sammccall wrote: > it seems

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389183. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. I am not sure why you are pinging this review often?! Maybe chat with people who gave you feedback before directly?! Myself I wasted so much time because of D107799 that I am very reluctant to enable

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

sylvestre.ledru added a comment. Maybe add it to the release notes too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Fix pushed to https://reviews.llvm.org/D114207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3139129 , @lkail wrote: > Hi we found regression in our internal tests. It compiles with clang-13.0.0 > https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but > fails with clang-trunk

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. In D114099#3148631 , @sylvestre.ledru wrote: > Actually, it breaks on all Debian. > Could you please revert it? Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099

[clang] fd759d4 - Revert "The _Float16 type is supported on x86 systems with SSE2 enabled."

Author: Zahira Ammarguellat Date: 2021-11-23T08:00:57-05:00 New Revision: fd759d42c9f84d16efa99a59620cbb3e6836fed4 URL: https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4 DIFF:

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Actually, it breaks on all Debian. Could you please revert it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Full log: https://llvm-jenkins.debian.net/view/Debian%20sid/job/llvm-toolchain-binaries/architecture=amd64,distribution=unstable,label=amd64/104/consoleFull CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. As mentioned in https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b#commitcomment-60741407 This change is breaking build of compiler-rt on Ubuntu bionic and others on amd64:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389166. sgatev added a comment. Remove unnecessary constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

  1   2   >