[PATCH] D114849: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

skc7 created this revision. skc7 added reviewers: sameerds, yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, jvesely, kzhuravl. skc7 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. __builtin_nontemporal_store() fails on

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void created this revision. void added reviewers: dblaikie, nickdesaulniers. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A series of unary operators and casts may obscure the variable we're trying to analyze. Ignore them for the

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390914. junaire added a comment. Adjust code style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

thevinster added inline comments. Comment at: lld/lib/CMakeLists.txt:1 add_subdirectory(Core) Just wondering, can't we delete this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390912. junaire added a comment. Reuse existing code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390911. keith added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390910. keith added a comment. Stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390908. keith added a comment. Herald added subscribers: dang, sstefan1, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. More deletions Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163229 , @int3 wrote: > lgtm. Could you make a post to llvm-dev before landing this? Thanks! Sent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163232 , @MaskRay wrote: > Consider moving the clang driver change to a separate change so that the > removal is a more pure file deletion (other than some build system changes) Fair enough, I'll submit as a follow up

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

MaskRay accepted this revision. MaskRay added a comment. Consider moving the clang driver change to a separate change so that the removal is a more pure file deletion (other than some build system changes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm. Could you make a post to llvm-dev before landing this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y marked 11 inline comments as done. vaibhav.y added a comment. Mark completed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 ___

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. I chose to remove the darwinnew / darwinold symlinks here as well. Let me know if you all think we should leave those around for a while for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b553297ef3e: [clang-offload-bundler] Reuse original file extension for device archive member (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4b55329 - [clang-offload-bundler] Reuse original file extension for device archive member

Author: Sergey Dmitriev Date: 2021-11-30T20:38:59-08:00 New Revision: 4b553297ef3ee4dc2119d5429adf3072e90fac38 URL: https://github.com/llvm/llvm-project/commit/4b553297ef3ee4dc2119d5429adf3072e90fac38 DIFF:

[PATCH] D114583: [clang-format] Adjust braced list detection

cpplearner updated this revision to Diff 390890. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114583/new/ https://reviews.llvm.org/D114583 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp

[PATCH] D114834: [clang][PR52088]Fix assertion failure when passing bool as the type of next parameter

Lucas updated this revision to Diff 390889. Lucas added a comment. Include all local changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114834/new/ https://reviews.llvm.org/D114834 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D114834: [clang][PR52088]Fix assertion failure when passing bool as the type of next parameter

Lucas updated this revision to Diff 390886. Lucas added a comment. Checking with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114834/new/ https://reviews.llvm.org/D114834 Files: clang/lib/Sema/SemaExpr.cpp Index:

[PATCH] D114839: Reformat code style

Lucas created this revision. Lucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114839 Files: clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 added a comment. Hi @curdeius, I'm new to the project and I'm adding you as a reviewer because I noticed you reviewed a number of recent changes in this directory. Are you a good reviewer for this change? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 created this revision. davidvc1 added a reviewer: curdeius. davidvc1 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Running `clang-format` on the following input int lambdas() { return [&] { return [&] { return

[PATCH] D114769: [C++20] [Modules] [Concepts] Recognize same concepts more precisely in Serialization

ChuanqiXu updated this revision to Diff 390878. ChuanqiXu added a comment. Format codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114769/new/ https://reviews.llvm.org/D114769 Files: clang/lib/Serialization/ASTReaderDecl.cpp clang/test/Modules/Inputs/concept/A.cppm

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

This revision was automatically updated to reflect the committed changes. Closed by commit rG47f230ba2c8f: Add toggling for -fnew-infallible/-fno-new-infallible (authored by modimo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/new/

[clang] 47f230b - Add toggling for -fnew-infallible/-fno-new-infallible

Author: modimo Date: 2021-11-30T17:19:53-08:00 New Revision: 47f230ba2c8ff0e45e025163862ad699746b0ab0 URL: https://github.com/llvm/llvm-project/commit/47f230ba2c8ff0e45e025163862ad699746b0ab0 DIFF: https://github.com/llvm/llvm-project/commit/47f230ba2c8ff0e45e025163862ad699746b0ab0.diff LOG:

[PATCH] D114834: [clang]Fix assertion failure when passing bool as the type of next parameter

Lucas created this revision. Lucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114834 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/varargs.cpp Index:

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson added a comment. Ping. Is there anyone more suited to reviewing this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112113/new/ https://reviews.llvm.org/D112113 ___ cfe-commits mailing

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16216-16223 if (!getLangOpts().CPlusPlus) { // Postpone making the old definition visible until after we // complete parsing the new one and do the

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai created this revision. vsapsai added reviewers: bruno, jansvoboda11, rsmith. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Fix errors like clang/test/Modules/redefinition-c-tagtypes.m:36:10: error: reference to 'FST' is

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 390855. ellis added a comment. Emit metadata as `ConstantAsMetadata` instead of the more complicated `DIExpression`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

nickdesaulniers added a subscriber: nathanchance. nickdesaulniers added a comment. Herald added a subscriber: mstorsjo. @nathanchance reports in https://github.com/ClangBuiltLinux/linux/issues/1512 that // clang x.c register long current_stack_pointer asm("rsp"); void vmcs_set_bits() {

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:273 - if (!DataSize) + if (!CountersSize) return 0; kyulee wrote: > Is it no diff change? I wonder if there is a case where `CountersSize` is 0 > but not `DataSize`

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson added a comment. Pinging this thread with https://reviews.llvm.org/D113148 If we land both this revision and that one, then duplicate warnings won't be a problem. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

CJ-Johnson created this revision. CJ-Johnson added reviewers: ymandel, alexfh, njames93, hokein, whisperity. Herald added subscribers: carlosgalvezp, rnkovacs. CJ-Johnson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Updates

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b704d31b54a: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor… (authored by modimo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9b704d3 - [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

Author: modimo Date: 2021-11-30T15:12:45-08:00 New Revision: 9b704d31b54a61615e7d172a1ed040bff7423e9b URL: https://github.com/llvm/llvm-project/commit/9b704d31b54a61615e7d172a1ed040bff7423e9b DIFF: https://github.com/llvm/llvm-project/commit/9b704d31b54a61615e7d172a1ed040bff7423e9b.diff LOG:

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

rsmith added a comment. Generally this looks good. In addition to the `ExtWarn` for the `decltype(auto)` case, I think we're also missing a `-Wc++20-compat` warning for the feature as a whole. Comment at:

[PATCH] D114540: Big-endian version of vpermxor

This revision was automatically updated to reflect the committed changes. Closed by commit rG0850655da69a: Big-endian version of vpermxor (authored by tislam, committed by w2yehia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114540/new/

[clang] 0850655 - Big-endian version of vpermxor

Author: Tarique Islam Date: 2021-11-30T22:49:55Z New Revision: 0850655da69a700b7def4fe8d9a44d1c8d55877c URL: https://github.com/llvm/llvm-project/commit/0850655da69a700b7def4fe8d9a44d1c8d55877c DIFF: https://github.com/llvm/llvm-project/commit/0850655da69a700b7def4fe8d9a44d1c8d55877c.diff

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162157 , @mehdi_amini wrote: > In D114639#3162141 , @erichkeane > wrote: > >>> Right, but last time we did the motivation was specifically to get to >>> c++14, while here

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390824. RKSimon edited the summary of this revision. RKSimon added a comment. Changed cmake example back to VS2019 Added note for minimum cmake version necessary for VS2022 Updated the soft version limit to: _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 390822. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 390820. CJ-Johnson added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. ping * 3 Since this patch has been accepted by one code owner, and has been under review for over a month, I plan to submit it by the end of the week. If anyone has feedback/concerns, please comment on the review. CHANGES SINCE LAST ACTION

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

eandrews added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); +

[clang] 3ad0c6b - [clang-repl][NFC] Fix calling convention mismatch in test

Author: Elizabeth Andrews Date: 2021-11-30T13:26:10-08:00 New Revision: 3ad0c6b75ea503e0a5bf2faaad9a34da0a020de0 URL: https://github.com/llvm/llvm-project/commit/3ad0c6b75ea503e0a5bf2faaad9a34da0a020de0 DIFF:

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. Finally had some time to get back to this. Thanks @steakhal for your suggestion, the sample code in `ASTMatchersNodeTest.cpp` was helpful. I was actually looking for a good way of querying the target triple as I do agree that it is an better way of fixing this.

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the patch! I left a suggestion inline. Comment at: clang/lib/Sema/SemaChecking.cpp:16721 +bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) { + if (checkArgCount(*this, TheCall, 1)) If I understand correctly,

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); +

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 390795. stevewan added a comment. Herald added a subscriber: mgorny. Pin target triple before analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 Files:

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

salman-javed-nz added a comment. Will aim to review and come back to you in a couple of days. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/ https://reviews.llvm.org/D113422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

shafik added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1037 + "void foo(struct Param { int a; } *p);", Lang_C89); + EXPECT_TRUE(testStructuralMatch(Decls)); +} balazske wrote: > shafik wrote: > > I expect

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. There is clearly some more work to do to get the cmake file to be correct, but was hoping to check this looked like the direction you thought looked right for adding this test, since there isn't an obvious example to follow. Repository: rG LLVM Github Monorepo

[clang] f5ad6fa - [clang][docs] Inclusive language: remove use of sanity check in option description

Author: Zarko Todorovski Date: 2021-11-30T15:07:43-05:00 New Revision: f5ad6fa279cc012427b119828bdb679af5197c70 URL: https://github.com/llvm/llvm-project/commit/f5ad6fa279cc012427b119828bdb679af5197c70 DIFF:

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ad6fa279cc: [clang][docs] Inclusive language: remove use of sanity check in option… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

tra added a comment. In D114812#3162282 , @yaxunl wrote: > I am not sure whether we want to define a similar macro for cuda-clang. > > Maybe `__CLANG_RDC__` is better? I think it would make sense. For CUDA compatibility we can the define __CUDACC_RDC__

[clang] c379911 - [NFC][Clang]Inclusive language: Replace uses of whitelist in clang/test

Author: Zarko Todorovski Date: 2021-11-30T15:06:04-05:00 New Revision: c379911a94c1e777c232d1e3e65f5c70d0453234 URL: https://github.com/llvm/llvm-project/commit/c379911a94c1e777c232d1e3e65f5c70d0453234 DIFF:

[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

yaxunl added a comment. I am not sure whether we want to define a similar macro for cuda-clang. Maybe `__CLANG_RDC__` is better? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114812/new/ https://reviews.llvm.org/D114812 ___ cfe-commits

[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. nvcc defines `__CUDACC_RDC__` for both host and device compilation when -rdc=true is specified (https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#nvcc-identification-macro) This

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk added a comment. Sounds good. This patch is still pending, right? I don't see it in the logs. Do you need someone to push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ https://reviews.llvm.org/D111639

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG155f5a6dac62: [libc][clang-tidy] fix namespace check for externals (authored by michaelrj). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 155f5a6 - [libc][clang-tidy] fix namespace check for externals

Author: Michael Jones Date: 2021-11-30T11:44:24-08:00 New Revision: 155f5a6dac62a902a30f60e2717c4ba8fb828139 URL: https://github.com/llvm/llvm-project/commit/155f5a6dac62a902a30f60e2717c4ba8fb828139 DIFF: https://github.com/llvm/llvm-project/commit/155f5a6dac62a902a30f60e2717c4ba8fb828139.diff

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 390769. michaelrj added a comment. fix final comments before commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files:

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ThreadSafetyAnalysis.rst:471 - + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax. + +

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3162157 , @mehdi_amini wrote: > In D114639#3162141 , @erichkeane > wrote: > >>> Right, but last time we did the motivation was specifically to get to >>> c++14, while

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3162141 , @erichkeane wrote: >> Right, but last time we did the motivation was specifically to get to c++14, >> while here the motivation is to drop an old MSVC according to the >> MSVC-specific support we

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef);

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3162133 , @mehdi_amini wrote: > In D114639#3162069 , @erichkeane > wrote: > >> In D114639#3162032 , @RKSimon >> wrote: >> >>> In

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

rjmccall added a comment. Those all look good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

rnk added a comment. In D114576#3153189 , @mstorsjo wrote: > Would it be possible to move setting of this flag to somewhere else (e.g. > somewhere in Driver/ToolChains/MSVC.cpp), so that it would be picked up also > when building with the gcc-style

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3162069 , @erichkeane wrote: > In D114639#3162032 , @RKSimon wrote: > >> In D114639#3162000 , @mehdi_amini >> wrote: >> >>> In

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall These are the proposed changes which address some of your comments. I am planning on waiting for further clarification on some of the others. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

mcgrathr accepted this revision. mcgrathr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU ==

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm, but we should be sure to advise users that their debugging tools may need build adjustments to ensure they support the compressed formats. Repository: rG LLVM Github Monorepo

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Its really this case that caused me issues, the behaviour for the foo {} cases was different from the ::operator cases. My feeling is that one is being detected as a function the other not.

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm, but we should be sure to advise users who may need to use `-gdwarf-4` explicitly if their debugging tools become unhappy. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda =

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a subscriber: jfb. erichkeane added a comment. In D114639#3162032 , @RKSimon wrote: > In D114639#3162000 , @mehdi_amini > wrote: > >> In D114639#3161303

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. #TIL :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114809/new/ https://reviews.llvm.org/D114809

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, aaron.ballman. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updates the return types of these matchers' definitions to use `internal::Matcher`

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162000 , @mehdi_amini wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >>

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU == "cortex-a53") + CmdArgs.push_back("--fix-cortex-a53-843419");

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3161303 , @erichkeane wrote: > IMO, if we're updating the MSVC versions, we should do the same for the > GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and > Clang 3.5 is from 2014.

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. @mcgrathr Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek added a comment. Herald added a subscriber: abrachet. @mcgrathr This might be ready to land now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44605/new/ https://reviews.llvm.org/D44605 ___ cfe-commits mailing

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:851 + addString(AnnotationDie, dwarf::DW_AT_const_value, Value->getString()); +else if (const auto *Expr = dyn_cast(ValueOp)) + addConstantValue( It checks an

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3161978 , @nikic wrote: > FYI I reverted this due to test failures -- one specific assertion failure is > mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Thanks! I saw the failures and was going to revert,

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

fhahn added a comment. It is also breaking building `llvm-project/llvm/unittests/Support/Host.cpp` on macOS: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/25781/consoleFull FAILED: unittests/Support/CMakeFiles/SupportTests.dir/Host.cpp.o

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

nikic added a comment. FYI I reverted this due to test failures -- one specific assertion failure is mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163

[PATCH] D114394: Compile-time computation of string attribute hashes

nikic added a comment. Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=3608e18a946e77a474a468304b6c3904c55dbce0=0ce74a09cc8533a10fb67fdec4fb6ad8de4f1153=instructions Some improvement at `O3`, not much change for optimized builds. A concern I have is that this may be

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. In D114082#3149631 , @rnk wrote: >> it is possible to list all internal keys in one place > > I think one of the original goals of adding support for string attributes > (maybe @void will give some input) was

[clang] 40d5eea - Revert "Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible."

Author: Nikita Popov Date: 2021-11-30T18:36:32+01:00 New Revision: 40d5eeac6cd89a2360c3ba997cbaa816abca828c URL: https://github.com/llvm/llvm-project/commit/40d5eeac6cd89a2360c3ba997cbaa816abca828c DIFF: https://github.com/llvm/llvm-project/commit/40d5eeac6cd89a2360c3ba997cbaa816abca828c.diff

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef);

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

rnk added a comment. It looks like this Wall -> Weverything alias is from my 2017 change: https://reviews.llvm.org/rGf9b08a382cc1e0669805991849ad69efbd4703e8 The commit message doesn't link to any bugs or any other motivating material. All I said is that this is being done for MSVC

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

aaron.ballman added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:205-207 + // FIXME: We cannot yet handle delayed template parsing. If we run with + // -fdelayed-template-parsing we try adding the newly created decl to the + // active PTU which

[clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Author: Paul Robinson Date: 2021-11-30T08:58:40-08:00 New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db URL: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db DIFF: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

erichkeane added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); +

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

aaron.ballman added a comment. There is no information in this patch as to why the changes are needed or useful; please use a more descriptive summary next time. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:205-207 + // FIXME: We cannot yet handle delayed

  1   2   >