[PATCH] D115064: [clang-format][NFC] Replace deque with vector

owenpan added a comment. In D115064#3170615 , @curdeius wrote: > Maybe using `llvm::SmallVector` with some well-thought (data-based) static > number of elements would be better here, WDYT? I tend to agree as LLVM style

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Print type for

[PATCH] D115107: [clang][clangd] Desugar array type.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Desugar array type.

[PATCH] D114497: [PowerPC] Drop stdlib paths in freestanding tests

MaskRay added a comment. LGTM (in a trip, slow to reply) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114497/new/ https://reviews.llvm.org/D114497 ___ cfe-commits mailing list

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

fwolff created this revision. fwolff added reviewers: aaron.ballman, simon.giesecke, jcking1034. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D114497: [PowerPC] Drop stdlib paths in freestanding tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a0e850fa30: [PowerPC] Drop stdlib paths in freestanding tests (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114497/new/

[clang] 41a0e85 - [PowerPC] Drop stdlib paths in freestanding tests

Author: Zhihao Yuan Date: 2021-12-04T16:51:13-06:00 New Revision: 41a0e850fa30acf2ffd1c4ffda335f07ea0c249b URL: https://github.com/llvm/llvm-project/commit/41a0e850fa30acf2ffd1c4ffda335f07ea0c249b DIFF: https://github.com/llvm/llvm-project/commit/41a0e850fa30acf2ffd1c4ffda335f07ea0c249b.diff

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan accepted this revision. owenpan added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 391875. clemenswasser added a comment. Use LF line endings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt/cmake/config-ix.cmake

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 391873. clemenswasser added a comment. Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt/cmake/config-ix.cmake

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 391872. clemenswasser added a comment. Move `__lsan_init` call inside of `SANITIZER_WINDOWS` ifdef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 391871. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 391870. clemenswasser added a comment. Changed to core.autocrlf=false CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff marked 3 inline comments as done. fwolff added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:76 +arraySubscriptExpr(hasLHS(ContainerExpr), hasRHS(Zero)) + .bind(AddressOfName),

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

curdeius added a comment. I share Arthur's point of view and I prefer the pointers. I don't see an advantage of this proposed change. If only we had C#'s `out`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115061/new/

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 391869. fwolff marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks added a comment. This was not intended to be pushed, I forgot to move it out of the chunk. If we come to the conclusion that we want pointers I will revert this. If no one objects in the next say 3 days I will leave it so. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115072: [clang-format][NFC] Use member directly

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e8678903523: [clang-format][NFC] Use member directly (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115072/new/

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

This revision was automatically updated to reflect the committed changes. Closed by commit rG88fa4bfe1ec2: [clang-format][NFC] Use range based for for fake l parens (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

This revision was automatically updated to reflect the committed changes. Closed by commit rG4041f16bb489: [clang-format][NFC] Early return when nothing to do (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115067: [clang-format][NFC] Use range based for

This revision was automatically updated to reflect the committed changes. Closed by commit rGc25536e4feed: [clang-format][NFC] Use range based for (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115067/new/

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d1c85454daa: [clang-format][NFC] Move static variable in scope (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115068/new/

[PATCH] D115066: [clang-format][NFC] Reorder conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4483e9b5279b: [clang-format][NFC] Reorder conditions (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115066/new/

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG5878ac7d2db6: [clang-format][NFC] Merge two calls of isOneOf (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115065/new/

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7fdeda2c9db: [clang-format][NFC] Rename variable so no shadowing happens (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6e86789 - [clang-format][NFC] Use member directly

Author: Björn Schäpers Date: 2021-12-04T21:29:31+01:00 New Revision: 6e8678903523019903222e4521a5e41af743cab0 URL: https://github.com/llvm/llvm-project/commit/6e8678903523019903222e4521a5e41af743cab0 DIFF:

[clang] 88fa4bf - [clang-format][NFC] Use range based for for fake l parens

Author: Björn Schäpers Date: 2021-12-04T21:29:30+01:00 New Revision: 88fa4bfe1ec25e0ae74566bfc2ba213f2f96b44c URL: https://github.com/llvm/llvm-project/commit/88fa4bfe1ec25e0ae74566bfc2ba213f2f96b44c DIFF:

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG25f637913fe3: [clang-format][NFC] Prefer pass by reference (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115061/new/

[clang] 4041f16 - [clang-format][NFC] Early return when nothing to do

Author: Björn Schäpers Date: 2021-12-04T21:29:30+01:00 New Revision: 4041f16bb489d6cbdebfed33a2c5cc586cb3839b URL: https://github.com/llvm/llvm-project/commit/4041f16bb489d6cbdebfed33a2c5cc586cb3839b DIFF:

[clang] 8d1c854 - [clang-format][NFC] Move static variable in scope

Author: Björn Schäpers Date: 2021-12-04T21:29:30+01:00 New Revision: 8d1c85454daa40bd663d0ef4e8262fe6fc0f21ad URL: https://github.com/llvm/llvm-project/commit/8d1c85454daa40bd663d0ef4e8262fe6fc0f21ad DIFF:

[clang] c25536e - [clang-format][NFC] Use range based for

Author: Björn Schäpers Date: 2021-12-04T21:29:30+01:00 New Revision: c25536e4feed59f8a8685fac3ba225057b76a358 URL: https://github.com/llvm/llvm-project/commit/c25536e4feed59f8a8685fac3ba225057b76a358 DIFF:

[clang] 4483e9b - [clang-format][NFC] Reorder conditions

Author: Björn Schäpers Date: 2021-12-04T21:29:29+01:00 New Revision: 4483e9b5279bc71c9da7bbb0e1524c3671493ab6 URL: https://github.com/llvm/llvm-project/commit/4483e9b5279bc71c9da7bbb0e1524c3671493ab6 DIFF:

[clang] 5878ac7 - [clang-format][NFC] Merge two calls of isOneOf

Author: Björn Schäpers Date: 2021-12-04T21:29:29+01:00 New Revision: 5878ac7d2db692779c0d049a13cb29ed19d51ca9 URL: https://github.com/llvm/llvm-project/commit/5878ac7d2db692779c0d049a13cb29ed19d51ca9 DIFF:

[clang] e7fdeda - [clang-format][NFC] Rename variable so no shadowing happens

Author: Björn Schäpers Date: 2021-12-04T21:29:29+01:00 New Revision: e7fdeda2c9dbe545445335f060eb450d15577aec URL: https://github.com/llvm/llvm-project/commit/e7fdeda2c9dbe545445335f060eb450d15577aec DIFF:

[clang] 25f6379 - [clang-format][NFC] Prefer pass by reference

Author: Björn Schäpers Date: 2021-12-04T21:29:29+01:00 New Revision: 25f637913fe31b6d23e78ff07c725bb537dd3b97 URL: https://github.com/llvm/llvm-project/commit/25f637913fe31b6d23e78ff07c725bb537dd3b97 DIFF:

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115069/new/ https://reviews.llvm.org/D115069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks updated this revision to Diff 391857. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Incorporated feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115069/new/ https://reviews.llvm.org/D115069 Files:

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3054 + return true; +// & // comment +if (Right.is(TT_BlockComment)) Block, not line, comment Comment at: clang/unittests/Format/FormatTest.cpp:1947

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 391855. HazardyKnusperkeks added a comment. Formatting fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115064/new/ https://reviews.llvm.org/D115064 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3170615 , @curdeius wrote: > Deque, contrary to the vector, doesn't need to move the elements when > growing. I'm not sure if that's relevant here though. > Have you checked what's on average the maximum

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser created this revision. clemenswasser added a project: Sanitizers. Herald added subscribers: abrachet, phosek, krytarowski, mgorny. clemenswasser requested review of this revision. Herald added a project: clang. Herald added subscribers: Sanitizers, cfe-commits. This was done by me

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 391853. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. Fixed formatting and added a name for I[-1]. I[i + 1] is used in the loop condition, which also checks if i + 1 is valid, so do not give a name

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 391852. fwolff added a comment. Thanks for your comments @whisperity! They should all be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files:

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:151 + using Alias3 = TemplateTypeAlias; + Alias3 =(int) { return *this; } +}; fwolff wrote: > whisperity wrote: > > This is a

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:22 +constexpr llvm::StringLiteral DerefContainerExprName = "deref-container-expr"; +constexpr llvm::StringLiteral AddrofContainerExprName =

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff marked 2 inline comments as done. fwolff added a comment. Thanks for your comments @whisperity. I think I've addressed them, could you have another look? Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:151 + using Alias3

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff updated this revision to Diff 391850. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/ https://reviews.llvm.org/D114197 Files: clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff marked 2 inline comments as done. fwolff added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4524-4525 if (!Dependent) { -if (Context.hasSameUnqualifiedType(QualType(ClassDecl->getTypeForDecl(),0), - BaseType)) +

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/float128-ld-incompatibility.cpp:13 +long double ld{qf()}; // expected-error {{non-constant-expression cannot be narrowed from type '__float128' to 'long double' in initializer list}} expected-note

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + HazardyKnusperkeks

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + Quuxplusone

[PATCH] D113319: [clang-format] Improve require and concept handling

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3464-3483 + * ``RCPS_TwoLines`` (in configuration: ``TwoLines``) +The clause always gets its own line, and the content of the clause go +into the next line with some indentation. + +

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This seems reasonable its as if we only ever push_back and iterate backwards? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1294-1296 + Previous->isOneOf(tok::l_paren, tok::comma, tok::colon, TT_BinaryOperator, +

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + HazardyKnusperkeks

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 391836. skc7 added a comment. updated test IR files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391833. lichray marked an inline comment as done. lichray added a comment. - Switch to `llvm::SmallString` - Refactor code that prints C-style builtin escape sequences - Stop printing strings with embedded NULs in NTTP types - Add an

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 5 inline comments as done. lichray added inline comments. Comment at: clang/lib/AST/APValue.cpp:637-639 + // Nothing we can do about a sequence that is not null-terminated + if (!Data[--Size].getInt().isZero()) +return false; lichray wrote:

[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc34d157fc739: [Passes] Move AggressiveInstCombine after InstCombine (authored by anton-afanasyev). Repository: rG LLVM Github Monorepo CHANGES

[clang] c34d157 - [Passes] Move AggressiveInstCombine after InstCombine

Author: Anton Afanasyev Date: 2021-12-04T14:22:43+03:00 New Revision: c34d157fc73954366371aaca6291739921933e86 URL: https://github.com/llvm/llvm-project/commit/c34d157fc73954366371aaca6291739921933e86 DIFF:

[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

anton-afanasyev updated this revision to Diff 391823. anton-afanasyev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113179/new/

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2774bad11242: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args (authored by foad). Repository: rG LLVM Github Monorepo

[clang] 2774bad - [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

Author: Jay Foad Date: 2021-12-04T10:32:11Z New Revision: 2774bad1124215571ab154afcb5478c78cf46344 URL: https://github.com/llvm/llvm-project/commit/2774bad1124215571ab154afcb5478c78cf46344 DIFF: https://github.com/llvm/llvm-project/commit/2774bad1124215571ab154afcb5478c78cf46344.diff LOG:

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

ram7bhupal created this revision. ram7bhupal added reviewers: dblaikie, aaron.ballman. ram7bhupal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -Wdeclaration-after-statement doesn't do anything if combined with -std=c99 or newer. Take

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added a comment. Thanks a lot for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/ https://reviews.llvm.org/D113422 ___ cfe-commits mailing list

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG946eb7a037d5: [clang-tidy][NFC] Move CachedGlobList to GlobList.h (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/

[clang-tools-extra] 946eb7a - [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Author: Carlos Galvez Date: 2021-12-04T08:50:49Z New Revision: 946eb7a037d5f83ea9cdc99bac0f939ddd344e09 URL: https://github.com/llvm/llvm-project/commit/946eb7a037d5f83ea9cdc99bac0f939ddd344e09 DIFF: https://github.com/llvm/llvm-project/commit/946eb7a037d5f83ea9cdc99bac0f939ddd344e09.diff