[PATCH] D102614: [index] Add support for type of pointers to class members

OikawaKirie added a comment. ping What do you think about this patch? Can it be landed now? Or I should debug the crash in the Windows version detected with the previous version of my patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102614/new/ https://reviews.llvm.org/D102614

[PATCH] D114583: [clang-format] Adjust braced list detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc41b3b0fa0f4: [clang-format] Adjust braced list detection (authored by cpplearner, committed by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return false; + + // Parse the length of

[clang] c41b3b0 - [clang-format] Adjust braced list detection

Author: Tan S. B Date: 2021-12-05T22:39:29-08:00 New Revision: c41b3b0fa0f4f70aad8deaf48bcd42a04385066c URL: https://github.com/llvm/llvm-project/commit/c41b3b0fa0f4f70aad8deaf48bcd42a04385066c DIFF: https://github.com/llvm/llvm-project/commit/c41b3b0fa0f4f70aad8deaf48bcd42a04385066c.diff

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 391968. OikawaKirie added a comment. 1. Fix formatting bugs 2. Update lookup name format as `: ` in all comments and documents 3. Add the new test case as a part of `clang/test/Analysis/func-mapping-test.cpp` to verify the lookup name 4. Change the

[PATCH] D115132: [C++20] [Modules] Namespace Declaration shouldn't have module linkage

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, hubert.reinterpretcast, erichkeane. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. According to

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

MaskRay added a comment. To add on rnk's comment (deduplication of vague linkage data which may be included in multiple shared objects), another big reason is -Bsymbolic data does not work with copy relocations. -fno-pic programs generally cannot avoid copy relocations (except mips; mips did

[PATCH] D113237: [RISCV] Support I extension version 2.1

achieveartificialintelligence added a comment. In D113237#3124232 , @luismarques wrote: > In D113237#3124188 , @luismarques > wrote: > >> Should we also support `fence.i` with RVI 2.0, without zifencei? > >

[PATCH] D113237: [RISCV] Support Zifencei extension

achieveartificialintelligence updated this revision to Diff 391951. achieveartificialintelligence added a comment. Herald added subscribers: cfe-commits, jdoerfert, rupprecht, emaste, qcolombet. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: clang.

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

zixuan-wu added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence. Hi, all. Why is it not continued? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 391948. HsiangKai added a comment. - Use unique_ptr. - Avoid to create static global constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files:

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis added a comment. Looks like this breaks tests on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/68330#746376c2-ce48-4ffc-b60f-515619dee28c Failed Tests (2): Clang :: Driver/ve-toolchain.c Clang :: Driver/ve-toolchain.cpp Repository: rG LLVM Github

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

rjmccall added a comment. That's not an unreasonable idea, and we did consider it, and in fact it's still on the table as something we could do. However, it's a significantly more complex change, and we're not committed to doing it, and so we wanted to at least put this warning in place to

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-stringview-nullptr.cpp:94-95 + +// TODO: Handle cases where types, such as Class and Struct below, are +// constructed with null arguments. +class Class { I

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-stringview-nullptr.cpp:735 void function_invocation() /* f */ { + // Single Argument Function Invocation This diff is also noisy, but it's about adding missing

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson updated this revision to Diff 391940. CJ-Johnson added a comment. Add missing tests for function arguments and fix incorrect warning message for static_cast cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

fwolff created this revision. fwolff added reviewers: mizvekov, compnerd. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51776

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Any luck with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:299 + if (DebugInfoCorrelate) { +ProfDataIOVec IOVecData[] = { Should it be down after `__llvm_write_binary_ids` below although it doesn't do anything in general? I

[clang] 296ebeb - Test commit to check access.

Author: Jack Andersen Date: 2021-12-05T14:35:33-05:00 New Revision: 296ebeb808a71e44a64e0f805cffc6e3a3bf6182 URL: https://github.com/llvm/llvm-project/commit/296ebeb808a71e44a64e0f805cffc6e3a3bf6182 DIFF: https://github.com/llvm/llvm-project/commit/296ebeb808a71e44a64e0f805cffc6e3a3bf6182.diff

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:174-194 return applyFirst( {HandleTemporaryCXXFunctionalCastExpr, HandleTemporaryCXXTemporaryObjectExprAndCompoundLiteralExpr, -

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson created this revision. CJ-Johnson added a reviewer: ymandel. Herald added a subscriber: carlosgalvezp. CJ-Johnson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. bugprone-stringview-nullptr was not initially written

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, JonasToth, lebedev.ri. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52254

[PATCH] D114583: [clang-format] Adjust braced list detection

cpplearner added a comment. Yes, I need someone to commit it on my behalf. My name and email address: `Tan S. B. ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114583/new/ https://reviews.llvm.org/D114583 ___ cfe-commits mailing list

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. What can/should I do next in order to proceed with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Probably obsoleted by 729bf9b26b657df8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114865/new/ https://reviews.llvm.org/D114865

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391915. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files:

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

pengfei added a comment. @skan This change seems don't work for -fpic, see https://godbolt.org/z/h3nWoerPe I don't have any idea to handle these cases, I suggest we should revert this patch first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar Do you have any updates on the topic? What approximate time frame should I expect? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 ___ cfe-commits

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. Regression compared to the status quo: This code no longer warns (as noted by Hubert above) auto f = [](bool b) { if (b) return 42; static int x = 0; return x; }; constexpr int x = f(true); const int *p = GCC doesn't warn and... if we wanted to

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 391906. cor3ntin added a comment. Treat non-literals in constexpr as an error before C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files:

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks reopened this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115061/new/ https://reviews.llvm.org/D115061

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3171950 , @owenpan wrote: > In D115064#3170615 , @curdeius > wrote: > >> Maybe using `llvm::SmallVector` with some well-thought (data-based) static >> number of

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. In D111400#3165668 , @hubert.reinterpretcast wrote: > In D111400#3164301 , @cor3ntin > wrote: > >> If the issue is regarding the support and extension warning in C++20 and >> older