[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. In D114235#3173745 , @aaron.ballman wrote: > I've not had the chance, sorry! My review queue is rather full at the moment, > so I'm still digging out from under quite a few reviews (around 50 at last > count) and it may be a

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

rjmccall added a comment. I agree that you shouldn't call `suspend`, but doesn't `coro.end` have the behavior of marking the coroutine done? Should we just be calling `coro.end` on this path? Comment at: llvm/docs/Coroutines.rst:1661 +should return true. All of the

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

rjmccall added a reviewer: GorNishanov. rjmccall added a comment. I imagine Gor hoped for this optimization to be implemented someday, assuming it's still allowed by the language specification. Maybe you would be interested in pursuing that? It sounds like it's really just (1) emitting the

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind, junparser, ychen. ChuanqiXu added projects: clang, LLVM. Herald added a subscriber: hiraditya. ChuanqiXu requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. I found that

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind, junparser, ychen, aaron.ballman. ChuanqiXu added projects: clang, LLVM. Herald added a subscriber: hiraditya. ChuanqiXu requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert.

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void updated this revision to Diff 392281. void added a comment. Simplify the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848 Files: clang/lib/Analysis/UninitializedValues.cpp

Re: [clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change in the near future)? On Tue, Nov 30, 2021 at 8:59 AM

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rjmccall added a comment. Don't worry about `GC::Strong`. ObjC GC is thoroughly dead (unless there's GNU-runtime interest in it?), and AFAIK we've never made any effort to incorporate it into our treatment of non-trivial structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

dblaikie added a comment. In D113743#3174073 , @krisb wrote: > In D113743#3173981 , @JDevlieghere > wrote: > >> Hey Kristina, this broke TestSetData.py on GreenDragon: >>

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

khchen added a comment. > Is it (D70401 ) good enough to solve or > complete rv32e issue? It need to 1. disallow ilp32e ABI with D ISA extension.

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith added inline comments. Comment at: clang/lib/AST/Type.cpp:2500 +return BaseElementType.isTriviallyCopyableType(Context) && + !BaseElementType.isDestructedType(); + } devin.jeanpierre wrote: > rsmith wrote: > > You can simplify this a little

[PATCH] D114966: [clang][deps] Split filesystem caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:253-255 + if (SharedOriginalContents.WasInserted) +SharedStat->Stat = +readFile(Filename, getUnderlyingFS(), SharedOriginalContents.Value);

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

zixuan-wu added a comment. In D70401#3172750 , @khchen wrote: > In D70401#3172457 , @zixuan-wu wrote: > >> Hi, all. Why is it not continued? > > Sorry, I have to work on other tasks so stop the rv32e implementation

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

Carrot added a comment. Finally complain comes. It slows down a hot path in tcmalloc. A simplified test case is at https://godbolt.org/z/T6sshjf7M Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added a comment. In D111617#3060377 , @HsiangKai wrote: > Although it reduces the header size, this patch will increase the binary size > of clang. > > Debug build: > Before this patch: > > textdatabss

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:64-70 MinimizedFileContents.push_back('\0'); - Result.Contents = std::move(MinimizedFileContents); - // Now make the null terminator implicit again, so that

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + void wrote: > nickdesaulniers wrote: > > Q: are

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

NoQ added a comment. > It can happen if the `Loc` was perfectly constrained to a concrete > value (`nonloc::ConcreteInt`) This shouldn't happen. It should be `loc::ConcreteInt` which is, well, a `Loc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115199: [X86][AMX] Support amxpreserve attribute in clang.

LuoYuanke created this revision. Herald added a reviewer: aaron.ballman. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115199 Files:

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. (Sorry for delayed reply -- I made the mistake of signing up to phabricator with my personal email, which I don't check very well, apparently!) Comment at: clang/include/clang/Basic/AttrDocs.td:3211-3215 +The compiler will pass and return a

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 392214. devin.jeanpierre added a comment. Suggested changes from code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files:

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I think it's generally better to not run cleanups on the way to a `terminate` call, not only for code size but also for debuggability. This change seems like an improvement to me.

[PATCH] D114812: [CUDA][HIP] Add pre-defined macro `__CLANG_RDC__`

yaxunl updated this revision to Diff 392205. yaxunl retitled this revision from "[HIP] Add pre-defined macro `__HIPCC_RDC__`" to "[CUDA][HIP] Add pre-defined macro `__CLANG_RDC__`". yaxunl edited the summary of this revision. Herald added a subscriber: carlosgalvezp. CHANGES SINCE LAST ACTION

[PATCH] D114407: [CUDA][SPIRV] Use OpenCLKernel CC for CUDA -> SPIRV

This revision was automatically updated to reflect the committed changes. Closed by commit rGabbdc13e6803: [CUDA][SPIRV] Use OpenCLKernel CC for CUDA - SPIRV (authored by dcastagna, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] abbdc13 - [CUDA][SPIRV] Use OpenCLKernel CC for CUDA -> SPIRV

Author: Daniele Castagna Date: 2021-12-06T15:06:57-08:00 New Revision: abbdc13e6803562bce4e42866a9ebf7f2a04a89b URL: https://github.com/llvm/llvm-project/commit/abbdc13e6803562bce4e42866a9ebf7f2a04a89b DIFF:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 392189. arnamoy10 added a comment. Addressing reviewers comments Major changes are as follows: 1. Skipping unsupported clauses and skip the case when there is an ordered directive inside the simd construct 2. Traversing all the blocks in the Canonical

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392180. dgoldman added a comment. Use consistent IsSystem detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index:

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392176. dgoldman added a comment. Fix IncludeSpelling issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index:

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

dblaikie added a comment. This'll at least need a test case added - though the specifics of how the warning should work I'll leave up to @aaron.ballman - unless he wants some second opinions. (I don't immediately have a strong feeling either way regarding the current or proposed behavior)

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b172f60c692: [HIP] Fix -fgpu-rdc for Windows (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115039/new/

[clang] 3b172f6 - [HIP] Fix -fgpu-rdc for Windows

Author: Yaxun (Sam) Liu Date: 2021-12-06T16:42:23-05:00 New Revision: 3b172f60c6926b43f87de1eaa3fa4c873bdb6de4 URL: https://github.com/llvm/llvm-project/commit/3b172f60c6926b43f87de1eaa3fa4c873bdb6de4 DIFF:

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will now search through the framework includes to identify the framework include path to a file, and then suggest a framework style include

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

CJ-Johnson updated this revision to Diff 392157. CJ-Johnson added a comment. Switch to using empty string edits everywhere except equality comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis added a comment. This looks right to me. Comment at: clang/lib/Driver/Driver.cpp:1846 +if (RuntimePaths.size() > 0 && getVFS().exists(RuntimePaths[0])) + llvm::outs() << RuntimePaths[0] << '\n'; else This either needs to print all of them,

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a reviewer: rnk. vitalybuka added a subscriber: rnk. vitalybuka added a comment. LGTM in general, but it can be cut into smaller patches. + @rnk for Windows suff Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h"

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + nickdesaulniers wrote: > Q: are there any unary operators

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea removed a reviewer: deadalnix. aganea added a comment. Ping! Any further comments? Thanks in advance for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl added a comment. In D115039#3174154 , @tra wrote: >> Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage. > > I wonder when would this happen? I'm not sure we ever want gpubin handles > from different TUs merged. I think it may

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + Q: are there any unary operators that are not

[PATCH] D114938: [Analyzer][NFCi] SValBuilder: Simlify a SymExpr to the absolute simplest form

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. You mentioned in the summary that there are different places where simplification-like machinary kicks in, which hindered the test case synthesis. What places did you refer to exactly?

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2598 +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { + FormattingOff = true; curdeius wrote: > HazardyKnusperkeks

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

This revision was automatically updated to reflect the committed changes. Closed by commit rG341a30a4ba4b: [clang][ASTImporter] Update lookup table correctly at deduction guides. (authored by balazske, committed by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 341a30a - [clang][ASTImporter] Update lookup table correctly at deduction guides.

Author: Balázs Kéri Date: 2021-12-06T20:40:16+01:00 New Revision: 341a30a4ba4bdb537916986cbc0bac8b5b31d8f6 URL: https://github.com/llvm/llvm-project/commit/341a30a4ba4bdb537916986cbc0bac8b5b31d8f6 DIFF: https://github.com/llvm/llvm-project/commit/341a30a4ba4bdb537916986cbc0bac8b5b31d8f6.diff

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2598 +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { + FormattingOff = true; HazardyKnusperkeks wrote: > curdeius wrote: > >

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a subscriber: aaron.ballman. oleg.smolsky added a comment. @aaron.ballman do you happen to know who is best to review a `clang-tidy` fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2598 +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { + FormattingOff = true; curdeius wrote: > This won't be enough

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

This revision was automatically updated to reflect the committed changes. Closed by commit rG73ee4e1cbd64: [clang][ARM] only check -mtp=cp15 for non-asm sources (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/

[clang] 73ee4e1 - [clang][ARM] only check -mtp=cp15 for non-asm sources

Author: Nick Desaulniers Date: 2021-12-06T11:31:23-08:00 New Revision: 73ee4e1cbd643028d63200f05199a128609aba5f URL: https://github.com/llvm/llvm-project/commit/73ee4e1cbd643028d63200f05199a128609aba5f DIFF:

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added a comment. In D114601#3172199 , @mojca wrote: > What can/should I do next in order to proceed with this? Next step would be to commit the patch. If you do not have commit access, I can help you with that. If that's the case, please let me

[clang] ead449a - Fixing this test which failed due to different warnings

Author: Aaron Ballman Date: 2021-12-06T14:13:29-05:00 New Revision: ead449aee4c1bd3ad309185528c430fdbd06cf2f URL: https://github.com/llvm/llvm-project/commit/ead449aee4c1bd3ad309185528c430fdbd06cf2f DIFF: https://github.com/llvm/llvm-project/commit/ead449aee4c1bd3ad309185528c430fdbd06cf2f.diff

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

rnk added a comment. In D102090#3172693 , @ebrevnov wrote: > I don't see what's wrong here (maybe you have specific example). IMHO, quite > opposite, LLVM will consistently use it's own instance while user's binary > it's own as if there were two

[clang] 0ef8ad0 - Fix a failing test case after 6c75ab5f66b403f7ca67e86aeed3a58abe10570b

Author: Aaron Ballman Date: 2021-12-06T13:53:43-05:00 New Revision: 0ef8ad08db6c154f14c0e060b71106dacd8f29fd URL: https://github.com/llvm/llvm-project/commit/0ef8ad08db6c154f14c0e060b71106dacd8f29fd DIFF: https://github.com/llvm/llvm-project/commit/0ef8ad08db6c154f14c0e060b71106dacd8f29fd.diff

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

tra added a comment. > Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage. I wonder when would this happen? I'm not sure we ever want gpubin handles from different TUs merged. I think it may result in different TUs attempting to load/init the same GPU binary multiple times.

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell added a comment. In D114885#3174074 , @thakis wrote: > Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 > min or so then. Something to keep in mind for relanding though :) Yeah, I'm currently trying to build

[clang] 1f257ac - Speculatively fix the LLDB build bots from 6c75ab5f66b403f7ca67e86aeed3a58abe10570b

Author: Aaron Ballman Date: 2021-12-06T13:30:15-05:00 New Revision: 1f257accd713a8e302d3fdd2cac615a303295c42 URL: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42 DIFF: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42.diff

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2597 +// or we will sort the contents of the string. +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { "we we"?

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Note to self: don't forget to hit "submit". The comments below have been left unsubmitted for two weeks. Sorry about that. The patch looks OK for the time being. That said, I do have concerns that

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1feb8ab - Update the status of N2412 in C (we do not implement large parts of it)

Author: Aaron Ballman Date: 2021-12-06T13:14:13-05:00 New Revision: 1feb8ab0d350640058ffa764e0aeeda2480d6302 URL: https://github.com/llvm/llvm-project/commit/1feb8ab0d350640058ffa764e0aeeda2480d6302 DIFF: https://github.com/llvm/llvm-project/commit/1feb8ab0d350640058ffa764e0aeeda2480d6302.diff

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

MyDeveloperDay added a comment. I recently reviewed this item, but I wonder what the overlap with D94661: [clang-format] [PR19056] Add support for access modifiers indentation is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115147: clang-format: [JS] test case for numeric separators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG327d966365d7: clang-format: [JS] test case for numeric separators. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115147/new/

[clang] 327d966 - clang-format: [JS] test case for numeric separators.

Author: Martin Probst Date: 2021-12-06T19:01:24+01:00 New Revision: 327d966365d7b34abd25a920e1f7b5aecfa5c70f URL: https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f DIFF: https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f.diff

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks all! I've commit the renaming in 6c75ab5f66b403f7ca67e86aeed3a58abe10570b and have started a new review for the generic ABI document in

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

thakis added a comment. Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 min or so then. Something to keep in mind for relanding though :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114885/new/

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3173981 , @JDevlieghere wrote: > Hey Kristina, this broke TestSetData.py on GreenDragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ > > Since the bot has been red for several hours I went ahead

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

thakis added a comment. Either this or D115139 broke check-llvm on arm macs: http://45.33.8.238/macm1/23120/step_11.txt getMacOSHostVersion sounds kind of triple-related, so I'm guessing it's this one. Please take a look, and revert for now if it takes a

[PATCH] D115169: Create a generic ABI document for _BitInt

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, erichkeane, rsmith. Herald added a subscriber: arphaman. aaron.ballman requested review of this revision. Herald added a project: clang. This document describes a generic ABI for targets to opt into if they wish. It

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, njames93. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=49298 clang-format does not respect

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6816b957d28: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] a6816b9 - [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

Author: Balazs Benics Date: 2021-12-06T18:38:58+01:00 New Revision: a6816b957d28ab7855f2af1277c72a6d65b600b4 URL: https://github.com/llvm/llvm-project/commit/a6816b957d28ab7855f2af1277c72a6d65b600b4 DIFF: https://github.com/llvm/llvm-project/commit/a6816b957d28ab7855f2af1277c72a6d65b600b4.diff

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

JDevlieghere added a comment. Hey Kristina, this broke TestSetData.py on GreenDragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ Since the bot has been red for several hours I went ahead and reverted your change in 4cb79294e8df8c91ae15264d1014361815d34a53

[clang] 63a6348 - Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" a

Author: James Farrell Date: 2021-12-06T17:35:26Z New Revision: 63a6348cad6caccf285c1661bc60d8ba5a40c972 URL: https://github.com/llvm/llvm-project/commit/63a6348cad6caccf285c1661bc60d8ba5a40c972 DIFF: https://github.com/llvm/llvm-project/commit/63a6348cad6caccf285c1661bc60d8ba5a40c972.diff

[clang] 4cb7929 - Revert "[clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block"

Author: Jonas Devlieghere Date: 2021-12-06T09:34:53-08:00 New Revision: 4cb79294e8df8c91ae15264d1014361815d34a53 URL: https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53 DIFF:

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added a comment. In D114966#3168108 , @dexonsmith wrote: > Thanks for working on this; seems like a great start. Thanks a lot for the extensive feedback! I'll work through it and create prep

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This looks good to me! I agree, an `enum class` would be cleaner though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bb2a4f3e654: [openmp] Default to new rtl for amdgpu (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6bb2a4f - [openmp] Default to new rtl for amdgpu

Author: Jon Chesterfield Date: 2021-12-06T16:56:14Z New Revision: 6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e URL: https://github.com/llvm/llvm-project/commit/6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e DIFF: https://github.com/llvm/llvm-project/commit/6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:724 + "attribute %0 does not support pack expansion in the last argument">; +def err_attribute_parm_pack_last_argument_only : Error< + "pack expansion in attributes is restricted to

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. ping: This is ready for review now. Thanks for your patience with the review as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 392080. Fznamznon added a comment. Applied suggestions from Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files:

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a comment. In D114235#3173549 , @mboehme wrote: > Aaron, have you had any chance to look at this yet? > > I added you as a reviewer because you expressed interest in something like > this in this discussion: >

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 392071. jozefl marked an inline comment as done. jozefl added a comment. Thanks, good point, fixed in the attached patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ? LangOpts.VScaleMin : 1, 16); + paulwalker-arm wrote: > This part is no longer needed because to get here you already know >

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 392067. simoll added a comment. Herald added subscribers: abrachet, kerbowa, ormris, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, sdardis, dschuff. Use the `-DCLANG_DEFAULT_LINKER` linker in all toolchains but VE. Since toolchains

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. One minor issue but otherwise looks good. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ?

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. fyi: if i remove the now 'dead' use of the CMAKE variable from my cmake , then i am able to build. so i see you reverted, thx. i guess some coordination amongst buildbot maintainers who might use this option checking zorg: the last two are me: not sure who owns the

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll reopened this revision. simoll added a comment. This revision is now accepted and ready to land. I've reverted the patch for now, this may show up for other toolchains, too. This patch has pushed down the responsibility for handling `-DCLANG_DEFAULT_LINKER` to the toolchains. However, I

[clang] f6ba645 - Revert "[Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains"

Author: Simon Moll Date: 2021-12-06T16:44:36+01:00 New Revision: f6ba6450396ce58212f247c72d84a54efd748b38 URL: https://github.com/llvm/llvm-project/commit/f6ba6450396ce58212f247c72d84a54efd748b38 DIFF: https://github.com/llvm/llvm-project/commit/f6ba6450396ce58212f247c72d84a54efd748b38.diff

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

JonChesterfield added a comment. It's a bit hard to tell. Definitely might work. I'm hoping someone will feed this into the internal CI infra. @ronlieb any objection to making this change on trunk and reverting it internally if things break there? Repository: rG LLVM Github Monorepo

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added a comment. Friendly ping to reviewers. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. If it works on your end it's good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115157/new/ https://reviews.llvm.org/D115157

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

JonChesterfield created this revision. JonChesterfield added reviewers: ronlieb, jhuber6, jdoerfert, pdhaliwal. Herald added subscribers: dang, kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Aaron, have you had any chance to look at this yet? I added you as a reviewer because you expressed interest in something like this in this discussion: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069097.html Is there someone else who would be more

[clang] 53154a8 - [ARM][clang] Add back branch protection tests

Author: Ties Stuij Date: 2021-12-06T15:03:33Z New Revision: 53154a83aee0ce969dc07e7168b3914ca1025030 URL: https://github.com/llvm/llvm-project/commit/53154a83aee0ce969dc07e7168b3914ca1025030 DIFF: https://github.com/llvm/llvm-project/commit/53154a83aee0ce969dc07e7168b3914ca1025030.diff LOG:

[PATCH] D115141: [ARM][clang] Add back branch protection tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG53154a83aee0: [ARM][clang] Add back branch protection tests (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115141/new/

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. Hi Simon, i am seeing a failure in our amdgpu buildbot after this patch . https://lab.llvm.org/staging/#/builders/200/builds/1407 we do depend on the cmake flag you removed. we specify this -DCLANG_DEFAULT_LINKER=lld FAILED:

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

This revision was automatically updated to reflect the committed changes. Closed by commit rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the… (authored by jamesfarrell). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5032467 - Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after par

Author: James Farrell Date: 2021-12-06T14:57:47Z New Revision: 50324670342d9391f62671685f4d6b4880a4ea9a URL: https://github.com/llvm/llvm-project/commit/50324670342d9391f62671685f4d6b4880a4ea9a DIFF: https://github.com/llvm/llvm-project/commit/50324670342d9391f62671685f4d6b4880a4ea9a.diff

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:75 - auto HandleTemporaryCXXStaticCastExpr = makeRule( - cxxStaticCastExpr( - hasSourceExpression(StringViewConstructingFromNullExpr)), -

  1   2   >