[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 393048. MyDeveloperDay added a comment. Add more unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files: clang/lib/Format/FormatToken.cpp clang/lib/Format/FormatToken.h

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG320e4efe99d3: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu added a comment. Thanks for reviewing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115219/new/ https://reviews.llvm.org/D115219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu updated this revision to Diff 393039. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115219/new/ https://reviews.llvm.org/D115219 Files: llvm/docs/Coroutines.rst llvm/lib/Transforms/Coroutines/CoroSplit.cpp

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. In D114505#3181637 , @dexonsmith wrote: > LGTM. Sorry for missing this before. Looks to me like the debian build > failure above is unrelated. > > If you need someone to commit for you, please include the info for >

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. Thanks, @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

This revision was automatically updated to reflect the committed changes. Closed by commit rG352e36e10d2c: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 352e36e - [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

Author: Chuanqi Xu Date: 2021-12-09T14:40:25+08:00 New Revision: 352e36e10d2cff310cacfc98aab39d508682e61d URL: https://github.com/llvm/llvm-project/commit/352e36e10d2cff310cacfc98aab39d508682e61d DIFF: https://github.com/llvm/llvm-project/commit/352e36e10d2cff310cacfc98aab39d508682e61d.diff

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 393030. ChuanqiXu added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. The idea is to reduce the number of places

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 393028. ChuanqiXu added a comment. Update comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Sema/Sema.h clang/lib/AST/Decl.cpp

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 393027. ChuanqiXu added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Sema/Sema.h clang/lib/AST/Decl.cpp

[clang] 9791b58 - [C++20 Modules] Don't create global module fragment for extern linkage declaration in GMF already

Author: Chuanqi Xu Date: 2021-12-09T13:55:15+08:00 New Revision: 9791b589516b644a6273607b46a9c6661993d667 URL: https://github.com/llvm/llvm-project/commit/9791b589516b644a6273607b46a9c6661993d667 DIFF: https://github.com/llvm/llvm-project/commit/9791b589516b644a6273607b46a9c6661993d667.diff

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/include/llvm/ProfileData/InstrProfWriter.h:48 public: - InstrProfWriter(bool Sparse = false, bool InstrEntryBBEnabled = false);

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

pengfei added inline comments. Comment at: llvm/test/Verifier/callbr.ll:42 + callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "i,X,i"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8* blockaddress(@test3, %3)) to label %1 [label %3, label %4] 1:

[PATCH] D115199: [WIP][X86][AMX] Support amxpreserve attribute in clang.

LuoYuanke updated this revision to Diff 393012. LuoYuanke added a comment. Herald added a subscriber: martong. Updating D115199 : [WIP][X86][AMX] Support amxpreserve attribute in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, but I came across it pretty quickly; might be worth leaving for a couple of days in case someone else has comments. CHANGES SINCE LAST ACTION

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added a comment. In D115374#3181670 , @logan-5 wrote: > To be clear, it sounds like we should //either// add `.take()` for moving the > string out of `raw_string_ostream`'s string reference, //or// make > `raw_string_ostream` not need to be

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added a comment. To be clear, it sounds like we should //either// add `.take()` for moving the string out of `raw_string_ostream`'s string reference, //or// make `raw_string_ostream` not need to be flushed (after which there won't be as clear a use for `.take()`, since you can just use

[PATCH] D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands

arphaman created this revision. arphaman added reviewers: ravikandhadai, dexonsmith, steven_wu. Herald added subscribers: dang, ributzka, hiraditya. arphaman requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This patch extends clang frontend

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Sorry for missing this before. Looks to me like the debian build failure above is unrelated. If you need someone to commit for you, please include the info for GIT_AUTHOR_NAME

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23 +; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1 +; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch @craig.topper can you triple check this change to

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 393001. nickdesaulniers added a comment. - try to update this correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115311/new/ https://reviews.llvm.org/D115311 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8556 unsigned ResNo = 0; // ResNo - The result number of the next output. - unsigned NumMatchingOps = 0; for (auto

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers added inline comments. Comment at: llvm/test/Verifier/callbr.ll:41 ; the asm goto is in the arg list to the asm). - callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "X,X,X"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8*

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; sorry for missing this previously! (I'd have been happy for you to commit this without review, BTW, since it seems a bit obvious, but no excuse of course for me being slow...)

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added a comment. In D115374#3181491 , @logan-5 wrote: > In D115374#3181383 , @dexonsmith > wrote: > >> I don't feel strongly, but IMO the code might be a bit harder to >> read/maintain with the 

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 updated this revision to Diff 392996. logan-5 added a comment. Eliminate some explicit `.flush()`es by using temporary `raw_string_ostream`s where possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115374/new/

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

NoQ added a comment. Like, that's the whole reason why `nonloc::LocAsInteger` exists: so that we could cast a pointer to an integer and actually have a way to represent the resulting value as `NonLoc`. I'm confident that there's a way to get it right, simply because the program under analysis

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392994. nickdesaulniers added a comment. - phab sux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115409/new/ https://reviews.llvm.org/D115409 Files:

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 392993. nickdesaulniers added a comment. - phab sux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files: llvm/test/Assembler/call-arg-is-callee.ll

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 392990. nickdesaulniers added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files: llvm/test/Assembler/call-arg-is-callee.ll

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

NoQ added a comment. > There is the reinterpret-cast operation which is capable of crossing these > two domains, producing an expression that can participate in arithmetic > operations, but on the abstract domain side, we still stick to Locs Such cast should turn the `loc::ConcreteInt` into a

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392988. nickdesaulniers added a comment. Herald added subscribers: cfe-commits, wenlei, asbirlea, zzheng, kbarton, nemanjai. Herald added a project: clang. - I'm just wrestling with arc at this point Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 392984. nickdesaulniers retitled this revision from "[WIP] alternative approach to D114895" to "[clang][CGStmt] emit i constraint rather than X for asm goto indirect dests". nickdesaulniers edited the summary of this revision. nickdesaulniers added a

[PATCH] D115311: [WIP] alternative approach to D114895

nickdesaulniers updated this revision to Diff 392983. nickdesaulniers added a comment. Herald added subscribers: llvm-commits, pengfei, hiraditya. Herald added a project: LLVM. - write an actual commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers created this revision. Herald added subscribers: wenlei, pengfei, asbirlea, zzheng, kbarton, hiraditya, nemanjai. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In D115311

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added a comment. In D115374#3181383 , @dexonsmith wrote: > I don't feel strongly, but IMO the code might be a bit harder to > read/maintain with the explicit flush. I worry that it'd be easy to move the > `flush()` away from the `return`. Not

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. Sure, adding an option is easy, if that's the consensus. What would you call it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

dexonsmith added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:623 - Decls.set_size(N); + Decls.truncate(N); Two things to confirm here. First is that the destructors are trivial. From clang/include/clang/AST/DeclAccessPair.h: ``` lang=c++

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

dexonsmith updated this revision to Diff 392977. dexonsmith added reviewers: Bigcheese, jansvoboda11, vsapsai. dexonsmith added a comment. Adding a couple of other possible reviewers. [no change, just retriggering bots after spurious failure] CHANGES SINCE LAST ACTION

LLVM build master will be offline for 1 hr for maintenance

Hello everyone, LLVM Lab along with the both production and staging build bots will be offline for about 1 hrs starting at 7:00 PM PST for maintenance. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h:36 +OS.flush(); +return Str; } logan-5 wrote: > Quuxplusone wrote: > > FWIW, it appears to me that in most (all?) of these cases, what's really

[PATCH] D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path

Ericson2314 accepted this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Looks good. Thanks for fixing this for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115403/new/ https://reviews.llvm.org/D115403

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added a comment. I don't feel strongly, but IMO the code might be a bit harder to read/maintain with the explicit flush. I worry that it'd be easy to move the `flush()` away from the `return`. Not sure I'm right; could just be familiarity with `str()`. Have you considered other

[PATCH] D115332: [clang][deps] Use lock_guard instead of unique_lock

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115332/new/ https://reviews.llvm.org/D115332

[PATCH] D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path

arphaman created this revision. arphaman added reviewers: bro4all, Ericson2314, ravikandhadai. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. Compiler-rt started emitting the macho_embedded libraries in /lib/darwin/macho_embedded

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd1d49dc0cc: OpenMP: Avoid using SmallVector::set_size() (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] cfd1d49 - OpenMP: Avoid using SmallVector::set_size()

Author: Duncan P. N. Exon Smith Date: 2021-12-08T15:22:50-08:00 New Revision: cfd1d49dc0cc4369ace2e9485bdba04b27f158b5 URL: https://github.com/llvm/llvm-project/commit/cfd1d49dc0cc4369ace2e9485bdba04b27f158b5 DIFF:

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

Meinersbur accepted this revision. Meinersbur added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115378/new/ https://reviews.llvm.org/D115378 ___ cfe-commits mailing list

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

dexonsmith added a comment. This looks really nice. One problem is that it's subtle to confirm whether it's thread-safe. The local cache access parts of CachedFileSystemEntry lock-free, but the CachedFileSystemEntry might get changed later (i.e., filled in with minimized content). Are

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:31 +/// states of its predecessor basic blocks. +TypeErasedDataflowAnalysisState computeBlockInputState( +std::vector> , should this be declared in the

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:93 - virtual bool isIRLevelProfile() const = 0; - tejohnson wrote: > It seems like these helper methods could still be defined using the new > bitset, which would

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392938. snehasish added a comment. Remove extra line in PGOInstrumentation.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files:

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392937. snehasish added a comment. Reintroduce the helpers while keeping the bitset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files:

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

JonChesterfield added a comment. Not exactly that. The weak symbol isn't the function name, as that gets renamed or inlined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/ https://reviews.llvm.org/D115283

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added a comment. In D115283#3180836 , @yaxunl wrote: > If we only need to check whether `__ockl_hostcall_internal` exists in the > final module in LLVM codegen to determine whether we need the hostcall > metadata, probably we don't even need a

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. > Thanks! Do you need someone to commit on your behalf? If so, what name and > email address would you like used for patch attribution? That would be great, thanks! You can use "Paul Altin " for the attribution. > We're definitely happy to consider these kinds of

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

JonChesterfield added a comment. Openmp defines a weak symbol in the hostcall_invoke function. Optimisation and deadstripping friendly, no compiler support necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115378/new/ https://reviews.llvm.org/D115378

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

tejohnson added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:93 - virtual bool isIRLevelProfile() const = 0; - It seems like these helper methods could still be defined using the new bitset, which would reduce some of the code

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392927. snehasish added a comment. Cleanup for review - - Added some more descriptive comments. - Removed a couple of unintentional blank lines. - Removed a couple of commented lines of code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h:36 +OS.flush(); +return Str; } Quuxplusone wrote: > FWIW, it appears to me that in most (all?) of these cases, what's really > wanted is not "a

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish created this revision. snehasish added reviewers: xur, davidxl. Herald added subscribers: wenlei, hiraditya. snehasish requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change refactors the ProfileKind enum

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

yaxunl added a comment. If we only need to check whether `__ockl_hostcall_internal` exists in the final module in LLVM codegen to determine whether we need the hostcall metadata, probably we don't even need a function attribute or even module flag. Repository: rG LLVM Github Monorepo

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

Quuxplusone added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h:36 +OS.flush(); +return Str; } FWIW, it appears to me that in most (all?) of these cases, what's really wanted is not "a string //and// a

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

dexonsmith created this revision. dexonsmith added a reviewer: dblaikie. dexonsmith requested review of this revision. Herald added a project: clang. Update UnresolvedSet to use (and expose) `SmallVector::truncate()` instead of `SmallVector::set_size()`. The latter is going to made private in a

Re: RFC: proposing to relax standardization requirements for Clang extensions

On Tue, 7 Dec 2021 at 13:22, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tl;dr: our Clang "get involved" page implies that proposed extensions > to Clang must also be proposed to a standards committee > (https://clang.llvm.org/get_involved.html#criteria). This is a good >

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:48 + << std::declval())> +std::ostream <<(std::ostream , + const DataflowAnalysisState ) { This would also

[PATCH] D115379: ASTMatchers: Avoid using SmallVector::set_size()

dexonsmith created this revision. dexonsmith added reviewers: njames93, aaron.ballman. dexonsmith requested review of this revision. Herald added a project: clang. Update `variadicMatcherDescriptor` to assert on reserved capacity and to call `emplace_back()` instead of calling `set_size()` and

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

dexonsmith created this revision. dexonsmith added a reviewer: Meinersbur. Herald added subscribers: guansong, hiraditya, yaxunl. dexonsmith requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. Update

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added reviewers: aaron.ballman, whisperity, alexfh, malcolm.parsons. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. Adding some additional reviewers. At a high level, I think this is a reasonable direction to go, but I wonder if this should be hidden behind a

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 created this revision. logan-5 added a reviewer: aaron.ballman. logan-5 added a project: clang. Herald added subscribers: abrachet, ctetreau, dexonsmith, martong. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. Returning `OS.str()` is guaranteed to copy

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

aaron.ballman added a comment. In D115106#3172949 , @simon.giesecke wrote: > Thanks a lot for addressing this issue! I am just trying it on our codebase. > >> The problem actually has nothing to do with the out-of-line definition being >> inline; the

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392865. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield added a comment. @aaron.ballman Look to you like this is ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 ___ cfe-commits mailing list

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2116 + + // __builtin_reduce_xor restricts the element type to vector of integers type + // only. nit: the element type will be restricted to `int`, so maybe say something like `only

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor suggestion in the docs, but otherwise LGTM. Comment at: llvm/docs/Coroutines.rst:1382 +The `coro.end` intrinsic in the normal path wouldn't do this since the

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, that's fine, I have no objection to removing it. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115222/new/

[PATCH] D113638: [xray] Add support for hexagon architecture

kparzysz accepted this revision. kparzysz added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir added a comment. In D115320#3178682 , @jeroen.dobbelaere wrote: > Do you have a testcase ? Thank you for the review. Please take a look at the new diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir updated this revision to Diff 392840. schittir added a subscriber: mikerice. schittir added a comment. Add test case Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 392835. vtjnash added a comment. fix cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 392830. mbenfield added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 Files: clang/include/clang/Basic/Attr.td

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the fix and your patience with getting it landed! I've commit on your behalf in 5d3b8956e83484ff7234dda5e939abbdc9bd2c88 Repository: rG LLVM

[clang-tools-extra] 5d3b895 - Don't offer partial fix-its for `modernize-pass-by-value`

Author: Adrian Vogelsgesang Date: 2021-12-08T13:31:30-05:00 New Revision: 5d3b8956e83484ff7234dda5e939abbdc9bd2c88 URL: https://github.com/llvm/llvm-project/commit/5d3b8956e83484ff7234dda5e939abbdc9bd2c88 DIFF:

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:201-202 + case EST_BasicNoexcept: + case EST_DependentNoexcept: // Let's be optimistic here (necessary e.g. + // for variant

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. It seems like your test file passes even before your patch. I've just checked it. My last pull from the baseline was on Nov 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115149/new/

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

avogelsgesang added a comment. > What name and email address would you like me to use for patch attribution? Adrian Vogelsgesang, avogelsges...@salesforce.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, except I'd prefer the `#include`s be changed separately since that cleanup seems unrelated to this change. Comment at:

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman added a comment. In D112648#3165302 , @avogelsgesang wrote: > @aaron.ballman can you please commit this on my behalf? I don't have commit > access OMG, I'm sorry for missing this note! Yes, I'm happy to commit on your behalf. What name

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 392821. ASDenysPetrov added a comment. Improved dynamic type recognition. Provided `-fstrict-aliasing` compiler flag dependency. Still has issues with some cases (see it at the bottom of the test file). WIP. CHANGES SINCE LAST ACTION

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added a comment. In D115283#3179651 , @yaxunl wrote: > One drawback of this approach is that it does not work for LLVM modules > generated from assembly or programmatically e.g. Tensorflow XLA. > > Another drawback is that if

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:35 +TypeErasedDataflowAnalysis ) { + TypeErasedDataflowAnalysisState State = {Analysis.typeErasedInitialElement(), +

Re: TCE target nonconforming definition of long long and intmax_t

Hi Aaron, Indeed the 32b TCE target is not fully compliant in this aspect; its 64b emulation support is not complete, therefore we advertise only these 32b limits. We have an in-progress 64b target where the limits are 64b, but it's not upstreamed yet. Yes, TCE target is still maintained, but

  1   2   >