[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

FreddyYe created this revision. Herald added a subscriber: pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The name `__bfloat` may mislead its real type is bfloat16, but in fact it's not. Repository: rG LLVM Github

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Thanks for fixing this. LGTM. Please wait for @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Esme wrote: > dblaikie wrote: > > shchenz wrote: > > > Will we generate a redundant flag if we define a private type in the > > > class or a public

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: dblaikie wrote: > shchenz wrote: > > Will we generate a redundant flag if we define a private type in the class > > or a public type in the

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393805. Esme added a comment. Add a case to show that the default access flag is not recorded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/ https://reviews.llvm.org/D115503 Files:

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, erichkeane, hubert.reinterpretcast. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Since the serialization code would recognize

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: shchenz wrote: > Will we generate a redundant flag if we define a private type in the class or > a public type in the struct/union? Maybe we could

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

joerg added a comment. Last update introduced a lot of unrelated changes? But the actual intended change seems fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. Thanks @mstorsjo for the inputs. > However outside of the core OS, any function in the CRT, that uses long > doubles, is going to be wrong Good point! I didn't think much on the CRT library. But I think this is not a blocking issue, given 1. The option is off by

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Will we generate a redundant flag if we define a private type in the class or a public type in the struct/union? Maybe we could add a case for that

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

zixuan-wu added a subscriber: pcwang-thead. zixuan-wu added a comment. In D70401#3175266 , @khchen wrote: >> Is it (D70401 ) good enough to solve or >> complete rv32e issue? > > It need to > > 1. disallow ilp32e ABI with

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393789. Esme retitled this revision from "[DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types." to "[DebugInfo][Clang] record the access flag for class/struct/union types.". Esme added a comment. Thanks! @dblaikie Separate into Clang

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

Luhaocong updated this revision to Diff 393788. Luhaocong added a comment. re-upload with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llvm.org/D115430 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

kito-cheng added a comment. Could you re-upload diff with full context? You can create that via `git format-patch -1 -U999` or `git diff -U99 > mypatch.patch`. [1] https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393785. jackoalan added a comment. Test coverage for more than one `<@>` per arg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 393782. MaskRay retitled this revision from "[Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie" to "[Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie". MaskRay edited the summary of this revision. MaskRay added a

[clang] 5fadb39 - [Driver][test] Make some tests work with CLANG_DEFAULT_PIE_ON_LINUX=on

Author: Fangrui Song Date: 2021-12-12T16:28:33-08:00 New Revision: 5fadb39e9bc2ceb8bd887b174fc73647920caf79 URL: https://github.com/llvm/llvm-project/commit/5fadb39e9bc2ceb8bd887b174fc73647920caf79 DIFF: https://github.com/llvm/llvm-project/commit/5fadb39e9bc2ceb8bd887b174fc73647920caf79.diff

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay added inline comments. Comment at: clang/CMakeLists.txt:230 +option(CLANG_DEFAULT_PIE "Default to -fPIE and -pie (Linux only)" OFF) +if(CLANG_DEFAULT_PIE) joerg wrote: > This option should really be called something like CLANG_DEFAULT_PIE_ON_LINUX >

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393781. jackoalan added a comment. Fix ResponseFiles test for Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files: clang/docs/UsersManual.rst

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393777. jackoalan added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add entry to user manual explaining the `<@>` token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

mgorny added a comment. This change causes a test regression on Gentoo (where `CLANG_RESOURCE_DIR="../../../../lib/clang/${clang_version}"`): FAIL: Clang :: ClangScanDeps/resource_directory.c (1961 of 29550) TEST 'Clang :: ClangScanDeps/resource_directory.c' FAILED

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

mstorsjo added a comment. In D115441#3187009 , @rnk wrote: > I seem to recall assuming that Windows `long double` was 64-bits in many, > many places. Unfortunately, I have no idea where that could've happened. Nothing comes to mind for me about that -

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG05bea533d1fc: [clang-format] [PR49298] Sort includes pass will sort inside raw strings (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 05bea53 - [clang-format] [PR49298] Sort includes pass will sort inside raw strings

Author: mydeveloperday Date: 2021-12-12T17:00:43Z New Revision: 05bea533d1fc1bcd63ccb84df9d0edab9701ad70 URL: https://github.com/llvm/llvm-project/commit/05bea533d1fc1bcd63ccb84df9d0edab9701ad70 DIFF: https://github.com/llvm/llvm-project/commit/05bea533d1fc1bcd63ccb84df9d0edab9701ad70.diff

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 393750. clemenswasser added a comment. Herald added subscribers: luke957, s.egerton, simoncook. Implement ProcessGlobalRegions Fix Interceptors for Windows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/