[PATCH] D115673: [clang-format] C# switch expression formatting differs from normal switch formatting

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. AFAIK (which is very limited when it comes to C#), the cases can have also other expressions, not only ints and _. But that can be left for a different patch. Example from

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

FreddyYe abandoned this revision. FreddyYe added a comment. agree with @pengfei . sorry for noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115611/new/ https://reviews.llvm.org/D115611 ___

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks, @yaxunl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

pengfei requested changes to this revision. pengfei added a comment. This revision now requires changes to proceed. I would suggest we drop the change. Sorry for my fickleness :( Comment at: clang/lib/Headers/avx512bf16intrin.h:32 /// \param __A ///A bfloat data. ///

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115611/new/ https://reviews.llvm.org/D115611 ___

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

FreddyYe updated this revision to Diff 394137. FreddyYe added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115611/new/ https://reviews.llvm.org/D115611 Files: clang/lib/Headers/avx512bf16intrin.h

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

FreddyYe updated this revision to Diff 394134. FreddyYe added a comment. changed into `unsigned short` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115611/new/ https://reviews.llvm.org/D115611 Files: clang/lib/Headers/avx512bf16intrin.h

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3188302 , @dblaikie wrote: > Got any data on how much this (combined with the LLVM patch) increases debug > info size of, say, a clang self-host build? I assume not much, but wouldn't > hurt to know. Before: $ size

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23 +; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1 +; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch nickdesaulniers wrote: > @craig.topper can you triple

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added a comment. @qiucf, fyi, have vacation until January. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/D109751 ___ cfe-commits mailing list

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added a comment. In D109751#3178494 , @qiucf wrote: > Thanks for the reminder. Here GCC and Clang diverges in the handling of > `__ibm128`/`__float128` and `long double`. Not sure whether GCC will 'fix' > the behavior, but here

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

pengfei added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return)) + callbr void asm sideeffect "",

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis edited the summary of this revision. ellis added reviewers: kyulee, alanphipps, MaskRay, wenlei, davidxl. ellis updated this revision to Diff 394121. ellis added a comment. ellis published this revision for

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tyb0807 updated this revision to Diff 394120. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 Files:

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134 "maximum!"); + assert(RVVVectorBitsMin >= ZvlLen && + "Minimum V extension vector length should be at least the length " eopXD wrote: > eopXD wrote: > >

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394119. eopXD marked 8 inline comments as done. eopXD added a comment. Rebase and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tyb0807 updated this revision to Diff 394116. tyb0807 added a comment. Allow linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tyb0807 created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. tyb0807 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This commit should contain all the necessary boilerplate to make the

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

tejohnson added inline comments. Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:241 +// to be unreachable; if it returns false, `F` might still +// be unreachble but not covered by this helper function. +static bool mustBeUnreachableFunction(const Function ) {

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3190788 , @Quuxplusone wrote: > Am I seeing correctly that there's no feature-test macro for `auto(x)`? Oh, no, there isn't, and there wasn't a `__cpp_auto` either. I'll open a core issue. > I basically have to

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782 +if (IsZvlExt) { + ExtName.consume_back("b"); + unsigned ZvlLen; craig.topper wrote: > craig.topper wrote: > > I think we should check the return value from consume_back

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782 +if (IsZvlExt) { + ExtName.consume_back("b"); + unsigned ZvlLen; craig.topper wrote: > I think we should check the return value from consume_back and getAsInteger

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc809da7d9ce7: Revert [InstrProf] Attach debug info to counters

[clang] c809da7 - Revert "[InstrProf] Attach debug info to counters"

Author: Ellis Hoag Date: 2021-12-13T18:15:17-08:00 New Revision: c809da7d9ce78a463f9c5e38a9bf7b4c22b232de URL: https://github.com/llvm/llvm-project/commit/c809da7d9ce78a463f9c5e38a9bf7b4c22b232de DIFF: https://github.com/llvm/llvm-project/commit/c809da7d9ce78a463f9c5e38a9bf7b4c22b232de.diff

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This reverts commit 800bf8ed29fbcaa9436540e83bc119ec92e7d40f

[clang] 800bf8e - [InstrProf] Attach debug info to counters

Author: Ellis Hoag Date: 2021-12-13T17:51:22-08:00 New Revision: 800bf8ed29fbcaa9436540e83bc119ec92e7d40f URL: https://github.com/llvm/llvm-project/commit/800bf8ed29fbcaa9436540e83bc119ec92e7d40f DIFF: https://github.com/llvm/llvm-project/commit/800bf8ed29fbcaa9436540e83bc119ec92e7d40f.diff

[PATCH] D114565: [InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG800bf8ed29fb: [InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

jfb added a comment. In D115440#3183778 , @melver wrote: > GCC devs say that initializing explicit alloca() is a bug, because they > aren't "automatic storage": > https://lkml.kernel.org/r/20211209201616.gu...@gate.crashing.org > .. which is also the

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394097. ellis added a comment. Rebase and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128

[PATCH] D115387: [instcombine] Canonicalize constant index type to i64 for extractelement/insertelement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ad9ef4e7ae: [instcombine] Canonicalize constant index type to i64 for… (authored by reames). Herald added subscribers: cfe-commits, kerbowa,

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

Quuxplusone added a comment. Am I seeing correctly that there's no feature-test macro for `auto(x)`? I'm proposing to introduce `#define _LIBCPP_AUTO_CAST(expr)` into libc++, so that we can use it for Ranges things that specify in terms of `auto(x)`... but if I want to make it conditionally

[PATCH] D115685: [NFC] Fix typos in release notes

MaskRay accepted this revision. MaskRay added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115685/new/ https://reviews.llvm.org/D115685 ___ cfe-commits mailing list

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd762c3d905ba: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic… (authored by tianshilei1992). Repository: rG LLVM

[clang] d762c3d - [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

Author: Shilei Tian Date: 2021-12-13T19:18:28-05:00 New Revision: d762c3d905baf18d0f17a24799c9c4517b3c95fa URL: https://github.com/llvm/llvm-project/commit/d762c3d905baf18d0f17a24799c9c4517b3c95fa DIFF: https://github.com/llvm/llvm-project/commit/d762c3d905baf18d0f17a24799c9c4517b3c95fa.diff

[PATCH] D115685: [NFC] Fix typos in release notes

STL_MSFT created this revision. STL_MSFT added reviewers: ldionne, Mordante, EricWF, mclow.lists. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. STL_MSFT requested review of this revision. Herald added projects: clang, libc++, clang-tools-extra. Herald added subscribers:

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

nridge added a comment. In D115425#3190698 , @sammccall wrote: >> there's perhaps a matter of principle where clangd should try to avoid using >> code patterns (here, non-self-contained files) in its implementation code >> that it does not support > >

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2915 case BO_EQ: -Result = (LHSValue == RHSValue); +Result = -(LHSValue == RHSValue); break; craig.topper wrote: > craig.topper wrote: > > erichkeane wrote: > > >

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

sammccall added a comment. That bothers me too. I'm sure it's possible to factor the generated files so that they're self-contained, I didn't work hard on that yet. So I don't think it's central to the question. > there's perhaps a matter of principle where clangd should try to avoid using >

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

nridge added a comment. In D115425#3190603 , @sammccall wrote: > I had a discussion with @kadircet about this, we're not sure whether it > factors out enough to be better/simpler overall. (Hand-written ConfigFragment > + ConfigYAML + docs, vs table +

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

jyknight added inline comments. Comment at: llvm/test/Verifier/callbr.ll:42 + callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "i,X,i"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8* blockaddress(@test3, %3)) to label %1 [label %3, label %4] 1:

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:185-189 + const FormatToken *Previous = AnnotatedLines[StartLineIndex - 1]->Last; + while (Previous && Previous->is(tok::comment)) { +Previous = Previous->Previous; +

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman updated this revision to Diff 394065. dgoldman added a comment. Minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115679/new/ https://reviews.llvm.org/D115679 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

jyknight added a comment. This looks reasonable to me, but I'd like to wait for a conclusion on D115409 first. (Which probably will result in rewriting the commit message, as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

sammccall added a comment. In D115425#3190418 , @nridge wrote: > The patch is failing to build for me locally, with > `clang-tools-extra/clangd/ConfigFragment.h:100:10: fatal error: > 'ConfigFragment.gen.h' file not found`. I did re-run cmake and the

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

jyknight added a comment. This looks good to me, but I'd like to wait for a conclusion on D115409 first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

jyknight added a comment. OK, I do think that special case definitely needs to be deleted. It's assuming that the block args are in a particular place in the argument list of the callbr -- the place Clang put them -- and then assigned special behavior based on that location. But I think it

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This currently isn't used by anything, but will be used by

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1327f8a574a: [clang][amdgpu] - Choose when to promote VarDecl

[clang] d1327f8 - [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

Author: Ethan Stewart Date: 2021-12-13T16:31:24-06:00 New Revision: d1327f8a574a0936f462387778adf0dfc14358f6 URL: https://github.com/llvm/llvm-project/commit/d1327f8a574a0936f462387778adf0dfc14358f6 DIFF: https://github.com/llvm/llvm-project/commit/d1327f8a574a0936f462387778adf0dfc14358f6.diff

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2915 case BO_EQ: -Result = (LHSValue == RHSValue); +Result = -(LHSValue == RHSValue); break; craig.topper wrote: > erichkeane wrote: > > efriedma wrote: > > > Using

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2915 case BO_EQ: -Result = (LHSValue == RHSValue); +Result = -(LHSValue == RHSValue); break; erichkeane wrote: > efriedma wrote: > > Using "operator=" to assign an int

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai planned changes to this revision. vsapsai added a comment. In discussions outside of this review the consensus is that "warning: ambiguous use of internal linkage declaration" is correct, so I won't change anything for C++. For Objective-C I still need to find a way to handle anonymous

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. This may cause perf regressions for HIP. Comment at: clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp:10 // X86: @_ZN1A3FooE ={{.*}} constant i32 123, align 4 -//

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd0b00b5c60d: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport (authored by mgorny). Herald added a project: clang. Repository:

[clang] fd0b00b - [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

Author: Michał Górny Date: 2021-12-13T23:00:31+01:00 New Revision: fd0b00b5c60dcee1ac60e6121571e251fb242e63 URL: https://github.com/llvm/llvm-project/commit/fd0b00b5c60dcee1ac60e6121571e251fb242e63 DIFF: https://github.com/llvm/llvm-project/commit/fd0b00b5c60dcee1ac60e6121571e251fb242e63.diff

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

mgorny added a comment. Thanks! Done and merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115580/new/ https://reviews.llvm.org/D115580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:157 ABI stability. +- When using ``asm goto`` with outputs whose constraint modifier is ``"+"``, we + now change the numbering of the labels to occur after hidden tied inputs for

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. That sounds good here. Infer addrspaces is pretty complicated, given marginal benefit for (4) this patch seems to hit the mark. Repository: rG LLVM Github Monorepo

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

tianshilei1992 updated this revision to Diff 394050. tianshilei1992 added a comment. add all other clauses supported by `atomic` to fix assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115586/new/ https://reviews.llvm.org/D115586 Files:

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added a comment. To add: I DID just try to fix that thing: [ekeane1@scsel-clx-24 clang]$ git diff diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 2b69c3727852..330772d2b10a 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++

[PATCH] D115625: [clang-format] add support for cppm files

rsmith added a comment. FWIW, Clang also supports `.ccm`, `.cxxm`, and `.c++m`. See https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Types.cpp#L273 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115625/new/ https://reviews.llvm.org/D115625

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

nridge added a comment. The patch is failing to build for me locally, with `clang-tools-extra/clangd/ConfigFragment.h:100:10: fatal error: 'ConfigFragment.gen.h' file not found`. I did re-run cmake and the error persists. Is there another step I'm missing? Repository: rG LLVM Github

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 394046. arnamoy10 added a comment. Thanks @Meinersbur for the comments. Addressing reviewers comments: 1. Update code to make the matadata addition correct, as per reviewers comments. 2. Using `LoopInfo` to identify BasicBlocks to iterate through. 3.

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Please update the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115580/new/ https://reviews.llvm.org/D115580

[PATCH] D115673: [clang-format] C# switch expression formatting differs from normal switch formatting

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, jbcoe. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/52677 clang-format doesn't format C# switch

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2915 case BO_EQ: -Result = (LHSValue == RHSValue); +Result = -(LHSValue == RHSValue); break; efriedma wrote: > Using "operator=" to assign an int to an APInt is going to

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

ayermolo added a comment. @modocache Just checking is this diff abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 ___ cfe-commits mailing list

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

tianshilei1992 reopened this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Reopen to resolve build error reported by build bolt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115586/new/

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3190324 , @JonChesterfield wrote: > Patch looks ok to me. This will fix the miscompile (we end up with a store to > addrspace(4) at present) without upsetting whatever hacks rely on > addrspace(4). @arsenm reasonable

[clang] d6449d0 - Revert "[NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive"

Author: Shilei Tian Date: 2021-12-13T16:31:04-05:00 New Revision: d6449d0d08222cbe0789cd67091f27d2061e7f9e URL: https://github.com/llvm/llvm-project/commit/d6449d0d08222cbe0789cd67091f27d2061e7f9e DIFF: https://github.com/llvm/llvm-project/commit/d6449d0d08222cbe0789cd67091f27d2061e7f9e.diff

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2915 case BO_EQ: -Result = (LHSValue == RHSValue); +Result = -(LHSValue == RHSValue); break; Using "operator=" to assign an int to an APInt is going to lead to

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

JonChesterfield added a comment. Patch looks ok to me. This will fix the miscompile (we end up with a store to addrspace(4) at present) without upsetting whatever hacks rely on addrspace(4). @arsenm reasonable as a point fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added a comment. Note I am adding the folks who were added as reviewers the last time I did vector constexpr work: https://reviews.llvm.org/D79755 I again looked into operator[] to simplify things, but the 'LValueBase' stuff (seemingly required to do something like: VecTy[3] = 1;)

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane created this revision. erichkeane added reviewers: RKSimon, aaron.ballman, void, efriedma. erichkeane requested review of this revision. All of our boolean operations on vector types should be using something like vcmpeqd, which results in a mask of '-1' for the 'truth' type. We are

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c23acbc023f: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic… (authored by tianshilei1992). Repository: rG LLVM

[clang] 5c23acb - [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

Author: Shilei Tian Date: 2021-12-13T16:20:10-05:00 New Revision: 5c23acbc023fbb9fdc6c56f4d2212ecb0432874e URL: https://github.com/llvm/llvm-project/commit/5c23acbc023fbb9fdc6c56f4d2212ecb0432874e DIFF: https://github.com/llvm/llvm-project/commit/5c23acbc023fbb9fdc6c56f4d2212ecb0432874e.diff

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

mgorny added a comment. Yes, I'm sorry, I meant libclang-cpp. FAILED: unittests/Basic/BasicTests : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -m32 -march=znver2 --param l1-cache-size=32 --param l1-cache-line-size=64 -O2 -pipe -frecord-gcc-switches -fPIC -fno-semantic-interposition

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

mikerice added a comment. Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp for the new clause or the flang build will fail. CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo updated this revision to Diff 394017. chrisdangelo added a comment. These changes allow the analyzer to silence an issue discovered by MallocChecker if the SymRef or Statement in question is of a struct that has been declared with the compiler attribute annotation

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

MaskRay added a comment. > in order to fix linking when building clang against libclang I am confused by building `clang against libclang`. libclang is the C library (`libclang.so` on ELF platforms). Do you mean `CLANG_LINK_CLANG_DYLIB` `libclang-cpp.so`? What's your cmake command line to

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 394015. MaskRay added a comment. Rename test/Driver/default-pie.c to linux-default-pie.c clang-format a region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115647/new/ https://reviews.llvm.org/D115647 ___ cfe-commits mailing list

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay added a comment. In D113372#3188178 , @joerg wrote: > Last update introduced a lot of unrelated changes? But the actual intended > change seems fine now. The last update just did a renaming. I have checked that changes are all intended.

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

MyDeveloperDay updated this revision to Diff 394010. MyDeveloperDay added a comment. Look backwards from the { rather than scanning the namespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115647/new/ https://reviews.llvm.org/D115647 Files:

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59 + // Namespace alias + if (Tok->isOneOf(tok::equal, tok::semi)) +return false; Should only be equal, right? Otherwise please add a test for

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3190041 , @arsenm wrote: > There's no real advantage to using addrspace(4) at all There are a few places where it's used as an optimization hint / as a crutch where we don't have a proper analysis. Fundamentally I

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. There's no real advantage to using addrspace(4) at all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115661/new/ https://reviews.llvm.org/D115661 ___ cfe-commits mailing list

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:714 void RISCVISAInfo::updateImplication() { + const StringMap> Implications = { + {"v", {"zvlsseg", "zvl128b"}}, I think I'd like to see this as a static data structure

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 updated this revision to Diff 394002. estewart08 added a comment. Resubmit patch with lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115661/new/ https://reviews.llvm.org/D115661 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 created this revision. estewart08 added a reviewer: JonChesterfield. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, kzhuravl. estewart08 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. There are instances where

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393994. luna added a comment. Add unit test for thinlto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 Files: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker marked 2 inline comments as done. collinbaker added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:500 + if (getTriple().isAndroid() && + getTriple().getEnvironmentName() != "android") { +llvm::outs() << getTriple().getEnvironmentName() <<

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 393978. collinbaker added a comment. - Address comments - Fix VEToolchain build error - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files:

[PATCH] D115248: [clang] Fix PR28101

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6485-6488 +if (getLangOpts().CPlusPlus && !D.getIdentifier() && +D.getName().getKind() == UnqualifiedIdKind::IK_TemplateId && +D.getContext() == DeclaratorContext::Member) +

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

curdeius added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:27 // Returns "" for anonymous namespace. -std::string computeName(const FormatToken *NamespaceTok) { +bool computeName(const FormatToken *NamespaceTok, std::string ) {

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128

  1   2   >