[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Thanks, @tra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394471. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. > GCC doesn't align fp80 long double to 16 bytes on i686, so I see no reason > for LLVM to do it. Is there some other compiler that you need ABI > compatibility with? Yes. ICC aligns long double to 16 bytes on 32bit Windows. (I mentioned it in the summary :). In

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna marked an inline comment as done. luna added a comment. thanks for the inputs! Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:16 + +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1 +

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394461. luna added a comment. Simplify filecheck by re-using one prefix to test the unreachable bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 Files:

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

owenpan added a reviewer: owenpan. owenpan added a comment. Can you add a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 ___ cfe-commits mailing

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3192840 , @dblaikie wrote: > Thanks for the data - looks good to me. Maybe include some of that data > (summary of total binary size change/total debug info size change - and if > you could include the flags (was this

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:16 + +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1 + I think it can be shared with the equivalent checks in

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:230 +// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s +// CHECK-V-MINVLEN: __riscv_v_min_vlen 128 frasercrmck wrote: > Are we able to test non-default values of

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394454. eopXD marked 3 inline comments as done. eopXD added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3189179 , @jdoerfert wrote: > All good but parser tests needed. Since we directly emit an error in Sema, I'm not sure if we can do the same thing as `clang/test/OpenMP/atomic_ast_print.cpp` because we can

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3190243 , @mikerice wrote: > Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp > for the new clause or the flang build will fail. > > CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare)

Re: [PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

On Tue, Dec 14, 2021 at 6:17 PM Richard Smith - zygoloid via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith added inline comments. > > > > Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 > +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > >

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb45ad7363c30: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3 (authored by thakis). Herald added a project: clang.

[clang] b45ad73 - [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

Author: Nico Weber Date: 2021-12-14T21:44:56-05:00 New Revision: b45ad7363c306e17422401f318cc243cb9fd99d4 URL: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4 DIFF: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4.diff

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, jyknight. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. See https://lists.llvm.org/pipermail/cfe-dev/2021-December/069608.html. We couldn't mark

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck %s --check-prefix=ENABLESPLITFLAG +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394443. luna marked an inline comment as done. luna added a comment. Simplify test by sharing one pattern across two filecheck lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna marked an inline comment as done. luna added a comment. thanks for review! Also in the previous reply, I forgot to mention I removed the the line `assert ((VTP.FuncVI) && "VTP.FuncVI must be nullptr` after finding existing references doesn't guarantee that [1], and

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck %s --check-prefix=ENABLESPLITFLAG +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}}

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394435. luna added a comment. Simplify test by using non-DAG prefix (for one pattern), and avoid capturing values since they are not used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with one more test simplification below. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added a comment. thanks for review! Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:64 +; Check that EnableSplitLTOUnit is off, and check the content of summary information. +; RUN: llvm-dis -o - %t3.o | FileCheck %s

[PATCH] D115692: [docs] Mark the support for coroutine as unreleased

ChuanqiXu added a comment. According to https://lists.llvm.org/pipermail/cfe-dev/2021-December/069607.html, it might be the time to mark it as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115692/new/ https://reviews.llvm.org/D115692

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394429. luna marked 2 inline comments as done. luna added a comment. Change test IR by removing irrelevant lines and using one prefix per FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a297fb9e: Avoid setting tbaa on the store of return type of call to inline assembler. (authored by schittir). Repository: rG LLVM Github

[clang] 4706a29 - Avoid setting tbaa on the store of return type of call to inline assembler.

Author: Sindhu Chittireddy Date: 2021-12-14T17:40:33-08:00 New Revision: 4706a297fb9ebe6af91ee2c92e5eb196dc2785f7 URL: https://github.com/llvm/llvm-project/commit/4706a297fb9ebe6af91ee2c92e5eb196dc2785f7 DIFF:

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

rsmith added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format

[clang-tools-extra] 6917f87 - [clangd] Cleanup unneeded use of shared_ptr. NFC

Author: Sam McCall Date: 2021-12-15T02:13:50+01:00 New Revision: 6917f87b3c7c3ea927f8834302a5e9c82fc40a9b URL: https://github.com/llvm/llvm-project/commit/6917f87b3c7c3ea927f8834302a5e9c82fc40a9b DIFF: https://github.com/llvm/llvm-project/commit/6917f87b3c7c3ea927f8834302a5e9c82fc40a9b.diff

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith created this revision. Andrew-William-Smith added reviewers: MyDeveloperDay, HazardyKnusperkeks, jbcoe. Andrew-William-Smith edited the summary of this revision. Andrew-William-Smith added a project: clang-format. Andrew-William-Smith retitled this revision from

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 394415. nickdesaulniers added a comment. - rebase onto D115688 +D115410 +D115311 , add notes to clang/docs/LanguageExtensions.rst Repository:

[PATCH] D114394: Compile-time computation of string attribute hashes

rnk added a comment. That's interesting, somehow clang spends 1% of its time for sqlite3 in attribute lookup. I wonder how we ended up doing so much string-based attribute lookup. These were not really ever intended to be used for anything semantically interesting for the middle end, they were

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 394406. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase onto D115688 + D115410 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo,

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 394403. nickdesaulniers added a comment. - rebase onto D115688 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files:

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:64 +; Check that EnableSplitLTOUnit is off, and check the content of summary information. +; RUN: llvm-dis -o - %t3.o | FileCheck %s --check-prefix=NOENABLESPLITFLAG +;

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. In D115409#3190589 , @jyknight wrote: > OK, I do think that special case definitely needs to be deleted. It's > assuming that the block args are in a particular place in the

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid planned changes to this revision. starsid added a comment. Thanks. I missed that in the comment thread. Will send back for review once ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. From earlier review comment: > Missing changes to run the unittests (test/builtins/Unit/) for the new > functions. That's the most important part, so we have some confidence the code actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3193431 , @yaxunl wrote: > What about situations of a derived pointer to the global variable? For example > > const int a[100] ; > > foo([50]); > > If we put a in addr space 4, it is easy to deduce [50] is

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true; I

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3193413 , @yaxunl wrote: > In D115661#3193157 , @arsenm wrote: > >> In D115661#3193152 , @yaxunl wrote: >> >>> In D115661#3192983

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394389. luna added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 Files: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3193157 , @arsenm wrote: > In D115661#3193152 , @yaxunl wrote: > >> In D115661#3192983 , @estewart08 >> wrote: >> >>> In

[PATCH] D115685: [NFC] Fix typos in release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd106a89172: [NFC] Fix typos in release notes. (authored by STL_MSFT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8bd106a - [NFC] Fix typos in release notes.

Author: Stephan T. Lavavej Date: 2021-12-14T14:19:42-08:00 New Revision: 8bd106a891726f6542c9364ff4041764a62aa2b7 URL: https://github.com/llvm/llvm-project/commit/8bd106a891726f6542c9364ff4041764a62aa2b7 DIFF:

[PATCH] D113917: Add infrastructure to support matcher names.

ymandel added a comment. Aaron - agreed on the points about `StringRef` vs `std::string`. But, before I make that change, what did you think of moving to a more general method `getMatcherSpec` that returns an object? That object will provide the name (for now) and other data in the future

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 added a comment. In D115661#3193157 , @arsenm wrote: > In D115661#3193152 , @yaxunl wrote: > >> In D115661#3192983 , @estewart08 >> wrote: >> >>> In

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo added a comment. Hi @aaron.ballman, It's nice to meet you, virtually. I've been working with @NoQ on this change. I've now removed the [wip] prefix. When you have some time, I'd appreciate your feedback. This change adds a new attribute "reference_counted". This attribute is

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo updated this revision to Diff 394374. chrisdangelo added a comment. Herald added a subscriber: jdoerfert. This change adds support for reference_counted attribute in pragma-attribute-supported-attributes-list. This change edits comments describing function signatures for

[clang] 1a60ae0 - [InstCombine] fold mask-with-signbit-splat to icmp+select

Author: Sanjay Patel Date: 2021-12-14T16:00:42-05:00 New Revision: 1a60ae02c65d26981017f59bc5918d3c2e363bfd URL: https://github.com/llvm/llvm-project/commit/1a60ae02c65d26981017f59bc5918d3c2e363bfd DIFF: https://github.com/llvm/llvm-project/commit/1a60ae02c65d26981017f59bc5918d3c2e363bfd.diff

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a comment. In D115441#3191482 , @pengfei wrote: > We have to change LLVM data layout because it's required by the calling > conversion. Is that necessary? It would be simpler to leave the fp80 value 4 byte aligned, which I believe is

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

JonChesterfield added a comment. Changing the has-constant-initialiser check to a more precise/robust one sounds reasonable to me. In D115661#3193157 , @arsenm wrote: > The backend also knows because the constant flag is set on the global > variable.

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 394353. Anastasia added a comment. Addressed review comments from Sven: - Improved docs and code comments; - Simplified tests; - Added warning in a group. - Aligned with translator PRs after merge. Note, that this change now references documentation from

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3193152 , @yaxunl wrote: > In D115661#3192983 , @estewart08 > wrote: > >> In D115661#3190477 , @yaxunl wrote: >> >>> This may cause

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3192983 , @estewart08 wrote: > In D115661#3190477 , @yaxunl wrote: > >> This may cause perf regressions for HIP. > > Do you have a test that would show such a regression?

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115751/new/ https://reviews.llvm.org/D115751 ___ cfe-commits mailing list

[PATCH] D113917: Add infrastructure to support matcher names.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:88 +/// can be useful for cases like debugging matchers. +template std::string makeMatcherNameFromType() { + return "Matcher"; ymandel wrote: > Please note

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394352. ychen added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394351. ychen added a comment. - Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09a704c5efba: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES

[clang] 09a704c - [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.

Author: Mingming Liu Date: 2021-12-14T20:18:04Z New Revision: 09a704c5efba2c07af5b457bf3afc5eb746f22c2 URL: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2 DIFF: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2.diff LOG:

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay added a comment. I tested this on the original code that made me make the original change, and I like your fix much better ;-) Thank you for this patch, interested on working on other C# clang-format issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

thakis created this revision. thakis added a reviewer: MaskRay. Herald added subscribers: mikhail.ramalho, mgorny. thakis requested review of this revision. See D28294 for context. https://reviews.llvm.org/D115751 Files: clang/test/CMakeLists.txt

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

dexonsmith added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:106-108 + std::unique_ptr OriginalContents; + std::unique_ptr MinimizedContents; PreprocessorSkippedRangeMapping PPSkippedRangeMapping;

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Lexer/pragma-message.c:14 #define STRING(x) STRING2(x) -#pragma message(":O I'm a message! " STRING(__LINE__)) // expected-warning

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

aaron.ballman added a comment. Thanks for the fix for this -- I think the changes look like they're correct, but the test coverage needs a bit of work. Comment at: clang/lib/Sema/SemaDecl.cpp:9191 << FixItHint::CreateInsertion(InsertLoc, "<>"); +

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 added a comment. In D115661#3190477 , @yaxunl wrote: > This may cause perf regressions for HIP. Do you have a test that would show such a regression? Emitting a store to address space (4) in a constructor seems the wrong thing to do.

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5f2d12cadc: [clang] diagnose_as_builtin attribute for Fortify diagnosing like builtins. (authored by mbenfield). Repository: rG LLVM Github

[clang] bc5f2d1 - [clang] diagnose_as_builtin attribute for Fortify diagnosing like builtins.

Author: Michael Benfield Date: 2021-12-14T19:42:23Z New Revision: bc5f2d12cadce765620efc56a1ca815221db47af URL: https://github.com/llvm/llvm-project/commit/bc5f2d12cadce765620efc56a1ca815221db47af DIFF: https://github.com/llvm/llvm-project/commit/bc5f2d12cadce765620efc56a1ca815221db47af.diff

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. Hi @aaron.ballman, does this make sense to you? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. ping:-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 394320. aaron.ballman added a comment. Updated based on review feedback. This protects all of the _WIDTH macros in stdint.h, which was a previous oversight. It also corrects the test case to actually test the scenario we care about (which requires

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added a comment. In D115503#3191156 , @Esme wrote: > In D115503#3188302 , @dblaikie > wrote: > >> Got any data on how much this (combined with the LLVM patch) increases debug >> info size of, say, a

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3191752 , @RKSimon wrote: > @rnk @stella.stamenova How long do you think it will be before you can update > your buildbots to VS2019 or VS2022 please? The mlir buildbot was updated already. The lldb buildbot

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__",

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94cba5b4e4: [HIPSPV][2/4] Add HIPSPV tool chain (authored by linjamaki, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4e94cba - [HIPSPV][2/4] Add HIPSPV tool chain

Author: Henry Linjamäki Date: 2021-12-14T10:22:38-08:00 New Revision: 4e94cba5b4e431794026085b89a34112b2d9ac0d URL: https://github.com/llvm/llvm-project/commit/4e94cba5b4e431794026085b89a34112b2d9ac0d DIFF:

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04192422c4e3: [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0419242 - [Clang][ScanDeps] Use the virtual path for module maps

Author: Michael Spencer Date: 2021-12-14T11:21:42-07:00 New Revision: 04192422c4e3b730c580498b8e948088cb15580b URL: https://github.com/llvm/llvm-project/commit/04192422c4e3b730c580498b8e948088cb15580b DIFF:

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1042de90589c: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie (authored by MaskRay). Changed prior to commit:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. In D108560#3192081 , @kadircet wrote: > Hi @salman-javed-nz ! > Also I am not sure what kind of timelines you have in mind for the > performance improvements, but I think it would be great to have them before > LLVM-14

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

peterstys updated this revision to Diff 394299. peterstys added a comment. Applied clang-formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. @martong wrote: > Denis, you can see in the `Revision Contents` that Diff 3 has the baseline > commit `63a6348`. When I check out `63a6348` then the newly added test file > triggers the assertion about `BO_Add`. Yes is see it: F21029827: image.png

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

jyknight added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__",

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added a comment. In D115715#3192085 , @aaron.ballman wrote: > It could be made to be useful outside of LLVM, but as it stands today, the > check is only intended to be useful for LLVM. If we want to make it useful > outside of LLVM,

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna added a comment. In D115492#3192624 , @tejohnson wrote: > lgtm after adding a description to test as noted below. Done. Thanks for review and feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394293. luna added a comment. Describe what the test case devirt_hybrid_after_filtering_unreachable.ll is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files:

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added a comment. In D115253#3192652 , @aaron.ballman wrote: > Updating based on off-list review feedback and adding a new reviewer. This added `DefineTypeSizeAndWidth()` as a helper for setting the `_MAX` and `_WIDTH` macros as a pair

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 394291. aaron.ballman added a reviewer: joerg. aaron.ballman added a comment. Updating based on off-list review feedback and adding a new reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.org/D115253

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 394290. ASDenysPetrov added a comment. Changed handler `check::` functions. Reworked. Covered more cases. Several cases left (marked as FIXME in the test file). For the glance some of them we can't handle because of (possibly) wrong symbolic modeling.

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm after adding a description to test as noted below. Comment at: llvm/test/ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll:1 +; Generate split module with

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394281. luna marked 2 inline comments as done. luna added a comment. Revise based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files:

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna marked 5 inline comments as done. luna added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:396 + } + // Identifies a function as unreachable if and only if + // 1) All summaries are live. tejohnson wrote: > Actually I think

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 ___ cfe-commits

[PATCH] D115685: [NFC] Fix typos in release notes

Mordante accepted this revision. Mordante added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115685/new/ https://reviews.llvm.org/D115685 ___ cfe-commits mailing list

  1   2   >