[PATCH] D115848: tidy-llvm

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Just use compilation database? https://github.com/llvm-mirror/clang-tools-extra/blob/1c8cadde7ea4ca20a449edcffe10d23b612fe5d6/clang-tidy/tool/run-clang-tidy.py#L100

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195955 , @ldionne wrote: > @tambre Any appetite for a libc++ patch? :) > > Otherwise, let me know and I'll put it in my list of things to fix up. Sure, I can take it up during the weekend. CHANGES SINCE LAST ACTION

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

rjmccall added a comment. This seems reasonable, but I think it's probably better to just doing it in the ASTContext code (`getTypeDeclTypeSlow`) the same way it's done for e.g. `RecordDecl`s with previous declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113638: [xray] Add support for hexagon architecture

dberris added a comment. Whoops -- sorry, I had forgotten to change my email settings and missed this. Thanks for the patch, it's exciting to see XRay being supported in the Hexagon architecture! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Ping! Could we see this previously approved patch over the line I’d like to use it to build a regression suit of code and format files without the need for every test to be in its own directory CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 394751. HsiangKai added a comment. Address @craig.topper and @frasercrmck's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 394748. OikawaKirie added a comment. Fix `YAML:1:293: error: Unrecognized escape code` error by replacing lit substitution pattern `%S` to `%/S`. Fix `cp` problems by removing the file copy operations. CHANGES SINCE LAST ACTION

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

ychen added a comment. In D114728#3196591 , @rjmccall wrote: > I don't have a strong opinion about attribute vs. metadata; if metadata are > the best technical path forward, that's fine with me. I don't think function > metadata can be "lost" the same

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; HsiangKai wrote: > craig.topper wrote: > > Is constant still used? >

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai added inline comments. Herald added subscribers: VincentWu, luke957. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; craig.topper wrote: > Is

[PATCH] D115848: tidy-llvm

CSears created this revision. CSears added a reviewer: jroelofs. Herald added a subscriber: carlosgalvezp. CSears requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using clang-tidy on LLVM itself (the proverbial eating your own

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

rjmccall added a comment. I don't have a strong opinion about attribute vs. metadata; if metadata are the best technical path forward, that's fine with me. I don't think function metadata can be "lost" the same way that metadata internal to a function can, right? Repository: rG LLVM

[PATCH] D115791: [CodeGen] Store ElementType in LValue

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115791/new/ https://reviews.llvm.org/D115791

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I don't find it at all weird to say that there's an invariant that certain intrinsics can only appear in functions with a particular attribute, and so the frontend has a

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394739. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen created this revision. ychen added reviewers: pcc, vsk, rjmccall. Herald added subscribers: dexonsmith, hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Information in the function `Prologue Data` is

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:110-111 + +CachedFileContents ::getFileContents( +StringRef Filename, llvm::sys::fs::UniqueID UID) { + CacheShard = CacheShards[llvm::hash_value(Filename) %

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. Hi @rnk , mine is Phoebe#3036. I haven't really used it before. No sure if I invited you correctly, so I try to explain here. > My comment here refers to the alignment of argument values, not user-declared > variables. The frontend controls the alignment of

[PATCH] D115709: [RISCV] Remove Vamo Extention

achieveartificialintelligence added a comment. I've updated the description. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 ___ cfe-commits mailing

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab5527c15f0: [ThinLTO] Ignore unreachable virtual functions in WPD in thin LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining abandoned this revision. SixWeining added a comment. Abandon because https://reviews.llvm.org/D115580 has already fixed it although later than my fix. Thanks @dexonsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

owenpan added a comment. Thanks for factoring the code. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1872 // calling `addUnwrappedLine()` here causes odd parsing errors. FormatTok->MustBreakBefore = true; }

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

ChuanqiXu added inline comments. Comment at: llvm/test/Other/new-pm-O0-defaults.ll:34 ; CHECK-DIS-NEXT: Running pass: AddDiscriminatorsPass +; CHECK-CORO: Running pass: CoroEarlyPass ; CHECK-DIS-NEXT: Running pass: AlwaysInlinerPass aeubanks wrote: > should

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 394697. junaire added a comment. Rename SemaBuiltinReduceMathPreCheck to PrepareBuiltinReduceMathOneArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files:

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:739 static constexpr ImpliedExtsEntry ImpliedExts[] = { -{{"v"}, {ImpliedExtsV}}, -{{"zfh"}, {ImpliedExtsZfh}}, +{"v", {ImpliedExtsV}}, +{"zfh", {ImpliedExtsZfh}},

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir Jake-Egan wrote: > jsji wrote: > > there is no `fmodule-format=obj` here, why are we failing here? > > >

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

aqjune added a comment. This sounds like a great fix to me! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115804/new/ https://reviews.llvm.org/D115804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added a comment. In D115648#3196142 , @luna wrote: > Simplify test case by using `-O3` to generate IR. Probably because of the diff from `ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll` to

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394689. luna marked an inline comment as done. luna added a comment. Simplify test case by using `-O3` to generate IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. Having done some out-of-tree testing, it seems this silently breaks enough ASTMatchers that it'll be hard to get it to stick. (We don't strictly need to block on out-of-tree failures, but I'm pretty sure a lot of stuff in-tree is broken too, and the out-of-tree users

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

rsmith added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:288 + /// template parameters, no matter how many elements there are. + unsigned EntireContentsOfLargeArray : 1; + It looks like nothing is setting this to `true` yet, so that

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:200-210 + // FIXME: This read can fail. + // In that case, we should probably update `CacheEntry::MaybeStat`. + // However, that is

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/ https://reviews.llvm.org/D108479 ___

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you fix one more race (and add good code comments). Reads of `PPSkippedRangeMappings` don't happen until after `MinimizedContentsAccess` is checked, but the writes need to

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63a565768e8f: [clang-format] Remove spurious JSON binding when DisableFormat = true (authored by Andrew-William-Smith, committed by

[clang] 63a5657 - [clang-format] Remove spurious JSON binding when DisableFormat = true

Author: Andrew Smith Date: 2021-12-15T23:09:28Z New Revision: 63a565768e8fdbb3260a88f584aa2c11a58fea93 URL: https://github.com/llvm/llvm-project/commit/63a565768e8fdbb3260a88f584aa2c11a58fea93 DIFF: https://github.com/llvm/llvm-project/commit/63a565768e8fdbb3260a88f584aa2c11a58fea93.diff LOG:

[PATCH] D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa94aab12a4e0: [clang-format] put non-empty catch block on one line with… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo

[clang] a94aab1 - [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

Author: mydeveloperday Date: 2021-12-15T23:06:52Z New Revision: a94aab12a4e0bec6cd1eb676a3360fc1b5ac8eee URL: https://github.com/llvm/llvm-project/commit/a94aab12a4e0bec6cd1eb676a3360fc1b5ac8eee DIFF: https://github.com/llvm/llvm-project/commit/a94aab12a4e0bec6cd1eb676a3360fc1b5ac8eee.diff

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:25-31 llvm::ErrorOr Stat = (*MaybeFile)->status(); if (!Stat) return Stat.getError(); llvm::vfs::File = **MaybeFile; llvm::ErrorOr>

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

q66 added a comment. On x86_64, the program predictably prints `Dv4_i`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106120/new/ https://reviews.llvm.org/D106120 ___ cfe-commits mailing list

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

q66 added a comment. and indeed, it affects semantics too: /tmp$ clang++ test.cc -o test -faltivec-src-compat=xl /tmp$

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394666. sammccall added a comment. TypePrinter prints UsingTypes with their underlying qualifiers by default. Fix qualifier bug in QualTypeNames Add a bit more detail to AST dump (UsingShadow) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

q66 added a comment. Hi, this warning also affects GCC-style vectors: e.g. typedef int myivec __attribute__((vector_size(16)); typedef float myfvec __attribute__((vector_size(16)); const myvec ret = (myfvec1 == myfvec2); // will issue a warning Should it? This means different semantics

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

dexonsmith added a comment. Lost track of this again :/. Was just about to commit this for you (finally) but it looks like https://reviews.llvm.org/D115580 has already fixed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D113622: [analyzer] support ignoring use-after-free checking with reference_counted attribute

NoQ added a comment. In D113622#3194580 , @steakhal wrote: > Could you please share the results to have look? How can I reproduce and > evaluate the effect of this change? You'll need a project that uses a lot of manual reference counting, typically

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a comment. @tambre Any appetite for a libc++ patch? :) Otherwise, let me know and I'll put it in my list of things to fix up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

pfultz2 added a comment. Thanks for merging as I dont have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46081/new/ https://reviews.llvm.org/D46081 ___ cfe-commits mailing list

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added a comment. @rsmith Ping. I'm all on you :) You are almost the only one designed these files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 ___

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Actually no. I think no one just had thought about it. :) I can try to commit it next week, this one I'm rather busy. Maybe someone else might do it before that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115827/new/ https://reviews.llvm.org/D115827

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394648. sammccall added a comment. Fix QualTypeNames bug that showed up in external testing. (Now covered by a unittest added separately) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/

[PATCH] D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency

t184256 created this revision. t184256 added reviewers: llvm-commits, thakis, v.g.vassilev. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. t184256 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang.

[clang] 62bcb75 - [AST] Add more testcases to QualTypeNamesTest. NFC

Author: Sam McCall Date: 2021-12-15T21:59:54+01:00 New Revision: 62bcb75ce5108c2536b8bf7f4428034d418b9c0b URL: https://github.com/llvm/llvm-project/commit/62bcb75ce5108c2536b8bf7f4428034d418b9c0b DIFF: https://github.com/llvm/llvm-project/commit/62bcb75ce5108c2536b8bf7f4428034d418b9c0b.diff

[clang] 32dede6 - [AST] Fix QualTypeNamesTest, which was spuriously passing

Author: Sam McCall Date: 2021-12-15T21:55:25+01:00 New Revision: 32dede65ae98703855d90b55d0b4ec0ebf88a385 URL: https://github.com/llvm/llvm-project/commit/32dede65ae98703855d90b55d0b4ec0ebf88a385 DIFF: https://github.com/llvm/llvm-project/commit/32dede65ae98703855d90b55d0b4ec0ebf88a385.diff

[PATCH] D115803: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

curdeius added a comment. In D115803#3195115 , @MyDeveloperDay wrote: > So am I right in thinking the got replaced out because C.Spaces was > > C.StartOfTokenColumn? (i.e. appendIndentText was given a negative number as > the 4th argument) Yes,

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

aeubanks added a comment. I agree that we really should only have one attribute builder class. A SmallVector does seem nicer than having a static array the size of all possible attributes. We should avoid creating copies of AttributeLists/Sets into AttrBuilders and just have AttrBuilder be a

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195533 , @tambre wrote: > I only took care of `std::atomic_init()` and seemingly completely missed > cleaning up uses of `ATOMIC_VAR_INIT`. > I do remember not being able to add a deprecation notice for >

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. No worries! > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 394626. aaron.ballman added a comment. Dropped changes to libc++ based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 Files: clang/docs/ReleaseNotes.rst

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. > > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all inside libc++. >

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

mubarizafzal added a comment. In D114559#3195423 , @flx wrote: > In D114559#3195357 , @mubarizafzal > wrote: > >> Hi, this patch is causing a build failure for clang-ppc64le-rhel >>

[PATCH] D115673: [clang-format] C# switch expression formatting differs from normal switch formatting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebed0ca71561: [clang-format] C# switch expression formatting differs from normal switch… (authored by MyDeveloperDay). Repository: rG LLVM Github

[clang] ebed0ca - [clang-format] C# switch expression formatting differs from normal switch formatting

Author: mydeveloperday Date: 2021-12-15T19:47:29Z New Revision: ebed0ca71561f5ca5d54b1f5ddf783897fea002e URL: https://github.com/llvm/llvm-project/commit/ebed0ca71561f5ca5d54b1f5ddf783897fea002e DIFF: https://github.com/llvm/llvm-project/commit/ebed0ca71561f5ca5d54b1f5ddf783897fea002e.diff

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a subscriber: tambre. ldionne added a comment. Sorry, I seemed to have missed this entirely. Since this is touching only `` and not libc++'s ``, I think it would actually be OK not to make any changes at all inside libc++. Nothing should break. We should separately implement

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8179e1fd519d: [clang][dataflow] Add simplistic constant-propagation analysis. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 8179e1f - [clang][dataflow] Add simplistic constant-propagation analysis.

Author: Yitzhak Mandelbaum Date: 2021-12-15T19:30:20Z New Revision: 8179e1fd519deccfb3b940468af46676164d6d75 URL: https://github.com/llvm/llvm-project/commit/8179e1fd519deccfb3b940468af46676164d6d75 DIFF: https://github.com/llvm/llvm-project/commit/8179e1fd519deccfb3b940468af46676164d6d75.diff

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

ymandel updated this revision to Diff 394617. ymandel marked 5 inline comments as done. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files:

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys updated this revision to Diff 394614. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h clang/unittests/Format/FormatTestCSharp.cpp Index:

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

flx added a comment. In D114559#3195357 , @mubarizafzal wrote: > Hi, this patch is causing a build failure for clang-ppc64le-rhel > , > can this be reverted? Hi, I just

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys updated this revision to Diff 394608. peterstys marked 2 inline comments as done. peterstys added a comment. Created tryParseCSharpLambda function to avoid code duplication. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files:

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but I leave the final sign-off about the behavior to others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. @martong Thanks for clarification. > TLDR, it is recommended to use the arcanist. I'm not able to use arcanist. It doesn't work on Windows (at least I've tryed several ways to set up it). BTW. I found a revision from which the

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

mubarizafzal added a comment. Hi, this patch is causing a build failure for clang-ppc64le-rhel , can this be reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115809: [ASTMatchers] Make ParamIndex unsigned.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned. (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 54ed30f - [ASTMatchers] Make ParamIndex unsigned.

Author: Felix Berger Date: 2021-12-15T13:47:34-05:00 New Revision: 54ed30fdd63b165efd3d3ce59aa96383fac80712 URL: https://github.com/llvm/llvm-project/commit/54ed30fdd63b165efd3d3ce59aa96383fac80712 DIFF: https://github.com/llvm/llvm-project/commit/54ed30fdd63b165efd3d3ce59aa96383fac80712.diff

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane updated this revision to Diff 394604. erichkeane marked 7 inline comments as done. erichkeane added a comment. Fix Aaron+ Craig's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D115809: [ASTMatchers] Make ParamIndex unsigned.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115809/new/ https://reviews.llvm.org/D115809

[PATCH] D115709: [RISCV] Remove Vamo Extention

craig.topper added a comment. In D115709#3194538 , @frasercrmck wrote: > I think it'd be helpful for the description to note why this is being > removed, what happened to the extension, etc. I agree Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added a comment. Herald added a subscriber: ellis. ping @xur Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 ___ cfe-commits mailing list

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys updated this revision to Diff 394603. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unittests/Format/FormatTestCSharp.cpp

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10188 +bool VisitUnaryOperator(const UnaryOperator *E); +// FIXME: Missing: unary ~, conditional operator (for GNU // conditional select), shufflevector,

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10188 +bool VisitUnaryOperator(const UnaryOperator *E); +// FIXME: Missing: unary ~, conditional operator (for GNU // conditional select), shufflevector,

[PATCH] D115809: [ASTMatchers] Make ParamIndex unsigned.

flx created this revision. flx added a reviewer: sammccall. Herald added a subscriber: arphaman. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a compiler error/warning in

[PATCH] D113146: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

ychen added a comment. @aaron.ballman Thanks for taking a look! Yep, I'll wait. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113146/new/ https://reviews.llvm.org/D113146 ___ cfe-commits mailing list

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:145 +const BoundNodes = Results[0]; +const ASTContext =

[PATCH] D113146: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! However, I'd like to hear from @rsmith as he was the original code author here, so please give him a few days to respond before landing. Repository: rG LLVM Github

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1510595dce9c: [Sema] Mark explicit specialization declaration in a friend invalid (authored by ychen). Repository: rG LLVM Github Monorepo

[clang] 1510595 - [Sema] Mark explicit specialization declaration in a friend invalid

Author: Yuanfang Chen Date: 2021-12-15T10:26:55-08:00 New Revision: 1510595dce9c48b9e7ddd49becd422c4e5e66fc9 URL: https://github.com/llvm/llvm-project/commit/1510595dce9c48b9e7ddd49becd422c4e5e66fc9 DIFF: https://github.com/llvm/llvm-project/commit/1510595dce9c48b9e7ddd49becd422c4e5e66fc9.diff

[clang] 0d1363e - Revert "[Sema] Mark explicit specialization declaration in a friend invalid"

Author: Yuanfang Chen Date: 2021-12-15T10:25:37-08:00 New Revision: 0d1363e5614e24d164373e19e3f4b7102188d4e3 URL: https://github.com/llvm/llvm-project/commit/0d1363e5614e24d164373e19e3f4b7102188d4e3 DIFF: https://github.com/llvm/llvm-project/commit/0d1363e5614e24d164373e19e3f4b7102188d4e3.diff

[clang] 8cb6ecb - [Sema] Mark explicit specialization declaration in a friend invalid

Author: Yuanfang Chen Date: 2021-12-15T10:24:02-08:00 New Revision: 8cb6ecbc4da2b0cfd8dcf04f612dc413716d27a1 URL: https://github.com/llvm/llvm-project/commit/8cb6ecbc4da2b0cfd8dcf04f612dc413716d27a1 DIFF: https://github.com/llvm/llvm-project/commit/8cb6ecbc4da2b0cfd8dcf04f612dc413716d27a1.diff

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:25-31 llvm::ErrorOr Stat = (*MaybeFile)->status(); if (!Stat) return Stat.getError();

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 updated this revision to Diff 394600. jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. Rebase on top of D115346 , apply suggested changes to the cache structure and allocation strategy. Repository: rG LLVM Github

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195214 , @aaron.ballman wrote: > Thank you for the help here! FWIW, I'm not certain the libc++ tests need to > be changed at all -- shouldn't those all be using the macro definitions > obtained by libc++'s ``

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane updated this revision to Diff 394599. erichkeane retitled this revision from "Correct behavior of Vector boolean-operations, implement vector operator-" to "Implement some constexpr vector unary operators, fix boolean-ops". erichkeane edited the summary of this revision. erichkeane

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a comment. Let me know if it would be more helpful to set up a call, that might help us reach agreement sooner. I've used discord for this previously if that works for you, my username there is the same (`@rnk#8591`). In D115441#3194066 ,

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 394597. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback from Arthur. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 Files:

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

ymandel marked 10 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:97 + +} // namespace + sgatev wrote: > Why not put the definitions below also in the anonymous

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. @aaron.ballman Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added a comment. @craig.topper : Yep, probably so in both those cases. I'm working on a patch that includes the 2 'nots' as well, which complicates this whole section a bunch though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

ymandel updated this revision to Diff 394594. ymandel marked an inline comment as done. ymandel added a comment. Responds to reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files:

  1   2   3   >