[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. I hope that someone not from Intel will take a look as well. If this won't happen for reasonable amount of time, I'll submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Assuming that this patch is ready to land. @tra or @yaxunl, could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. It seems that it is not this patch that triggers the problem, which is similar to D75665 . IMO it is the problem of on-demand-parsing, but I do not have a Mac M1 device to reproduce this bug. Maybe we

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1282-1300 if (FormatTok->Tok.is(tok::string_literal)) { nextToken(); if (FormatTok->Tok.is(tok::l_brace)) { +if (Style.BraceWrapping.AfterExternBlock) { +

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1622 +// [module.interface]p6: +// A redeclaration of an entity X is implicitly exported if X was introduced by aaron.ballman wrote: > I

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3819 + Style.IndentExternBlock = FormatStyle::IEBS_NoIndent; + verifyFormat("extern \"C\"\n{ /*13*/\n}", Style); + verifyFormat("extern \"C\"\n{\n" curdeius wrote: > I'd prefer

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 395045. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D113237: [RISCV] Support I extension version 2.1

kito-cheng added a comment. @asb > Are you saying that there won't be a new ISA manual release (using whatever > naming scheme) that incorporates the ratified versions of bitmanip, crypto, > vector etc? Oh, I guess I using some word too strong there, here should have some newer release in

[clang] c50a4b3 - [Modules] Incorrect ODR detection for unresolved using type

Author: Chuanqi Xu Date: 2021-12-17T10:37:40+08:00 New Revision: c50a4b3f97497c27ad62797080b52f501dac5e38 URL: https://github.com/llvm/llvm-project/commit/c50a4b3f97497c27ad62797080b52f501dac5e38 DIFF: https://github.com/llvm/llvm-project/commit/c50a4b3f97497c27ad62797080b52f501dac5e38.diff

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc50a4b3f9749: [Modules] Incorrect ODR detection for unresolved using type (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113237: [RISCV] Support I extension version 2.1

kito-cheng added a comment. @jrtc27 > Outside of the I/F/D special cases, where F/D don't really matter and I2p0 is > just I2p1Zicsr2p0_Zifencei2p0,, I thought the new policy was that ratified > extensions would never be changed, only new extensions published, and thus > version numbers are

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

thakis added a comment. reverted in 770ef94097c02205b3ec9e902f1d6a9c99b5189c . thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[clang] 770ef94 - Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file"

Author: Nico Weber Date: 2021-12-16T20:46:51-05:00 New Revision: 770ef94097c02205b3ec9e902f1d6a9c99b5189c URL: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c DIFF: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c.diff

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. Could you please revert this on my behalf? I currently have no idea to fix this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

dschuff added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/23920/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames added a comment. I'm starting to split this into individual pieces with the writeonly dependence removed. The first one handles indirect calls, and is posted as D115916 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4625b84 - [WebAssembly] Support clang -fwasm-exceptions for bitcode

Author: Heejin Ahn Date: 2021-12-16T16:49:24-08:00 New Revision: 4625b848793f8cfa4affac8d03b9f498b3e477fe URL: https://github.com/llvm/llvm-project/commit/4625b848793f8cfa4affac8d03b9f498b3e477fe DIFF: https://github.com/llvm/llvm-project/commit/4625b848793f8cfa4affac8d03b9f498b3e477fe.diff

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4625b848793f: [WebAssembly] Support clang -fwasm-exceptions for bitcode (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395025. aheejin added a comment. Remove an unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395024. aheejin marked 2 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I do not know how this error happens. Maybe we can currently revert this patch an have another try in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

ahatanak added a comment. This commit seems to have caused a test to fail: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/26118/testReport/ Can you fix the failure or revert the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3192823 , @stella.stamenova wrote: > In D114639#3191752 , @RKSimon wrote: > >> @rnk @stella.stamenova How long do you think it will be before you can >> update your

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

jyknight added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return)) + callbr void asm sideeffect "",

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) {

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth created this revision. Herald added subscribers: abrachet, ormris, dexonsmith, wenlei, phosek, hiraditya, mgorny. paulkirth updated this revision to Diff 394995. paulkirth added a comment. paulkirth updated this revision to Diff 394997. paulkirth added reviewers: phosek, mcgrathr,

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58d9c1aec88d: [Try2][InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 58d9c1a - [Try2][InstrProf] Attach debug info to counters

Author: Ellis Hoag Date: 2021-12-16T14:20:30-08:00 New Revision: 58d9c1aec88d5d4c783643df057d87f6b0c9f693 URL: https://github.com/llvm/llvm-project/commit/58d9c1aec88d5d4c783643df057d87f6b0c9f693 DIFF: https://github.com/llvm/llvm-project/commit/58d9c1aec88d5d4c783643df057d87f6b0c9f693.diff

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) { //

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, lichray. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/43196 Fixes #43196 -> is

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394982. ellis added a comment. Use `std::string` instead of `Twine` to pass around the default raw profile name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115693/new/ https://reviews.llvm.org/D115693

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115901/new/ https://reviews.llvm.org/D115901 ___

[PATCH] D115879: [clang-format] extern with new line brace without indentation

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:3815 + + Style.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; + Style.BreakBeforeBraces =

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added inline comments. Comment at: compiler-rt/lib/lsan/lsan_allocator.h:52-53 -#if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \ -defined(__arm__) || SANITIZER_RISCV64 || defined(__hexagon__) +#if defined(__mips64) || defined(__aarch64__)

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3231 +return Style; + } else if (ParserErrorCode != ParseError::Success) { +return make_string_error("Error reading " + ConfigFile + ": " + else after return But I prefer

[PATCH] D115902: [OPENMP]Look through member function call base during implicit DSA analysis.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, ddpagan. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to look through the base of the member function

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

dreachem created this revision. dreachem added reviewers: jdoerfert, koops, cchen. Herald added subscribers: guansong, yaxunl. dreachem requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Update status for the atomic 'fail' clause to

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Thanks! I will work on making those changes Comment at: clang-tools-extra/test/clang-tidy/CTTestTidyModule.cpp:24-25 + + //void registerMatchers(ast_matchers::MatchFinder *Finder) override; + //void check(const ast_matchers::MatchFinder::MatchResult

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. > Thanks! I landed this as 9198d04c06b561cd78d9407cedd50f7b995ee6d8 > this > morning (sorry for the slight delay in getting this landed). No worries, thanks @aaron.ballman! CHANGES SINCE LAST

[PATCH] D115865: [clang-format] add support for branch attribute macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b671c3fe0d6: [clang-format] add support for branch attribute macros (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2b671c3 - [clang-format] add support for branch attribute macros

Author: mydeveloperday Date: 2021-12-16T20:36:25Z New Revision: 2b671c3fe0d6f6517dc5396e73d28285d6fe6223 URL: https://github.com/llvm/llvm-project/commit/2b671c3fe0d6f6517dc5396e73d28285d6fe6223 DIFF: https://github.com/llvm/llvm-project/commit/2b671c3fe0d6f6517dc5396e73d28285d6fe6223.diff

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer added a comment. Is this a new feature in MSVC? Seems like it might be. If so, should it be predicated on `isCompatibleWithMSVC(1925)` or something? CHANGES SINCE

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115792/new/ https://reviews.llvm.org/D115792 ___ cfe-commits mailing list

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 394951. aheejin added a comment. Revert a function name change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3198340 , @JonChesterfield wrote: > In D109885#3198296 , @arsenm wrote: > >> This isn't a feature, it's the introduction of a bug. > > It would regress people depending on the

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, pengfei, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH}) if (NOT ${hsa-runtime64_FOUND}) arsenm wrote: > I also think

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3198296 , @arsenm wrote: > This isn't a feature, it's the introduction of a bug. It would regress people depending on the implicit pickup of /opt/rocm, leaving them with a straightforward workaround of

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH}) if (NOT ${hsa-runtime64_FOUND}) I also think CMAKE_INSTALL_PREFIX in the search hints

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3198290 , @JonChesterfield wrote: > In D109885#3198232 , @arsenm wrote: > >> Dropping the default install location from the default search hint is >> entirely unreasonable > >

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3198232 , @arsenm wrote: > Dropping the default install location from the default search hint is > entirely unreasonable That seems to be the feature request, though I haven't gone through the jira web to

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:392-394 + cl::Option *load_opt = cl::getRegisteredOptions().lookup("load"); + if (load_opt) +load_opt->addCategory(ClangTidyCategory);

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm requested changes to this revision. arsenm added a comment. Dropping the default install location from the default search hint is entirely unreasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

estewart08 added a comment. In D109885#3194819 , @ronlieb wrote: > @estewart08 thoughts on a good CMAKE variable to allow users to define > equivalent of /opt/rocm ? and not use environment variable inside the > cmake file. I would be ok with the

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10546-10548 + if (PointeeTy->isDependentType()) { +return true; + } Comment at: clang/lib/Sema/SemaExpr.cpp:13824

[libunwind] 1c4867e - [libunwind] Provide a way to conveniently install libunwind headers

Author: PoYao Chang Date: 2021-12-16T13:32:40-05:00 New Revision: 1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 URL: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 DIFF: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433.diff

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

rnk added a comment. I probably don't have time to review this, so let me redirect to @hans. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:2400 +static llvm::GlobalValue *getTlsGuardVar(CodeGenModule ) { + llvm::Type *VTy = llvm::Type::getInt8Ty(CGM.getLLVMContext());

[clang] ceb8055 - [OpenCL] Add pure attribute to vload builtins

Author: Stuart Brady Date: 2021-12-16T18:30:58Z New Revision: ceb80557e523f1894799ebadd5d985e11ee80461 URL: https://github.com/llvm/llvm-project/commit/ceb80557e523f1894799ebadd5d985e11ee80461 DIFF: https://github.com/llvm/llvm-project/commit/ceb80557e523f1894799ebadd5d985e11ee80461.diff LOG:

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceb80557e523: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Note: I think I've done everything requested, so I'm hoping to commit this tomorrow 1st thing in order to have it in time for everyone's vacations (and so my downstream can get it before the new year), unless I hear objections from the other reviewers. CHANGES

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a comment. I see, thanks for the info. Can you please add a targeted LLVM test for long double arguments? From what I can tell, the auto-generated update_llc_test_checks.py style tests are not a good fit for testing parameter passing because they pattern-match away the stack offsets

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added a comment. In D114995#3183240 , @malcolm.parsons wrote: > In D114995#3180475 , @aaron.ballman > wrote: > >> was there a reason we didn't cover that case originally or was it an >>

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:616 + bool isInExportDeclContext() const; + I think it would be good to add some comments to document the function (as done with surrounding code). Comment

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115883/new/ https://reviews.llvm.org/D115883

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: xazax.hun, steakhal, NoQ, martong, baloghadamsoftware. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet. ASDenysPetrov requested

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a comment. In D112221#3196740 , @tambre wrote: > In D112221#3195955 , @ldionne wrote: > >> @tambre Any appetite for a libc++ patch? :) >> >> Otherwise, let me know and I'll put it in my list of

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

aaron.ballman added a comment. In D114317#3197815 , @carlosgalvezp wrote: >> me pretty far behind on reviews > > Wow, that's a lot to review! I will keep it in mind and hopefully only ping > you when I have a nice final design ready to go. Really

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG333d66b09494: [analyzer][ctu] Fix wrong multiple definitions errors caused by space… (authored by OikawaKirie, committed by steakhal). Repository:

[clang] 333d66b - [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

Author: Ella Ma Date: 2021-12-16T17:47:59+01:00 New Revision: 333d66b09494b7ebc1a89f2befa79128a56f77e3 URL: https://github.com/llvm/llvm-project/commit/333d66b09494b7ebc1a89f2befa79128a56f77e3 DIFF: https://github.com/llvm/llvm-project/commit/333d66b09494b7ebc1a89f2befa79128a56f77e3.diff LOG:

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:200-210 + // FIXME: This read can fail. + // In that case, we should probably update `CacheEntry::MaybeStat`. + // However, that is

[PATCH] D115817: [clang] Cleanup unneeded Function nullptr checks [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d0bf1439727: [clang] Cleanup unneeded Function nullptr checks [NFC] (authored by mikerice). Herald added a project: clang. Herald added a

[clang] 2d0bf14 - [clang] Cleanup unneeded Function nullptr checks [NFC]

Author: Mike Rice Date: 2021-12-16T08:28:10-08:00 New Revision: 2d0bf14397276d1ece9db1eb1858a644aad77ff2 URL: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2 DIFF: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2.diff

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

aaron.ballman added a comment. Thanks for this new check! In terms of whether we should expose the check in C++: I think we shouldn't. Annex K *could* be supported by a C++ library implementation (http://eel.is/c++draft/library#headers-10), but none of the identifiers are added to namespace

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyModule.h:25-26 +#define CLANG_TIDY_REGISTER_CHECK(Factory, CheckType, CheckName) \ + Factory.registerCheck(CheckName, #CheckType) + aaron.ballman wrote: >

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. > me pretty far behind on reviews Wow, that's a lot to review! I will keep it in mind and hopefully only ping you when I have a nice final design ready to go. Really appreciate your early feedback! > I'd like to make sure I'm on the same page as you. Yes,

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

thakis added a comment. Thanks! Bots look happy again :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 2d89382 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-16T16:34:09+01:00 New Revision: 2d89382b5a21423180c7860163bb0e4cd3082e4b URL: https://github.com/llvm/llvm-project/commit/2d89382b5a21423180c7860163bb0e4cd3082e4b DIFF: https://github.com/llvm/llvm-project/commit/2d89382b5a21423180c7860163bb0e4cd3082e4b.diff

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

stuart updated this revision to Diff 394878. stuart added a comment. I've updated the review to include test changes that are required for check-clang-semaopencl to pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 Files:

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

hans added a comment. Thanks for the reminder! Landed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081 ___ cfe-commits mailing list

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc690c57213: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704) (authored by hans). Changed prior to commit: https://reviews.llvm.org/D112081?vs=380704=394877#toc Repository: rG LLVM

[clang] bbc690c - Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

Author: Hans Wennborg Date: 2021-12-16T16:30:06+01:00 New Revision: bbc690c57213054907284d8964dc0487d38fc57a URL: https://github.com/llvm/llvm-project/commit/bbc690c57213054907284d8964dc0487d38fc57a DIFF: https://github.com/llvm/llvm-project/commit/bbc690c57213054907284d8964dc0487d38fc57a.diff

[clang] 8285522 - [CodeGen] Always update map entry after adding initializer

Author: Nikita Popov Date: 2021-12-16T16:29:35+01:00 New Revision: 828552201420720ff52c9a27ea4e8f3697f1abc1 URL: https://github.com/llvm/llvm-project/commit/828552201420720ff52c9a27ea4e8f3697f1abc1 DIFF: https://github.com/llvm/llvm-project/commit/828552201420720ff52c9a27ea4e8f3697f1abc1.diff

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, MarcusJohnson91. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49804 Interaction

[PATCH] D104478: [clang] p2085 out-of-class comparison operator defaulting

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbe21a7748f: [clang] p2085 out-of-class comparison operator defaulting (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 5fbe21a - [clang] p2085 out-of-class comparison operator defaulting

Author: Nathan Sidwell Date: 2021-12-16T07:22:46-08:00 New Revision: 5fbe21a7748f91adbd1b16c95bbfe180642320a3 URL: https://github.com/llvm/llvm-project/commit/5fbe21a7748f91adbd1b16c95bbfe180642320a3 DIFF:

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

davrec added a comment. `throughUsingDecl` seems like a good solution, though I defer to regular ASTMatchers users. One other thought: can we add diagnostic notes using this new information, e.g. struct A1 { protected: using IntType = char; }; struct A2 { protected: using

[clang] 5aefb1d - Revert "[OpenCL] Add pure attribute to vload builtins"

Author: Stuart Brady Date: 2021-12-16T15:16:41Z New Revision: 5aefb1dc1eabd9286da9511b5227aa83443091b9 URL: https://github.com/llvm/llvm-project/commit/5aefb1dc1eabd9286da9511b5227aa83443091b9 DIFF: https://github.com/llvm/llvm-project/commit/5aefb1dc1eabd9286da9511b5227aa83443091b9.diff LOG:

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

thakis added a comment. looks like this broke tests: http://45.33.8.238/linux/63308/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a376bc28535: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1a376bc - [OpenCL] Add pure attribute to vload builtins

Author: Stuart Brady Date: 2021-12-16T14:55:31Z New Revision: 1a376bc285358037a5edc48b0d125f91bf5a69ca URL: https://github.com/llvm/llvm-project/commit/1a376bc285358037a5edc48b0d125f91bf5a69ca DIFF: https://github.com/llvm/llvm-project/commit/1a376bc285358037a5edc48b0d125f91bf5a69ca.diff LOG:

[clang] a0cf066 - [CodeGen] Store element type in ParamValue

Author: Nikita Popov Date: 2021-12-16T15:31:55+01:00 New Revision: a0cf066eac8aa55782a6dd2deb90adc89a707a8b URL: https://github.com/llvm/llvm-project/commit/a0cf066eac8aa55782a6dd2deb90adc89a707a8b DIFF: https://github.com/llvm/llvm-project/commit/a0cf066eac8aa55782a6dd2deb90adc89a707a8b.diff

[clang] 58c8c53 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-16T15:26:21+01:00 New Revision: 58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1 URL: https://github.com/llvm/llvm-project/commit/58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1 DIFF: https://github.com/llvm/llvm-project/commit/58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1.diff

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c7f2a4f8719: [CodeGen] use saturating FP casts when compiling with no-strict-float-cast… (authored by spatel). Herald added a project: clang.

[clang] 8c7f2a4 - [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

Author: Sanjay Patel Date: 2021-12-16T09:10:12-05:00 New Revision: 8c7f2a4f871928d8734ee3f03e67d09086850b60 URL: https://github.com/llvm/llvm-project/commit/8c7f2a4f871928d8734ee3f03e67d09086850b60 DIFF: https://github.com/llvm/llvm-project/commit/8c7f2a4f871928d8734ee3f03e67d09086850b60.diff

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

aaron.ballman added a reviewer: alexfh. aaron.ballman added a subscriber: alexfh. aaron.ballman added a comment. In D114317#3169067 , @carlosgalvezp wrote: > Kind ping to reviewers, I mostly want to know if you agree with the general > direction so I

  1   2   >