[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

owenpan added a comment. See D108752 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90232/new/ https://reviews.llvm.org/D90232 ___ cfe-commits mailing list

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

owenpan added a comment. See D108752 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14484/new/ https://reviews.llvm.org/D14484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

kyulee added a comment. For clarification, the lightweight pgo does not support merging raw data from memory (at runtime) due to missing structural data, but it does support merging raw files offline. Would you update the comment or error message? Repository: rG LLVM Github Monorepo

[PATCH] D115998: [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu

tianshilei1992 updated this revision to Diff 395313. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115998/new/ https://reviews.llvm.org/D115998 Files: clang/include/clang/Driver/Options.td Index:

[PATCH] D115998: [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu

tianshilei1992 created this revision. Herald added subscribers: dang, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. For now if we check `clang --help`, it

[clang] 56b2b1b - [NFC][Clang] Remove trailing spaces in `clang/include/clang/Driver/Options.td`

Author: Shilei Tian Date: 2021-12-18T21:32:49-05:00 New Revision: 56b2b1b8fd618775222d589100bad7584d392dcd URL: https://github.com/llvm/llvm-project/commit/56b2b1b8fd618775222d589100bad7584d392dcd DIFF: https://github.com/llvm/llvm-project/commit/56b2b1b8fd618775222d589100bad7584d392dcd.diff

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added a comment. @paulwalker-arm Thanks for the report, I've reverted the commit for now. I've put up D115994 to either fix the test or be told that clang generates incorrect initialization code, I'm not completely sure which it is. Repository: rG

[clang] aeb36ae - Revert "[ConstantFolding] Unify handling of load from uniform value"

Author: Nikita Popov Date: 2021-12-18T20:46:52+01:00 New Revision: aeb36ae0f4cbc5fb1d01921d89a80d62ccc2f058 URL: https://github.com/llvm/llvm-project/commit/aeb36ae0f4cbc5fb1d01921d89a80d62ccc2f058 DIFF: https://github.com/llvm/llvm-project/commit/aeb36ae0f4cbc5fb1d01921d89a80d62ccc2f058.diff

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

paulwalker-arm added a comment. This patch looks to be breaking the clang-aarch64-sve-vla-2stage buildbot (and probably also clang-aarch64-sve-vls-2stage). I've checked this using `./bin/clang -DNDEBUG -O3 -w -Werror=date-time -w pr19687.c && ./a.out && echo "success"`, which works before this

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay updated this revision to Diff 395291. MyDeveloperDay added a comment. Double check the interaction with the AlignConsecutiveAssignments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115990/new/ https://reviews.llvm.org/D115990 Files:

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, owenpan, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49846 Fixes #49846

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

luismarques added a comment. > enable 'm' extension with passing mattr=+m After this patch, it would be > -mattr=+m2p0. It's not obvious to me that support for extension versions should mean or has to mean that we always explicitly specify the version. Why can't we keep supporting the option

[PATCH] D115879: [clang-format] extern with new line brace without indentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3362fa59ec40: [clang-format] extern with new line brace without indentation (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo

[clang] 3362fa5 - [clang-format] extern with new line brace without indentation

Author: mydeveloperday Date: 2021-12-18T14:10:14Z New Revision: 3362fa59ec406ba1eebe9e9ee59a04b675ef2439 URL: https://github.com/llvm/llvm-project/commit/3362fa59ec406ba1eebe9e9ee59a04b675ef2439 DIFF: https://github.com/llvm/llvm-project/commit/3362fa59ec406ba1eebe9e9ee59a04b675ef2439.diff

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu created this revision. zixuan-wu added reviewers: asb, craig.topper, kito-cheng, luismarques, apazos, jrtc27, Jim, akuegel. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, armkevincheng, eric-k256, vkmr, frasercrmck, jdoerfert, evandro, sameer.abuasal,

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay, I got sick last week and read through email newest to oldest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. This is having an impact on code in flang, I don't deny it might be better, but it may not be what is wanted. - explicit Expr(const Scalar ) : u{Constant{x}} {} - explicit Expr(Scalar &) : u{Constant{std::move(x)}} {} + explicit Expr(const Scalar ) : u {

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG936a67f089ef: [clang-format] Extra spaces surrounding arrow in templated member call in… (authored by MyDeveloperDay). Repository: rG LLVM Github

[clang] 936a67f - [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

Author: mydeveloperday Date: 2021-12-18T11:38:29Z New Revision: 936a67f089efd31354cf1f1f3b864b81fb5aad0e URL: https://github.com/llvm/llvm-project/commit/936a67f089efd31354cf1f1f3b864b81fb5aad0e DIFF: https://github.com/llvm/llvm-project/commit/936a67f089efd31354cf1f1f3b864b81fb5aad0e.diff