[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz updated this revision to Diff 395606. salman-javed-nz added a comment. Remove unnecessary `llvm::` qualification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116085/new/ https://reviews.llvm.org/D116085 Files:

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei created this revision. pengfei added reviewers: skan, xiangzhangllvm, craig.topper, coby. Herald added subscribers: ChuanqiXu, hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D115225

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// const a = in JavaScript. +if (Style.isJavaScript() && PreviousNotConst->is(tok::kw_const)) + return true; owenpan wrote: > MyDeveloperDay wrote: > > owenpan

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok added a comment. PING !!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115510/new/ https://reviews.llvm.org/D115510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 added a comment. Okay, I reached the same point as D115561 , that the compiler stops at the first position it encounters error, so all those mixed uses cannot be in the same test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116068: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Just to keep code consistent as

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

ABataev added a comment. Tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115573/new/ https://reviews.llvm.org/D115573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. I think I'm going to build another patches on top of this one and land them altogether. In this way, I don't need to add any test in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115573/new/ https://reviews.llvm.org/D115573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116066: [WIP] Ignore list for noundef

vitalybuka planned changes to this revision. vitalybuka added a comment. Not ready for review, we probably don't needs this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116066/new/ https://reviews.llvm.org/D116066

[PATCH] D116066: [WIP] Ignore list for noundef

vitalybuka created this revision. vitalybuka added a reviewer: kda. Herald added a subscriber: dexonsmith. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D116064 . Repository: rG

[PATCH] D116064: [WIP] Test for noundef ignore list

vitalybuka created this revision. vitalybuka added a reviewer: kda. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116064 Files:

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan updated this revision to Diff 395544. owenpan added a comment. Removed more redundant code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1964-1965 } - if (FormatTok->is(TT_FatArrow)) { -nextToken(); -// Fat arrows can be followed by simple expressions or by child blocks -// in curly braces. -

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] =

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

efriedma added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitialized;

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. In D114251#3197713 , @davrec wrote: > One other thought: can we add diagnostic notes using this new information, > e.g. This sounds plausible, though I didn't want to extend the scope of this patch further. I'm also not sure

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 395539. nickdesaulniers added a comment. - VisitChildren rather than VisitStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 Files:

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:3359 + + return VisitStmt(G, asc); } I think this should actually be `return VisitChildren(G);`; it produces a simpler CFG with the

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, jyknight, jyu2, efriedma. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When performing CFG based analyses, don't forget to check the child

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1955-1957 +if (Style.isCSharp() && FormatTok->is(TT_FatArrow) && +tryToParseChildBlock()) + continue; peterstys wrote: > It seems that this block could be

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// const a = in JavaScript. +if (Style.isJavaScript() && PreviousNotConst->is(tok::kw_const)) + return true; MyDeveloperDay wrote: > owenpan wrote: > > curdeius

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395517. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

This revision was automatically updated to reflect the committed changes. Closed by commit rGec2e26eaf635: [Clang] Add __builtin_function_start (authored by samitolvanen). Changed prior to commit: https://reviews.llvm.org/D108479?vs=391159=395516#toc Repository: rG LLVM Github Monorepo

[clang] ec2e26e - [Clang] Add __builtin_function_start

Author: Sami Tolvanen Date: 2021-12-20T12:55:33-08:00 New Revision: ec2e26eaf63558934f5b73a6e530edc453cf9508 URL: https://github.com/llvm/llvm-project/commit/ec2e26eaf63558934f5b73a6e530edc453cf9508 DIFF: https://github.com/llvm/llvm-project/commit/ec2e26eaf63558934f5b73a6e530edc453cf9508.diff

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

arphaman created this revision. arphaman added reviewers: ravikandhadai, yln, bro4all. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. The lexer can attempt to lex a _Pragma and crash with an out of bounds string access when it's

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

q66 added a comment. I see. Is there a way to compile-time-detect whether one is getting the XL behavior? This is still a potential concern for things that expose vector ops in public headers. There should be a macro of some kind to detect this at compile time and follow the XL semantics when

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo,

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395502. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files:

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

nemanjai added a comment. In D106120#3197209 , @q66 wrote: > Well, I'm more concerned about the actual semantics - as I see it, when using > generic vectors, they should be unaffected by the comparison behavior of > AltiVec vectors, which is not the

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://reviews.llvm.org/D114971

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I'm liking the new direction here; requesting changes since it looks like the filename is being used to pick the shard for UIDMap, which will lead to multiple opinions of

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

xazax.hun added a comment. I am looking at the CFG and wonder if this change is what we what to do in the first place: [B7 (ENTRY)] Succs (1): B6 [B1] 1: 0 2: (void)[B1.1] (CStyleCastExpr, ToVoid, void) Preds (2): B2(Unreachable) B3 Succs (1): B0 [B2

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

nickdesaulniers added a comment. Thanks for the patch. You're right about this change, sorry I made the mistake! Comment at: clang/test/CodeGen/stack-protector-guard.c:1-12 +// RUN: %clang_cc1 -mstack-protector-guard=sysreg -triple x86_64-unknown-unknown \ +// RUN:

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac719d7c9ae6: [InstrProf] Dont profile merge by default in lightweight mode (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES

[clang] ac719d7 - [InstrProf] Don't profile merge by default in lightweight mode

Author: Ellis Hoag Date: 2021-12-20T09:51:49-08:00 New Revision: ac719d7c9ae6a20a6ae530e308331b3d51b3d70e URL: https://github.com/llvm/llvm-project/commit/ac719d7c9ae6a20a6ae530e308331b3d51b3d70e DIFF: https://github.com/llvm/llvm-project/commit/ac719d7c9ae6a20a6ae530e308331b3d51b3d70e.diff

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

ellis updated this revision to Diff 395481. ellis added a comment. Expand warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115979/new/ https://reviews.llvm.org/D115979 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:50 + std::unique_ptr Cfg; + llvm::DenseMap StmtToBlock; +}; There is a special class for this at `clang/lib/Analysis/CFGStmtMap.cpp`. That also does

[PATCH] D115935: [clang][deps] NFC: Simplify handling of cached FS errors

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115935/new/ https://reviews.llvm.org/D115935

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values Anastasia wrote: > I can't remember if we have discussed this

[PATCH] D116049: [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/50051. Given the style:

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

AdamMagierFOSS created this revision. AdamMagierFOSS added reviewers: rjmccall, rsmith. AdamMagierFOSS requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code generation for the UBSan VLA size check was qualified by a con- dition that the

[clang] af27466 - Reland "[AST] Add UsingType: a sugar type for types found via UsingDecl"

Author: Sam McCall Date: 2021-12-20T18:03:15+01:00 New Revision: af27466c50398e3f04372850370eab8dc8abbb92 URL: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92 DIFF: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92.diff

[clang-tools-extra] af27466 - Reland "[AST] Add UsingType: a sugar type for types found via UsingDecl"

Author: Sam McCall Date: 2021-12-20T18:03:15+01:00 New Revision: af27466c50398e3f04372850370eab8dc8abbb92 URL: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92 DIFF: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92.diff

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

nemanjai added a comment. Converting more generic code to target-specific intrinsics is sometimes necessary to ensure the generic IR doesn't get transformed in a way that is disadvantageous. I believe that the description of this review claims that to be the case for these negated FMA's. The

[clang] cc56c66 - Revert "[AST] Add UsingType: a sugar type for types found via UsingDecl"

Author: Sam McCall Date: 2021-12-20T17:53:56+01:00 New Revision: cc56c66f27e131b914082d3bd21180646e842e9a URL: https://github.com/llvm/llvm-project/commit/cc56c66f27e131b914082d3bd21180646e842e9a DIFF: https://github.com/llvm/llvm-project/commit/cc56c66f27e131b914082d3bd21180646e842e9a.diff

[PATCH] D116026: [clang] Adjust coroutine namespace diagnostics]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG565c17574dd0: [clang] Adjust coroutine namespace diagnostics (authored by urnathan). Herald added a project: clang. Herald added a subscriber:

[clang] 565c175 - [clang] Adjust coroutine namespace diagnostics

Author: Nathan Sidwell Date: 2021-12-20T08:50:16-08:00 New Revision: 565c17574dd062cf3096d578c4a2ab058f494c6d URL: https://github.com/llvm/llvm-project/commit/565c17574dd062cf3096d578c4a2ab058f494c6d DIFF:

[clang] 23b2045 - [clang] p2085 out-of-class comparison operator defaulting

Author: Nathan Sidwell Date: 2021-12-20T08:47:54-08:00 New Revision: 23b2045eef45884566722d06f3e09224a0f6dc6c URL: https://github.com/llvm/llvm-project/commit/23b2045eef45884566722d06f3e09224a0f6dc6c DIFF:

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

nemanjai added a comment. We should not be emitting the attribute in modules that do not have any use of `long double`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016

[PATCH] D116043: [clangd] Don't trim xrefs references if we overran the limit

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG81967b4fa77a: [clangd] Dont trim xrefs references if we overran the limit (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 81967b4 - [clangd] Don't trim xrefs references if we overran the limit

Author: Kadir Cetinkaya Date: 2021-12-20T17:22:24+01:00 New Revision: 81967b4fa77ab5fc9840f272cb4fab1814df11e7 URL: https://github.com/llvm/llvm-project/commit/81967b4fa77ab5fc9840f272cb4fab1814df11e7 DIFF:

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1600db19d63: [AST] Add UsingType: a sugar type for types found via UsingDecl (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang] e1600db - [AST] Add UsingType: a sugar type for types found via UsingDecl

Author: Sam McCall Date: 2021-12-20T17:15:38+01:00 New Revision: e1600db19d6303f84b995acb9340459694e06ea9 URL: https://github.com/llvm/llvm-project/commit/e1600db19d6303f84b995acb9340459694e06ea9 DIFF: https://github.com/llvm/llvm-project/commit/e1600db19d6303f84b995acb9340459694e06ea9.diff

[PATCH] D116043: [clangd] Don't trim xrefs references if we overran the limit

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1388 + TargetsInMainFile.insert(ID); + // Not all symbols can be referenced from outside (e.g. function-locals). + // TODO: we could skip TU-scoped symbols here (e.g. static functions)

[PATCH] D116043: [clangd] Don't trim xrefs references if we overran the limit

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:1388 + TargetsInMainFile.insert(ID); + // Not all symbols can be referenced from outside (e.g.

[PATCH] D116043: [clangd] Don't trim xrefs references if we overran the limit

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This preserves all the results

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6786cdd5757: [HIPSPV][3/4] Enable SPIR-V emission for HIP (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a6786cd - [HIPSPV][3/4] Enable SPIR-V emission for HIP

Author: Yaxun (Sam) Liu Date: 2021-12-20T10:45:09-05:00 New Revision: a6786cdd575701ec1a1bc42adc086cfb70201ad3 URL: https://github.com/llvm/llvm-project/commit/a6786cdd575701ec1a1bc42adc086cfb70201ad3 DIFF:

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ye-luo added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH}) if (NOT ${hsa-runtime64_FOUND}) JonChesterfield wrote: > arsenm wrote: > > I also

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3198375 , @arsenm wrote: > In D109885#3198340 , > @JonChesterfield wrote: > >> I'm very mistrusting of mixing a rocm toolchain with a trunk toolchain as >> they're

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added a comment. In D115921#3201346 , @luismarques wrote: >> enable 'm' extension with passing mattr=+m After this patch, it would be >> -mattr=+m2p0. > > It's not obvious to me that support for extension versions should mean or has > to

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

This revision was automatically updated to reflect the committed changes. Closed by commit rGcff192739bb6: [clang-include-fixer] Fix incorrect ranking because of dangling references (authored by danlark, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] cff1927 - [clang-include-fixer] Fix incorrect ranking because of dangling references

Author: Danila Kutenin Date: 2021-12-20T15:56:57+01:00 New Revision: cff192739bb6dd67b2ec58f055af2ae2834c4348 URL: https://github.com/llvm/llvm-project/commit/cff192739bb6dd67b2ec58f055af2ae2834c4348 DIFF:

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116037/new/ https://reviews.llvm.org/D116037

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 395434. sammccall added a comment. Herald added a reviewer: shafik. Fix ASTImporter, add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files:

[PATCH] D116007: [clang-format] Fix BreakBeforeBraces: Attach ignored with trailing requires-expression of function.

curdeius added a comment. Ok, I'll have a look on it. Thanks for reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116007/new/ https://reviews.llvm.org/D116007 ___ cfe-commits mailing list

[PATCH] D116007: [clang-format] Fix BreakBeforeBraces: Attach ignored with trailing requires-expression of function.

JohelEGP added a comment. Thank you for doing this. With the patch, I get this diff: diff diff --git a/sources/details/waarudo.details.utilities.cpp b/sources/details/waarudo.details.utilities.cpp index 0b3680e..6e234ac 100644 --- a/sources/details/waarudo.details.utilities.cpp +++

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

danlark created this revision. danlark added reviewers: alexfh, klimek. Herald added subscribers: arphaman, mgrang. danlark requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. SymbolAndSignals stores SymbolInfo which stores two

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13824 SourceLocation OpLoc) { - if (Op->isTypeDependent()) + if (Op->isTypeDependent() && !Op->getType()->isPointerType()) return S.Context.DependentTy;

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet updated this revision to Diff 395410. courbet added a comment. Try to get rid of "dependent and not a pointer" checks checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 Files:

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

sepavloff added a comment. In D115804#3201681 , @spatel wrote: > In D115804#3201044 , @craig.topper > wrote: > >> What's the plan for constrained intrinsics versions of these intrinsics? The >> IRBuilder calls

[PATCH] D115934: [analyzer] Add range constructor to CallDescriptionMap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6a861e644a9: [analyzer] Add range constructor to CallDescriptionMap (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c6a861e - [analyzer] Add range constructor to CallDescriptionMap

Author: Endre Fülöp Date: 2021-12-19T13:03:20+01:00 New Revision: c6a861e644a99a9e0b5a6acf40394127bc125f51 URL: https://github.com/llvm/llvm-project/commit/c6a861e644a99a9e0b5a6acf40394127bc125f51 DIFF: https://github.com/llvm/llvm-project/commit/c6a861e644a99a9e0b5a6acf40394127bc125f51.diff

[PATCH] D115931: [analyzer] Enable move semantics for CallDescriptionMap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0321eb86158: [analyzer] Enable move semantics for CallDescriptionMap (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e0321eb - [analyzer] Enable move semantics for CallDescriptionMap

Author: Endre Fülöp Date: 2021-12-19T13:02:34+01:00 New Revision: e0321eb8615810c4115d46b15b60dc89f23cdbef URL: https://github.com/llvm/llvm-project/commit/e0321eb8615810c4115d46b15b60dc89f23cdbef DIFF: https://github.com/llvm/llvm-project/commit/e0321eb8615810c4115d46b15b60dc89f23cdbef.diff

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// const a = in JavaScript. +if (Style.isJavaScript() && PreviousNotConst->is(tok::kw_const)) + return true; owenpan wrote: > curdeius wrote: > > Nit. > +1 I

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

gamesh411 created this revision. gamesh411 added reviewers: steakhal, martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. gamesh411 requested

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

jansvoboda11 updated this revision to Diff 395399. jansvoboda11 added a comment. Prevent eager minimization of not-to-be-minimized files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://reviews.llvm.org/D114971 Files:

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal marked an inline comment as done. steakhal added a comment. In D114622#3200678 , @NoQ wrote: > These checks are almost 2000 lines of code each and it looks like all they do > is figure out if two statements are the same and we have a very

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

peterstys added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1955-1957 +if (Style.isCSharp() && FormatTok->is(TT_FatArrow) && +tryToParseChildBlock()) + continue; It seems that this block could be removed altogether,

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, (the original code had a unit test so we should be good). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2005 - } - break; case tok::l_square: MyDeveloperDay wrote: > Is this case not covered by this? I presume not as you didn't remove any unit > tests > >

[PATCH] D115931: [analyzer] Enable move semantics for CallDescriptionMap

gamesh411 updated this revision to Diff 395395. gamesh411 added a comment. Remove static asserts as it adds little to no value in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115931/new/ https://reviews.llvm.org/D115931 Files:

[PATCH] D115934: [analyzer] Add range constructor to CallDescriptionMap

gamesh411 updated this revision to Diff 395394. gamesh411 added a comment. Remove static asserts as it only makes the tests more brittle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115934/new/ https://reviews.llvm.org/D115934 Files:

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev updated this revision to Diff 395393. sgatev added a comment. Remove anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files:

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116011/new/ https://reviews.llvm.org/D116011

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2005 - } - break; case tok::l_square: Is this case not covered by this? I presume not as you didn't remove any unit tests

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov marked 3 inline comments as done. azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/invalid-device-enqueue-types-cl3.0.cl:5 +void f() { + clk_event_t e; + queue_t q; Anastasia wrote: > I know that many test have prefix "invalid" but

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 395390. azabaznov added a comment. Simplified running lines in tests, use 'verify' when validating features, simplify condition in Sema Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 created this revision. zero9178 added reviewers: mstorsjo, rnk. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stdcall name mangling requires a suffix with the number equal to the sum of the byte count of all parameter

[PATCH] D116007: [clang-format] Fix BreakBeforeBraces: Attach ignored with trailing requires-expression of function.

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116007/new/ https://reviews.llvm.org/D116007

[PATCH] D116008: [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG960712ccc710: [clang-format] Fix wrong indentation of namespace identifiers after a concept… (authored by curdeius). Repository: rG LLVM Github

[clang] 960712c - [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

Author: Marek Kurdej Date: 2021-12-20T09:13:32+01:00 New Revision: 960712ccc7103ded3d95e10c61516126836a1eba URL: https://github.com/llvm/llvm-project/commit/960712ccc7103ded3d95e10c61516126836a1eba DIFF: https://github.com/llvm/llvm-project/commit/960712ccc7103ded3d95e10c61516126836a1eba.diff