[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev marked an inline comment as done. sgatev added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 ___ cfe-commits

[PATCH] D116169: [JSONNodeDumper] Do not print mangled names for local variables (PR49111)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8043beb8901c: [JSONNodeDumper] Do not print mangled names for local variables (PR49111) (authored by nikic). Herald added a project: clang. Herald

[clang] 8043beb - [JSONNodeDumper] Do not print mangled names for local variables (PR49111)

Author: Nikita Popov Date: 2021-12-23T08:55:41+01:00 New Revision: 8043beb8901cb95fce4266b498262acf08494510 URL: https://github.com/llvm/llvm-project/commit/8043beb8901cb95fce4266b498262acf08494510 DIFF: https://github.com/llvm/llvm-project/commit/8043beb8901cb95fce4266b498262acf08494510.diff

[PATCH] D116206: [clang] adds `__add_cv` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116206 Files:

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196 + +class VirtualDestructorTest : public ::testing::Test { +protected: gribozavr2 wrote: > DYM

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev updated this revision to Diff 395979. sgatev marked an inline comment as done. sgatev added a comment. Rename a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files:

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66d602c3f58: [clang-format] Fix wrong indentation after trailing requires clause. (authored by curdeius). Repository: rG LLVM Github Monorepo

[clang] f66d602 - [clang-format] Fix wrong indentation after trailing requires clause.

Author: Marek Kurdej Date: 2021-12-23T08:22:12+01:00 New Revision: f66d602c3f58bd8a312c79bb404eac9dabf1a730 URL: https://github.com/llvm/llvm-project/commit/f66d602c3f58bd8a312c79bb404eac9dabf1a730 DIFF: https://github.com/llvm/llvm-project/commit/f66d602c3f58bd8a312c79bb404eac9dabf1a730.diff

[PATCH] D116205: [clang] adds `__add_volatile` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116205 Files:

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind, Quuxplusone, urnathan. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. According to

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb added a comment. This patch is heavily based off D67052 , and I'll be listing @zoecarver as a co-author in my commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116203 Files:

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei reopened this revision. pengfei added a comment. This revision is now accepted and ready to land. There are several buildbot fail. Need to investigate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/

[clang] a954558 - Revert "[X86][MS-InlineAsm] Use exact conditions to recognize MS global variables"

Author: Phoebe Wang Date: 2021-12-23T12:44:33+08:00 New Revision: a954558e878ed9e97e99036229e99af8c6b6c881 URL: https://github.com/llvm/llvm-project/commit/a954558e878ed9e97e99036229e99af8c6b6c881 DIFF: https://github.com/llvm/llvm-project/commit/a954558e878ed9e97e99036229e99af8c6b6c881.diff

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG682d01a1c1c5: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables (authored by pengfei). Repository: rG LLVM Github

[clang] 682d01a - [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

Author: Phoebe Wang Date: 2021-12-23T11:46:03+08:00 New Revision: 682d01a1c1c52bd95d3d06267d6017395770256b URL: https://github.com/llvm/llvm-project/commit/682d01a1c1c52bd95d3d06267d6017395770256b DIFF: https://github.com/llvm/llvm-project/commit/682d01a1c1c52bd95d3d06267d6017395770256b.diff

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. Look almost good! Thanks for doing this. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Do we

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid added a comment. I do not have commit access to the main repo. If someone who does could push it up I would appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; Quuxplusone wrote: >

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395959. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Format codes and edit summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files:

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; ChuanqiXu wrote: >

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; Quuxplusone wrote: >

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395954. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:398-400 + if (Tok && Tok->is(tok::kw_typedef)) +Tok = Tok->getNextNonComment(); + if (Tok && Tok->isOneOf(tok::kw_class, tok::kw_struct)) { Nits: - It's

[PATCH] D116196: [clangd] Add CompileFlags.Compiler option to override argv0

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is separate from

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207210 , @clemenswasser wrote: > The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`. Off-cause , I am asking to replace with correct value each test. > Also there are many test cases,

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. Maybe `asan_client` (like `stats_client` above), or `asan_inline`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 ___ cfe-commits

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. I don't like the name "asan_dso". DSO means "dynamic shared object", and this is the very opposite of that. Maybe "asan_private" or "asan_helper"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I suspect Driver part is going to be reverted a couple of time. Maybe extract it into a separate patch? Comment at: compiler-rt/lib/asan/CMakeLists.txt:167

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`. Also there are many test cases, where `LSAN_BASE` gets used multiple times. Removing it would result in bad repetition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207150 , @clemenswasser wrote: > @vitalybuka could you or someone else help me get the lsan tests running on > Windows? > For example lets look at > `compiler-rt\test\lsan\TestCases\leak_check_at_exit.cpp` (and

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

MyDeveloperDay added a comment. Can you test the typedef case you added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @vitalybuka could you or someone else help me get the lsan tests running on Windows? For example lets look at `compiler-rt\test\lsan\TestCases\leak_check_at_exit.cpp` (and basically all other tests, this serves as an easy example) I imagine that the following

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is consistent with the behavior of Doxygen, and allows users to write strings with C escapes

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Single-variant enums were still getting placed on a single

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395929. tianshilei1992 added a comment. just emit the error but not return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files:

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo updated this revision to Diff 395926. chrisdangelo added a comment. "I think it makes sense to simply copy that file and replace function attributes with parameter attributes and see if it still passes." - @NoQ (Tue, Dec 21, 12:28 PM) Sounds good. This newest change adds

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. And initialize the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I really need to get my requires patch done... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116183/new/

[PATCH] D116137: [clang-tidy] Remove dead plugin code

thakis added a comment. If this code is truly dead, this looks fine to me. But IIRC D97693 was about no longer linking clang-tidy into libclang, while clang-tidy/plugin/ClangTidyPlugin.cpp (if I read the comments therein right) is for using clang-tidy as a

[clang-tools-extra] d840f3e - Resolve -Wdocumentation warning in ClangTidyDiagnosticConsumer (NFC)

Author: Salman Javed Date: 2021-12-23T10:25:05+13:00 New Revision: d840f3edf0297699e750413e629543c2a9271b90 URL: https://github.com/llvm/llvm-project/commit/d840f3edf0297699e750413e629543c2a9271b90 DIFF: https://github.com/llvm/llvm-project/commit/d840f3edf0297699e750413e629543c2a9271b90.diff

[PATCH] D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inspection of the first character can just be handled by the loop as well, it does exactly the same

[clang-tools-extra] 86618e3 - Resolve lint warning about converting unsigned to signed (NFC)

Author: Salman Javed Date: 2021-12-23T09:46:14+13:00 New Revision: 86618e37bded924d0a7a06ef0818bb9b2311532d URL: https://github.com/llvm/llvm-project/commit/86618e37bded924d0a7a06ef0818bb9b2311532d DIFF: https://github.com/llvm/llvm-project/commit/86618e37bded924d0a7a06ef0818bb9b2311532d.diff

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. Thanks for taking a look. I will update the diff to address your comments. Have a good new years break. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:197 + SourceLocation Loc = FileStartLoc.getLocWithOffset( +

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52834. Before this patch,

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 395914. kstoimenov added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This will allow linking in the callbacks directly instead of using PLT. Repository:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Do we still need

[PATCH] D116174: [clang] support relative roots to vfs overlays

keith added a comment. This LGTM but I'm interested to hear from folks with more knowledge about the VFS' desired behavior to comment on if this will have any unexpected side effects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395904. Jake-Egan added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/codegen-body/test.c

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse added a comment. Hmmm. I thought this was quiet after landing -- and it turns out the reason why is there's still a sneek-circuit in clang that's turning instruction referencing off by default. Woe is me; should have done more end-to-end testing :|. On the upside, in the last few weeks

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

luismarques added a comment. I think this would benefit from increased test coverage, namely to show that the mattr command-line options are properly handled. Some possible ideas: - Tests with the correct extension versions (maybe add a test file that exercises the version for all extensions).

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu added a comment. @ezhulenev I finally made it! Thanks for your help! @mehdi_amini @ftynse hi, might you help to look if the change in mlir part is good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu updated this revision to Diff 395835. ChuanqiXu retitled this revision from "[Coroutines] Set presplit attribute in Clang" to "[Coroutines] Set presplit attribute in Clang and mlir". ChuanqiXu edited the summary of this revision. ChuanqiXu added a reviewer: mehdi_amini. ChuanqiXu added

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

jrtc27 added a comment. Do not bring back V draft 0.7. It is gone, it will never be supported again by LLVM under that name. The standard extension namespace is reserved for ratified extensions and development snapshots only, not old drafts vendors decided to ship. For those, non-standard

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu updated this revision to Diff 395803. zixuan-wu edited the summary of this revision. zixuan-wu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added a comment. In D43002#3205190 , @MaskRay wrote: > Some test nits:) I don't know CodeView :( Fixed, thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. Sounds good to me. > CMAKE_INSTALL_PREFIX should be removed. I think we have consensus on that ^, orthogonal to the /opt/rocm presence or absence. As long as there's some way to tell cmake to use a given HSA, and it seems there are several, deleting that

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb added a comment. Our conclusion is that the /opt/rocm weak default needs to stay in place. Thus this patch should be abandoned in my opinion. MarkS and I are requesting the folks that requestedt his change within AMD, revisit it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. @ronlieb do you have any more information? The patch says remove /opt/rocm but the discussion seems to be going another way. What's the actual req here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb requested changes to this revision. ronlieb added a comment. This needs to be revisited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ https://reviews.llvm.org/D109885 ___

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

MaskRay added a comment. Some test nits:) I don't know CodeView :( Comment at: clang/test/CodeGenCXX/debug-info-objname.cpp:1 +// RUN: cp %s %T/debug-info-objname.cpp +// RUN: cd %T The whole file appears to be CRLF where almost all other tests use LF in

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet added a comment. some drive-by comments, i'll be AFK for a while though. so please don't block this on my approval if people disagree. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:197 + SourceLocation Loc = FileStartLoc.getLocWithOffset(

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395896. rmaz added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the sepavloff wrote: > Response

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395893. rmaz added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz created this revision. Herald added subscribers: dexonsmith, hiraditya. rmaz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This diff adds support for relative roots to VFS overlays. The directory root will be made

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196 + +class VirtualDestructorTest : public ::testing::Test { +protected: DYM "Noreturn" instead of "Virtual"? Repository: rG LLVM Github

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

On Wed, Dec 22, 2021 at 11:47 AM Jeremy Morse wrote: > On Wed, Dec 22, 2021 at 4:34 PM David Blaikie via cfe-commits > wrote: > > Is there a way to turn this off now, if it's broken for some user/use > case? I guess using an -mllvm flag, instead of an -Xclang flag? > > Yup, that should be

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the Response and configuration

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

On Wed, Dec 22, 2021 at 4:34 PM David Blaikie via cfe-commits wrote: > Is there a way to turn this off now, if it's broken for some user/use case? I > guess using an -mllvm flag, instead of an -Xclang flag? Yup, that should be achieved by "-mllvm -experimental-debug-variable-locations=false",

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nathanchance updated this revision to Diff 395879. nathanchance added a comment. Herald added subscribers: luke957, s.egerton, simoncook. - Move test from x86-outline-atomics.c to unsupported-outline-atomics.c (Marco). - Add a test for riscv64 to ensure it works with multiple architectures

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

Is there a way to turn this off now, if it's broken for some user/use case? I guess using an -mllvm flag, instead of an -Xclang flag? Generally I think for a significant change like this the process would be to add it under a flag, off by default, encourage people to test it by opting in via the

[clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

Author: Jeremy Morse Date: 2021-12-22T16:30:05Z New Revision: ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f URL: https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f DIFF: https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f.diff LOG:

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added a comment. You need some unit tests to show it working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list

[PATCH] D116068: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa364e8f6adeb: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into… (authored by tianshilei1992). Repository: rG LLVM

[clang] a364e8f - [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

Author: Shilei Tian Date: 2021-12-22T11:24:15-05:00 New Revision: a364e8f6adeb4b42296413b6112a8bdfbd2ea116 URL: https://github.com/llvm/llvm-project/commit/a364e8f6adeb4b42296413b6112a8bdfbd2ea116 DIFF: https://github.com/llvm/llvm-project/commit/a364e8f6adeb4b42296413b6112a8bdfbd2ea116.diff

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Abandon the change because of the trade off between the amount of changes and benefit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115573/new/

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery created this revision. GPery requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116170 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116167: [clangd] Adjust compile flags so they work when applied to other file(type)s.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It's reasonable to want to

[clang] da007a3 - [JSONNodeDumper] Regenerate test checks (NFC)

Author: Nikita Popov Date: 2021-12-22T16:56:52+01:00 New Revision: da007a33c95a37c1331a14bc4f377982598fe68a URL: https://github.com/llvm/llvm-project/commit/da007a33c95a37c1331a14bc4f377982598fe68a DIFF: https://github.com/llvm/llvm-project/commit/da007a33c95a37c1331a14bc4f377982598fe68a.diff

[clang-tools-extra] fd8fc5e - [clang-tidy] abseil-string-find-startswith: detect `s.rfind(z, 0) == 0`

Author: Ivan Gerasimov Date: 2021-12-22T16:45:51+01:00 New Revision: fd8fc5e8d93849f4a2c8dea087690b1a0e6ea7df URL: https://github.com/llvm/llvm-project/commit/fd8fc5e8d93849f4a2c8dea087690b1a0e6ea7df DIFF:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I have confirmed that this problem is not due to this patch. Besides, on Mac, both m1 and intel, the on-demand-parsing as well as loading an AST file generated via driver argument `-emit-ast` will also trigger this problem. However, when loading an AST file

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395864. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395863. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. No worries, it's indeed good practice! Feel free to take a look at the docs, where this (and many more features) is described :) https://clang.llvm.org/extra/clang-tidy/ > will disable all default checks (-*) and enable all clang-analyzer-* checks > except for

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. bump, review requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666 + HasMOPS |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || + ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; So, this is enabled by default (as in "is mandatory

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok marked an inline comment as done. alok added a comment. Thanks @djtodoro . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115510/new/ https://reviews.llvm.org/D115510 ___ cfe-commits mailing list

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

chill added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:125 ARM::AEK_DOTPROD| ARM::AEK_BF16 | ARM::AEK_I8MM)) +ARM_ARCH("armv8.8-a", ARMV8_8A, "8.8-A", "v8.8a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8,

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb271880c8f: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of… (authored by alok). Changed prior to commit: https://reviews.llvm.org/D115510?vs=393447=395860#toc Repository:

[clang] 5eb2718 - [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

Author: Alok Kumar Sharma Date: 2021-12-22T20:04:21+05:30 New Revision: 5eb271880c8fc59835797806ac44f736eaf3ddbd URL: https://github.com/llvm/llvm-project/commit/5eb271880c8fc59835797806ac44f736eaf3ddbd DIFF:

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg abandoned this revision. reyg added a comment. Well now I feel stupid for not realizing that, thanks for pointing it out :) At least I learned how to hack around in clang-tidy  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116163/new/

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. In D116163#3206473 , @reyg wrote: > I actually couldn't find a way to black-list specific checks. Is there a way > to do that? Just prepend a dash to the check name that you want to disable:

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall updated this revision to Diff 395858. sammccall added a comment. Also handle -Wno- flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116147/new/ https://reviews.llvm.org/D116147 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 395856. momo5502 edited the summary of this revision. momo5502 added a comment. Herald added a subscriber: dexonsmith. A call to `isCompatibleWithMSVC` was added with the proper version that introduced the change (1925) and comments describing the intention

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg added a comment. I actually couldn't find a way to black-list specific checks. Is there a way to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116163/new/ https://reviews.llvm.org/D116163

  1   2   >