[PATCH] D116262: [clang] adds `__remove_reference` as a compiler built-in

xbolva00 added a comment. Missing description / motivation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116262/new/ https://reviews.llvm.org/D116262 ___ cfe-commits mailing list

[PATCH] D116262: [clang] adds `__remove_reference` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116262 Files:

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG097208dbf077: [C++20] [Coroutines] Allow promise_type to not define return_void or… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] 097208d - [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

Author: Chuanqi Xu Date: 2021-12-24T13:37:51+08:00 New Revision: 097208dbf07786f3da84aec5b5f571c6e95a10e2 URL: https://github.com/llvm/llvm-project/commit/097208dbf07786f3da84aec5b5f571c6e95a10e2 DIFF: https://github.com/llvm/llvm-project/commit/097208dbf07786f3da84aec5b5f571c6e95a10e2.diff

[clang] f3d4e16 - [C++20] Conform coroutine's comments in clang (NFC-ish)

Author: Chuanqi Xu Date: 2021-12-24T12:41:44+08:00 New Revision: f3d4e168dbc7e736ef535c673ee635a40feb2037 URL: https://github.com/llvm/llvm-project/commit/f3d4e168dbc7e736ef535c673ee635a40feb2037 DIFF: https://github.com/llvm/llvm-project/commit/f3d4e168dbc7e736ef535c673ee635a40feb2037.diff

[PATCH] D116261: [WIP][Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:10991 + EncounteredAtomicKinds.contains(OMPC_capture)) +AtomicKind = OMPC_compare_capture; // OpenMP 5.0, 2.17.7 atomic Construct, Restrictions This is the place where

[PATCH] D116261: [WIP][Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: arphaman, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This

[PATCH] D116260: [clang] adds `__remove_cv` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116260 Files:

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/coroutines.cpp:987 +// +// So it isn't ill-formed if the promise doesn't define return_value and return_void. It is just a UB. +coro no_return_value_or_return_void() { Quuxplusone wrote: > It's not

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu updated this revision to Diff 396126. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116204/new/ https://reviews.llvm.org/D116204 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11398-11400 +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +// code gen. +Diag(Body->getBeginLoc(),

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 396122. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[clang] 71b3bfd - [ASan] Moved optimized callbacks into a separate library.

Author: Kirill Stoimenov Date: 2021-12-24T00:40:44Z New Revision: 71b3bfde9cd296525bbf5b1619e199074156d12b URL: https://github.com/llvm/llvm-project/commit/71b3bfde9cd296525bbf5b1619e199074156d12b DIFF: https://github.com/llvm/llvm-project/commit/71b3bfde9cd296525bbf5b1619e199074156d12b.diff

[PATCH] D113718: Don't append the working directory to absolute paths

dblaikie added a subscriber: thakis. dblaikie added a comment. @thakis - I think you folks over in Chrome land implemented/use `-fdebug-prefix-map` (or do you use `-fdebug-compilation-dir`?) so might be interested in this change. CHANGES SINCE LAST ACTION

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang created this revision. akhuang added reviewers: hans, thakis. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make clang-cl error when a function definition is missing 'noexcept', and succeed without warnings when missing

[clang] a67c0fc - [Hexagon] Revamp HVX flag verification in driver

Author: Krzysztof Parzyszek Date: 2021-12-23T15:18:08-08:00 New Revision: a67c0fc1fbe8479eb5b3d7c189395bfe6cb98086 URL: https://github.com/llvm/llvm-project/commit/a67c0fc1fbe8479eb5b3d7c189395bfe6cb98086 DIFF:

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207867 , @clemenswasser wrote: > @vitalybuka I have now removed all `LSAN_BASE` occurrences. > However the invocations of the compiled test executables don't seem to work > either. > This doesn't work: > `// RUN:

[PATCH] D116242: [clang] adds `__remove_volatile` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116242 Files:

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if (arm::getARMSubArchVersionNumber(EffectiveTriple) < 7 && -

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if (arm::getARMSubArchVersionNumber(EffectiveTriple) < 7 && -

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

Random06457 created this revision. Random06457 added a reviewer: atanasyan. Herald added subscribers: dang, jrtc27, hiraditya, arichardson, mgorny, sdardis. Random06457 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

kastiglione added a comment. Herald added a subscriber: carlosgalvezp. +1 to committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 ___ cfe-commits

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov requested review of this revision. kstoimenov added a comment. Added empty asan_static_rtl.cpp to work around the Windows build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396083. kstoimenov added a comment. Fixed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396082. kstoimenov added a comment. s/set/append/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396081. kstoimenov added a comment. Added asan_rtl_static.cpp empty file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files:

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

curdeius added a comment. Why this option is useful? Why would someone want to have a different alignment in casts than in other places? As such I'm opposed to introducing one more option. Is there any well established code style that has something like this? Repository: rG LLVM Github

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3045 +// parenthesis of a cast we know we are in a cast. +if (!Left.isOneOf(TT_PointerOrReference, tok::l_paren)) + for (const FormatToken *Tok = What are

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers created this revision. nickdesaulniers added reviewers: nathanchance, ardb, peter.smith. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This conditional check for

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D116188#3208378 , @yodaldevoid wrote: > Correct commit email Since you only upload a diff, there is no name or email. ;)

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe8180af5854: [clang][driver] Warn when -mno-outline-atomics is used with a non-AArch64… (authored by nathanchance). Repository: rG LLVM Github

[clang] be8180a - [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

Author: Nathan Chancellor Date: 2021-12-23T12:36:42-07:00 New Revision: be8180af5854806a343c3dd334d97ba2c4bfadfa URL: https://github.com/llvm/llvm-project/commit/be8180af5854806a343c3dd334d97ba2c4bfadfa DIFF:

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid updated this revision to Diff 396064. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

yodaldevoid updated this revision to Diff 396062. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116229/new/ https://reviews.llvm.org/D116229 Files: clang/include/clang/Format/Format.h

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid updated this revision to Diff 396060. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid added a comment. In D116189#3207717 , @MyDeveloperDay wrote: > We need your name and email address to be able to commit as you Ah, right. `arcanist` should keep that information, but I wish Phabricator would give a way to provide it as

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

MaskRay added a comment. I slightly adjusted the test in eafc64ed6325eba962096d4a947d7e45e909bfde :) `-no-canonical-prefixes` can usually be omitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] eafc64e - [Driver][test] Remove unneeded -no-canonical-prefixes and use preferred --target=

Author: Fangrui Song Date: 2021-12-23T11:25:13-08:00 New Revision: eafc64ed6325eba962096d4a947d7e45e909bfde URL: https://github.com/llvm/llvm-project/commit/eafc64ed6325eba962096d4a947d7e45e909bfde DIFF: https://github.com/llvm/llvm-project/commit/eafc64ed6325eba962096d4a947d7e45e909bfde.diff

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 396055. jackoalan added a comment. Make expansion token a parameter of `ExpandResponseFiles` and limit use to `readConfigFile`. Elaborate manual entry further and add entry to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I personally prefer that pointers are aligned to the right

[PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

Mordante requested changes to this revision. Mordante added a comment. This revision now requires changes to proceed. This revision reverts more than intended. Since it now touches libcxx directory it requires libc++ approval. Please reduce the revert to the intended scope. Repository: rG

[PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski,

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:33 + bool operator!=(const RISCVExtensionVersion ) const { +return !operator==(Version); + } Use `!(*this == Version)` Comment at:

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu updated this revision to Diff 395963. ChuanqiXu added a comment. Clean codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/test/CodeGenCoroutines/coro-always-inline.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. And, I am seeing a lot of failures on nvptx machine (sm_70, cuda11.4) with this patch, libomptarget :: nvptx64-nvidia-cuda :: offloading/bug49021.cpp libomptarget :: nvptx64-nvidia-cuda :: offloading/bug49334.cpp libomptarget :: nvptx64-nvidia-cuda ::

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added a comment. In D115921#3206156 , @jrtc27 wrote: > Do not bring back V draft 0.7. It is gone, it will never be supported again > by LLVM under that name. The standard extension namespace is reserved for > ratified extensions and

Re: [PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

I got a couple of options myself: adan_instrumentation asan_fast_path asan_mini What do you think? On Wed, Dec 22, 2021, 3:30 PM Evgenii Stepanov via Phabricator < revi...@reviews.llvm.org> wrote: > eugenis added a comment. > > I don't like the name "asan_dso". DSO means "dynamic shared

RE: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[AMD Official Use Only] @Singh, Pushpinder is this resolved? You were most recently working on it. Thx -Original Message- From: Johannes Doerfert via Phabricator Sent: Wednesday, December 22, 2021 5:46 PM To: georgakoud...@llnl.gov; jdoerf...@anl.gov; jhub...@vols.utk.edu;

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert accepted this revision. jdoerfert added a comment. Can we land this? AMD issues seems resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___

[clang] 1d1b5ef - [Hexagon] Driver/preprocessor options for Hexagon v69

Author: Krzysztof Parzyszek Date: 2021-12-23T10:17:08-08:00 New Revision: 1d1b5efdef49fa814a7e4feadd175a3dfc6460a0 URL: https://github.com/llvm/llvm-project/commit/1d1b5efdef49fa814a7e4feadd175a3dfc6460a0 DIFF:

[PATCH] D116226: [clang] adds `__remove_const` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116226 Files:

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

pbarrio requested changes to this revision. pbarrio added a comment. This revision now requires changes to proceed. Suggest clarifying the commit message to something like: "Added warning for potential cases of unaligned access when option -mno-unaligned-access has been specified". Nice

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid updated this revision to Diff 396041. yodaldevoid added a comment. Addressed reviewer comments - Removed unnecessary null checks - Added tests for typedefs preceding short enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. > 1. It it possible to limit the new syntax to config files only? It would > avoid concerns of gcc compatibility. Yes, ultimately this use case only calls for extending config files. > Is it possible to use more understandable designation, like `` or > something

[clang] 4bf3165 - Revert "[ASan] Moved optimized callbacks into a separate library."

Author: Kirill Stoimenov Date: 2021-12-23T17:13:18Z New Revision: 4bf31659fac73ed6ebeb4b4d95dc41aac5dcd666 URL: https://github.com/llvm/llvm-project/commit/4bf31659fac73ed6ebeb4b4d95dc41aac5dcd666 DIFF: https://github.com/llvm/llvm-project/commit/4bf31659fac73ed6ebeb4b4d95dc41aac5dcd666.diff

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bf31659fac7: Revert [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This reverts commit ab3640aa0e8361921a5d0cdc393a5b75e78ec22b

[clang] 4c8becb - [Hexagon] Add Hexagon v69 builtins to clang

Author: Krzysztof Parzyszek Date: 2021-12-23T09:00:15-08:00 New Revision: 4c8becbeee18a4ef83a6d8005b0e0fe19a5077ed URL: https://github.com/llvm/llvm-project/commit/4c8becbeee18a4ef83a6d8005b0e0fe19a5077ed DIFF:

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ created this revision. mubashar_ added a reviewer: lenary. Herald added a subscriber: kristof.beyls. mubashar_ requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A warning for when potential cases of unaligned access with option

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

lebedev.ri added a comment. In D116216#3208096 , @pvellien wrote: > The testcases related to this patch are already added via this patch > https://reviews.llvm.org/D112820. If this patch does not result in test changes, then there is no test coverage.

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/coroutines.cpp:987 +// +// So it isn't ill-formed if the promise doesn't define return_value and return_void. It is just a UB. +coro no_return_value_or_return_void() { It's not UB; it's

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. The testcases related to this patch are already added via this patch https://reviews.llvm.org/D112820. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

sepavloff added a comment. Thank you for the detailed explanation. Now I see how you are going to use this facility and think it worth implementation. A couple of questions. 1. It it possible to limit the new syntax to config files only? It would avoid concerns of gcc compatibility. 2. The

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab3640aa0e83: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[clang] ab3640a - [ASan] Moved optimized callbacks into a separate library.

Author: Kirill Stoimenov Date: 2021-12-23T16:40:36Z New Revision: ab3640aa0e8361921a5d0cdc393a5b75e78ec22b URL: https://github.com/llvm/llvm-project/commit/ab3640aa0e8361921a5d0cdc393a5b75e78ec22b DIFF: https://github.com/llvm/llvm-project/commit/ab3640aa0e8361921a5d0cdc393a5b75e78ec22b.diff

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added a comment. Renamed it 'dso' to 'static'. I know it could be a little bit confusing. I was considering 'static_link' or 'always_static', but it seems too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396031. kstoimenov marked an inline comment as done. kstoimenov added a comment. Remaned dso to static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files:

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. looks good! Yay, Halting Problem :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116204/new/ https://reviews.llvm.org/D116204 ___

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0045d01af96f: [SPIR-V] Add a toolchain for SPIR-V in clang (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0045d01 - [SPIR-V] Add a toolchain for SPIR-V in clang

Author: Anastasia Stulova Date: 2021-12-23T15:10:09Z New Revision: 0045d01af96ff56c5b62d133be076020a33867ff URL: https://github.com/llvm/llvm-project/commit/0045d01af96ff56c5b62d133be076020a33867ff DIFF: https://github.com/llvm/llvm-project/commit/0045d01af96ff56c5b62d133be076020a33867ff.diff

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. test coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

SjoerdMeijer added a comment. > If anybody has contacts to GCC that would be very helpful. Unfortunately I > don't think I will be able to drive this. Ok, I will bring this up internally first with some folks that work on GCC and see what happens. To be continued... Repository: rG LLVM

[clang] 7977fd7 - [OpenMP] Remove no-op cast (NFC)

Author: Nikita Popov Date: 2021-12-23T15:15:26+01:00 New Revision: 7977fd7cfc5b60742af062ae4aef46fe400cca9d URL: https://github.com/llvm/llvm-project/commit/7977fd7cfc5b60742af062ae4aef46fe400cca9d DIFF: https://github.com/llvm/llvm-project/commit/7977fd7cfc5b60742af062ae4aef46fe400cca9d.diff

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[clang] bf2b555 - [CodeGen] Use CreateConstInBoundsGEP() in one more place

Author: Nikita Popov Date: 2021-12-23T14:58:47+01:00 New Revision: bf2b5551f9192106b1997f7c9c3bdc36be2dc381 URL: https://github.com/llvm/llvm-project/commit/bf2b5551f9192106b1997f7c9c3bdc36be2dc381 DIFF: https://github.com/llvm/llvm-project/commit/bf2b5551f9192106b1997f7c9c3bdc36be2dc381.diff

[clang] 2c7dc13 - [CGBuilder] Add CreateGEP() overload that accepts an Address

Author: Nikita Popov Date: 2021-12-23T14:53:42+01:00 New Revision: 2c7dc13146ba0c2991e4950ce159276ad5d9aece URL: https://github.com/llvm/llvm-project/commit/2c7dc13146ba0c2991e4950ce159276ad5d9aece DIFF: https://github.com/llvm/llvm-project/commit/2c7dc13146ba0c2991e4950ce159276ad5d9aece.diff

[clang] 86b001a - [C++20] [Modules] Mark imported module as imported if not exported

Author: Chuanqi Xu Date: 2021-12-23T21:14:13+08:00 New Revision: 86b001a94172ac625f17f381c971dad3b9367278 URL: https://github.com/llvm/llvm-project/commit/86b001a94172ac625f17f381c971dad3b9367278 DIFF: https://github.com/llvm/llvm-project/commit/86b001a94172ac625f17f381c971dad3b9367278.diff

[clang] 1e2c31c - Revert "[C++20] [Coroutines] Mark imported module as imported if not exported"

Author: Chuanqi Xu Date: 2021-12-23T21:10:07+08:00 New Revision: 1e2c31c66be79b6ca6aeb42fc2835017935b8b27 URL: https://github.com/llvm/llvm-project/commit/1e2c31c66be79b6ca6aeb42fc2835017935b8b27 DIFF: https://github.com/llvm/llvm-project/commit/1e2c31c66be79b6ca6aeb42fc2835017935b8b27.diff

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG368318bcce66: [C++20] [Coroutines] Mark imported module as imported if not exported (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] 368318b - [C++20] [Coroutines] Mark imported module as imported if not exported

Author: Chuanqi Xu Date: 2021-12-23T20:51:05+08:00 New Revision: 368318bcce66d9fef420fc34cca361b79d80cee5 URL: https://github.com/llvm/llvm-project/commit/368318bcce66d9fef420fc34cca361b79d80cee5 DIFF: https://github.com/llvm/llvm-project/commit/368318bcce66d9fef420fc34cca361b79d80cee5.diff

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2234 +/// In this example directive '#pragma omp atomic' has 'compare' clause. +class OMPCompareClause : public OMPClause { +public: `final` Comment at:

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @vitalybuka I have now removed all `LSAN_BASE` occurrences. However the invocations of the compiled test executables don't seem to work either. This doesn't work: `// RUN: %env_lsan_opts=use_stacks=0:use_registers=0 not %run %t foo 2>&1 | FileCheck %s

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu updated this revision to Diff 396009. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116204/new/ https://reviews.llvm.org/D116204 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116098/new/ https://reviews.llvm.org/D116098 ___ cfe-commits mailing list

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

ChuanqiXu updated this revision to Diff 396007. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116098/new/ https://reviews.llvm.org/D116098 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/module-transtive-instantiation.cpp

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1431-1432 +// +// Then AnalysisBasedWarning would emit a warning about `foo()` lacks a +// co_return statements. +Fallthrough =

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

urnathan added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1431-1432 +// +// Then AnalysisBasedWarning would emit a warning about `foo()` lacks a +// co_return statements. +Fallthrough = S.ActOnNullStmt(PromiseRecordDecl->getLocation());

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

ChuanqiXu added a comment. In D116098#3207812 , @urnathan wrote: > as all exports are also imports, is there a reason we don;t also add the > exports into the import table? I am not sure if it has an intentional reason or it is just an oversight. From

[clang] 53f0538 - [CodeGen] Use correct element type for store to sret

Author: Nikita Popov Date: 2021-12-23T13:02:49+01:00 New Revision: 53f0538181fd62f2a5efa9c73589f75e80454a8e URL: https://github.com/llvm/llvm-project/commit/53f0538181fd62f2a5efa9c73589f75e80454a8e DIFF: https://github.com/llvm/llvm-project/commit/53f0538181fd62f2a5efa9c73589f75e80454a8e.diff

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

urnathan added a comment. as all exports are also imports, is there a reason we don;t also add the exports into the import table? is Exports really 'ExportedImports' and 'Imports' really 'NotExportedImports'? If that's the case, this patch is fine. Comment at:

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, kzhuravl. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. HIP program with printf call fails to compile with -fsanitize=address option,

[clang] 09669e6 - [CodeGen] Avoid pointer element type access when creating LValue

Author: Nikita Popov Date: 2021-12-23T10:53:15+01:00 New Revision: 09669e6c5fa1e8db9c1091cc264640fb0377d6b6 URL: https://github.com/llvm/llvm-project/commit/09669e6c5fa1e8db9c1091cc264640fb0377d6b6 DIFF: https://github.com/llvm/llvm-project/commit/09669e6c5fa1e8db9c1091cc264640fb0377d6b6.diff

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

MyDeveloperDay added a comment. We need your name and email address to be able to commit as you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189 ___ cfe-commits

[PATCH] D116171: [OpenMP] Fix incorrect type when casting from uintptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1201a0f3955b: [OpenMP] Fix incorrect type when casting from uintptr (authored by nikic). Herald added a project: clang. Herald added a subscriber: