[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

junaire updated this revision to Diff 396492. junaire edited the summary of this revision. junaire added a comment. Refactor code a little bit and fix wrong names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396490. junaire added a comment. Extend emitUnaryBuiltin instead of adding a new overload, also apply it to __builtin_elementwise_abs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.

[clang] 7f1eaea - [OpenMP][NFC] Extract assumption helpers into own header file

Author: Johannes Doerfert Date: 2021-12-28T23:53:29-06:00 New Revision: 7f1eaeafe7a13fc642e9510f43ec19390b32157d URL: https://github.com/llvm/llvm-project/commit/7f1eaeafe7a13fc642e9510f43ec19390b32157d DIFF: https://github.com/llvm/llvm-project/commit/7f1eaeafe7a13fc642e9510f43ec19390b32157d.d

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3191148 , @hubert.reinterpretcast wrote: > In D109751#3178494 , @qiucf wrote: > >> Thanks for the reminder. Here GCC and Clang diverges in the handling of >> `__ibm128`/`__float

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. In D113126#3212033 , @jdoerfert wrote: > In D113126#3211935 , > @tianshilei1992 wrote: > >>

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

jdoerfert added a comment. In D113126#3211935 , @tianshilei1992 wrote: > In D113126#3122947 , @jdoerfert > wrote: > >> In D113126#3122659 , >> @tianshilei1992 wrote: >>

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > HazardyKnusperkeks wrote: > > zwliew wrote: > > > HazardyKnusperkeks wrote: > >

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); HazardyKnusperkeks wrote: > zwliew wrote: > > Is there a reason for this to be limited to 1? I

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew updated this revision to Diff 396458. zwliew added a comment. Support inheritance in a chain of more than 1 parents I made the following changes: 1. Refactor the code for loading and parsing configs into a separate function 2. Add a new test case (9.1.2) to test the case mentioned in ht

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

sammccall added a comment. Ooh, this is messy indeed. Thanks for digging! Comment at: clang-tools-extra/clangd/Selection.cpp:526 + // the traversal order of SizeExpr and ElementTypeLoc, which gives a chance + // for the SizeExpr to claim its tokens. + bool TraverseConstantAr

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

sammccall updated this revision to Diff 396455. sammccall added a comment. Clean up style, remove fixed fixme, add an extra testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116352/new/ https://reviews.llvm.org/D116352 Files: clang-tools-e

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

sammccall created this revision. sammccall added reviewers: kadircet, usaxena95. Herald added a subscriber: arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Provide signature while typing t

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3211929 , @nathanchance wrote: > @hyeongyukim I am currently offline for the evening but it seems like my > reduction might have been too aggressive. It looks like this code comes from > `ravb_set_gti()` > (http

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

tianshilei1992 added a comment. In D113126#3122947 , @jdoerfert wrote: > In D113126#3122659 , > @tianshilei1992 wrote: > >> I'm not convinced. `std::strlen` can do the job. Can you explain more why >> need it? >

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted at 8 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a comment. @hyeongyukim I am currently offline for the evening but it seems like my reduction might have been too aggressive. It looks like this code comes from `ravb_set_gti()` (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/rene

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3116810 , @nathanchance wrote: > Prior to the latest revert (fd9b099906c61e46574d1ea2d99b973321fe1d21 > ), the > Linux kernel's binary verifier

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew added a comment. In D72326#3211701 , @HazardyKnusperkeks wrote: > Do you plan to refactor something for this review, or do you think you are > done? Then I will look at it again as a whole. I'm going to try refactoring the code for loading and pa

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + HazardyKnusperkeks wrote: > zwliew wrote: > > HazardyKnusperkeks wrote: > > > zwliew wrote: > >

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3419 + if (isa(D)) { vs. if (isa(D)) { + for (auto *A : D.attrs()) { for (auto *A : D.attrs()) + if (shouldProcessAttr(A)) { if (shouldPr

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

owenpan added a comment. In D116318#3211689 , @HazardyKnusperkeks wrote: > I'm against that patch. > >> Don't pay for what you don't use. > > We should not put the size check into every call. That's what you must do now **without **this patch, which wil

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396430. ksyx added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/CMakeLists.txt

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396428. ksyx marked 5 inline comments as done. ksyx added a comment. - Apply suggestions from clangfmt - Add missing period of comments - Fix namespace ending comment - Add comment for notes on return value of WhitespaceManager's method CHANGES SINCE LAST ACTIO

[PATCH] D116342: [clang][AST] Fix crash when printing error

ellis created this revision. ellis added a reviewer: dblaikie. ellis published this revision for review. ellis added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/AST/TypePrinter.cpp:242 case Type::ObjCObjectPoi

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd284b7ac061: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[clang] cd284b7 - [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

Author: Nick Desaulniers Date: 2021-12-28T13:28:34-08:00 New Revision: cd284b7ac0615afc6e0f1a30da2777e361de27a3 URL: https://github.com/llvm/llvm-project/commit/cd284b7ac0615afc6e0f1a30da2777e361de27a3 DIFF: https://github.com/llvm/llvm-project/commit/cd284b7ac0615afc6e0f1a30da2777e361de27a3.di

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added a comment. Do you plan to refactor something for this review, or do you think you are done? Then I will look at it again as a whole. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3054 + enum SeparateDefinitionStyle { +/// Leave definition blocks separated as they are without changing anything +SDS_Leave, Add full stop at the end of sentences

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

HazardyKnusperkeks added a comment. I'm against that patch. > Don't pay for what you don't use. We should not put the size check into every call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116318/new/ https://reviews.llvm.org/D116318

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1903 /// lead to incorrect code formatting due to incorrect decisions made due to - /// clang-formats lack of complete semantic information. + /// clang-format's lack of complete sem

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added a comment. In D116316#3211269 , @curdeius wrote: > Could you have a look at preceding reviews and see if there wasn't a similar > patch before? > I think that this option is a bit too limited. > Only removing braces doesn't seem

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:2114 + if (Result.add(R)) +return; + } HazardyKnusperkeks wrote: > Why only add the first replacement? This worked well as the `Error` class `

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396421. ksyx marked 4 inline comments as done. ksyx added a comment. Herald added a subscriber: mgorny. - Change version from 15 to 14 - Add option `SDS_Never`, rename `SDS_Between` => `SDS_Always` - Add unit tests - Separate class into new file CHANGES SINCE L

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2027 +// namespaces by inserting a line break between them. +class DefinitionBlockSeparator : public TokenAnalyzer { +public: curdeius wrote: > Please consider moving it to a differ

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2900 + /// \version 14 + unsigned PenaltyBreakOpenParenthesis; + Please resort. Comment at: clang/lib/Format/Format.cpp:1238 LLVMStyle.PenaltyBreakTe

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks added a comment. Does it affect calling code? `a.operator++(5);` Should it? But please add tests for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 _

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > HazardyKnusper

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-cortex-cpus.c:445 +// RUN: %clang -target armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s +// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | File

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

alxu created this revision. alxu added a project: clang. alxu requested review of this revision. Herald added a subscriber: cfe-commits. This causes modern glibc to unset math_errhandling MATH_ERRNO. gcc 12 also sets some other macros, but most of them are associated with flags ignored by clang,

[clang] 89aa87c - [clang] Fix AttrDocs.td formatting.

Author: Michael Benfield Date: 2021-12-28T19:13:03Z New Revision: 89aa87c4e601985dae4b41206f0c5594e8742c78 URL: https://github.com/llvm/llvm-project/commit/89aa87c4e601985dae4b41206f0c5594e8742c78 DIFF: https://github.com/llvm/llvm-project/commit/89aa87c4e601985dae4b41206f0c5594e8742c78.diff L

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

Quuxplusone added inline comments. Comment at: clang/lib/Format/TemplateArgumentKeywordFixer.cpp:55 +// For `auto` language version, be conservative and assume we are < C++17 +KeepTemplateTemplateKW = (Style.Standard == FormatStyle::LS_Auto) || +

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

Quuxplusone added inline comments. Comment at: clang/unittests/Format/TemplateArgumentKeywordFixerTest.cpp:119 + Style); +} + My personal recommended style is that the programmer uses `template` consistently and therefore anytime you see the (more

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3755 + * ``bool AfterOperatorOverloading`` If ``true``, put a space between operator overloading and opening parentheses. + curdeius wrote: > I'm not fond of the current

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/CMakeLists.txt:232 +if(CLANG_DEFAULT_PIE_ON_LINUX) + set(CLANG_DEFAULT_PIE_ON_LINUX 1) +endif() arichardson wrote: > Can these 3 lines be removed after D115751? Thx. Remov

[clang] b5d3bbc - [CMake] Remove unneeded CLANG_DEFAULT_PIE_ON_LINUX canonicalization after D115751

Author: Fangrui Song Date: 2021-12-28T10:49:52-08:00 New Revision: b5d3bbcc9433193351a22b738c7ff4b007cb1e68 URL: https://github.com/llvm/llvm-project/commit/b5d3bbcc9433193351a22b738c7ff4b007cb1e68 DIFF: https://github.com/llvm/llvm-project/commit/b5d3bbcc9433193351a22b738c7ff4b007cb1e68.diff

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3755 + * ``bool AfterOperatorOverloading`` If ``true``, put a space between operator overloading and opening parentheses. + I'm not fond of the current name, exactly the "Overl

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

curdeius added a comment. Thanks for addressing the comments quickly. I'll have one more thorough look in the coming days. Comment at: clang/lib/Format/TemplateArgumentKeywordFixer.cpp:55 +// For `auto` language version, be conservative and assume we are < C++17 +KeepT

[PATCH] D115604: [Support] Expand `` as the base directory in response files.

jackoalan updated this revision to Diff 396410. jackoalan added a comment. Rebase, use the slightly more intuitive `` token to expand base paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files: c

[clang] e6e7bdd - Drop unnecessary const from return types (NFC)

Author: Kazu Hirata Date: 2021-12-28T10:01:39-08:00 New Revision: e6e7bdd6a90ca8ba896fb92f6e0e642d42c84efc URL: https://github.com/llvm/llvm-project/commit/e6e7bdd6a90ca8ba896fb92f6e0e642d42c84efc DIFF: https://github.com/llvm/llvm-project/commit/e6e7bdd6a90ca8ba896fb92f6e0e642d42c84efc.diff L

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 396408. lichray added a comment. - Put tests in TypePrinterTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang added inline comments. Comment at: clang/lib/Format/TemplateArgumentKeywordFixer.h:36 +} // end namespace format +} // end namespace clang + avogelsgesang wrote: > curdeius wrote: > > Please make the comments consistent with other files. > Consisten

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang updated this revision to Diff 396403. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. Fix namespace comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116290/new/ https://reviews.llvm.org/D116290 Fil

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang added inline comments. Comment at: clang/include/clang/Format/Format.h:3691 + /// COULD lead to incorrect code formatting due to incorrect decisions made + /// due to clang-formats lack of complete semantic information. As such extra + /// care should be take

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang updated this revision to Diff 396401. avogelsgesang marked 7 inline comments as done. avogelsgesang added a comment. Thank you for your review, @curdeius! I updated my change to address most of your comments. Regarding "KeepTemplateTemplateKW", I think we had a misunderstanding (see

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

owenpan added a comment. In D116318#3211258 , @curdeius wrote: > Wasn't assert enough? Could you add a test with code that provokes the > problem? This fix is an NFC, so there will be no (user) test case for it. :) The current behavior does not match t

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3211178 , @junaire wrote: > In order to use `emitUnaryBuiltin` in other cases, I changed the function > interface. > This allows us to use it in all `Builder.CreateUnaryIntrinsic()` cases, but > will make > the function

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3404 + + * ``SDS_Leave`` (in configuration: ``Leave``) +Leave definition blocks separated as they are. This enumeration surely needs 3 settings ``` Leave, // don't

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18515 +TEST_F(FormatTest, BreakPenaltyAfterLParen) { + FormatStyle Style = getLLVMStyle(); 1) fix the formatting 2) add a default case which shows how the bracket will

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay added a comment. See D95168: [clang-format] Add Insert/Remove Braces option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 __

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); There should be a PARSE unit test too

[PATCH] D116328: [ast-matchers] Add hasSubstmt() traversal matcher for caseStmt(), defaultStmt()

LegalizeAdulthood updated this revision to Diff 396392. LegalizeAdulthood added a comment. Update based on comments from lint check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116328/new/ https://reviews.llvm.org/D116328 Files: clang/docs/LibASTMatchersReference.html clang/includ

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 396338. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subj

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

labath resigned from this revision. labath added a comment. I'm sorry, but I don't feel qualified to review this. Last time I saw this file was in 2013. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116329/new/ https://reviews.llvm.org/D116329 __

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for working on this. Please add unit tests that verify the expected behaviour. Keep them simple. You can inspire yourself from existing tests. Comment a

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

curdeius added a comment. Could you have a look at preceding reviews and see if there wasn't a similar patch before? I think that this option is a bit too limited. Only removing braces doesn't seem enough. Also, one should probably be able to decide when to add/remove them by e.g. setting the nu

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Wasn't assert enough? Could you add a test with code that provokes the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11631

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

curdeius added a comment. Looks nice already. Thanks for working on this. Comment at: clang/include/clang/Format/Format.h:3691 + /// COULD lead to incorrect code formatting due to incorrect decisions made + /// due to clang-formats lack of complete semantic information. As

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke marked 13 inline comments as done. Sockke added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:145 + if ((!ReceivingCallExpr || + ReceivingCallExpr->getDirectCallee()->isTemplateInstantiation()) && + (!Re

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 396385. Sockke added a comment. Sorry for the late reply. I made improvements to the patch in response to the questions you raised. @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: c

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396380. junaire added a comment. In order to use `emitUnaryBuiltin` in other cases, I changed the function interface. This allows us to use it in all `Builder.CreateUnaryIntrinsic()` cases, but will make the function body very small. Repository: rG LLVM

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

qiucf updated this revision to Diff 396379. qiucf marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116003/new/ https://reviews.llvm.org/D116003 Files: clang/test/CodeGen/stack-protector-guard.c Index: clang/test/Co