[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396835. ksyx marked 3 inline comments as done. ksyx added a comment. Change the `SDS_Leave` style check to be assert not having this style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files:

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; HazardyKnusperkeks

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396826. ksyx added a comment. Use `reformat` method instead of calling the single method only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst

[clang-tools-extra] e47a224 - [clang-tidy] Use nullptr instead of 0 or NULL (NFC)

Author: Kazu Hirata Date: 2021-12-31T13:54:34-08:00 New Revision: e47a224ccfbbfd61f31136db53768dabbb85e563 URL: https://github.com/llvm/llvm-project/commit/e47a224ccfbbfd61f31136db53768dabbb85e563 DIFF: https://github.com/llvm/llvm-project/commit/e47a224ccfbbfd61f31136db53768dabbb85e563.diff

[PATCH] D116328: [ast-matchers] Add hasSubstmt() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

LegalizeAdulthood added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:358 REGISTER_MATCHER(hasStructuredBlock); + REGISTER_MATCHER(hasSubstmt); REGISTER_MATCHER(hasSyntacticForm); I see there is another matcher called

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: > >

[clang-tools-extra] 255ee64 - [clang-tools-extra] Remove unused using (NFC)

Author: Kazu Hirata Date: 2021-12-31T10:51:10-08:00 New Revision: 255ee643a8c559375a9c9787ef7d121790040818 URL: https://github.com/llvm/llvm-project/commit/255ee643a8c559375a9c9787ef7d121790040818 DIFF: https://github.com/llvm/llvm-project/commit/255ee643a8c559375a9c9787ef7d121790040818.diff

[PATCH] D116459: [Clang][Sema] Adjust formatting (NFC)

egorzhdan created this revision. Herald added a reviewer: aaron.ballman. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a preparation for another change in the watchOS/tvOS availability logic. It is extracted into a

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. @dexonsmith The issue with `-grecord-command-line`/`-frecord-command-line` is that it isn't producing a self-standing command-line. For example: > clang-cl /c main.cpp /clang:-grecord-command-line /Z7 would record: `d:\\git\\llvm-project\\stage1\\bin\\clang-cl.exe

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:88 +for (const FieldDecl *Field : Type->getAsRecordDecl()->fields()) { + FieldLocs.insert({Field, (Field->getType())}); +} sgatev wrote: >

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd50072f74e3e: [ARM] Introduce an empty armv8.8-a architecture. (authored by simon_tatham, committed by tmatheson). Repository: rG LLVM Github

[clang] d50072f - [ARM] Introduce an empty "armv8.8-a" architecture.

Author: Simon Tatham Date: 2021-12-31T16:43:53Z New Revision: d50072f74e3ee50b750a618fcdf05739dec9542d URL: https://github.com/llvm/llvm-project/commit/d50072f74e3ee50b750a618fcdf05739dec9542d DIFF: https://github.com/llvm/llvm-project/commit/d50072f74e3ee50b750a618fcdf05739dec9542d.diff LOG:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 396804. aganea added a comment. This revision is now accepted and ready to land. Herald added subscribers: abrachet, mgorny. Rebase & simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reuses the

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 396783. momo5502 marked 4 inline comments as done. momo5502 added a comment. Comments were addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[PATCH] D116351: Update Bug report URL to Github Issues

Quuxplusone added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[PATCH] D116351: Update Bug report URL to Github Issues

ksyx added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/;, xbolva00 wrote: > This url should

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396737. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Drop the change in lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst

[PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: lld/docs/_templates/indexsidebar.html:3-4 lld bugs should be reported at the - LLVM https://bugs.llvm.org/;>Bugzilla. + LLVM https://github.com/llvm/llvm-project/issues/;>Issues. ChuanqiXu wrote: > MaskRay wrote: >

[PATCH] D116351: Update Bug report URL to Github Issues

xbolva00 added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/;, This url should redirect to github

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev marked 4 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:32 +template +bool denseMapsAreEqual(const llvm::DenseMap , + const llvm::DenseMap ) { xazax.hun

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; HazardyKnusperkeks wrote: > Better, but I still think we

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396782. ksyx added a comment. Change lambda variable names' leading letter to uppercase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396781. ksyx marked 5 inline comments as done. ksyx added a comment. Change lambda variable names' leading letter to uppercase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files:

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tmatheson updated this revision to Diff 396780. tmatheson added a comment. Minor fix after rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tmatheson updated this revision to Diff 396779. tmatheson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396778. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files:

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); HazardyKnusperkeks wrote: > rajatbajpai

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2edcde00cb39: [MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass (authored by Random06457, committed by atanasyan). Changed prior to

[clang] 2edcde0 - [MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

Author: Random Date: 2021-12-31T15:59:44+03:00 New Revision: 2edcde00cb396cc17d8d8b171a6ebaa97fd30e59 URL: https://github.com/llvm/llvm-project/commit/2edcde00cb396cc17d8d8b171a6ebaa97fd30e59 DIFF: https://github.com/llvm/llvm-project/commit/2edcde00cb396cc17d8d8b171a6ebaa97fd30e59.diff LOG:

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116238/new/ https://reviews.llvm.org/D116238 ___

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; Better, but I still think we should have the

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

pratlucas accepted this revision. pratlucas added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 ___ cfe-commits mailing list

[PATCH] D116439: Fix `readability-const-return-type` for pure virtual function.

Sockke created this revision. Sockke added a reviewer: aaron.ballman. Herald added a subscriber: carlosgalvezp. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It cannot match a `pure virtual function`. This patch fixes

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Anastasia updated this revision to Diff 396771. Anastasia added a comment. Added corrections from Justas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116271/new/ https://reviews.llvm.org/D116271 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index:

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

zixuan-wu added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence. Could abandon it due to D108189 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95589/new/

[PATCH] D116415: [Arm] Remove duplicate CPU tests

tmatheson added reviewers: lenary, dmgreen, cpirker, olista01, vsukharev, SjoerdMeijer. tmatheson added a comment. Thanks for the review @nickdesaulniers. Adding a few more reviewers just to check that I'm not missing something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116415: [Arm] Remove duplicate CPU tests

tmatheson added inline comments. Comment at: clang/test/Driver/arm-cortex-cpus.c:217 // RUN: %clang -target arm -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V81A %s -// RUN: %clang -target arm -march=armv8.1a -mlittle-endian -### -c %s 2>&1 | FileCheck