[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

Ericson2314 accepted this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Not sure what the exact division of labor is between the GNU and MinGW backends, but assuming there is no way to share this between them the patch looks good. Repository: rG

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. Note this is a first draft, I need to go test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 ___ cfe-commits mailing list

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 created this revision. Ericson2314 added a reviewer: tstellar. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is continuing in the path of D51714

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood added a comment. This was accepted before in August, 2019, but the script changed in the meantime. I've repeated the Extract Class on top-of-tree, so presumably this is still acceptable. However, I don't know how commit access has changed. (I don't think I have it anymore.)

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 396909. LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood edited the summary of this revision. LegalizeAdulthood set the repository for this revision to rG LLVM Github Monorepo. LegalizeAdulthood added a comment. Rebase on top

[PATCH] D116342: [clang][AST] Fix crash when printing error

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/TypePrinter.cpp:242 case Type::ObjCObjectPointer: CanPrefixQualifiers = T->isObjCIdType() || T->isObjCClassType() ||

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

Eugene.Zelenko added a comment. Please mention new option in Release Notes (in changes in existing checks section). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 ___ cfe-commits mailing list

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

mehdi_amini created this revision. mehdi_amini added reviewers: rriddle, jpienaar, Mogball. Herald added a subscriber: carlosgalvezp. mehdi_amini requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option allows to eliminate

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

zero9178 created this revision. zero9178 added reviewers: mstorsjo, compnerd, mati865. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC on Windows ignores this flag completely [0] which some build systems sadly rely on when

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

LegalizeAdulthood updated this revision to Diff 396878. LegalizeAdulthood retitled this revision from "[ast-matchers] Add hasSubstmt() traversal matcher for caseStmt(), defaultStmt(), labelStmt()" to "[ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(),

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

thakis added a comment. Thanks for the patch! This looks roughly right to me. Maybe the list of ESTs that are allowed to be mismatched should be opt-in instead of opt-out? (i.e. instead of checking for "not EST_BasicNoexcept / EST_DependentNoexcept", check for EST_NoThrow (I think?) Not sure

[clang] f4ffcab - Remove redundant string initialization (NFC)

Author: Kazu Hirata Date: 2022-01-01T12:34:11-08:00 New Revision: f4ffcab1787ad19ad9c2596688306de8a45f904a URL: https://github.com/llvm/llvm-project/commit/f4ffcab1787ad19ad9c2596688306de8a45f904a DIFF: https://github.com/llvm/llvm-project/commit/f4ffcab1787ad19ad9c2596688306de8a45f904a.diff

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 396869. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 396867. zinovy.nis added a comment. Fix clang-format issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, aaron.ballman. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. zinovy.nis requested review of this revision. Herald added a subscriber: cfe-commits. A comma-separated list of

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev marked 3 inline comments as done. sgatev added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 ___ cfe-commits

[clang] 683e6ee - [CodeGen] Remove redundant string initialization (NFC)

Author: Kazu Hirata Date: 2022-01-01T09:14:23-08:00 New Revision: 683e6ee7d04f01e068b5d17b54ac2395fb6bf554 URL: https://github.com/llvm/llvm-project/commit/683e6ee7d04f01e068b5d17b54ac2395fb6bf554 DIFF: https://github.com/llvm/llvm-project/commit/683e6ee7d04f01e068b5d17b54ac2395fb6bf554.diff

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396846. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396831. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396825. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396824. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396822. Ericson2314 added a comment. Big rebase and cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. I guess reopening is the better way to redo after revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**SeparateDefinitionBlocks** (``SeparateDefinitionStyle``) :versionbadge:`clang-format 14` + Specifies the use of empty lines to separate definition blocks, including classes,

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo added a reviewer: MaskRay. mstorsjo added a comment. Adding more potential reviewers. For context, see https://github.com/llvm/llvm-project/blob/llvmorg-14-init/clang/lib/Driver/Driver.cpp#L335-L353 where the original option is filtered out. Repository: rG LLVM Github Monorepo

[PATCH] D116314: [clang-format] Add style to separate definition blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thank you for this patch, I'll also definately use this myself. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**SeparateDefinitionBlocks** (``SeparateDefinitionStyle``)