[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3699 + unsigned ChunkIndex = 0; + auto AddChunk = [&](std::string Placeholder) { +if (ChunkIndex > 0) nit: const ref. Comment at:

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 397206. achieveartificialintelligence added a comment. Use `DAGOperand` instead of `RegisterOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b6e21f19da: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation (authored by curdeius). Repository: rG LLVM Github

[clang] e2b6e21 - [clang-format] Fix incorrect formatting of lambdas inside brace initialisation

Author: Marek Kurdej Date: 2022-01-04T08:28:12+01:00 New Revision: e2b6e21f19da6fe0da9349264e43286f0441b4ca URL: https://github.com/llvm/llvm-project/commit/e2b6e21f19da6fe0da9349264e43286f0441b4ca DIFF: https://github.com/llvm/llvm-project/commit/e2b6e21f19da6fe0da9349264e43286f0441b4ca.diff

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

denzor200 created this revision. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. denzor200 requested review of this revision. Herald added a project: clang-tools-extra. Added a check for converting ``BOOST_FOREACH(..., ...)`` loops to use the new range-based loops in C++11. This

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116563/new/ https://reviews.llvm.org/D116563 ___ cfe-commits mailing list

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116562/new/ https://reviews.llvm.org/D116562 ___ cfe-commits mailing list

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116561/new/ https://reviews.llvm.org/D116561 ___ cfe-commits mailing list

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116560/new/ https://reviews.llvm.org/D116560 ___ cfe-commits mailing list

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116559/new/ https://reviews.llvm.org/D116559 ___ cfe-commits mailing list

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116558/new/ https://reviews.llvm.org/D116558 ___ cfe-commits mailing list

[clang] 304d30b - [clang] Fix warning about unused variable [NFC]

Author: Mikael Holmen Date: 2022-01-04T07:28:16+01:00 New Revision: 304d30bc594bf99bba9ee780007ac78755a9ff7a URL: https://github.com/llvm/llvm-project/commit/304d30bc594bf99bba9ee780007ac78755a9ff7a DIFF: https://github.com/llvm/llvm-project/commit/304d30bc594bf99bba9ee780007ac78755a9ff7a.diff

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217 +let Predicates = [HasStdExtF] in { +def : FPFMADynFrmAlias; +def : FPFMADynFrmAlias; craig.topper wrote: > Why do the aliases not apply to Zfinx?

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217 +let Predicates = [HasStdExtF] in { +def : FPFMADynFrmAlias; +def : FPFMADynFrmAlias; Why do the aliases not apply to Zfinx? Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:124 class FPFMA_rrr_frm funct2, string opcodestr, -RegisterClass rty> +RegisterOperand rty> : RVInstR4Frmhttps://reviews.llvm.org/D93298/new/

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 397193. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

owenpan added a comment. Unless the test cases are wrong, they should not be changed. The original test case looked correct to me as it was doing a continuation indent between `type{` and `}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 397191. achieveartificialintelligence added a comment. Address @craig.topper 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:170 + +static DecodeStatus DecodeGPRF32RegisterClass(MCInst , uint64_t RegNo, + uint64_t Address, Can we make

[PATCH] D116325: [X86] Add missing CET intrinsics support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bab74280570: [X86] Add missing CET intrinsics support (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0bab742 - [X86] Add missing CET intrinsics support

Author: Freddy Ye Date: 2022-01-04T11:40:40+08:00 New Revision: 0bab7428057048d94774a91c329ae902fcffc170 URL: https://github.com/llvm/llvm-project/commit/0bab7428057048d94774a91c329ae902fcffc170 DIFF: https://github.com/llvm/llvm-project/commit/0bab7428057048d94774a91c329ae902fcffc170.diff

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

craig.topper added a subscriber: khchen. craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:290 +if (ExtName == "zdinx") + Features.push_back("+zfinx"); @kito-cheng or @khchen is the right way to do this? Or should it be

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 397184. owenpan added a comment. - Fixed a bug found by applying the patch on the entire `clang` source tree. - Added an exception: the braces are not removed if the right one is followed by a comment on the same line. - Updated an existing test case and

[PATCH] D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

MaskRay added a comment. Without testing `libclang_rt.profile{{.*}}.a` in clang/test/Driver, such functionality may regress. If I am to refactor `addProfileRTLibs`, I may not notice the untested feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added a comment. @Quuxplusone do you feel good with the current message? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. In D114995#3218022 , @aaron.ballman wrote: > In D114995#3218004 , @oleg.smolsky > wrote: > >> @aaron.ballman could you commit this change please? I've never had commit >>

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. In D116020#3218453 , @majnemer wrote: > I wonder if we should have different behavior for MSVC targets. > > If I do: > > class Incomplete; > extern "C" int __stdcall Fn(int, Incomplete, long long); > auto fnptr = > > MSVC

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. In D114077#3218446 , @thakis wrote: > Still broken on windows: http://45.33.8.238/win/51764/step_4.txt I think the builder is stuck, that build is some hours old and doesn't have the fix in it. (Which leaves the possibility

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. Looks great! Please give others some time to review it as it is a holiday season... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

ksyx accepted this revision. ksyx added a comment. This revision is now accepted and ready to land. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 ___ cfe-commits mailing list

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

majnemer added a comment. I wonder if we should have different behavior for MSVC targets. If I do: class Incomplete; extern "C" int __stdcall Fn(int, Incomplete, long long); auto fnptr = MSVC generates: EXTRN _Fn@12:PROC It appears that they skip over incomplete types. Should the

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Still broken on windows: http://45.33.8.238/win/51764/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___ cfe-commits

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, the change seems sensible to me. But I’d prefer if you could hold off pushing it for another couple days, as others who might want to comment might not be following during the

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. In D116557#3218328 , @ksyx wrote: > Thanks for the fix :) No Problem. Comment at: clang/docs/ReleaseNotes.rst:300 - Option ``SeparateDefinitionBlocks`` has been added to insert or remove empty

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks updated this revision to Diff 397148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: clang/include/clang/Format/Format.h

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 added a comment. In D114787#3188735 , @aaron.ballman wrote: > https://reviews.llvm.org/D115094 is a review for doing effectively the same > fix. Can you coordinate with the other patch author to determine who will > drive this fix? I sent an

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use that

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

ksyx added a comment. Thanks for the fix :) Comment at: clang/docs/ReleaseNotes.rst:300 - Option ``SeparateDefinitionBlocks`` has been added to insert or remove empty lines between definition blocks including functions, classes, structs, enums, The

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And then

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. Without the enum documentation I got $ ./clang/docs/tools/dump_format_style.py Traceback (most recent call last): File "/c/GIT/llvm-dev/./clang/docs/tools/dump_format_style.py", line 344, in opts = OptionsReader(f).read_options() File

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: ksyx, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. the Style's

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added a comment. Can you make the test check for the diagnose message? Also, do we have a test to verify an isa trait is properly handled? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG1188f241acb7: Revert [clang-format][NFC] Prefer pass by reference (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115061?vs=391858=397137#toc Repository: rG LLVM

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

This revision was automatically updated to reflect the committed changes. Closed by commit rGd48d1f8ee845: [clang-format][NFC] Merge another two calls to isOneOf (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf014ab933f35: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115060?vs=391853=397135#toc Repository:

[clang] 1188f24 - Revert "[clang-format][NFC] Prefer pass by reference"

Author: Björn Schäpers Date: 2022-01-03T23:06:56+01:00 New Revision: 1188f241acb78dacef00b7b6b3ec0b04cb43c786 URL: https://github.com/llvm/llvm-project/commit/1188f241acb78dacef00b7b6b3ec0b04cb43c786 DIFF:

[clang] d48d1f8 - [clang-format][NFC] Merge another two calls to isOneOf

Author: Björn Schäpers Date: 2022-01-03T23:06:55+01:00 New Revision: d48d1f8ee84577a1ca38d4fe03956ee27884e399 URL: https://github.com/llvm/llvm-project/commit/d48d1f8ee84577a1ca38d4fe03956ee27884e399 DIFF:

[clang] f014ab9 - [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

Author: Björn Schäpers Date: 2022-01-03T23:06:55+01:00 New Revision: f014ab933f35805159021d2d0c856a3c9af21a85 URL: https://github.com/llvm/llvm-project/commit/f014ab933f35805159021d2d0c856a3c9af21a85 DIFF:

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. Friendly bump :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 397131. HazardyKnusperkeks set the repository for this revision to rG LLVM Github Monorepo. HazardyKnusperkeks added a comment. Now with SmallVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a subscriber: dblaikie. aganea added a comment. I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at least? (or maybe enable it through cmake, if ever there's a setting to detect we're running as a bot) Or just reverse the default setting on the main branch, ie.

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

tmatheson updated this revision to Diff 397127. tmatheson added a comment. Combine V8 and V9 macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116154/new/ https://reviews.llvm.org/D116154 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. In D116527#3217211 , @MyDeveloperDay wrote: > The fix looks ok, butr I don't understand the cause of the side effect? is it > explicitly aligning to the v of `auto v`? It's adding two spaces inside the `auto v = ...`,

[PATCH] D116314: [clang-format] Add style to separate definition blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6f88ffdae1: [clang-format] Style to separate definition blocks (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames updated this revision to Diff 397124. reames edited the summary of this revision. reames added a comment. Rework account for only being to infer on nocapture arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115003/new/ https://reviews.llvm.org/D115003 Files:

[clang] 6f6f88f - [clang-format] Style to separate definition blocks

Author: ksyx Date: 2022-01-03T15:47:39-05:00 New Revision: 6f6f88ffdae1e12e5f950ef418827a77a55c09c7 URL: https://github.com/llvm/llvm-project/commit/6f6f88ffdae1e12e5f950ef418827a77a55c09c7 DIFF: https://github.com/llvm/llvm-project/commit/6f6f88ffdae1e12e5f950ef418827a77a55c09c7.diff LOG:

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation when the return type has square brackets `[]`.

curdeius updated this revision to Diff 397123. curdeius added a comment. This patch fixes as well https://github.com/llvm/llvm-project/issues/27146. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116553/new/

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation when the return type has square brackets `[]`.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52943. Before: namespace

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

aykevl added a comment. avr-gcc checks whether the device supports the flash bank used. For example: $ cat test.c int d = 5; const int ro = 5; __flash const int f = 5; __flash1 const int f1 = 5; __flash2 const int f2 = 5; $ avr-gcc -mmcu=attiny84 -Os -c -o test.o test.c

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for adding the parse checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

sammccall added a comment. In D115106#3218000 , @aaron.ballman wrote: >> I think `anyRedeclaration(functionDecl(isStaticStorageClass))`is too >> difficult to get right and too easy to get wrong for such a common/simple >> concept. > > Get right in

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood updated this revision to Diff 397121. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Add `stmtExpr` test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116518/new/ https://reviews.llvm.org/D116518 Files:

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe3180742ad: [clang-format] Add penalty for breaking after ( (authored by G. Pery gp...@pm.me, committed by curdeius). Repository: rG LLVM

[clang] cfe3180 - [clang-format] Add penalty for breaking after '('

Author: G. Pery Date: 2022-01-03T21:06:34+01:00 New Revision: cfe3180742adfc72ad6f5de55cbfc84befb90c97 URL: https://github.com/llvm/llvm-project/commit/cfe3180742adfc72ad6f5de55cbfc84befb90c97 DIFF: https://github.com/llvm/llvm-project/commit/cfe3180742adfc72ad6f5de55cbfc84befb90c97.diff LOG:

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

curdeius accepted this revision. curdeius added a comment. LGTM. If you need help landing this (if you don't have commit rights), just give your name and email that you want to be used for the contribution and someone will land it for you. See also

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This doesn't seem like a correct revert. What command are you using to generate this? `git revert` is what you should be using, e.g.

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0)

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397116. Ericson2314 added a comment. Oops, forgot some includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 Files: clang/CMakeLists.txt

[PATCH] D116550: [clang-tidy] Recognize transformer checks as providing fixits

LegalizeAdulthood updated this revision to Diff 397115. LegalizeAdulthood added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116550/new/ https://reviews.llvm.org/D116550 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. In D114077#3218006 , @thakis wrote: > Breaks building on windows: http://45.33.8.238/win/51774/step_4.txt > > Ptal! Fixed (I think) in a61f34ea2502d900c57a332174d4c103b6963c80

[PATCH] D116521: [llvm][clang][flang][lld][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397114. Ericson2314 added a comment. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox,

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai updated this revision to Diff 397112. rajatbajpai added a comment. Incorporated review comments. Updated release note and example scenario. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283

[clang] db77f7a - Silence a "not all control paths return a value" warning; NFC

Author: Aaron Ballman Date: 2022-01-03T14:20:09-05:00 New Revision: db77f7a074d70f0092ba0870ad0ce42417095348 URL: https://github.com/llvm/llvm-project/commit/db77f7a074d70f0092ba0870ad0ce42417095348 DIFF: https://github.com/llvm/llvm-project/commit/db77f7a074d70f0092ba0870ad0ce42417095348.diff

[PATCH] D116550: [clang-tidy] Recognize transformer checks as providing fixits

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. LegalizeAdulthood requested review of this revision. [clang-tidy] Recognize transformer checks as

[clang-tools-extra] a61f34e - [clangd] Fix windows build after 478863ef58c7f7314e06

Author: Sam McCall Date: 2022-01-03T20:17:20+01:00 New Revision: a61f34ea2502d900c57a332174d4c103b6963c80 URL: https://github.com/llvm/llvm-project/commit/a61f34ea2502d900c57a332174d4c103b6963c80 DIFF: https://github.com/llvm/llvm-project/commit/a61f34ea2502d900c57a332174d4c103b6963c80.diff

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92417eaf3329: [CodeCompletion] Signature help for braced constructor calls (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 92417ea - [CodeCompletion] Signature help for braced constructor calls

Author: Sam McCall Date: 2022-01-03T20:14:59+01:00 New Revision: 92417eaf3329dc823c905ec6a608b83ac62b4f7c URL: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c DIFF: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c.diff

[clang] 92417ea - [CodeCompletion] Signature help for braced constructor calls

Author: Sam McCall Date: 2022-01-03T20:14:59+01:00 New Revision: 92417eaf3329dc823c905ec6a608b83ac62b4f7c URL: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c DIFF: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c.diff

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added a comment. In D114995#3218004 , @oleg.smolsky wrote: > @aaron.ballman could you commit this change please? I've never had commit > rights... Thanks! Sure can! Is `Oleg Smolsky ` the correct attribution for the patch, or would you

[PATCH] D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

saiislam added a comment. In D116540#3217689 , @jdoerfert wrote: > In D116540#3217684 , @saiislam > wrote: > >> 1. I don't know why "pgi" is present here as a vendor. Should it be renamed >> as nvidia instead?

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Breaks building on windows: http://45.33.8.238/win/51774/step_4.txt Ptal! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. @aaron.ballman could you commit this change please? I've never had commit rights... Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 397107. momo5502 added a comment. In D115456#3217857 , @majnemer wrote: > In D115456#3217595 , @momo5502 > wrote: > >> In D115456#3216811

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

aaron.ballman added a comment. In D115106#3217968 , @sammccall wrote: > Yeah, this is a thorny question. The language hasn't chosen clear names and > neither has the AST in many cases. > (Just yesterday I lost a lot of time to

[PATCH] D116540: [OpenMP] Add nvidia as a compiler vendor for OpenMP

saiislam updated this revision to Diff 397108. saiislam added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Added nec as compiler vendor. 2. Fixed clang test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106349: [clang-format] respect AfterEnum for enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7972b2e42276: [clang-format] respect AfterEnum for enums (authored by m1cha, committed by curdeius). Changed prior to commit:

[clang] 7972b2e - [clang-format] respect AfterEnum for enums

Author: Michael Zimmermann Date: 2022-01-03T20:01:10+01:00 New Revision: 7972b2e42276346e85bb6d4fb7e03bbd5a9af53f URL: https://github.com/llvm/llvm-project/commit/7972b2e42276346e85bb6d4fb7e03bbd5a9af53f DIFF:

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void ProcessOverloadCandidates(Sema , unsigned CurrentArg,

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

sammccall added a comment. Yeah, this is a thorny question. The language hasn't chosen clear names and neither has the AST in many cases. (Just yesterday I lost a lot of time to CXXRecordDecl->getBodyRBrace()...) I think `anyRedeclaration(functionDecl(isStaticStorageClass))`is too difficult to

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam created this revision. saiislam added reviewers: jdoerfert, alokmishra.besu, cchen, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Passing any feature

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

aaron.ballman added reviewers: rsmith, joerg, rjmccall, andrew.w.kaylor, aaron.ballman. aaron.ballman added a comment. Thanks for this! I'm adding some more reviewers to the list to help get this reviewed. The patch doesn't seem to apply cleanly, so precommit CI isn't running on it. Can you

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: lld/CMakeLists.txt:17 - execute_process(COMMAND "${LLVM_CONFIG_PATH}" - "--obj-root" - "--includedir" `--obj-root` is the same thing as `--prefix`, so this is in

  1   2   3   >