[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99f7d55c: [clang][dataflow] Add transfer functions for data members and this pointers (authored by sgatev). Repository: rG LLVM Github

[clang] 99f7d55 - [clang][dataflow] Add transfer functions for data members and this pointers

Author: Stanislav Gatev Date: 2022-01-12T07:38:26Z New Revision: 99f7d55cd56566d23ee222e272729e05535c URL: https://github.com/llvm/llvm-project/commit/99f7d55cd56566d23ee222e272729e05535c DIFF: https://github.com/llvm/llvm-project/commit/99f7d55cd56566d23ee222e272729e05535c.diff

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

Jimerlife added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:36 +// zbf extension +TARGET_BUILTIN(__builtin_riscv_bfp, "LiLiLi", "nc", "experimental-zbf") craig.topper wrote: > Capital Z done Comment at:

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

sgatev updated this revision to Diff 399219. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117012/new/ https://reviews.llvm.org/D117012 Files:

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

Jimerlife updated this revision to Diff 399216. Jimerlife edited the summary of this revision. Jimerlife added a comment. According to machine target, write two intrinsic __builtin_riscv_bfp_rv32 and __builtin_riscv_bfp_rv64. Support __builtin_riscv_bfp_rv32 used in RV64 target. Repository:

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:171 +return true; + // FIXME: Remove this std symbol list, as they should be covered by the +

[clang] bbced74 - [NFC] Remove invisible character in comments

Author: Chuanqi Xu Date: 2022-01-12T14:10:18+08:00 New Revision: bbced7419991cbe4611536289f032b8777c8b59b URL: https://github.com/llvm/llvm-project/commit/bbced7419991cbe4611536289f032b8777c8b59b DIFF: https://github.com/llvm/llvm-project/commit/bbced7419991cbe4611536289f032b8777c8b59b.diff

[PATCH] D117087: [WIP] [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu created this revision. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This patch tries to implement RVO for coroutine's return object got from `get_return_object`. >From [dcl.fct.def.coroutine]/p7 we could know

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance I tried to reproduce the last warning (intelfbhw_validate_mode), but I failed to produce it. I think my reproducer is correct, but it does not make any warning. Can you tell me which part was wrong? clang -O2 -flto=thin

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective… (authored by saiislam). Repository: rG LLVM Github

[clang] 876b5ea - [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

Author: Saiyedul Islam Date: 2022-01-12T05:24:49Z New Revision: 876b5ea96bf5890074aec61bc2c6a37b2cdc0617 URL: https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617 DIFF: https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617.diff

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:774 + while (!WorkList.empty()) { +auto ExtName = WorkList.pop_back_val(); +auto I = llvm::lower_bound(ImpliedExts, ExtName); Use StringRef instead of auto here.

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood updated this revision to Diff 399186. LegalizeAdulthood added a comment. - clang-format - use Token::isLiteral instead of homebrew token predicate - rename predicate on token list to reflect isLiteral CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116386/new/

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

MaskRay added a comment. In D116633#3236352 , @kda wrote: > In D116633#3226228 , @MaskRay wrote: > >> This needs a clang/test/Driver test to show that `%clang >> -fsanitize-memory-param-retval` translates to CC1

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. In D116633#3226228 , @MaskRay wrote: > This needs a clang/test/Driver test to show that `%clang > -fsanitize-memory-param-retval` translates to CC1 > `-fsanitize-memory-param-retval`. Could you point me to an example?

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0) return true; return false; } +/// \endcode +///

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117078: Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

kda created this revision. kda added reviewers: vitalybuka, eugenis. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117078 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D112913: Misleading bidirectional detection

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:16 +using namespace clang; + +static bool containsMisleadingBidi(StringRef Buffer,

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks nice. I think we'll need to think carefully before changing the default here. It seems like the choice here would depend on what token the location of the diagnostic

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea added inline comments. Comment at: clang/include/clang/Driver/Options.td:2493 MarshallingInfoInt>; +def fhotpatch : Flag<["-"], "fhotpatch">, Group, Flags<[CC1Option]>, + HelpText<"Ensure that all functions can be hotpatched at runtime">, hans wrote:

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea updated this revision to Diff 399168. aganea marked 4 inline comments as done. aganea edited the summary of this revision. aganea added a comment. Herald added a subscriber: kristof.beyls. As suggested by @hans Also added test coverage for ARM/ARM64. Repository: rG LLVM Github

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399163. kda added a comment. A few improvements. - Add -fsanitize-address-param-retval to clang. - updated flag help text and dropped use of flag (to be picked up later). - adjust help text - refined rendering of help text - add code generation - introduce

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; rnk wrote: > rnk wrote: > > dblaikie wrote: > > > Just came

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

This revision was automatically updated to reflect the committed changes. Closed by commit rG3110060bc721: AST: Avoid using SmallVector::set_size() in UnresolvedSet (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115386/new/

[clang] 3110060 - AST: Avoid using SmallVector::set_size() in UnresolvedSet

Author: Duncan P. N. Exon Smith Date: 2022-01-11T17:47:23-08:00 New Revision: 3110060bc721a02e69ead4c56e037a03d31bedef URL: https://github.com/llvm/llvm-project/commit/3110060bc721a02e69ead4c56e037a03d31bedef DIFF:

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399139. CJ-Johnson added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399135. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files:

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399134. CJ-Johnson edited the summary of this revision. CJ-Johnson added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files:

[PATCH] D115379: ASTMatchers: Avoid using SmallVector::set_size()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0b2a1a629da: ASTMatchers: Avoid using SmallVector::set_size() (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115121: Update bugprone-stringview-nullptr to prefer the empty string for most edits

CJ-Johnson updated this revision to Diff 399130. CJ-Johnson added a comment. Switching back to original plan of adding support for return statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files:

[clang] f0b2a1a - ASTMatchers: Avoid using SmallVector::set_size()

Author: Duncan P. N. Exon Smith Date: 2022-01-11T17:01:46-08:00 New Revision: f0b2a1a629dab17f2ea161a9281d8dc63b37a7a0 URL: https://github.com/llvm/llvm-project/commit/f0b2a1a629dab17f2ea161a9281d8dc63b37a7a0 DIFF:

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8159 + std::string BitcodeSuffix; + if (TCArgs.hasFlag(options::OPT_fopenmp_target_new_runtime, + options::OPT_fno_openmp_target_new_runtime, true))

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:268 + // Link the bitcode library late if we're using device LTO. + if (getDriver().isUsingLTO(/* IsOffload */ true)) +return; Can/should probably always link

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

JonChesterfield added a comment. Oh, right. Nvptx is still lowering to machine code per-tu. We don't want the devicertl linking as machine code, so it has to go in per-tu. Or we could link nvptx as IR instead, and send that plus amdgpu down the same code path. Probably makes applications

[clang] b271566 - [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

Author: Adam Magier Date: 2022-01-12T01:11:52+01:00 New Revision: b2715660ed0f821619f51158fb92cd8bddd105d8 URL: https://github.com/llvm/llvm-project/commit/b2715660ed0f821619f51158fb92cd8bddd105d8 DIFF: https://github.com/llvm/llvm-project/commit/b2715660ed0f821619f51158fb92cd8bddd105d8.diff

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2715660ed0f: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter (authored by AdamMagierFOSS). Changed prior to commit: https://reviews.llvm.org/D116048?vs=399057=399114#toc

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 added a comment. In D117048#3235763 , @JonChesterfield wrote: > Do we have a hook where we could link it at, uh, link time on nvtptx without > LTO? Amdgpu had a llvm-link already there. Always bothered me a little that > we link a copy per TU

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

JonChesterfield added a comment. Do we have a hook where we could link it at, uh, link time on nvtptx without LTO? Amdgpu had a llvm-link already there. Always bothered me a little that we link a copy per TU then hope the optimiser sorts it out nicely. Repository: rG LLVM Github Monorepo

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1034 + void target() { +int Foo = Bar; +// [[p]] A chained access would be nice, like `Qux.Baz`. Repository: rG LLVM Github Monorepo

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

AdamMagierFOSS added a comment. Thanks once again for the feedback - I'll make the changes and commit directly. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2256 + llvm::Value *size = EmitScalarExpr(sizeExpr); + clang::QualType sizeExprType =

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:763 + /// Set the address space for functions for the given target. + virtual void setProgramAddressSpace() { ProgramAddrSpace = 0; } + eandrews wrote: > I'm not entirely sure

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399096. Ericson2314 added a comment. Retrigger CI now that deps are fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

sgatev added a comment. Thank you both for the reviews! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:52 + setStorageLocation(*ParamDecl, ParamLoc); + initValueInStorageLocation(ParamLoc, ParamDecl->getType()); +} xazax.hun

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

sgatev updated this revision to Diff 399094. sgatev marked 12 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117012/new/ https://reviews.llvm.org/D117012 Files:

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews marked 3 inline comments as done. eandrews added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:763 + /// Set the address space for functions for the given target. + virtual void setProgramAddressSpace() { ProgramAddrSpace = 0; } +

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. With this

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 399080. eandrews added a comment. Add program address space to TargetInfo. Targets with non-default address space for functions should explicitly set value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. What's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99152/new/ https://reviews.llvm.org/D99152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

LegalizeAdulthood updated this revision to Diff 399076. LegalizeAdulthood added a comment. - clang-format - use `const IdentifierTable &` to avoid accidental modification - drop braces from simple block statements as per style guide CHANGES SINCE LAST ACTION

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

jyknight added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__",

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, very minor requests, but otherwise LGTM; feel free to commit with these changes. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2256 + llvm::Value

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

This revision was automatically updated to reflect the committed changes. Closed by commit rG6479f03daec1: [clang][#47272] Avoid suggesting deprecated version of a declaration over… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6479f03 - [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

Author: Markus Böck Date: 2022-01-11T22:58:10+01:00 New Revision: 6479f03daec1786d1e45f9148bd9298caafba9d2 URL: https://github.com/llvm/llvm-project/commit/6479f03daec1786d1e45f9148bd9298caafba9d2 DIFF: https://github.com/llvm/llvm-project/commit/6479f03daec1786d1e45f9148bd9298caafba9d2.diff

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116775/new/ https://reviews.llvm.org/D116775 ___ cfe-commits mailing list

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Thanks @Quuxplusone! @rsmith, I plan to commit this (with the suggested fix to release notes applied) sometime on Fri (Jan 14) unless I hear further feedback, in case you want to weigh in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

AdamMagierFOSS updated this revision to Diff 399057. AdamMagierFOSS added a comment. Updating based on feedback from rjmccall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116048/new/ https://reviews.llvm.org/D116048 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Ah thanks. Yea no worries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

aaron.ballman added a comment. In D116814#3235240 , @estan wrote: > BTW how are backports to release branches made in LLVM? (sorry if it's in the > docs somewhere!) We document the process here:

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ronlieb, gregrodgers, JonChesterfield. Herald added subscribers: ormris, dang, steven_wu, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ronlieb, gregrodgers, JonChesterfield. Herald added subscribers: kerbowa, guansong, inglorion, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. BTW how are backports to release branches made in LLVM? (sorry if it's in the docs somewhere!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone accepted this revision. Quuxplusone added a comment. LGTM FWIW. I'm not the right person to approve for libc, but I'm not sure any of the currently listed reviewers are any more appropriate either. So you should find and ping a new reviewer, or just ship it, at your discretion. :)

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; rnk wrote: > dblaikie wrote: > > Just came across this code

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I'm happy with this, but I'd like to get an ack from @craig.topper or @efriedma about the backwards compatibility concern. I think it's addresed. Comment at:

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c562f62a4ee: [clang] number labels in asm goto strings after tied inputs (authored by nickdesaulniers). Changed prior to commit:

[clang] 5c562f6 - [clang] number labels in asm goto strings after tied inputs

Author: Nick Desaulniers Date: 2022-01-11T12:09:24-08:00 New Revision: 5c562f62a4ee15592f5d764d0710553a4b07a6f2 URL: https://github.com/llvm/llvm-project/commit/5c562f62a4ee15592f5d764d0710553a4b07a6f2 DIFF:

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I commit on your behalf in 36af07334246a87a0f3fb9bbc85dedfca04b00d1 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 36af073 - Accept string literal decay in conditional operator

Author: Elvis Stansvik Date: 2022-01-11T15:05:30-05:00 New Revision: 36af07334246a87a0f3fb9bbc85dedfca04b00d1 URL: https://github.com/llvm/llvm-project/commit/36af07334246a87a0f3fb9bbc85dedfca04b00d1 DIFF:

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Ah right, `Elvis Stansvik ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one comment. This is great, thanks! Comment at: clang/test/Sema/attr-availability-tvos.c:66 + +#ifdef USE_VERSION_MAP +// iOS 9.3 corresponds to tvOS 9.2, as

[PATCH] D115936: [ASTMatcher] Add a new matcher called isInTopNamespace

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:465-467 + /// Helper to check if a Decl in a specific top level namespace, while inline + /// namespaces will be skipped. + bool isInTopNamespace(llvm::StringRef) const; I'm

[PATCH] D116967: [HIP] Fix device malloc/free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG694fd10659eb: [HIP] Fix device malloc/free (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 694fd10 - [HIP] Fix device malloc/free

Author: Yaxun (Sam) Liu Date: 2022-01-11T14:49:34-05:00 New Revision: 694fd10659eb32399b0c4fb31f2d062040d800b4 URL: https://github.com/llvm/llvm-project/commit/694fd10659eb32399b0c4fb31f2d062040d800b4 DIFF:

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8463fd22b1f: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests (authored by nickdesaulniers). Changed prior to commit:

[clang] c8463fd - [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

Author: Nick Desaulniers Date: 2022-01-11T11:48:40-08:00 New Revision: c8463fd22b1ff05c0273e7f446c9feeb114c3798 URL: https://github.com/llvm/llvm-project/commit/c8463fd22b1ff05c0273e7f446c9feeb114c3798 DIFF:

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Looks like all the review comments have been addressed. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:120 - // FIXME: Add `StorageLocation` for `this`. + StorageLocation *ThisPointeeLoc = nullptr; It feels a bit wrong to have a separate

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/RedundantVoidArgCheck.cpp:157-161 + if (ProtoToken.is(tok::TokenKind::l_paren)) { +State = TokenState::LeftParen; + } else if (isMacroIdentifier(Idents, ProtoToken)) {

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79ebc3b0dd13: [llvm][test] rewrite callbr to use i rather than X constraint NFC (authored by nickdesaulniers). Changed prior to commit:

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; dblaikie wrote: > Just came across this code today - it's

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5df9cc098b5: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e5df9cc - [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial

Author: Akira Hatanaka Date: 2022-01-11T11:18:24-08:00 New Revision: e5df9cc098b554ebb066792e40cbde6feddc57bc URL: https://github.com/llvm/llvm-project/commit/e5df9cc098b554ebb066792e40cbde6feddc57bc DIFF:

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added a comment. In D115253#3217331 , @aaron.ballman wrote: > Ping Ping (I'd like to get this into Clang 14 as I have follow-up work that's related for `_BitInt` support in C23). CHANGES SINCE LAST ACTION

[PATCH] D117012: [clang][dataflow] Add transfer functions for data members and this pointers

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:57 + if (const auto *MethodDecl = dyn_cast()) { +if (!MethodDecl->isStatic()) { +

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

aaron.ballman added a comment. In D116814#3234768 , @estan wrote: > Thanks @aaron.ballman. I don't have commit/push rights, so someone please > commit for me when you got the time. Happy to! What name and email address would you like me to use for

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) Naghasan wrote: > tra wrote: > > t4c1 wrote: > > > tra

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399020. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116948/new/ https://reviews.llvm.org/D116948

[libunwind] 0a8d15a - [libc++][libc++abi][libunwind] Dedup install path var definitions

Author: John Ericson Date: 2022-01-11T18:24:50Z New Revision: 0a8d15ad55e344419400f037393f2208214e33e0 URL: https://github.com/llvm/llvm-project/commit/0a8d15ad55e344419400f037393f2208214e33e0 DIFF: https://github.com/llvm/llvm-project/commit/0a8d15ad55e344419400f037393f2208214e33e0.diff LOG:

[PATCH] D116967: [HIP] Fix device malloc/free

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:80 +#if HIP_VERSION_MAJOR > 4 || (HIP_VERSION_MAJOR == 4 && HIP_VERSION_MINOR >= 5) +extern "C" __device__ unsigned long long __ockl_dm_alloc(unsigned long long __size);

[PATCH] D117037: [clang][CodeComplete] Perform approximate member search in bases

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3456 +TEST(CompletionTest, UndeducedType) { + clangd::CodeCompleteOptions Opts;

[PATCH] D117037: [clang][CodeComplete] Perform approximate member search in bases

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D117036: [clangd] Retire --inlay-hints flag

kadircet added a comment. nit: I'd rename the patch to `remove` rather than `retire`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117036/new/ https://reviews.llvm.org/D117036 ___ cfe-commits mailing

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Thanks @aaron.ballman. I don't have commit/push rights, so someone please commit for me when you got the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814

[PATCH] D117036: [clangd] Retire --inlay-hints flag

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

  1   2   >