[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19610 getLLVMStyleWithColumns(35)); - verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", - getLLVMStyleWithColumns(31)); + verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"",

[clang] 3cf86c3 - Revert unrelated change from: [clang-format] Fix break being added to macro define with ColumnLimit: 0

Author: Marek Kurdej Date: 2022-01-14T08:43:59+01:00 New Revision: 3cf86c36112fd1b059c8aead3d04656c542195ce URL: https://github.com/llvm/llvm-project/commit/3cf86c36112fd1b059c8aead3d04656c542195ce DIFF: https://github.com/llvm/llvm-project/commit/3cf86c36112fd1b059c8aead3d04656c542195ce.diff

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810 + + verifyFormat("#define A LOOONG() LOOONG()\n", + ZeroColumn); futuarmo wrote: > owenpan wrote: > > Please remove the newline

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG47a9eb2117aa: [clang-format] Fix break being added to macro define with ColumnLimit: 0 (authored by futuarmo, committed by curdeius). Changed prior to commit:

[clang] 47a9eb2 - [clang-format] Fix break being added to macro define with ColumnLimit: 0

Author: Armen Khachkinaev Date: 2022-01-14T08:42:22+01:00 New Revision: 47a9eb2117aa7c61d8d2a9bf81a91e76a059a035 URL: https://github.com/llvm/llvm-project/commit/47a9eb2117aa7c61d8d2a9bf81a91e76a059a035 DIFF:

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810 + + verifyFormat("#define A LOOONG() LOOONG()\n", + ZeroColumn); owenpan wrote: > Please remove the newline and re-run

[clang] 4f4340e - [NFC] [Coroutines] Refactor implementation in checkFinalSuspendNoThrow

Author: Chuanqi Xu Date: 2022-01-14T15:37:01+08:00 New Revision: 4f4340ee2af36909db77aeedb1d22c2ba52d2dfa URL: https://github.com/llvm/llvm-project/commit/4f4340ee2af36909db77aeedb1d22c2ba52d2dfa DIFF: https://github.com/llvm/llvm-project/commit/4f4340ee2af36909db77aeedb1d22c2ba52d2dfa.diff

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

OikawaKirie added a comment. Could you please commit it on my behalf (Ella Ma )? Thanks a lot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116329/new/ https://reviews.llvm.org/D116329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. BTW, please rebase on main. There is one conflict about function `getOrCreateSrcLocStr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114413/new/ https://reviews.llvm.org/D114413

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. Herald added a subscriber: awarzynski. @Meinersbur Here is the c++ code test. Without the chunk size specified, the running result using OMPIRBuilder is correct. #include int main() { int i, N = 10; float x = 0.0; #pragma omp for schedule(static, 2)

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LG! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116329/new/ https://reviews.llvm.org/D116329 ___ cfe-commits mailing list

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

ArcsinX added a comment. In D116966#3242170 , @aaronpuchert wrote: > This is only observable on Windows, right? Thanks for your reply. Yes, PLUGIN_TOOL argument is used on Windows only, so this problems can't be observed on non-Windows systems and

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399883. Ericson2314 added a comment. Rebase after landing the polly change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D115456: [MS] Implement on-demand TLS initialization for Microsoft CXX ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG072e2a7c67b7: [MS] Implement on-demand TLS initialization for Microsoft CXX ABI (authored by momo5502, committed by majnemer). Repository: rG

[clang] 072e2a7 - [MS] Implement on-demand TLS initialization for Microsoft CXX ABI

Author: Maurice Heumann Date: 2022-01-13T21:23:23-08:00 New Revision: 072e2a7c67b74b8bde35f78ac0b0b13a269380f8 URL: https://github.com/llvm/llvm-project/commit/072e2a7c67b74b8bde35f78ac0b0b13a269380f8 DIFF:

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM with few nits Comment at: clang/lib/CodeGen/BackendUtil.cpp:362 + MemorySanitizerOptions{TrackOrigins, Recover, CompileKernel, +

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

junaire added a comment. > @junaire did you already get commit access or should I commit this change on > your behalf? Yeah, I already have commit access, just waiting for your approval ;D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116736/new/

[PATCH] D117271: [AArch64] clang support for Armv8.8/9.3 MOPS

tyb0807 created this revision. Herald added subscribers: hiraditya, kristof.beyls. tyb0807 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces clang command line support for the new Armv8.8-A and Armv9.3-A

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. It caused by bug in AutoUpgrade.cpp, fixed on D117270 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 399869. owenpan added a comment. - Fixed a bug that missed braces in nested blocks. - Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. +1 Let's get this in :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117093: [C++20] [Modules] Exit early if export decl is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8916cfdd94: [C++20] [Modules] Exit early if export decl is not valid (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117093/new/

[clang] 4f8916c - [C++20] [Modules] Exit early if export decl is not valid

Author: Chuanqi Xu Date: 2022-01-14T10:21:42+08:00 New Revision: 4f8916cfdd941db2a4c4cdad6e5bc549532277a2 URL: https://github.com/llvm/llvm-project/commit/4f8916cfdd941db2a4c4cdad6e5bc549532277a2 DIFF: https://github.com/llvm/llvm-project/commit/4f8916cfdd941db2a4c4cdad6e5bc549532277a2.diff

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

rnk added a comment. Thanks! Does this have any impact on binary size, as a proxy for more thorough performance testing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. OK, LGTM. Thanks! @fakepaper56 @khchen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

fdwr added a comment. > I think no one just had thought about it. :) @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm squeaking on behalf of a few stackoverflowers  (#52158077 ,

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

OikawaKirie updated this revision to Diff 399841. OikawaKirie added a comment. Updated as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116329/new/ https://reviews.llvm.org/D116329 Files: clang/test/Tooling/clang-check-analyze-save-temps.cpp

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 399840. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files: clang/lib/CodeGen/Address.h Index: clang/lib/CodeGen/Address.h

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

cjdb added a comment. > That said, I think this particular check is more mature and closer to landing > than the other one. Based on the amount of effort in this patch already, > unless there are strong objections, I think we should base the "make this > const if it can be made so" checks on

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This mitigates the extra memory caused by D115725 . Repository: rG LLVM Github Monorepo

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810 + + verifyFormat("#define A LOOONG() LOOONG()\n", + ZeroColumn); Please remove the newline and

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

aaronpuchert added a subscriber: aaron.ballman. aaronpuchert added a comment. This is only observable on Windows, right? Then perhaps @aaron.ballman can comment on this. The change looks legitimate to me, but I don't work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399826. kda added a comment. Herald added a subscriber: ormris. enable eager-checks with -fsanitize-memory-param-retval Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633

[PATCH] D116844: [Driver][Fuchsia] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe289561205e8: [Driver][Fuchsia] -r: imply -nostdlib like GCC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116844/new/

[clang] e289561 - [Driver][Fuchsia] -r: imply -nostdlib like GCC

Author: Fangrui Song Date: 2022-01-13T15:49:19-08:00 New Revision: e289561205e844ab403c1c9e6814b2e44fb8d415 URL: https://github.com/llvm/llvm-project/commit/e289561205e844ab403c1c9e6814b2e44fb8d415 DIFF: https://github.com/llvm/llvm-project/commit/e289561205e844ab403c1c9e6814b2e44fb8d415.diff

[PATCH] D116844: [Driver][Fuchsia] -r: imply -nostdlib like GCC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. Thank you! I was going to send the same change but you beat me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116844/new/

[PATCH] D116174: [clang] support relative roots to vfs overlays

benlangmuir added a comment. Each VFS may have its own working directory, so it could be surprising if we use the OS working directory instead of that. This is complicated by the fact the VFS working directory may not be set yet during parsing the yaml (I haven't checked). I'm not really

[PATCH] D116844: [Driver][Fuchsia] -r: imply -nostdlib like GCC

MaskRay added a comment. This is a similar patch:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116844/new/ https://reviews.llvm.org/D116844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116174: [clang] support relative roots to vfs overlays

dexonsmith added subscribers: vsapsai, benlangmuir. dexonsmith added a comment. In D116174#3206895 , @keith wrote: > This LGTM but I'm interested to hear from folks with more knowledge about the > VFS' desired behavior to comment on if this will have

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rjmccall added a comment. In D97446#3241828 , @JonChesterfield wrote: > I'd much refer we put variables in arrays corresponding to their intended > lifespan instead of the binary format they're destined for. I agree that LLVM features should generally

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2093 + "Only globals with definition can force usage."); + if (getTriple().isOSBinFormatELF()) +LLVMCompilerUsed.emplace_back(GV);

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 399793. MuAlphaOmegaEpsilon added a comment. Update code after review and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files:

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

JonChesterfield added a comment. In D97446#3241735 , @MaskRay wrote: > For your comment it appears an issue in the internalisation pass. It is > orthogonal to this patch. > Do you have a reduced example with reproduce instructions for the issue? I >

[PATCH] D116659: [llvm][clang][vfs] NFC: Simplify directory iteration

dexonsmith added a comment. In D116659#3241727 , @benlangmuir wrote: >> I don't know, I'm a bit skeptical we want to make it so easy to ignore >> errors so easily. I'd rather require clients to explicitly ignore the error. > > That's my gut feeling

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399784. kda added a comment. Herald added subscribers: luke957, s.egerton, simoncook. Drop attribute changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rjmccall added a comment. I can understand how we got here, but it's a bad place to have ended up. Toolchains that do dead-stripping need a way to prevent it for specific objects and functions. Windows and Darwin toolchains have historically done aggressive dead-stripping in both the compiler

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay added a comment. In D97446#3241617 , @JonChesterfield wrote: >> Modulo optimizer bugs, __attribute__((used)) hasn't changed semantics. >> If your downstream project does not handle llvm.compiler.used, maybe handle >> it now :) > > There seems to

[PATCH] D116659: [llvm][clang][vfs] NFC: Simplify directory iteration

benlangmuir added a comment. > I don't know, I'm a bit skeptical we want to make it so easy to ignore errors > so easily. I'd rather require clients to explicitly ignore the error. That's my gut feeling too. I suspect a bunch of this code should be explicitly ignoring `ENOENT`, but not

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

tra added a comment. In D116673#3237873 , @JackAKirk wrote: >>> I can land the patch on your behalf. Are you OK to use the name/email in >>> this patch or do you prefer to use a different email for the LLVM commit? > > Thanks very much. Yes the

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbef3eb83442a: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80… (authored by JackAKirk, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bef3eb8 - [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

Author: Jack Kirk Date: 2022-01-13T13:29:48-08:00 New Revision: bef3eb83442a2f30c761a03793bd56c961f49cdd URL: https://github.com/llvm/llvm-project/commit/bef3eb83442a2f30c761a03793bd56c961f49cdd DIFF: https://github.com/llvm/llvm-project/commit/bef3eb83442a2f30c761a03793bd56c961f49cdd.diff

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG07f9fb8b5141: [clangd] Elide even more checks in SelectionTree. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 07f9fb8 - [clangd] Elide even more checks in SelectionTree.

Author: Sam McCall Date: 2022-01-13T22:27:51+01:00 New Revision: 07f9fb8b51417ec3e6f46508e1b5ef78287b32ad URL: https://github.com/llvm/llvm-project/commit/07f9fb8b51417ec3e6f46508e1b5ef78287b32ad DIFF: https://github.com/llvm/llvm-project/commit/07f9fb8b51417ec3e6f46508e1b5ef78287b32ad.diff

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG004acbb47d61: [clangd] Suppress warning about system_header pragma when editing headers (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 004acbb - [clangd] Suppress warning about system_header pragma when editing headers

Author: Sam McCall Date: 2022-01-13T22:24:05+01:00 New Revision: 004acbb47d61ffcc52da0c85ef6e6747a7cc7c14 URL: https://github.com/llvm/llvm-project/commit/004acbb47d61ffcc52da0c85ef6e6747a7cc7c14 DIFF: https://github.com/llvm/llvm-project/commit/004acbb47d61ffcc52da0c85ef6e6747a7cc7c14.diff

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss marked an inline comment as done. belkiss added a comment. And thanks @aganea, @hans & @rnk! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.org/D116861 ___

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss updated this revision to Diff 399764. belkiss added a comment. Simplify test, remove the inline specific CHECK-NOT since we have the implicit-check-not in FileCheck args checking that no errors have occured in the whole file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG71a082f72674: [clangd] Implement textDocument/typeDefinition (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 71a082f - [clangd] Implement textDocument/typeDefinition

Author: Sam McCall Date: 2022-01-13T22:15:10+01:00 New Revision: 71a082f72674ceba0797748543dcef3620b22822 URL: https://github.com/llvm/llvm-project/commit/71a082f72674ceba0797748543dcef3620b22822 DIFF: https://github.com/llvm/llvm-project/commit/71a082f72674ceba0797748543dcef3620b22822.diff

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1883 + QualType VisitIfStmt(const IfStmt *S) { return type(S->getCond()); } + QualType VisitCaseStmt(const CaseStmt *S) { return

[PATCH] D116659: [llvm][clang][vfs] NFC: Simplify directory iteration

dexonsmith added a subscriber: benlangmuir. dexonsmith added a comment. In D116659#3237061 , @jansvoboda11 wrote: > I agree that introducing new iterator and implementing `iterator_range<...> > FileSystem::dir_range()` is better solution than a macro.

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

JonChesterfield added a comment. > Modulo optimizer bugs, __attribute__((used)) hasn't changed semantics. > If your downstream project does not handle llvm.compiler.used, maybe handle > it now :) There seems to be some confusion here. The 'downstream project' is openmp, which has worked around

[PATCH] D117119: [clangd][clang-tidy] Remove uses of `std::vector`

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117119/new/ https://reviews.llvm.org/D117119

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay added a comment. In D97446#3241416 , @JonChesterfield wrote: > It looks deeply wrong to be marking globals as either llvm.used or > llvm.compiler.used based on the output file format. It should be based on the > (purpose of) the global. > > In

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2587 + // Check for unsupported clauses + if (S.clauses().size() > 0) { +// Currently no clause is supported Comment at:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added a comment. [testing] Could you add a test for `applySimd` into `OpenMPIRBuilderTests.cpp`, so we have a test that is independent of Clang? Comment at: clang/test/OpenMP/irbuilder_simd.cpp:3 +// expected-no-diagnostics +// RUN: %clang_cc1

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added a comment. @curdeius, all tests pass on fresh build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___ cfe-commits mailing list

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

aaron.ballman added a comment. In D116328#3241486 , @LegalizeAdulthood wrote: > In D116328#3241329 , @aaron.ballman > wrote: > >> In D116328#3223344 , >>

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

LegalizeAdulthood added a comment. In D116328#3241329 , @aaron.ballman wrote: > In D116328#3223344 , > @LegalizeAdulthood wrote: > >> My takeaway: >> >> - if `has` isn't expensive, I can either ditch this

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

JonChesterfield added a comment. It looks deeply wrong to be marking global as either llvm.used or llvm.compiler.used based on the output file format. It should be based on the (purpose of) the global. In D97446#3241142 , @rnk wrote: > This change was

[PATCH] D117093: [C++20] [Modules] Exit early if export decl is invalid

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaModule.cpp:530-531 + CurContext->addDecl(D); + PushDeclContext(S, D); + ChuanqiXu wrote: >

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great! Comment at: clang-tools-extra/clangd/Selection.cpp:364 +return *Offset < First; + log("Start {0}", Tok.dumpForTests(SM)); +

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64da6eb06570: [Driver][Gnu] -r: imply -nostdlib like GCC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 64da6eb - [Driver][Gnu] -r: imply -nostdlib like GCC

Author: Fangrui Song Date: 2022-01-13T11:25:23-08:00 New Revision: 64da6eb06570adf38c96075de0116f6d29d5ba81 URL: https://github.com/llvm/llvm-project/commit/64da6eb06570adf38c96075de0116f6d29d5ba81 DIFF: https://github.com/llvm/llvm-project/commit/64da6eb06570adf38c96075de0116f6d29d5ba81.diff

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/TypeCheck/global-new-alignment.cpp:33 +int main() { + // CHECK-NOT: runtime error: constructor call on misaligned address [[PTR:0x[0-9a-f]*]] for type 'Param', which requires 16 byte alignment +

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

aaron.ballman added a comment. In D116328#3223344 , @LegalizeAdulthood wrote: > My takeaway: > > - if `has` isn't expensive, I can either ditch this public matcher or move it > to be a private matcher used in my check I don't think `has()` is

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rnk added a subscriber: rjmccall. rnk added a comment. I think the main thing here is that the diagnostic is incorrect: It claims that the type requires `__STDC_DEFAULT_NEW_ALIGNMENT__` (16) byte alignment, but it doesn't, it only requires 8. That's confusing. The next question is, does LLVM

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane added inline comments. Comment at: clang/test/Preprocessor/init.c:1523 // WEBASSEMBLY-NEXT:#define __BIGGEST_ALIGNMENT__ 16 +// WEBASSEMBLY-NEXT:#define __BITINT_MAXWIDTH__ 8388608 // WEBASSEMBLY-NEXT:#define __BOOL_WIDTH__ 8 aaron.ballman wrote: >

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/init.c:1523 // WEBASSEMBLY-NEXT:#define __BIGGEST_ALIGNMENT__ 16 +// WEBASSEMBLY-NEXT:#define __BITINT_MAXWIDTH__ 8388608 // WEBASSEMBLY-NEXT:#define __BOOL_WIDTH__ 8 erichkeane wrote: >

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane added inline comments. Comment at: clang/test/Preprocessor/init.c:1523 // WEBASSEMBLY-NEXT:#define __BIGGEST_ALIGNMENT__ 16 +// WEBASSEMBLY-NEXT:#define __BITINT_MAXWIDTH__ 8388608 // WEBASSEMBLY-NEXT:#define __BOOL_WIDTH__ 8 Actually why are we

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. CFE changes LGTM, the limits.h/.cpp changes LOOK right, but please give others a chance to take a look. Comment at: clang/lib/Sema/SemaType.cpp:2270 + // The max

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, rsmith. Herald added a subscriber: dschuff. aaron.ballman requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. Part of the `_BitInt` feature in C2x

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay added a comment. In D97446#3241142 , @rnk wrote: > In D97446#3240309 , @JonChesterfield > wrote: > >> If I had a red buildbot to reference I would have reverted - the commit >> message does not make it

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Assuming all other tests pass, I'm ok Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1362 + LangStandard::lang_cxx17); +} + xazax.hun wrote: > I think this changed from 14 to 17 in the last revision. Is this intentional? Not intentional. Thanks

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev updated this revision to Diff 399714. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ https://reviews.llvm.org/D117218 Files:

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1362 + LangStandard::lang_cxx17); +} + I think this changed from 14 to 17 in the last revision. Is this intentional? Repository: rG LLVM Github Monorepo

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rnk added a comment. In D97446#3240309 , @JonChesterfield wrote: > I don't know the context of this patch but changing attribute((used)) to put > things under compiler.used is definitely a breaking change. Please introduce > a new attribute if

[PATCH] D117177: [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional-callbacks, added in https://reviews.llvm.org/D116207

This revision was automatically updated to reflect the committed changes. Closed by commit rG529f098789d3: [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional… (authored by browneee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 529f098 - [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional-callbacks, added in https://reviews.llvm.org/D116207

Author: Andrew Browne Date: 2022-01-13T10:05:45-08:00 New Revision: 529f098789d334de9cd06e913ad9525719fa0774 URL: https://github.com/llvm/llvm-project/commit/529f098789d334de9cd06e913ad9525719fa0774 DIFF: https://github.com/llvm/llvm-project/commit/529f098789d334de9cd06e913ad9525719fa0774.diff

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev updated this revision to Diff 399707. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ https://reviews.llvm.org/D117218 Files:

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:114 +} else if (S->getCastKind() == CK_NoOp) { + auto *SubExprLoc = Env.getStorageLocation(*SubExpr, SkipPast::None); + if (SubExprLoc

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

dmgreen accepted this revision. dmgreen added a comment. LGTM. Thanks for the update. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:147 AARCH64_ARCH_EXT_NAME("sme-i64", AArch64::AEK_SMEI64, "+sme-i64", "-sme-i64") +AARCH64_ARCH_EXT_NAME("pmuv3",

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

efriedma abandoned this revision. efriedma added a comment. Herald added a subscriber: libcxx-commits. A very similar patch was merged in e0d01294bc124211a8ffb55e69162eb34a242680 . Repository: rCXX libc++ CHANGES SINCE

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

carlosgalvezp added a comment. Great catch and thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116750/new/ https://reviews.llvm.org/D116750 ___ cfe-commits mailing list

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

hans added a reviewer: sepavloff. hans added a comment. I'm not familiar enough with the code to review it (though it sounds right to me). Looks like it was written by Serge originally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:114 +} else if (S->getCastKind() == CK_NoOp) { + auto *SubExprLoc =

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

hans added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13 +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// ERR-HOTPATCH: error: unsupported option '/hotpatch' for target +// HOTPATCH: S_COMPILE3 [size =

  1   2   >