[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400449. HazardyKnusperkeks marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 5 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if

[clang] d771cf2 - [PowerPC] Allow -mfloat128 option for VSX targets

Author: Qiu Chaofan Date: 2022-01-17T15:12:33+08:00 New Revision: d771cf277565f579aba24fef522355f4406323c9 URL: https://github.com/llvm/llvm-project/commit/d771cf277565f579aba24fef522355f4406323c9 DIFF: https://github.com/llvm/llvm-project/commit/d771cf277565f579aba24fef522355f4406323c9.diff

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

nridge added a comment. Thanks, this is a pretty nice addition! My only piece of high-level feedback is probing if the array element designators (`[0]=`) are useful enough to be worth the space/noise. The rest is minor implementation comments. Comment at:

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo updated this revision to Diff 400439. glotchimo added a comment. Explicitly declare `FormatToken` type instead of using `auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421 Files:

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. In D109557#3247167 , @HazardyKnusperkeks wrote: > Could you please rebase the patch? I promise I will commit it **very** > shortly afterwards. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 400435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

LegalizeAdulthood added a comment. In D117306#3245915 , @njames93 wrote: > How does this check play with the `modernize-make-shared` check? Wouldn't it be orthogonal? This check looks for existing `make_shared` usages, whereas modernize-make-shared

[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

kito-cheng abandoned this revision. kito-cheng added a comment. Herald added subscribers: alextsao1999, VincentWu, luke957, achieveartificialintelligence. Further development move to https://reviews.llvm.org/D111617 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG427d3b93eeba: [Driver][FreeBSD] -r: imply -nostdlib like GCC (authored by MaskRay). Changed prior to commit:

[clang] 427d3b9 - [Driver][FreeBSD] -r: imply -nostdlib like GCC

Author: Fangrui Song Date: 2022-01-16T19:44:48-08:00 New Revision: 427d3b93eebadb57ef72e1eb167dd41043b87f39 URL: https://github.com/llvm/llvm-project/commit/427d3b93eebadb57ef72e1eb167dd41043b87f39 DIFF: https://github.com/llvm/llvm-project/commit/427d3b93eebadb57ef72e1eb167dd41043b87f39.diff

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 400419. Ericson2314 added a comment. 1. Updating D117419 : [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (NextLine.Type == LT_Invalid || NextLine.First->MustBreakBefore)

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

ChuanqiXu added a comment. In D114908#3223981 , @rnk wrote: > Friendly ping for a modules CTAD bugfix. Not sure if you met the same problem with me. In our downstream, we did a workaround like: if (Context.getLangOpts().CPlusPlusModules &&

[PATCH] D117292: [Driver] Pass the flag -dI to cc1 invocation

qichaogu added a comment. Could someone help commit the patch? I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117292/new/ https://reviews.llvm.org/D117292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

LegalizeAdulthood added a comment. Except for a couple nits, LGTM. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.h:25-26 +public: + InefficientArrayTraversalCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name,

[PATCH] D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:144 + auto *Lattice = + llvm::any_cast(); +

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/SharedPtrArrayMismatchCheck.cpp:21-26 +SharedPtrArrayMismatchCheck::SharedPtrArrayMismatchCheck( +StringRef Name, ClangTidyContext *Context) +: ClangTidyCheck(Name, Context) {} +

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:288 +// Try to merge a control statement block with left brace unwrapped. +if (TheLine->Last->is(tok::l_brace) && TheLine->First->isOneOf(tok::kw_if, tok::kw_while,

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400400. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Updated, now using a pointer (potential null) for PreviousLine. CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Could you please rebase the patch? I promise I will commit it **very** shortly afterwards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D18914: [clang-tidy] new readability-redundant-inline

Izaron added a comment. In D18914#2399705 , @chfast wrote: > This check can be useful in other case like this: > > inline constexpr const int x = 1; > > where `inline` and `const` are redundant. In your case `inline` is not actually redundant (at least

[PATCH] D117435: [clang] Warning for inline constexpr functions

Izaron added a comment. In D117435#3247137 , @rjmccall wrote: > I don't remember if this is written up anywhere, but clang has a longstanding > policy that style enforcement belongs in a linter rather than the compiler. > One programmer's "redundant"

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. Thanks for fixing this. It hit my quite some times, but never had the time to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3246838 , @curdeius wrote: > Thanks for having a try on this. > However, I don't like this approach too much. You add many changes and a > single test. That's not sufficient. > Also, handling C++ keywords

[PATCH] D117435: [clang] Warning for inline constexpr functions

Izaron added inline comments. Comment at: clang/test/Headers/x86-intrinsics-headers-clean.cpp:4-5 // RUN: %clang_cc1 -ffreestanding -triple x86_64-unknown-unknown -Wsystem-headers \ -// RUN: -Wcast-qual -fsyntax-only -flax-vector-conversions=none -x c++ -verify %s +// RUN:

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood added a comment. I added some comments on the other review. Is constructing an `IncludeInserter` particularly expensive? I'm just curious. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117129/new/ https://reviews.llvm.org/D117129

[PATCH] D117435: [clang] Warning for inline constexpr functions

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I don't remember if this is written up anywhere, but clang has a longstanding policy that style enforcement belongs in a linter rather than the compiler. One programmer's

[PATCH] D117435: [clang] Warning for inline constexpr functions

Izaron updated this revision to Diff 400399. Izaron added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117435/new/ https://reviews.llvm.org/D117435

[PATCH] D112408: [RISCV][MC] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:353 + +multiclass VIndexLoadStore EEWList> { + foreach n = EEWList in { Why is this class only used for [64] Comment at:

[PATCH] D112408: [RISCV][MC] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:91 void updateMinVLen(); + void updateMaxEew(); }; There's no definition for this Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:821 -let

[PATCH] D117435: [clang] Warning for inline constexpr functions

Izaron added a comment. I will provide more context in this comment. **Why this patch?** Clang currently has a warning for duplicating specifiers (`inline inline`, `extern extern`, `consteval consteval`, etc.), but has no warnings for redundant weaker specifiers. I suggest to add such a group

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo added a comment. Excellent, thank you! I'll get right on these edits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421 ___ cfe-commits mailing list

[PATCH] D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117388/new/ https://reviews.llvm.org/D117388

[PATCH] D117435: [clang] Warning for inline constexpr functions

Izaron created this revision. Izaron added reviewers: rjmccall, rsmith. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "inline constexpr" and "inline consteval" function declarations are redundant and shall be written rather as

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

curdeius added a comment. Thanks for working on this! I'll have a closer look tomorrow or on Tuesday. Comment at: clang/lib/Format/WhitespaceManager.cpp:735 +// Do not align operator= overloads. +if (C.Tok->Previous && C.Tok->Previous->is(tok::kw_operator)) { +

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37e6496c800b: [clang][dataflow] Add transfer functions for bind temporary and static cast (authored by sgatev). Repository: rG LLVM Github

[clang] 37e6496 - [clang][dataflow] Add transfer functions for bind temporary and static cast

Author: Stanislav Gatev Date: 2022-01-16T17:41:02Z New Revision: 37e6496c800b33cbf6f7967d90eab53327147478 URL: https://github.com/llvm/llvm-project/commit/37e6496c800b33cbf6f7967d90eab53327147478 DIFF: https://github.com/llvm/llvm-project/commit/37e6496c800b33cbf6f7967d90eab53327147478.diff

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

sgatev updated this revision to Diff 400392. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117339/new/ https://reviews.llvm.org/D117339 Files:

[PATCH] D117421: Fix 31568 (i.e. incorrect alignment of operator= overloads).

glotchimo created this revision. glotchimo added a comment. glotchimo updated this revision to Diff 400390. glotchimo added reviewers: MyDeveloperDay, djasper. glotchimo added a project: clang-format. glotchimo added a subscriber: cfe-commits. glotchimo published this revision for review. Herald

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. In D117416#3246838 , @curdeius wrote: > Thanks for having a try on this. > However, I don't like this approach too much. You add many changes and a > single test. That's not sufficient. > Also, handling C++ keywords in all

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Yes, test for alignment should be possible, something like _Bool alig_test(void) { // CHECK: ret i1 true yvoid *p = _mm_malloc(2014, 16); _Bool ret = ((__SIZE_TYPE__)p % 16) == 0; _mm_free(p); return ret; } For alloc size not sure how..

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https://reviews.llvm.org/D117431 ___

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn created this revision. fhahn added reviewers: reames, nikic, lebedev.ri, nhaehnle. Herald added a subscriber: dexonsmith. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Similar to the migration of or-folding to FoldOr,

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

fhahn added a comment. Not really familiar with testing for clang headers. Is it possible to test the new attributes have the desired effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added a comment. - Update broken test case - Rebase on latest main (8eb74626f ) - Build and run `ninja check-clang` I don't have commit access, so I would appreciate help landing. Let me know if there's anything else I

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

davrec added a reviewer: rsmith. davrec added a subscriber: rsmith. davrec added a comment. In D117390#3246799 , @kimgr wrote: > @daverec I don't have commit access, could you help me land this? > > I've rebased on `main` without conflicts, and `ninja

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr updated this revision to Diff 400381. kimgr added a comment. Fix spurious semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391 Files: clang/lib/AST/Expr.cpp

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius requested changes to this revision. curdeius added a comment. Thanks for having a try on this. However, I don't like this approach too much. You add many changes and a single test. That's not sufficient. Also, handling C++ keywords in all cases (e.g. `delete` as a function name) *may*

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added inline comments. Comment at: clang/unittests/Tooling/CastExprTest.cpp:111 + "const char *f() {\n" + " constexpr X x;\n"; + " return x;\n" Oops, spurious semicolon here. Will post a new version once

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:417 + // '-x assembler-with-cpp' if it has not a '.S' suffix. + for (unsigned I = 0; I < DriverArgs.size(); I++) { +StringRef Arg(DriverArgs.getArgString(I)); In this for

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:419 +StringRef Arg(DriverArgs.getArgString(I)); +if (Arg.equals("assembler-with-cpp")) + return; We need not care about '-x c++' or '-x c', which are excluded by above

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 400375. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h

[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

sammccall added inline comments. Comment at: clang/docs/JSONCompilationDatabase.rst:95 + + Either **arguments** or **command** is required. **arguments** is preferred, + as shell (un)escaping is a possible source of errors. Hopefully I'm not too far out on a

[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

sammccall created this revision. sammccall added a reviewer: hokein. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - prefer `arguments` over `command`, and add example - clarify that there's no shell-unescaping of `arguments`

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

kimgr added a comment. @daverec I don't have commit access, could you help me land this? I've rebased on `main` without conflicts, and `ninja check-clang` ran successfully after rebase. Let me know if there's anything else I can do as far as prep work. Repository: rG LLVM Github Monorepo

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

saschanaz added a comment. That same check decorate_proc_maps.cpp failed on D117405 too 樂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117407/new/ https://reviews.llvm.org/D117407

[clang] 4608b1d - Resolve lit failures in clang-aarch64*

Author: hyeongyu kim Date: 2022-01-16T23:06:05+09:00 New Revision: 4608b1d726daa808abf08f0f0860636a7b20771f URL: https://github.com/llvm/llvm-project/commit/4608b1d726daa808abf08f0f0860636a7b20771f DIFF: https://github.com/llvm/llvm-project/commit/4608b1d726daa808abf08f0f0860636a7b20771f.diff

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. Let me know if I should rebase this onto the latest main branch, at the moment the Windows build is passing but the Debian build is not, failing at `compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp` for no immediately

[clang] edbb8a8 - [clang-format] Add return code to git-clang-format

Author: owenca Date: 2022-01-16T02:41:10-08:00 New Revision: edbb8a843c130e60d71cb73e56a33d5ba2cc0ec9 URL: https://github.com/llvm/llvm-project/commit/edbb8a843c130e60d71cb73e56a33d5ba2cc0ec9 DIFF: https://github.com/llvm/llvm-project/commit/edbb8a843c130e60d71cb73e56a33d5ba2cc0ec9.diff LOG:

[PATCH] D117414: [clang-format] Add return code to git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbb8a843c13: [clang-format] Add return code to git-clang-format (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. This is GCC's handling on AVR https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/config/avr/avr.c;h=62973927fdc30d502e5d225f83cdde958bf2dad0;hb=refs/heads/master#l10424 around line 10433 / function `static void avr_file_start (void)`, gcc rises an error `architecture

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay, MaskRay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Devices belongs to the avr1 family do not has

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added a comment. We can land non-macro related code for zve first and continue on proceeding patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added a comment. TL;DR: -- - Binary size of clang increase ~200k, which is +0.07% for debug build and +0.13% for release build. - Single file compilation speed up ~33x speed up for debug build and ~8.5x speed up for release build - Regression time reduce ~10% (`ninja

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 400358. kito-cheng added a comment. Herald added subscribers: alextsao1999, hiraditya. Changes: - Using different approach to implement to prevent build time explosion. - build time for `SemaRVVLookup.cpp` is ~6 sec in my machine. Repository: rG

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: .arclint:5 "type": "script-and-regex", - "script-and-regex.script": "bash utils/arcanist/clang-format.sh", +

[PATCH] D117414: [clang-format] Add return code to git-clang-format

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. So simple but so nice, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117414/new/ https://reviews.llvm.org/D117414 ___

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius added a comment. Does it fix https://github.com/llvm/llvm-project/issues/46915? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 ___ cfe-commits

[PATCH] D117414: [clang-format] Add return code to git-clang-format

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117414/new/ https://reviews.llvm.org/D117414

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:203 + return CopyRef; +return Fail; + } If C is default constructible, would it be nice to skip here instead of failing?

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:84 + +if (!GslHeader.empty() && (FixHint == "gsl::at()")) { Diag << FixItHint::CreateInsertion(BaseRange.getBegin(), "gsl::at(")