[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. Hope that someone familiar with CMake can take a look. > As currently implemented llvm-driver contains dsymutil, llvm-ar, > llvm-cxxfilt, llvm-objcopy, and clang (if clang is included in the build). I think either (bundled clang+binary utilities) or (bundled lld+binary

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404343. Quuxplusone added a comment. Move the regression test to clang/test/SemaTemplate/, alongside the one for D118552 . Also, make it test the error message wording. CHANGES SINCE LAST ACTION

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

rjmccall added a comment. It's a type that the debugger integration uses when it doesn't know the type of a symbol. If it's a data symbol, you make a `VarDecl` with `UnknownAny` type; if it's a function symbol, you make a `FunctionDecl` with `UnknownAny`. In either case, if the user fails to

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404341. Quuxplusone added a comment. It seems like we need `tryToRecoverWithCall` to always identify a diagnostic explaining the problem, so just short-circuit-returning `ExprError()` with no diagnostic is not acceptable. Let's try this version instead.

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 abandoned this revision. benshi001 added a comment. Re-implement in https://reviews.llvm.org/D118095 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 ___ cfe-commits mailing list

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. The other implementation (https://reviews.llvm.org/D117423) is abundoned, since we should not put AVR specified checks in the common code in Clang.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404340. benshi001 retitled this revision from "[AVR][clang] Reject non assembly source files for the avr1 family" to "[clang][AVR] Reject non assembly source files for the avr1 family". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added a subscriber: rjmccall. Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3375 +assert(T->isSpecificPlaceholderType(BuiltinType::UnknownAny) && "Unresolved placeholder type"); + } Btw, I strongly suspect that

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404336. void added a comment. Make this only for x86. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone created this revision. Quuxplusone added reviewers: ChuanqiXu, saar.raz, rsmith. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. PR52905 was originally papered over in a different way, but I believe this is

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404326. void added a comment. Don't zero out all sub and super registers that are callee-saved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files:

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

This revision was automatically updated to reflect the committed changes. LegalizeAdulthood marked an inline comment as done. Closed by commit rG994802068267: [clang-tidy] Organize the release notes a little better (authored by LegalizeAdulthood). Changed prior to commit:

[clang-tools-extra] 9948020 - [clang-tidy] Organize the release notes a little better

Author: Richard Date: 2022-01-29T20:32:25-07:00 New Revision: 9948020682679653dad81c6350d9900c22dc2951 URL: https://github.com/llvm/llvm-project/commit/9948020682679653dad81c6350d9900c22dc2951 DIFF: https://github.com/llvm/llvm-project/commit/9948020682679653dad81c6350d9900c22dc2951.diff LOG:

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 404323. psigillito marked 2 inline comments as done. psigillito added a comment. - unnecessary whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files:

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:221-227 Removed checks ^^ Improvements to include-fixer - The improvements are...

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 404322. psigillito added a comment. - wrap vector in function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: clang/lib/Format/FormatToken.h

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG653836251ac4: [clang][AVR] Set -fno-use-cxa-atexit to default (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6538362 - [clang][AVR] Set '-fno-use-cxa-atexit' to default

Author: Ben Shi Date: 2022-01-30T02:26:19Z New Revision: 653836251ac41775e3d376e9ee28efd2ea0232b2 URL: https://github.com/llvm/llvm-project/commit/653836251ac41775e3d376e9ee28efd2ea0232b2 DIFF: https://github.com/llvm/llvm-project/commit/653836251ac41775e3d376e9ee28efd2ea0232b2.diff LOG:

[PATCH] D118535: [clang] Move XCore specific options from Clang.cpp to XCore.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac3894cf1e09: [Clang] Move XCore specific options from Clang.cpp to XCore.cpp (authored by benshi001). Repository: rG LLVM Github Monorepo

[clang] ac3894c - [Clang] Move XCore specific options from Clang.cpp to XCore.cpp

Author: Ben Shi Date: 2022-01-30T02:24:35Z New Revision: ac3894cf1e093baff747d63bd37844b9176bcbe0 URL: https://github.com/llvm/llvm-project/commit/ac3894cf1e093baff747d63bd37844b9176bcbe0 DIFF: https://github.com/llvm/llvm-project/commit/ac3894cf1e093baff747d63bd37844b9176bcbe0.diff LOG:

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. In D118095#3282039 , @MaskRay wrote: > I do not know whether the complexity is justified. Rejecting some -mmcu= for > C source files looks quite dubious. Does it really help users? > > Bear in mind that all these complexity

[PATCH] D111100: enable plugins for clang-tidy

phosek added a comment. We started seeing CMake error after this change landed: CMake Error at cmake/modules/AddLLVM.cmake:683 (add_dependencies): The dependency target "clang-tidy-headers" of target "CTTestTidyModule" does not exist. Call Stack (most recent call first):

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

salman-javed-nz added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:221-227 Removed checks ^^ Improvements to include-fixer - The improvements are... Small nit, not about this patch, but the

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 404307. ychen added a comment. - address Alexandre's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNotes.rst

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked 2 inline comments as done. ychen added a comment. Thanks a lot for reviewing the patch! In D118428#3281721 , @aganea wrote: > Cool! :) Seems good generally. > Sounds like an expensive flag for the runtime perf :-D But I guess it makes >

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 3 PM PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. @peixin Thanks for testing edge cases. You hit multiple issues: 1. Chunksize was i32, combining it with a i64 induction variable caused an error. Fixed the latest update of this patch. 2. OpenMPIRBuilder currently doesn't work really with exceptions. See D115216

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

MaskRay added a comment. I do not know whether the complexity is justified. Rejecting some -mmcu= for C source files looks quite dubious. Does it really help users? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. +1 for assert Comment at: clang/lib/Format/FormatToken.h:126 +/// Sorted operators that can follow a C variable. +static const std::vector

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list

[PATCH] D118535: [clang] Move XCore specific options from Clang.cpp to XCore.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118535/new/ https://reviews.llvm.org/D118535

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

Meinersbur created this revision. Meinersbur added reviewers: kiranchandramohan, ftynse, peixin, jdoerfert, clementval, Leporacanthicus, kiranktp, arnamoy10, bryanpkc, Chuanfeng, AMDChirag, anchu-rajendran, SouraVX, fghanim, jdenny, MatsPetersson, ABataev. Herald added subscribers: zzheng,

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked an inline comment as done. JonasToth added a comment. ping @aaron.ballman just in case the patch is now down on the list, I am sorry for my high latency :( Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h:29 + :

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 404297. JonasToth added a comment. - use boolean for options - fix snafoo on `arc` usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 404296. JonasToth added a comment. - use boolean for option parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D111100: enable plugins for clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG36892727e4f1: enable plugins for clang-tidy (authored by vtjnash). Changed prior to commit: https://reviews.llvm.org/D00?vs=401997=404294#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 3689272 - enable plugins for clang-tidy

Author: Jameson Nash Date: 2022-01-29T14:21:19-05:00 New Revision: 36892727e4f19a60778e371d78f8fb09d8122c85 URL: https://github.com/llvm/llvm-project/commit/36892727e4f19a60778e371d78f8fb09d8122c85 DIFF: https://github.com/llvm/llvm-project/commit/36892727e4f19a60778e371d78f8fb09d8122c85.diff

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius accepted this revision. curdeius added a comment. LGTM but please add an assert(is_sorted). Comment at: clang/lib/Format/FormatToken.h:126 +/// Sorted operators that can follow a C variable. +static const std::vector COperatorsFollowingVar = { +tok::l_square,

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 404288. psigillito marked an inline comment as done. psigillito added a comment. - review changes, lower_bound to binary_search Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito marked 7 inline comments as done. psigillito added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2716-2718 + auto COperatorMatch = + std::lower_bound(COperatorsFollowingVar.begin(), + COperatorsFollowingVar.end(),

[clang] 56cc697 - [clang][dataflow] Merge distinct pointer values in Environment::join

Author: Stanislav Gatev Date: 2022-01-29T16:33:15Z New Revision: 56cc697323445337134cc2bbe8ce8b1f60131574 URL: https://github.com/llvm/llvm-project/commit/56cc697323445337134cc2bbe8ce8b1f60131574 DIFF: https://github.com/llvm/llvm-project/commit/56cc697323445337134cc2bbe8ce8b1f60131574.diff

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56cc69732344: [clang][dataflow] Merge distinct pointer values in Environment::join (authored by sgatev). Repository: rG LLVM Github Monorepo

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } frasercrmck wrote: > khchen wrote: > > frasercrmck wrote: > > > khchen

[PATCH] D118518: [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG424400da2db8: [clang][NFC] Change some -getType()-isPlaceholderType() to just… (authored by arthur.j.odwyer). Changed prior to commit:

[clang] 424400d - [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()

Author: Arthur O'Dwyer Date: 2022-01-29T10:20:22-05:00 New Revision: 424400da2db86558917e6da19a821e160acc48d1 URL: https://github.com/llvm/llvm-project/commit/424400da2db86558917e6da19a821e160acc48d1 DIFF:

Re: [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

I will take care of it today. The bot does have vs2019 installed and it should be picking up latest VS (and it was when I updated it), so there is an easy fix (remove 2017) and then I can investigate why it stopped picking up latest. Get Outlook for iOS

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. In D114483#3281731 , @aaron.ballman wrote: > In D114483#3281718 , @aaron.ballman > wrote: > >> In D114483#3281714 , @zahiraam >> wrote: >>

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. In D114483#3281718 , @aaron.ballman wrote: > In D114483#3281714 , @zahiraam > wrote: > >> In D114483#3280905 , @MaskRay >> wrote: >> >>>

[clang] a10ff37 - Speculatively fix the sphinx build for Clang's attribute reference

Author: Aaron Ballman Date: 2022-01-29T09:39:26-05:00 New Revision: a10ff373ddfa82a67c580a87f6258aa6ab8dd595 URL: https://github.com/llvm/llvm-project/commit/a10ff373ddfa82a67c580a87f6258aa6ab8dd595 DIFF: https://github.com/llvm/llvm-project/commit/a10ff373ddfa82a67c580a87f6258aa6ab8dd595.diff

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. fixes https://github.com/llvm/llvm-project/issues/50631 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118428: [clang-cl] Support the /JMC flag

aganea added a reviewer: mstorsjo. aganea added a subscriber: belkiss. aganea added a comment. Cool! :) Seems good generally. Sounds like an expensive flag for the runtime perf :-D But I guess it makes the debugging experience a bit nicer. Comment at:

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. In D114483#3281714 , @zahiraam wrote: > In D114483#3280905 , @MaskRay wrote: > >> Closed by 8ba9c794feb30cd969b9776c39873def10c51bff >>

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. In D114483#3280905 , @MaskRay wrote: > Closed by 8ba9c794feb30cd969b9776c39873def10c51bff > . > > If the commit message contained `Differential Revision:`,

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers marked an inline comment as done. vabridgers added a comment. Thanks for the comments, I'll address. Best Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050

[PATCH] D118532: Fix -Wreserved-identifier in presence of system macro

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor nit Comment at: clang/lib/Sema/SemaDecl.cpp:5720 if (Status != ReservedIdentifierStatus::NotReserved && -

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118519/new/ https://reviews.llvm.org/D118519

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman added a comment. In D117238#3281010 , @jkorous wrote: > I verified locally that reverting this patch fixes the build. > Reverted in fad7e491a0770ac4336934030ac67d77e7af5520 >

[clang] a6cabd9 - Revert fad7e491a0770ac4336934030ac67d77e7af5520 with fixes applied

Author: Aaron Ballman Date: 2022-01-29T08:12:16-05:00 New Revision: a6cabd98021fe357d14601eca2031bf775de URL: https://github.com/llvm/llvm-project/commit/a6cabd98021fe357d14601eca2031bf775de DIFF: https://github.com/llvm/llvm-project/commit/a6cabd98021fe357d14601eca2031bf775de.diff

[PATCH] D118535: [clang] Move XCore specific options from Clang.cpp to XCore.cpp

benshi001 created this revision. benshi001 added reviewers: MaskRay, rsmith. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118535 Files:

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added a comment. In D118385#3281620 , @nikic wrote: > It might make sense to split this into individual changes, so it's clearer > what impact each of them has. > > I tested just moving the `AddXYZ` methods into the header, which had a large >

[PATCH] D118527: [X86] Promote default mtune from generic to sandybridge

pengfei abandoned this revision. pengfei added a comment. New approch D118534 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118527/new/ https://reviews.llvm.org/D118527

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

nikic added a comment. It might make sense to split this into individual changes, so it's clearer what impact each of them has. I tested just moving the `AddXYZ` methods into the header, which had a large positive impact:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:114 +if (auto *FirstVal = dyn_cast(Val)) { + auto *SecondVal = cast(It->second); sgatev wrote: > xazax.hun wrote: > > xazax.hun wrote: > > >

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

sgatev marked 2 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:114 +if (auto *FirstVal = dyn_cast(Val)) { + auto *SecondVal = cast(It->second); xazax.hun wrote: > xazax.hun

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit:

[clang] 058c5df - Raise the minimum Visual Studio version to VS2019

Author: Simon Pilgrim Date: 2022-01-29T10:56:41Z New Revision: 058c5dfc78cd1a1a6075bba9799e63f3ec871c0d URL: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d DIFF: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d.diff

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:114 +if (auto *FirstVal = dyn_cast(Val)) { + auto *SecondVal = cast(It->second); xazax.hun wrote: > xazax.hun wrote: > > Shouldn't we ensure that

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:114 +if (auto *FirstVal = dyn_cast(Val)) { + auto *SecondVal = cast(It->second); xazax.hun wrote: > Shouldn't we ensure that `operator==` return true

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:114 +if (auto *FirstVal = dyn_cast(Val)) { + auto *SecondVal = cast(It->second); Shouldn't we ensure that `operator==` return true when we have two

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. AVR is baremetal environment, it does not support __cxa_atexit(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. AVR is baremetal environment, it does not support __cxa_atexit() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. This patch fixes https://github.com/llvm/llvm-project/issues/43443 https://github.com/llvm/llvm-project/issues/50631 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 updated this revision to Diff 404244. benshi001 retitled this revision from "[clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace" to "[clang][AVR] Set '-fno-use-cxa-atexit' to default". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D118532: Fix -Wreserved-identifier in presence of system macro

serge-sans-paille created this revision. serge-sans-paille added reviewers: lebedev.ri, aaron.ballman, rsmith. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not warn on reserved identifiers resulting from expansion