[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

zixuan-wu added a comment. It's difficult to run llvm-test-suite in ilp32e abi in Linux. Because there are no workable environment such as runtime and kernel for ilp32e in GNU series tools. And we can not run llvm-test-suite in baremental environment(NOT linux but elf triple). So I have a

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek created this revision. phosek added reviewers: beanz, smeenai, ldionne, compnerd. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester,

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

zixuan-wu commandeered this revision. zixuan-wu added a reviewer: pcwang-thead. zixuan-wu added a comment. In D70401#3250049 , @khchen wrote: > 2. Have you try to run llvm-test-suite with rv32e config on qemu? It's difficult to run llvm-test-suite in

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius added a comment. +1 to Arthur's comments. Does it fix any of the recently created issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 ___

[PATCH] D119711: Add asan support for MSVC debug runtimes

lo1ol added a comment. Ok, I get current situation. Sorry for my late answer. I made some investigation yesterday and compared msvc and clang versions of asan. In my tests msvc version seems more stable. All my tests is written via catch2 framework (v2.13.8). So, first example is: #define

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

dblaikie added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 409157. ChuanqiXu added a comment. Address comment to check if the duplicated default template arguments are the same and add tests to address the negative cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/

[PATCH] D119686: [RISCV] Add the passthru operand for nomask vadc/vsbc/vmerge/vfmerge IR intrinsics.

khchen updated this revision to Diff 409156. khchen added a comment. rebase and add more one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119686/new/ https://reviews.llvm.org/D119686 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D118253: [RISCV] Add the passthru operand for some RVV nomask unary and nullary intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8973dd389e7: [RISCV] Add the passthru operand for some RVV nomask unary and nullary… (authored by khchen). Changed prior to commit:

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

achieveartificialintelligence added a comment. In D119846#3325334 , @skan wrote: > @achieveartificialintelligence Please explain why a patch is reverted in the > commit message next time. OK, thanks for your guidance! Repository: rG LLVM Github

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

skan added a comment. @achieveartificialintelligence Please explain why a patch is reverted in the commit message next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119846/new/ https://reviews.llvm.org/D119846

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30ca5e2e23f: [C++20] [Coroutines] Implement return value optimization for get_return_object (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d30ca5e - [C++20] [Coroutines] Implement return value optimization for get_return_object

Author: Chuanqi Xu Date: 2022-02-16T13:38:00+08:00 New Revision: d30ca5e2e23fe50dcd8d5d602bf7cfc61b4c1561 URL: https://github.com/llvm/llvm-project/commit/d30ca5e2e23fe50dcd8d5d602bf7cfc61b4c1561 DIFF: https://github.com/llvm/llvm-project/commit/d30ca5e2e23fe50dcd8d5d602bf7cfc61b4c1561.diff

[clang] 9cc49c1 - Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`"

Author: Shao-Ce SUN Date: 2022-02-16T11:57:49+08:00 New Revision: 9cc49c1951dcc4db594bf1f90755e16f89efd1ca URL: https://github.com/llvm/llvm-project/commit/9cc49c1951dcc4db594bf1f90755e16f89efd1ca DIFF: https://github.com/llvm/llvm-project/commit/9cc49c1951dcc4db594bf1f90755e16f89efd1ca.diff

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe25c06cc5bd: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter` (authored by achieveartificialintelligence). Repository: rG

[clang] 5d110ed - Revert "[NFC] Update new warning to test"

Author: Nico Weber Date: 2022-02-15T22:23:26-05:00 New Revision: 5d110ed4cd475b9b70bc9faecfe4f0767740c5a3 URL: https://github.com/llvm/llvm-project/commit/5d110ed4cd475b9b70bc9faecfe4f0767740c5a3 DIFF: https://github.com/llvm/llvm-project/commit/5d110ed4cd475b9b70bc9faecfe4f0767740c5a3.diff

[PATCH] D118586: [C++20][Modules] Initial handling for module partitions.

ChuanqiXu added a comment. Oh, I did similar thing in our downstream version. I planned to show it in next few weeks. Now it looks I could only give up on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. `MCRegisterInfo` is not used b/c it can be got from `MCContext`. It makes sense to remove it in the parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 125abb6 - Revert "Add support for floating-point option `ffp-eval-method` and for"

Author: Nico Weber Date: 2022-02-15T22:02:25-05:00 New Revision: 125abb61f7ae52f9dbf4b82d5f90b70ef107fb62 URL: https://github.com/llvm/llvm-project/commit/125abb61f7ae52f9dbf4b82d5f90b70ef107fb62 DIFF: https://github.com/llvm/llvm-project/commit/125abb61f7ae52f9dbf4b82d5f90b70ef107fb62.diff

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

ChuanqiXu added a comment. Herald added a subscriber: pcwang-thead. It looks this landed without being approved: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335. It broke the test. If we need to revert it, we need to revert

[PATCH] D119727: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics.

monkchiang accepted this revision. monkchiang added a comment. This revision is now accepted and ready to land. LGTM, Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119727/new/ https://reviews.llvm.org/D119727

[clang] 25cdf87 - [NFC] Update new warning to test

Author: Chuanqi Xu Date: 2022-02-16T10:51:56+08:00 New Revision: 25cdf87b13eb990eb84d31211280f4b0d5d470b3 URL: https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3 DIFF: https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3.diff

[PATCH] D118893: [C++20][Modules] Track valid import state.

ChuanqiXu added a comment. BTW, I guess it would be helpful to add the index in the series in the title. Like `[C++20][Modules] Track valid import state (1/8)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/

[PATCH] D118893: [C++20][Modules] Track valid import state.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error<

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7847199044e: [RISCV] Add the passthru operand for RVV nomask binary intrinsics. (authored by khchen). Herald added a subscriber: qcolombet.

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } ChuanqiXu wrote: > junparser wrote: > > I mean, remove the if statements here since the retuen expr is null. > We

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen created this revision. ychen added reviewers: hans, rnk, aganea, JDevlieghere, labath. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The motivation is to enable the

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + According to [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | P1857R3 ]], it might not be good to add macro declarative

[PATCH] D119772: [clang] [NFC] More exhaustive tests for deducing void return types

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119772/new/ https://reviews.llvm.org/D119772

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } junparser wrote: > I mean, remove the if statements here since the retuen expr is null. We couldn't. Since we need

[clang] 13b6f31 - Fix crash when deserializing a lambda expression in a decltype.

Author: Richard Smith Date: 2022-02-15T17:56:45-08:00 New Revision: 13b6f31548784452990da6dba555af8d7a061958 URL: https://github.com/llvm/llvm-project/commit/13b6f31548784452990da6dba555af8d7a061958 DIFF: https://github.com/llvm/llvm-project/commit/13b6f31548784452990da6dba555af8d7a061958.diff

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3804-3809 +if (DAR != DAR_Succeeded) { + if (OrigResultType.getBeginLoc().isValid()) +Diag(OrigResultType.getBeginLoc(), diag::note_deducing_return_type_for) +<< FD <<

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3271084 , @MaskRay wrote: > No worries! Thanks for the reply. > > I use Debian and want it to work well and support the > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` direction. > Currently,

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3805 +if (DAR != DAR_Succeeded) { + if (OrigResultType.getBeginLoc().isValid()) +Diag(OrigResultType.getBeginLoc(), diag::note_deducing_return_type_for) > I am curious

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone updated this revision to Diff 409095. Quuxplusone added a comment. Rebase; adjust more expected output in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119778/new/ https://reviews.llvm.org/D119778 Files:

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 409090. Quuxplusone added a comment. Rebase; fix the clang-format nit; reinsert a missing `FD->setInvalidDecl()` that seemed to be causing crashes in Modules code under libcxx/test/ but otherwise doesn't seem to be tested in clang/test/ :( Repository:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

lebedev.ri added a comment. I'm personally ignoring this review because quite honestly i was horrified of just how nonchalantly dismissive/accusative the reaction was to the problem i raised during the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

Quuxplusone added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3018-3019 do { +bool LambdaThisTimeAllowed = LambdaNextTimeAllowed; +LambdaNextTimeAllowed = false; + Nit: For this pattern, consider `bool LambdaThisTimeAllowed =

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3324598 , @sylvestre.ledru wrote: > Could you please stop with the pings? and chat directly ? (It seems that you > are colleagues?!) > > I would like to follow what is happening here but not get flooded. (I don't

Re: [clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

Where was this reviewed? On Wed, Feb 16, 2022 at 12:59 AM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2022-02-15T13:59:27-08:00 > New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335 > > URL: >

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!) I would like to follow what is happening here but not get flooded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch,

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik updated this revision to Diff 409056. shafik marked 5 inline comments as done. shafik added a comment. Addressed comments on SmallVector size and fixed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119178/new/ https://reviews.llvm.org/D119178 Files:

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-15T13:59:27-08:00 New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335 URL: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335 DIFF:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 409046. pkasting added a comment. Fix test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks abandoned this revision. aeubanks added a comment. I posted an RFC a while back for basically removing size levels from optimization levels but never seriously looked into it: https://groups.google.com/g/llvm-dev/c/NrZsR8OZTts/m/P5t14TKaAQAJ Repository: rG LLVM Github Monorepo

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 updated this revision to Diff 409043. jhuber6 added a comment. Removing `-lm` semantics so it is linked by default. Also adding the flag to the tested output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8205 +if (llvm::find(LibraryArgs, "m") == LibraryArgs.end() && !D.CCCIsCXX()) + continue; + JonChesterfield wrote: > jhuber6 wrote: > > jdoerfert wrote: > > > I'd switch

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. In D119792#3324354 , @Quuxplusone wrote: > I think it would be an extremely good idea to commit all 20 of these test > cases to clang/test/CodeGenCXX/, with their current behavior, as a > preliminary patch. Then, D119792

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Izaron updated this revision to Diff 409035. Izaron added a comment. I've added an assert that will prevent similar bugs. Let's look if we're good with this one? Here is the list of eval contexts:

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield added a comment. I'm not confident it's only attributes that we rely on mlink-builtin-bitcode patching up, that could be poor phrasing on my part. Making the pipeline robust to underspecified IR input may be easier (and arguably more useful) than changing the rocm library to be

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3312621 , @ychen wrote: > In D118428#3312440 , @paulkirth > wrote: > >> Hi, >> >> We have two failing test cases on Fuchsia's clang canary builder on Windows >> x64. >> >> LLVM

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer arguments

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Quuxplusone added a reviewer: mizvekov. Quuxplusone added a comment. The code is above my pay grade, but FWIW, I super support the intent of this patch! Let's get p2025 support into Clang! :) > The collection of common cases contains 20 examples: §4.1. Examples. Here is > the current status of

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da319fe770b: [clang-format][NFC] Give State.Stack.back() a meaningful name (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb786a4aefeda: [clang-format] Extend SpaceBeforeParens for requires (authored by HazardyKnusperkeks). Changed prior to commit:

[PATCH] D119138: [clang-format] Further improve support for requires expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcd1e4612f4f: [clang-format] Further improve support for requires expressions (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8da319f - [clang-format][NFC] Give State.Stack.back() a meaningful name

Author: Björn Schäpers Date: 2022-02-15T21:37:38+01:00 New Revision: 8da319fe770b21d342a534bf02d2b88fffe667cc URL: https://github.com/llvm/llvm-project/commit/8da319fe770b21d342a534bf02d2b88fffe667cc DIFF:

[clang] b786a4a - [clang-format] Extend SpaceBeforeParens for requires

Author: Björn Schäpers Date: 2022-02-15T21:37:36+01:00 New Revision: b786a4aefedaf68eb7710d9c01a18ad1d0c820b7 URL: https://github.com/llvm/llvm-project/commit/b786a4aefedaf68eb7710d9c01a18ad1d0c820b7 DIFF:

[clang] bcd1e46 - [clang-format] Further improve support for requires expressions

Author: Björn Schäpers Date: 2022-02-15T21:37:35+01:00 New Revision: bcd1e4612f4fa2d12a51f0708c619ae3b2deaa2b URL: https://github.com/llvm/llvm-project/commit/bcd1e4612f4fa2d12a51f0708c619ae3b2deaa2b DIFF:

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, iains wrote: > urnathan

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3324024 , @sammccall wrote: > In D119363#3323867 , @dgoldman > wrote: > >> In D119363#3323778 , @sammccall >> wrote: >> >>> I'm a

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, urnathan wrote: > I think it's

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 409005. dgoldman marked 3 inline comments as done. dgoldman added a comment. Template fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files:

[PATCH] D118893: [C++20][Modules] Track valid import state.

urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error<

[PATCH] D119615: [CUDA][HIP] Do not promote constexpr var with non-constant initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG73b22935a7a8: [CUDA][HIP] Do not promote constexpr var with non-constant initializer (authored by yaxunl).

[clang] 73b2293 - [CUDA][HIP] Do not promote constexpr var with non-constant initializer

Author: Yaxun (Sam) Liu Date: 2022-02-15T15:15:55-05:00 New Revision: 73b22935a7a863679021598db6a45fcfb62cd321 URL: https://github.com/llvm/llvm-project/commit/73b22935a7a863679021598db6a45fcfb62cd321 DIFF:

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron updated this revision to Diff 408999. Izaron added a comment. Fix Scope::dumpImpl with more precise log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792 Files: clang/include/clang/Sema/Scope.h

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ecafb41327: [OpenMP] Add support for CPU offloading in new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/

[clang] 24ecafb - [OpenMP] Add support for CPU offloading in new driver

Author: Joseph Huber Date: 2022-02-15T15:05:30-05:00 New Revision: 24ecafb4132704db513d550f2edfe875d353287f URL: https://github.com/llvm/llvm-project/commit/24ecafb4132704db513d550f2edfe875d353287f DIFF: https://github.com/llvm/llvm-project/commit/24ecafb4132704db513d550f2edfe875d353287f.diff

[PATCH] D118893: [C++20][Modules] Track valid import state.

iains added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error<

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin added inline comments. Comment at: llvm/include/llvm/CodeGen/RegisterBankInfo.h:220 : ID(ID), Cost(Cost), OperandsMapping(OperandsMapping), - NumOperands(NumOperands) { -} + NumOperands(NumOperands) {} ah - `clang-format`

[clang] 1ea3266 - DebugInfo: Don't simplify template names using _BitInt(N)

Author: David Blaikie Date: 2022-02-15T11:58:40-08:00 New Revision: 1ea326634b582f5574e0b22b85e5b0c631b30dcf URL: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf DIFF: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf.diff

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin created this revision. mtrofin added a reviewer: qcolombet. Herald added subscribers: foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto : llvm::make_range(OpenMPTCRange.first, OpenMPTCRange.second))

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jdoerfert added a subscriber: arsenm. jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto :

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall added a comment. In D119363#3323867 , @dgoldman wrote: > In D119363#3323778 , @sammccall > wrote: > >> I'm a bit concerned about the parent map vs ASTMatchFinder's view being out >> of sync: we'll

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:735 // We don't merge short records. -FormatToken *RecordTok = Line.First; -// Skip record modifiers. -while (RecordTok->Next && -

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3323778 , @sammccall wrote: > I'm a bit concerned about the parent map vs ASTMatchFinder's view being out > of sync: we'll have a ProtocolLoc node that has a parent but the parent > doesn't have the child. > > I'm

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408970. dgoldman marked 4 inline comments as done. dgoldman added a comment. Template and variable casing fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, I think it's confusing to

[PATCH] D118893: [C++20][Modules] Track valid import state.

urnathan added a comment. Looks right to me -- I also implemented such a state machine in GCC's parser. There are a bunch of formatting issues to fix of course. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< +

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall added a comment. I'm a bit concerned about the parent map vs ASTMatchFinder's view being out of sync: we'll have a ProtocolLoc node that has a parent but the parent doesn't have the child. I'm not sure this breaks anything immediately, but I think we should also make these nodes

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

craig.topper added a comment. LGTM other than what I think is an unnecessary include. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:15 #include "RISCVISelLowering.h" +#include "MCTargetDesc/RISCVBaseInfo.h" #include "MCTargetDesc/RISCVMatInt.h"

[clang] 5dc0a16 - [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

Author: Amy Kwan Date: 2022-02-15T12:30:50-06:00 New Revision: 5dc0a1657be14df68bfc33deb2fb75476acdaec8 URL: https://github.com/llvm/llvm-project/commit/5dc0a1657be14df68bfc33deb2fb75476acdaec8 DIFF: https://github.com/llvm/llvm-project/commit/5dc0a1657be14df68bfc33deb2fb75476acdaec8.diff

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc0a1657be1: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only. (authored by amyk). Repository: rG LLVM Github

[PATCH] D102614: [index] Add support for type of pointers to class members

akyrtzi added a comment. > What do you think about this patch? Can it be landed now? Or I should debug > the crash in the Windows version detected with the previous version of my > patch. Is your change introducing the crash or is the crash triggered with the test file without your changes as

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh added a comment. In D119858#3323565 , @Anastasia wrote: > LGTM! Thanks! > > I imagine this is another change to align with `opencl-c.h`? Yes. This addresses the issue of D119398 for tablegen (although the

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) arphaman wrote: > Suggestion: It might be good to factor

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl updated this revision to Diff 408944. aprantl added a comment. Refactored code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119850/new/ https://reviews.llvm.org/D119850 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine this is another change to align with `opencl-c.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119858/new/

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https://reviews.llvm.org/D119613

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 408937. dgoldman added a comment. Rebase on top of latest ProtocolLoc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files:

  1   2   3   >