[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. I'm concerned providing these is going to cause issues. The provided implementation are not atomic. Blindly assuming that the user is compiling for a target that doesn't have pre-emptible threads seems like a bad idea. How do you expect users to use these methods,

[PATCH] D119686: [RISCV] Add the passthru operand for nomask vadc/vsbc/vmerge/vfmerge IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119686/new/ https://reviews.llvm.org/D119686

[PATCH] D119688: [RISCV] Add the passthru operand for vmv.vv/vmv.vx/vfmv.vf IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119688/new/ https://reviews.llvm.org/D119688

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu updated this revision to Diff 409503. ChuanqiXu added a comment. Handle static variable only. Don't touch inline variable now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 Files: clang/lib/Serialization/ASTWriterDecl.cpp

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG910a642c0a5b: [compiler-rt] Implement ARM atomic operations for architectures without SMP… (authored by kpdev42). Repository: rG LLVM Github

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. In D119949#3328254 , @cloudhan wrote: > As the original bug reporter, I don't think this is a proper fix for it. > There seems to be some kind of bug deep in the frontend. This just hide it > anyway. Yeah, maybe there's a

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

cloudhan added a comment. As the original bug reporter, I don't think this a proper fix for it. There seems to be some kind of bug deep in the frontend. This just hide it anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2955-2960 +FirstDecl, +GlobalFragment, +ImportAllowed, +ImportFinished, +PrivateFragment, +NotACXX20Module I guess it is worth to add comment for these fields.

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + urnathan wrote: > iains wrote: > > urnathan wrote: > > > urnathan

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 8pm PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad updated this revision to Diff 409445. brad added a comment. Remove a file I did not mean to include as part of the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989 Files:

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad created this revision. brad added reviewers: sammccall, kadircet. brad added a project: clang. Herald added subscribers: usaxena95, arphaman, krytarowski. brad requested review of this revision. Herald added subscribers: llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM,

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. RFC sent: https://discourse.llvm.org/t/rfc-just-my-code-stepping-for-non-msvc-debuggers/60279 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

rsmith added a comment. In D119778#3327161 , @Quuxplusone wrote: > Apply @rsmith's suggested approach. Thanks, the structure of the change looks good to me. Looking through the test changes, I'm a bit torn by the value proposition of this note. Some

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. After offline discussion with @sfertile , the warning should occur only when the struct member is passed on the stack. I will be updating the patch shortly. @aaron.ballman Thank you for the thorough reviews comments and sorry for the churn. Repository: rG LLVM

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3766 +Expr *, const AutoType *AT, +bool HasReturnStmt) { + // If this is the conversion function for a lambda, we choose

[clang] ef39235 - [clang-format] Make checking for a record more robust and avoid a loop.

Author: Marek Kurdej Date: 2022-02-16T23:05:49+01:00 New Revision: ef39235cb94289281d610e4df52ad2a746d6af61 URL: https://github.com/llvm/llvm-project/commit/ef39235cb94289281d610e4df52ad2a746d6af61 DIFF: https://github.com/llvm/llvm-project/commit/ef39235cb94289281d610e4df52ad2a746d6af61.diff

[clang] 48a31c8 - [clang-format] Mark FormatToken::getPreviousNonComment() nodiscard. NFC.

Author: Marek Kurdej Date: 2022-02-16T22:56:32+01:00 New Revision: 48a31c8f429022a07e2e35f3e62d5f495117f2e7 URL: https://github.com/llvm/llvm-project/commit/48a31c8f429022a07e2e35f3e62d5f495117f2e7 DIFF: https://github.com/llvm/llvm-project/commit/48a31c8f429022a07e2e35f3e62d5f495117f2e7.diff

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 409401. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron marked an inline comment as done. Izaron added a comment. @Quuxplusone Thanks for reviewing the patch! We can wait some time if someone else wants to take a look. Though I doubt if there may be major complaints on extendind the tests (especially with comments and references to a

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. Thanks for the review, if it looks good, can we get this to land now? Otherwise more comments are welcome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG64ecdc1cb168: [OpenMP] Pass AMDGPU math libraries into the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/

[clang] 64ecdc1 - [OpenMP] Pass AMDGPU math libraries into the linker wrapper

Author: Joseph Huber Date: 2022-02-16T16:40:40-05:00 New Revision: 64ecdc1cb168dddc06aa57a8bac5afb8abe05634 URL: https://github.com/llvm/llvm-project/commit/64ecdc1cb168dddc06aa57a8bac5afb8abe05634 DIFF: https://github.com/llvm/llvm-project/commit/64ecdc1cb168dddc06aa57a8bac5afb8abe05634.diff

[clang] 55639c2 - [OpenMP] Properly save strings when doing LTO

Author: Joseph Huber Date: 2022-02-16T16:40:39-05:00 New Revision: 55639c2f7c3ede5a3fba26e82cb038355d4d8542 URL: https://github.com/llvm/llvm-project/commit/55639c2f7c3ede5a3fba26e82cb038355d4d8542 DIFF: https://github.com/llvm/llvm-project/commit/55639c2f7c3ede5a3fba26e82cb038355d4d8542.diff

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron marked an inline comment as done. Izaron added inline comments. Comment at: clang/test/CodeGenCXX/nrvo.cpp:165 if (B) -return y; - return x; +return y; // NRVO is impossible + return x; // NRVO is impossible Quuxplusone wrote: >

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek added a comment. Provide fallback for `TARGET_TRIPLE` and print a warning about deprecation and future removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918

[clang] d81f003 - [clang-format] Fix formatting of struct-like records followed by variable declaration.

Author: Marek Kurdej Date: 2022-02-16T22:37:32+01:00 New Revision: d81f003ce1419aee6cfb8d26f0bca9153278872a URL: https://github.com/llvm/llvm-project/commit/d81f003ce1419aee6cfb8d26f0bca9153278872a DIFF: https://github.com/llvm/llvm-project/commit/d81f003ce1419aee6cfb8d26f0bca9153278872a.diff

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGd81f003ce141: [clang-format] Fix formatting of struct-like records followed by variable… (authored by curdeius). Changed prior to commit:

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 409394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron updated this revision to Diff 409389. Izaron added a comment. I placed links to corresponding p2025 examples. Some of the examples are reasonably absent from the test, such as 1st (RVO, not NRVO), 13th (consteval methods are not getting to LLVM IR), 17th (there are no NRVOs for

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius marked 3 inline comments as done. curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:735 // We don't merge short records. -FormatToken *RecordTok = Line.First; -// Skip record modifiers. -while

[clang] 05a77fc - [clang-format] Fall through and avoid an unnecessary check. NFC.

Author: Marek Kurdej Date: 2022-02-16T22:07:09+01:00 New Revision: 05a77fc3f97adddc1af3d4fb6d4234047ed09a99 URL: https://github.com/llvm/llvm-project/commit/05a77fc3f97adddc1af3d4fb6d4234047ed09a99 DIFF: https://github.com/llvm/llvm-project/commit/05a77fc3f97adddc1af3d4fb6d4234047ed09a99.diff

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM FWIW. You might want to wait for someone more authoritative to take a look; but it's also only adding test coverage, so it seems pretty uncontroversial, I would think.

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron updated this revision to Diff 409374. Izaron added a comment. Thanks! Yes I should've write comments that are understandable not only for me =) I added comments to the existing tests as well. Though NRVO attribute is bound to the variable, I'm also more comfortable to place comments in

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { +

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Izaron added a comment. After an investigation in GDB I can say that the assert seems to be wrong. Since Clang instantiates classes and functions "on the fly" where appropriate, we indeed can get a run-time evaluation context after a compile-time evaluation context. I was sure that evaluation

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone updated this revision to Diff 409359. Quuxplusone added a comment. Apply @rsmith's suggested approach. > I don't see any obvious way that this patch could be responsible for that > failure, unless it's something like a pre-existing use of uninitialized > memory or a use-after-free

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409349. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? I don't see this failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

rsmith added a comment. In D119778#3326285 , @Quuxplusone wrote: > I'll update with the `CodeSynthesisContext` approach in a little bit. But > meanwhile there's a problem with both the current patch //and// (I think even > more) with the new approach.

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. > - how does that work, actually? How does it differentiate between "my" code > and "code that happens to be compiled in the current CU" (e.g. the STL). > What's the significance of the funky `___x@c` symbols? The non-user code is specified by a config file

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:39 +// represent conjunctions, disjunctions, and negations. +AtomicBoolValue, +BoolConjunctionValue, xazax.hun wrote: > Do we need `Value` in the `Kind` if

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev updated this revision to Diff 409330. sgatev marked 5 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119953/new/ https://reviews.llvm.org/D119953 Files:

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Any idea what's going on in that Modules/cxx20-export-import.cpp failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added a comment. In D93298#3326230 , @asb wrote: > I think all my comments have been addressed. @craig.topper - are you happy > your RegInfo question is addressed? I'm happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. @thakis, @ChuanqiXu I have fixed the warning and added a group to it. Can you please review? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409307. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:28 + + /// Returns the environment of the basic block that contains `S` or nullptr if + /// there isn't one. xazax.hun wrote: > Depending on how willing

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:28 + + /// Returns the environment of the basic block that contains `S` or nullptr if + /// there isn't one. Depending on how willing sensitive we are to memory

[clang] 572e2cd - Reverting ce420820c815e806bab9c5f17cb3b829a616548a because it fails expensive checks

Author: Rashmi Mudduluru Date: 2022-02-16T09:25:53-08:00 New Revision: 572e2cd56a43429bdbc88c886e260b5facff9048 URL: https://github.com/llvm/llvm-project/commit/572e2cd56a43429bdbc88c886e260b5facff9048 DIFF:

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev updated this revision to Diff 409296. sgatev added a comment. Remove unnecessary IgnoreParens calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119953/new/ https://reviews.llvm.org/D119953 Files:

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; iains wrote: >

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Quuxplusone added a comment. Excellent! Comment at: clang/test/CodeGenCXX/nrvo.cpp:622 + if (b) +return x; + else Similar to what you did in `test5`, I think it'd be helpful to comment //on the return line itself// whether NRVO is

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC]

[clang] 9d59cfc - clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

Author: Jameson Nash Date: 2022-02-16T11:59:09-05:00 New Revision: 9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1 URL: https://github.com/llvm/llvm-project/commit/9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1 DIFF: https://github.com/llvm/llvm-project/commit/9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1.diff

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d59cfc67ead: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM this time. Thanks very much for the rework! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841

[clang] 5781839 - Revert "[OpenMP] Pass AMDGPU math libraries into the linker wrapper"

Author: Joseph Huber Date: 2022-02-16T11:54:44-05:00 New Revision: 5781839f7a348d4f942e6c7ee5d720e93517022a URL: https://github.com/llvm/llvm-project/commit/5781839f7a348d4f942e6c7ee5d720e93517022a DIFF: https://github.com/llvm/llvm-project/commit/5781839f7a348d4f942e6c7ee5d720e93517022a.diff

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added a comment. In D119841#3326638 , @JonChesterfield wrote: > This is asserting somewhere in clang-linker-wrapper, e.g. > https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Yes, must be when we try to sort the device files. I'll revert

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; urnathan wrote: >

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

ronlieb added a comment. Hi Joseph, seems to have broken amdgpu buildbit, please revert and fix ? https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield added a comment. This is asserting somewhere in clang-linker-wrapper, e.g. https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG61fb260d9d8c: [OpenMP] Pass AMDGPU math libraries into the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:522 + + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); Is it possible to return a StringRef rather than a copy? Repository:

[clang] 61fb260 - [OpenMP] Pass AMDGPU math libraries into the linker wrapper

Author: Joseph Huber Date: 2022-02-16T11:39:11-05:00 New Revision: 61fb260d9d8c26a61a8dfd64e94d51f2c9a06830 URL: https://github.com/llvm/llvm-project/commit/61fb260d9d8c26a61a8dfd64e94d51f2c9a06830 DIFF: https://github.com/llvm/llvm-project/commit/61fb260d9d8c26a61a8dfd64e94d51f2c9a06830.diff

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0604d86c07ab: Darwin: introduce a global override for debug prefix map entries. (authored by aprantl). Herald added a project: clang. Changed prior

[clang] 0604d86 - Darwin: introduce a global override for debug prefix map entries.

Author: Adrian Prantl Date: 2022-02-16T08:36:26-08:00 New Revision: 0604d86c07ab8a28b95df689aff4ddd26347f35f URL: https://github.com/llvm/llvm-project/commit/0604d86c07ab8a28b95df689aff4ddd26347f35f DIFF: https://github.com/llvm/llvm-project/commit/0604d86c07ab8a28b95df689aff4ddd26347f35f.diff

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added a comment. In D119850#3326266 , @thakis wrote: > (I wish there was a flag that said "clang, never ever read any env vars > please". Some people think that builds should be deterministic and not depend > on random env vars people might

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:520-522 + /// Get the primary module interface name from a partition. + + std::string getPrimaryModuleInterfaceName() const { stray blank line? Comment at:

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + iains wrote: > urnathan wrote: > > urnathan wrote: > > > ChuanqiXu wrote: > > > > iains wrote: > > > > > ChuanqiXu wrote: > > > > > > According to [[ >

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, with or without the -lm lookup Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire created this revision. junaire added reviewers: aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. junaire requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The ElaboratedType can have no

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

lkail added a comment. Hi, is this patch ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/ https://reviews.llvm.org/D28213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:5 + // AARCH64-LABEL: @add_float_rr( + // AARCH64: fadd reassoc nnan ninf nsz arcp afn

[clang] 597f2bc - [clang] [test] [NFC] Eliminate some hard tabs in tests

Author: Arthur O'Dwyer Date: 2022-02-16T10:42:58-05:00 New Revision: 597f2bcee895c1a9cc18067b85d6846137c11816 URL: https://github.com/llvm/llvm-project/commit/597f2bcee895c1a9cc18067b85d6846137c11816 DIFF:

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409254. thakis added a comment. Pass `-B` with `-fuse-ld=lld` since the latter flag only has an effect if ld64.lld exists on disk, and clang/test doesn't depend on lld (and shouldn't). Also move object_path_lto to its own file since it can run fine on

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius accepted this revision. curdeius added a comment. In D119893#3326247 , @HazardyKnusperkeks wrote: > Formatting Test added. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409243. thakis added a comment. undo no_deduplicate bit again for now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld-lto.c

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. Okay, this should work now for those cases! Sorry, I kept thinking it was clang/examples that was broken, and missed that it was clang/test that was failing, so I failed to see what I needed to fix there too, so that we were not trying to build the tests in

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 409241. vtjnash added a comment. add one more missing case to check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone added a comment. I'll update with the `CodeSynthesisContext` approach in a little bit. But meanwhile there's a problem with both the current patch //and// (I think even more) with the new approach. @rsmith any help?: When I try my latest patch with the libc++ tests, with

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. with the assert fixed Comment at: clang/lib/Sema/SemaModule.cpp:119 +default: + assert(0 && "how did we get a partition type set?"); +}

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

thakis added a comment. (I wish there was a flag that said "clang, never ever read any env vars please". Some people think that builds should be deterministic and not depend on random env vars people might have set (and then not do correct incremental rebuilds when the value of such env var

[clang] 6690b7d - [OpenCL] Ensure atomic_init is guarded with extension

Author: Sven van Haastregt Date: 2022-02-16T15:12:23Z New Revision: 6690b7d3ac9ab6410b7909207552ce4edbe2147b URL: https://github.com/llvm/llvm-project/commit/6690b7d3ac9ab6410b7909207552ce4edbe2147b DIFF: https://github.com/llvm/llvm-project/commit/6690b7d3ac9ab6410b7909207552ce4edbe2147b.diff

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array aaron.ballman wrote:

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + urnathan wrote: > urnathan wrote: > > ChuanqiXu wrote: > > > iains wrote: > > > > ChuanqiXu wrote: > > > > > According to [[ > > > > >

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + urnathan wrote: > ChuanqiXu wrote: > > iains wrote: > > > ChuanqiXu wrote: > > > > According to [[ > > > >

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409237. HazardyKnusperkeks added a comment. Formatting Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + ChuanqiXu wrote: > iains wrote: > > ChuanqiXu wrote: > > > According to [[ > > > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html |

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. The bot that broke last time stayed green on the reland: https://lab.llvm.org/staging/#/builders/204/builds/1591 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2654-2656 +if (!C.hasSameType(DefaultArgumentX->getType(), + DefaultArgumentY->getType())) + return false; Can this ever trigger and the below expression

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

MattDevereau updated this revision to Diff 409236. MattDevereau added a comment. Removed -O1 and -ffast-math flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. I think all my comments have been addressed. @craig.topper - are you happy your RegInfo question is addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'import' keyword. - /// \param Path The module access path. + /// \param NamePath The module toplevel name as an access path. + /// \param Partition

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

hokein added a comment. comments on preprocessor part. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:49 +/// | `printf("hello, "); +/// |-+ Conditional -+ Directive #ifndef NDEBUG +/// | |-+ Code

  1   2   >