[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 410058. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

keith added a comment. In D102669#3325467 , @steakhal wrote: > Hi @keith, I've seen you commented on a clang driver-related issue: "Why does > march=native not work on Apple M1?" >

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

dblaikie added a comment. In D119409#3332476 , @urnathan wrote: > In D119409#3332313 , @dblaikie > wrote: > >> > > That's interesting data. I guess one could emit the out-of-line bodies into > their own

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410041. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files:

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev marked 2 inline comments as done. sgatev added a comment. I think we should provide such functionality and it probably should also apply to some of the pointer and reference values. Not sure what the default should be, but having the ability to choose the level of soundness for certain

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added inline comments. Comment at: llvm/lib/Support/Host.cpp:1326 + case CPUFAMILY_ARM_CYCLONE: +return "apple-a7"; + case CPUFAMILY_ARM_TYPHOON: jrtc27 wrote: > ARM only calls it cyclone, AArch64 allows both but apple-a7 is the canonical > name

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 410040. keith marked 2 inline comments as done. keith added a comment. Code review improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files:

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

nridge added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:545 + // TemplateTypeParmTypes for implicit TTPs, instead of AutoTypes. + // Also we don't look very hard, just stripping const, references, pointers. + static TemplateTypeParmTypeLoc

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

ab added a comment. In D119788#3331324 , @keith wrote: > Thanks for the tips! I left the default as generic here, but I totally take > your point on defaulting to the newest and I'm happy to update if you feel > strongly, lmk what you think I agree

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

jrtc27 added a comment. In D118987#3319697 , @steakhal wrote: > It seems like the `clang-ve-ninja` doesn't really want to accept any patches > from me :D > I hope it's not personal. Let's be friends bot, please. > > Link to the breakage:

[PATCH] D120149: [clang][dataflow] Add support for global storage values

xazax.hun added a comment. Shouldn't there be a functionality to invalidate all the globals at every function call by default? Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:141 +// Global vars are already initialized in `Environment`. +if

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:335 - NonLoc makeIntValWithPtrWidth(uint64_t integer, bool isUnsigned) { -return nonloc::ConcreteInt( -BasicVals.getIntWithPtrWidth(integer,

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:80 + +/// Initializes global storage values in sub-expressions of `S`. +static void initGlobalVars(const Stmt , Environment ) {

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410014. sgatev marked 3 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files:

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6 +/// Check sparc-sun-solaris2.11, 32bit +// RUN: %clang %s -### 2>&1 \ +// RUN: --target=sparc-sun-solaris2.11 \ The first line is now

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

egorzhdan created this revision. Herald added subscribers: dexonsmith, dang. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This new flag enables `__has_feature(cxx_unstable)` that would replace libc++ macros for individual

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight created this revision. jyknight added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, arphaman, martong. Herald added a reviewer: shafik. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. Thank you all! I have modified the summary, this patch focus on fixing non-working `__attribute__((no_sanitize("bounds"))) ` attribute. I will try to fix kernel `ksize()` related issue and `-fno-sanitize-undefined-trap-on-error` on separate patches. Repository: rG

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius marked an inline comment as done. curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1951 +// FIXME: Maybe we should handle identifiers ending with "_cast", +// e.g. bit_cast? +return true;

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rG54a962bbfee8: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG805f7a4fa4ce: [clang] Add `ObjCProtocolLoc` to represent protocol references (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 54a962b - [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

Author: David Goldman Date: 2022-02-18T15:24:00-05:00 New Revision: 54a962bbfee86d5af90d5fdd39b4ff4ec8030f12 URL: https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12 DIFF: https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12.diff

[clang] 805f7a4 - [clang] Add `ObjCProtocolLoc` to represent protocol references

Author: David Goldman Date: 2022-02-18T15:24:00-05:00 New Revision: 805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1 URL: https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1 DIFF: https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1.diff

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120149: [clang][dataflow] Add support for global storage values

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:74-77 + auto *V = dyn_cast(); + if (V == nullptr) +return; + initGlobalVar(*V, Env);

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3332521 , @jdoerfert wrote: > FWIW, https://github.com/llvm/llvm-project/issues/53931 Yes. Working on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp abandoned this revision. carlosgalvezp added a comment. Understood, thanks a lot for the clarification and for the time taken! I will then abandon this patch given the high risk involved. I will forward this feedback to MISRA in case there is a possibility to publish the upcoming

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC]

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1951 +// FIXME: Maybe we should handle identifiers ending with "_cast", +// e.g. bit_cast? +return true; Very unlikely `bit_cast` gives you

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

jdoerfert added a comment. FWIW, https://github.com/llvm/llvm-project/issues/53931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

urnathan added a comment. In D119409#3332313 , @dblaikie wrote: > That's interesting data. I guess one could emit the out-of-line bodies into their own sections, and then rely on linker section GC to elide them in the static link. But if you're

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3332441 , @nlopes wrote: > The main issue is that the kernel is wrong. It has a bug. The sanitizer's > error is not a false-positive! > So what you are proposing is a band-aid. It's not a real solution and it's >

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3331797 , @melver wrote: > Right, I was able to repro this. The problem is the trap, which generally > sucks that no_sanitize still leaves in the trap. > > We also have -fno-sanitize-undefined-trap-on-error, which

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

nlopes added a comment. In D119816#3332414 , @ztong0001 wrote: > In D119816#3331658 , @nlopes wrote: > >> Well, this patch is just a band-aid and a disaster waiting to happen. >> If kmalloc is tagged with an

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3331658 , @nlopes wrote: > Well, this patch is just a band-aid and a disaster waiting to happen. > If kmalloc is tagged with an `__attribute__` stating the allocation size, > then you can't dereference beyond that

[PATCH] D112916: Confusable identifiers detection

aaron.ballman added a comment. In D112916#3331592 , @cor3ntin wrote: > In D112916#3314184 , @cor3ntin > wrote: > >> @aaron.ballman Thanks for the ping. >> >> One one hand, I agree with you, on the other hand,

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. Can I ask you to deliver this one for me? My name and email in git format is "Krystian Kuzniarek " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https://reviews.llvm.org/D119682 ___ cfe-commits mailing

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473 + const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a", + "+v9.1a", "+v9.2a", "+v9.3a"}; auto Pos =

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

lattner added a comment. Hi all, I'm commenting on this based on my personal opinion, I don't speak for the LLVM board or anyone else. I am also not a lawyer :) This isn’t a clear cut case (as is typical!). LLVM's approach on patents protection revolves primarily around the terms in the

[clang-tools-extra] 9415fbb - [clangd] getHover - pass FormatStyle argument by const reference

Author: Simon Pilgrim Date: 2022-02-18T17:27:45Z New Revision: 9415fbbbcf73ab90692fafdac5bd6e302d07ba4b URL: https://github.com/llvm/llvm-project/commit/9415fbbbcf73ab90692fafdac5bd6e302d07ba4b DIFF: https://github.com/llvm/llvm-project/commit/9415fbbbcf73ab90692fafdac5bd6e302d07ba4b.diff

[clang] 74036db - Fix Wdocumentation unknown parameter warning

Author: Simon Pilgrim Date: 2022-02-18T17:27:45Z New Revision: 74036dbafd3d742e86464043f3e2f4d52bf79f1e URL: https://github.com/llvm/llvm-project/commit/74036dbafd3d742e86464043f3e2f4d52bf79f1e DIFF: https://github.com/llvm/llvm-project/commit/74036dbafd3d742e86464043f3e2f4d52bf79f1e.diff

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1740 +assert(Current.MatchingParen); +Current.MatchingParen->setType(TT_Unknown); + } To add some context, in the failing cases, the opening parenthesis was set

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53876. This is a solution

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. >> That's not the first time we renamed something. And most likely not the last >> time. > > But that doesn't mean we can't add "Previously known as IndentRequires", does > it? :) Of course! I just wanted to say

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

dblaikie added a comment. (maybe relevant: For what it's worth: I originally implemented inline function homing in modules codegen for Clang Header Modules - the results I got for object file size in an -O0 build were marginal - a /slight/ win in object file size, but not as much as we

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b749e5be21: [clangd] Tweak --query-driver to ignore slash direction on windows (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D120115?vs=409900=409957#toc Repository:

[clang-tools-extra] 47b749e - [clangd] Tweak --query-driver to ignore slash direction on windows

Author: Sam McCall Date: 2022-02-18T18:06:36+01:00 New Revision: 47b749e5be2190d1ccb214fd6364da462a9098cf URL: https://github.com/llvm/llvm-project/commit/47b749e5be2190d1ccb214fd6364da462a9098cf DIFF: https://github.com/llvm/llvm-project/commit/47b749e5be2190d1ccb214fd6364da462a9098cf.diff

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278 +} else if (llvm::sys::path::is_separator(Glob[I]) && + llvm::sys::path::is_separator('/') && +

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3565 else Ty = Context.CharTy; // 'x' -> char in C++ Perhaps worth updating this comment? e.g., // 'x' -> char in C++; u8'x' -> char in C11-C17 and in C++ without char8_t.

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. vabridgers requested review of this revision. Herald added a

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

carlocab added a comment. Thanks Petr. I don’t have commit access, so I’d appreciate it if you could commit this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119144/new/ https://reviews.llvm.org/D119144

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278 +} else if (llvm::sys::path::is_separator(Glob[I]) && +

[clang] 91cf639 - Fix Wdocumentation unknown parameter warning

Author: Simon Pilgrim Date: 2022-02-18T15:38:16Z New Revision: 91cf639ac069a797b1fac4134cf121bc9db6dff6 URL: https://github.com/llvm/llvm-project/commit/91cf639ac069a797b1fac4134cf121bc9db6dff6 DIFF: https://github.com/llvm/llvm-project/commit/91cf639ac069a797b1fac4134cf121bc9db6dff6.diff

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/include/clang/Format/Format.h:2540-2541 ///} /// \endcode - /// \version 13 + /// \version 15 bool IndentRequiresClause; MyDeveloperDay wrote: >

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry updated this revision to Diff 409935. kuzkry added a comment. Review fix: added note about IndentRequires. The generated HTML looks like this: F22153448: IndentRequires note.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

This revision was automatically updated to reflect the committed changes. Closed by commit rG68b7b357fdfc: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 68b7b35 - [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

Author: Shilei Tian Date: 2022-02-18T10:24:29-05:00 New Revision: 68b7b357fdfc00ed8807a887eba363d67c9dc3f5 URL: https://github.com/llvm/llvm-project/commit/68b7b357fdfc00ed8807a887eba363d67c9dc3f5 DIFF: https://github.com/llvm/llvm-project/commit/68b7b357fdfc00ed8807a887eba363d67c9dc3f5.diff

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccebf8ac8c61: [Clang][OpenMP] Add support for compare capture in parser (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[clang] ccebf8a - [Clang][OpenMP] Add support for compare capture in parser

Author: Shilei Tian Date: 2022-02-18T10:23:59-05:00 New Revision: ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c URL: https://github.com/llvm/llvm-project/commit/ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c DIFF: https://github.com/llvm/llvm-project/commit/ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c.diff

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. yaxunl requested review of this revision. The clang compiler prepends the HIP header include paths to the search list using -internal-isystem when building for the HIP language. This prevents

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. In D93298#3332058 , @jrtc27 wrote: > In D93298#3332038 , @xbolva00 wrote: > It appears that this is causing an assertion segfault in a rustc test over at our experimental rust +

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3332038 , @xbolva00 wrote: >>> It appears that this is causing an assertion segfault in a rustc test over >>> at our experimental rust + llvm@head bot: > > I dont think that patch author is required to debug this issue

[PATCH] D120131: [clangd] prototype: for singly-instantiated templates, examine the instantiation

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This prototype is crude and breaks things (e.g.

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. >> It appears that this is causing an assertion segfault in a rustc test over >> at our experimental rust + llvm@head bot: I dont think that patch author is required to debug this issue for "experimental rust + llvm@head" - downstream. >> Since I don't have a rust

[clang-tools-extra] 707157f - Revert rGc24e197aaad5333717a27f6e4346f97da84821ed "[clangd] getHover - pass FormatStyle argument by const reference"

Author: Simon Pilgrim Date: 2022-02-18T14:59:57Z New Revision: 707157f24834e814243c90cf1f5f50c75f3abcb9 URL: https://github.com/llvm/llvm-project/commit/707157f24834e814243c90cf1f5f50c75f3abcb9 DIFF: https://github.com/llvm/llvm-project/commit/707157f24834e814243c90cf1f5f50c75f3abcb9.diff

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3332020 , @achieveartificialintelligence wrote: > @krasimir Since I don't have a rust environment, can you help me to test if > D120130 works? Hm, actually, looking at the log, it

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. @krasimir Since I don't have a rust environment, can you help me to test if D120130 works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:491 + // We'll examine visible specializations and see if they yield a unique type. + bool VisitParmVarDecl(ParmVarDecl *PVD) { +if (!PVD->getType()->isDependentType()) Since this

[clang-tools-extra] c24e197 - [clangd] getHover - pass FormatStyle argument by const reference

Author: Simon Pilgrim Date: 2022-02-18T14:45:51Z New Revision: c24e197aaad5333717a27f6e4346f97da84821ed URL: https://github.com/llvm/llvm-project/commit/c24e197aaad5333717a27f6e4346f97da84821ed DIFF: https://github.com/llvm/llvm-project/commit/c24e197aaad5333717a27f6e4346f97da84821ed.diff

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

erichkeane added a comment. In D99134#3311363 , @jloser wrote: > Would love to see this cherry-picked into the llvm 14 release branch if > possible! I believe there is a bug in github that you can use to request that. This just landed as

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bff3a965022: Lambdas are not necessarily locals. This resolves DR48250. (authored by davidstone, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0bff3a9 - Lambdas are not necessarily locals. This resolves DR48250.

Author: David Stone Date: 2022-02-18T06:11:28-08:00 New Revision: 0bff3a965022647fcdd17cc8f2217f5a2cd30b4c URL: https://github.com/llvm/llvm-project/commit/0bff3a965022647fcdd17cc8f2217f5a2cd30b4c DIFF: https://github.com/llvm/llvm-project/commit/0bff3a965022647fcdd17cc8f2217f5a2cd30b4c.diff

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

erichkeane added a comment. In D99134#3331359 , @davidstone wrote: > In D99134#3331259 , @rsmith wrote: > >> Looks good. Do you need someone to land this for you? > > Yes, I do. I'll do that for you, working on it

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3331641 , @krasimir wrote: > It appears that this is causing an assertion segfault in a `rustc` test over > at our experimental rust + llvm@head bot: >

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:372 - Loc makeNull() { -return loc::ConcreteInt(BasicVals.getZeroWithPtrWidth()); } steakhal

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3331914 , @thakis wrote: > Thank you for reverting my follow-up as well! > > zahiraam, for the reland please include that follow-up fix in your commit :) Yes. Will do that. Thanks. Repository: rG LLVM Github

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Thank you for reverting my follow-up as well! zahiraam, for the reland please include that follow-up fix in your commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + yaxunl wrote: > tra wrote: > > Is this file necessary? `clang -###` should not need the file

[PATCH] D120106: [OpenMP] Add flag for disabling thread state in runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG0870a4f59aef: [OpenMP] Add flag for disabling thread state in runtime (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/

[clang] 0870a4f - [OpenMP] Add flag for disabling thread state in runtime

Author: Joseph Huber Date: 2022-02-18T08:35:05-05:00 New Revision: 0870a4f59aef21bf7707b00ebd4dcad7ce7ef807 URL: https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807 DIFF: https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807.diff

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

melver added a comment. Right, I was able to repro this. The problem is the trap, which generally sucks that no_sanitize still leaves in the trap. We also have -fno-sanitize-undefined-trap-on-error, which seems to have no effect either (should it?). So I think there are 2 problems: 1. Clang

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. In D119537#3323096 , @Trass3r wrote: > Is it intentional that the resolved type is not shown in the variable hover > (I guess, looking at the code): > > param payload > Type: const auto & > > // In

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall updated this revision to Diff 409902. sammccall marked 4 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 Files:

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

melver added a comment. What about this test then: https://github.com/llvm/llvm-project/blob/b0a0df980927ca54a7840a1b0c9766e98c05039b/clang/test/CodeGen/sanitize-coverage.c#L74 Can you show an independent C reproducer where no_sanitize does not work for you? Is there an LKML discussion? I

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. See

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay added a comment. I like `/// In clang-format 13 and 14 it was named ``IndentRequires``.` The code in theory should still support it so it should be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2540-2541 ///} /// \endcode - /// \version 13 + /// \version 15 bool IndentRequiresClause; HazardyKnusperkeks wrote: > I like that suggestion.. Repository:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers updated this revision to Diff 409896. vabridgers added a comment. refactor based on @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 Files:

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); iains wrote: > ChuanqiXu wrote: > > iains wrote: > > > urnathan wrote: > > > > iains wrote:

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3331396 , @ChuanqiXu wrote: > Thanks for explanation. Now it looks good to me. Let's accept it formally > after the series of partition landed and so that we could add test about > partitions. thanks, We're going

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:368 Loc makeNullWithType(QualType type) { -return loc::ConcreteInt(BasicVals.getZeroWithTypeSize(type)); - } - - Loc makeNull() { -return

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:177 }; +void initTerminals(std::vector ); sammccall wrote: > why is this exposed/required rather than being initialized by the > GrammarTable constructor? > Since

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 409893. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118196/new/ https://reviews.llvm.org/D118196 Files: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 409892. hokein marked 14 inline comments as done. hokein added a comment. - address comments - more api polishments - LRGraph unittest => lit tests - hide LRTable::Builder, move to LRTableBuild.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120081: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG977b1f574fa1: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 977b1f5 - [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

Author: Kadir Cetinkaya Date: 2022-02-18T12:16:38+01:00 New Revision: 977b1f574fa18219fde5f709b906c79202ef1916 URL: https://github.com/llvm/llvm-project/commit/977b1f574fa18219fde5f709b906c79202ef1916 DIFF:

[clang-tools-extra] 535e7b0 - [clangd] lookupSiblingsWithinContext - remove unnecessary nullptr check

Author: Simon Pilgrim Date: 2022-02-18T11:12:53Z New Revision: 535e7b09c189dd3a7ef65bd36a02962f0c98bd5e URL: https://github.com/llvm/llvm-project/commit/535e7b09c189dd3a7ef65bd36a02962f0c98bd5e DIFF: https://github.com/llvm/llvm-project/commit/535e7b09c189dd3a7ef65bd36a02962f0c98bd5e.diff

  1   2   >