[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 410233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp

[PATCH] D120220: [clang-format][NFC] Fix typos and inconsistencies

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1664 + // Ensure the list has 'type' in it auto type = std::find(Style->QualifierOrder.begin(), HazardyKnusperkeks wrote: > ;) Good catch! I will add it when landing D120217.

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473 + const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a", + "+v9.1a", "+v9.2a", "+v9.3a"}; auto Pos =

[clang] c1f17b0 - [RISCV] Fix the include search path order between sysroot and resource folder (Recommit again)

Author: Kito Cheng Date: 2022-02-21T15:25:21+08:00 New Revision: c1f17b0a9ea0d467eaa9589cc28db2787efe3ebf URL: https://github.com/llvm/llvm-project/commit/c1f17b0a9ea0d467eaa9589cc28db2787efe3ebf DIFF: https://github.com/llvm/llvm-project/commit/c1f17b0a9ea0d467eaa9589cc28db2787efe3ebf.diff

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 updated this revision to Diff 410225. tyb0807 added a comment. Cache architecture feature to avoid scanning the feature list over and over again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120111/new/ https://reviews.llvm.org/D120111

[PATCH] D120220: [clang-format][NFC] Fix typos and inconsistencies

HazardyKnusperkeks added a comment. A bit late, but maybe you want to do a follow up. ;) Comment at: clang/lib/Format/Format.cpp:1664 + // Ensure the list has 'type' in it auto type = std::find(Style->QualifierOrder.begin(), ;) Repository: rG LLVM

[clang] cc27952 - Revert "[RISCV] Fix the include search path order between sysroot and resource folder (Recommit)"

Author: Kito Cheng Date: 2022-02-21T14:56:58+08:00 New Revision: cc279529e8317301492f9625b6acc9a0bf52db56 URL: https://github.com/llvm/llvm-project/commit/cc279529e8317301492f9625b6acc9a0bf52db56 DIFF: https://github.com/llvm/llvm-project/commit/cc279529e8317301492f9625b6acc9a0bf52db56.diff

[PATCH] D119837: [RISCV] Fix the include search path order between sysroot and resource folder

kito-cheng added a comment. Recommit with windows path fix: https://reviews.llvm.org/rG47b1fa5fc48821eefefd157ed4af2f2cf3bacef4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119837/new/ https://reviews.llvm.org/D119837

[clang] 47b1fa5 - [RISCV] Fix the include search path order between sysroot and resource folder (Recommit)

Author: Kito Cheng Date: 2022-02-21T14:39:43+08:00 New Revision: 47b1fa5fc48821eefefd157ed4af2f2cf3bacef4 URL: https://github.com/llvm/llvm-project/commit/47b1fa5fc48821eefefd157ed4af2f2cf3bacef4 DIFF: https://github.com/llvm/llvm-project/commit/47b1fa5fc48821eefefd157ed4af2f2cf3bacef4.diff

[PATCH] D119837: [RISCV] Fix the include search path order between sysroot and resource folder

kito-cheng added a comment. Revert due to windows build regression fail: https://lab.llvm.org/buildbot/#/builders/216/builds/195 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119837/new/ https://reviews.llvm.org/D119837

[clang] 0a17ee1 - Revert "[RISCV] Fix the include search path order between sysroot and resource folder"

Author: Kito Cheng Date: 2022-02-21T14:25:49+08:00 New Revision: 0a17ee1ebe0c3384520ea14fdc1d33e38217341a URL: https://github.com/llvm/llvm-project/commit/0a17ee1ebe0c3384520ea14fdc1d33e38217341a DIFF: https://github.com/llvm/llvm-project/commit/0a17ee1ebe0c3384520ea14fdc1d33e38217341a.diff

[PATCH] D119837: [RISCV] Fix the include search path order between sysroot and resource folder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079d13668bf1: [RISCV] Fix the include search path order between sysroot and resource folder (authored by Kito Cheng kito.ch...@sifive.com).

[clang] 079d136 - [RISCV] Fix the include search path order between sysroot and resource folder

Author: Kito Cheng Date: 2022-02-21T14:06:47+08:00 New Revision: 079d13668bf1b7f929f1897af90f64caae41c81d URL: https://github.com/llvm/llvm-project/commit/079d13668bf1b7f929f1897af90f64caae41c81d DIFF: https://github.com/llvm/llvm-project/commit/079d13668bf1b7f929f1897af90f64caae41c81d.diff

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan updated this revision to Diff 410216. owenpan added a comment. Rebased and addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120217/new/ https://reviews.llvm.org/D120217 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 +static FormatToken *getLastNonComment(const UnwrappedLine ) { + for (const auto : llvm::reverse(Line.Tokens)) +if (Token.Tok->isNot(tok::comment)) HazardyKnusperkeks

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmsif.ll:34 ; CHECK-NEXT:vmv1r.v v10, v0 -; CHECK-NEXT:vsetvli zero, a0, e8, mf8, tu, mu +; CHECK-NEXT:vsetvli zero, a0, e8, mf8, ta, mu ; CHECK-NEXT:vmv1r.v v0, v9

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmsif.ll:34 ; CHECK-NEXT:vmv1r.v v10, v0 -; CHECK-NEXT:vsetvli zero, a0, e8, mf8, tu, mu +; CHECK-NEXT:vsetvli zero, a0, e8, mf8, ta, mu ; CHECK-NEXT:vmv1r.v v0, v9

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. In D119409#3332313 , @dblaikie wrote: > (maybe relevant: For what it's worth: I originally implemented inline > function homing in modules codegen for Clang Header Modules - the results I > got for object file size in an -O0

[PATCH] D120225: [Clang][Sema] Check unexpected else statement in cond-update-stmt

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. tianshilei1992 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 'cond-update-stmt', `else` statement is not expected. This patch adds the check in

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410203. tianshilei1992 added a comment. set `C` accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files:

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); urnathan wrote: > iains wrote: > > ChuanqiXu wrote: > > >

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410200. tianshilei1992 added a comment. fix error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files:

[PATCH] D120220: [clang-format][NFC] Fix typos and inconsistencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaacc110bdce7: [clang-format][NFC] Fix typos and inconsistencies (authored by kuzkry, committed by owenpan). Repository: rG LLVM Github Monorepo

[clang] aacc110 - [clang-format][NFC] Fix typos and inconsistencies

Author: Krystian Kuzniarek Date: 2022-02-20T17:20:34-08:00 New Revision: aacc110bdce71d1405d820cf282196855afeee26 URL: https://github.com/llvm/llvm-project/commit/aacc110bdce71d1405d820cf282196855afeee26 DIFF:

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2449 } else { - addUnwrappedLine(); - ++Line->Level; - parseStructuralElement(); - if (FormatTok->is(tok::eof)) -addUnwrappedLine(); - --Line->Level; +

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410191. tianshilei1992 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D120221: [AST] Fix typos

kuzkry added a comment. Can I ask you to deliver this one for me? I don't have permissions. My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120221/new/ https://reviews.llvm.org/D120221

[PATCH] D120221: [AST] Fix typos

kuzkry created this revision. kuzkry added a project: clang. kuzkry requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120221 Files: clang/lib/AST/ASTDiagnostic.cpp Index: clang/lib/AST/ASTDiagnostic.cpp

[PATCH] D120220: [clang-format] Fix typos and consistency

kuzkry added a comment. Can I ask you to deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120220/new/ https://reviews.llvm.org/D120220

[PATCH] D120220: [clang-format] fix typos and consistency

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

njames93 updated this revision to Diff 410187. njames93 marked 2 inline comments as done. njames93 added a comment. Remove double negative Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118927/new/ https://reviews.llvm.org/D118927 Files:

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

njames93 updated this revision to Diff 410186. njames93 marked an inline comment as done. njames93 added a comment. Update description and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118900/new/ https://reviews.llvm.org/D118900

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 +static FormatToken *getLastNonComment(const UnwrappedLine ) { + for (const auto : llvm::reverse(Line.Tokens)) +if (Token.Tok->isNot(tok::comment)) Get the

[PATCH] D119562: [clang-tidy] Provide fine control of color in run-clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc57b8ca721dd: [clang-tidy] Provide fine control of color in run-clang-tidy (authored by kesyog, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c57b8ca - [clang-tidy] Provide fine control of color in run-clang-tidy

Author: Kesavan Yogeswaran Date: 2022-02-20T22:00:28Z New Revision: c57b8ca721dd2e88ed96b7df65a518fdab738445 URL: https://github.com/llvm/llvm-project/commit/c57b8ca721dd2e88ed96b7df65a518fdab738445 DIFF: https://github.com/llvm/llvm-project/commit/c57b8ca721dd2e88ed96b7df65a518fdab738445.diff

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f310d1967c2: [clang-format][docs] Fix incorrect clang-format 13 configuration ... (authored by kuzkry, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119923: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b139923bc66: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9a7fdd6a8a: [clang-format] Fixed handling of requires clauses followed by attributes (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8f310d1 - [clang-format][docs] Fix incorrect 'clang-format 13' configuration ...

Author: Krystian Kuzniarek Date: 2022-02-20T22:33:27+01:00 New Revision: 8f310d1967c20d348c617af3a30999031c71fee0 URL: https://github.com/llvm/llvm-project/commit/8f310d1967c20d348c617af3a30999031c71fee0 DIFF:

[clang] 9b13992 - [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

Author: Björn Schäpers Date: 2022-02-20T22:33:27+01:00 New Revision: 9b139923bc6634c2d1667c54000debe00e7858f4 URL: https://github.com/llvm/llvm-project/commit/9b139923bc6634c2d1667c54000debe00e7858f4 DIFF:

[clang] be9a7fd - [clang-format] Fixed handling of requires clauses followed by attributes

Author: Björn Schäpers Date: 2022-02-20T22:33:26+01:00 New Revision: be9a7fdd6a8aec669bcb1f6a68087ab4a70ddb2e URL: https://github.com/llvm/llvm-project/commit/be9a7fdd6a8aec669bcb1f6a68087ab4a70ddb2e DIFF:

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

curdeius added a comment. Nice! A few minor comments though. Comment at: clang/include/clang/Format/Format.h:2572-2573 + /// Insert braces after control statements (``if``, ``else``, ``for``, ``do``, + /// and ``while``) in C++. + /// \warning Please add

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius planned changes to this revision. curdeius added a comment. This commit provokes failures in formatting tests of polly. Cf. https://lab.llvm.org/buildbot/#/builders/205/builds/3320. That's probably because of ) being annotated as CastRParen instead of Unknown before, hence being kept

[clang] 4701bca - Revert "[clang-format] Avoid inserting space after C++ casts."

Author: Marek Kurdej Date: 2022-02-20T22:19:51+01:00 New Revision: 4701bcae974704a336ac8e111d5b104f4834099c URL: https://github.com/llvm/llvm-project/commit/4701bcae974704a336ac8e111d5b104f4834099c DIFF: https://github.com/llvm/llvm-project/commit/4701bcae974704a336ac8e111d5b104f4834099c.diff

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410180. tianshilei1992 added a comment. fnish all checks and add note messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:33 LINK_LIBS + clangAnalysis clangTidy sammccall wrote: > JonasToth wrote: > > njames93 wrote: > > >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 410179. JonasToth marked 14 inline comments as done. JonasToth added a comment. - address reviews comments, part 1 - Merge branch 'main' into feature_rebase_const_transform_20210808 - fixing iterator-to-bool conversion and addressing other more review

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGe021987273be: [clang-format] Avoid inserting space after C++ casts. (authored by curdeius). Changed prior to commit:

[clang] e021987 - [clang-format] Avoid inserting space after C++ casts.

Author: Marek Kurdej Date: 2022-02-20T21:58:37+01:00 New Revision: e021987273bece6e94bc6f43b6b5232de10637c8 URL: https://github.com/llvm/llvm-project/commit/e021987273bece6e94bc6f43b6b5232de10637c8 DIFF: https://github.com/llvm/llvm-project/commit/e021987273bece6e94bc6f43b6b5232de10637c8.diff

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9567babef30: Fix extraneous whitespace addition in line comments on clang-format directives (authored by penagos, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d9567ba - Fix extraneous whitespace addition in line comments on clang-format directives

Author: Luis Penagos Date: 2022-02-20T21:53:50+01:00 New Revision: d9567babef302cfd7e827df64138151ba2614b83 URL: https://github.com/llvm/llvm-project/commit/d9567babef302cfd7e827df64138151ba2614b83 DIFF: https://github.com/llvm/llvm-project/commit/d9567babef302cfd7e827df64138151ba2614b83.diff

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This new option `InsertBraces` has been

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added a comment. Will you still work on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116290/new/ https://reviews.llvm.org/D116290 ___ cfe-commits mailing list

[PATCH] D119562: [clang-tidy] Provide fine control of color in run-clang-tidy

kesyog added a comment. I don't have commit privileges, so I'll need help committing this to `main`. My name is "Kesavan Yogeswaran" and my email is hikes [at] google [dot] com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/

[clang] ce0fdf1 - Put back err_drv_negative_columns/err_drv_small_columns for flang

Author: Benjamin Kramer Date: 2022-02-20T15:42:20+01:00 New Revision: ce0fdf116334506bd5c4609ab86111f8136a1408 URL: https://github.com/llvm/llvm-project/commit/ce0fdf116334506bd5c4609ab86111f8136a1408 DIFF:

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos added a comment. I don’t have commit rights; if someone could commit on my behalf that’d be great. - Luis Penagos - l...@penagos.co Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188

[clang-tools-extra] 3a1d6a3 - [clangd] Remove uuidof warning. Clang never emits this one.

Author: Benjamin Kramer Date: 2022-02-20T14:44:47+01:00 New Revision: 3a1d6a361c822173abd87ff47fd8613892fc747f URL: https://github.com/llvm/llvm-project/commit/3a1d6a361c822173abd87ff47fd8613892fc747f DIFF:

[clang] 52fcdc8 - Prune unused diagnostics. NFC.

Author: Benjamin Kramer Date: 2022-02-20T14:06:58+01:00 New Revision: 52fcdc8d69d20b48fb5266b00f505dc89b19be9b URL: https://github.com/llvm/llvm-project/commit/52fcdc8d69d20b48fb5266b00f505dc89b19be9b DIFF:

[clang] 51c0650 - Unionize clang::DynTypedNodeList. NFC.

Author: Benjamin Kramer Date: 2022-02-20T12:12:39+01:00 New Revision: 51c0650f6ba8128fb07036b4be8512bb5f727c1a URL: https://github.com/llvm/llvm-project/commit/51c0650f6ba8128fb07036b4be8512bb5f727c1a DIFF:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

carlosgalvezp added a comment. I tried to download the diff and apply it from the root of llvm-project, but I must be doing something wrong... $ git apply D117522.diff D117522.diff:808: trailing whitespace. - attempt to free an illegal D117522.diff:809:

[PATCH] D119562: [clang-tidy] Provide fine control of color in run-clang-tidy

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:69 + val = val.lower() + if val in ['', 'true', '1']: +return True Didn't

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:1536 void MatchFinder::match(const clang::DynTypedNode , ASTContext ) { internal::MatchASTVisitor Visitor(, Options); Visitor.set_active_ast_context(); Is there a

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 410139. njames93 added a comment. Moved TraceReporter into the MatchASTVisitor class Added some missing new lines Fixed patch not being based off a commit in trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

kimgr added a comment. Having looked at this some more, I wonder if this patch is covering for another problem. Running even the simplest example fails on an assertion in `Sema::BuildCXXTypeConstructExpr`: https://godbolt.org/z/fMPcsh4f3. It looks like that function is creating the majority of

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

njames93 added a comment. In D113422#992 , @carlosgalvezp wrote: > Nothing other than readability, `CachedGlobList` //is a// `GlobList` so it > made sense to implement it with standard, by-the-book inheritance. But no, > it's not used

[clang] 6738792 - Revert "[C++20][Modules][1/8] Track valid import state."

Author: Iain Sandoe Date: 2022-02-20T10:22:07Z New Revision: 673879249d4d1c4e6d763a6db4a4812d721b41b6 URL: https://github.com/llvm/llvm-project/commit/673879249d4d1c4e6d763a6db4a4812d721b41b6 DIFF: https://github.com/llvm/llvm-project/commit/673879249d4d1c4e6d763a6db4a4812d721b41b6.diff LOG:

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added a comment. In D113422#748 , @njames93 wrote: > Was there any real use case for making this polymorphic, The overhead for a > virtual function call seems a little unnecessary IMO? Nothing other than readability, `CachedGlobList`

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3f9a584ad4: [C++20][Modules][1/8] Track valid import state. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/

[clang] 8a3f9a5 - [C++20][Modules][1/8] Track valid import state.

Author: Iain Sandoe Date: 2022-02-20T10:13:57Z New Revision: 8a3f9a584ad43369cf6a034dc875ebfca76d9033 URL: https://github.com/llvm/llvm-project/commit/8a3f9a584ad43369cf6a034dc875ebfca76d9033 DIFF: https://github.com/llvm/llvm-project/commit/8a3f9a584ad43369cf6a034dc875ebfca76d9033.diff LOG:

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Thanks a lot! Do you have commit rights or you want someone to land it for you? For the latter, we'll need your name and email for the commit attribution. Repository: rG LLVM

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. @hubert.reinterpretcast Gentle ping in case you didn't see Aaron's message - there isn't too much urgency though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400

[PATCH] D120205: Restore documentation for __builtin_assume

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, vdelvecc. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This got removed by 6cacd420a1d72bca7809e6b516fb1e18ac6056c8