[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3921 + return cast(GVE); +return dyn_cast_or_null(N); + } aprantl wrote: > When would we enter a nullptr into the cache? In this change, only llvm::DIImportedEntity

[PATCH] D121446: Add -no-unused-coverage option

Hiralo created this revision. Hiralo added a reviewer: vsk. Hiralo added a project: clang. Herald added subscribers: dexonsmith, wenlei, dang. Herald added a project: All. Hiralo requested review of this revision. Herald added a subscriber: cfe-commits. commit

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 414577. kavitha-natarajan added a comment. @aprantl Updated the comments following LLVM coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, kito.cheng, rsmith, asb, DavidSpickett, kaz7. Herald added subscribers: krytarowski, mgorny. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414583. lkail added a comment. Add `-verify`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Hi @ftynse , could you please take a look at it and see if there is anything that should be changed? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414575. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index:

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414574. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index:

[PATCH] D121434: [clang-format][NFC] Group QualifierAlignment with other C++ passes

owenpan updated this revision to Diff 414572. owenpan added a comment. Swapped the order of the definitions of `BracesRemover` and `BracesInserter`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121434/new/ https://reviews.llvm.org/D121434 Files: clang/lib/Format/Format.cpp Index:

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC. Herald added subscribers: steven.zhang, shchenz, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai updated this revision to Diff 414565. vsapsai added a comment. Fix tests on Debian by using `-fobjc-nonfragile-abi` explicitly as declaring ivars in extensions is supported only with non-fragile ABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

This revision was automatically updated to reflect the committed changes. Closed by commit rG25df633c243f: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV… (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120976: [AMDGPU] Add llvm.amdgcn.s.setprio intrinsic

kerbowa updated this revision to Diff 414559. kerbowa added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add clang builtin and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120976/new/

[PATCH] D121434: [clang-format][NFC] Group QualifierAlignment with other C++ passes

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121431/new/ https://reviews.llvm.org/D121431

[PATCH] D121359: [AVR] Add more devices

benshi001 updated this revision to Diff 414538. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121359/new/ https://reviews.llvm.org/D121359 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Driver/ToolChains/AVR.cpp clang/test/Misc/target-invalid-cpu-note.c

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

4vtomat created this revision. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} andrew.w.kaylor wrote: > Unfortunately, I don't think it's this

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

efriedma added a comment. That makes sense, sure. -fms-compatibility is on by default for clang-cl anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

rnk added a subscriber: rsmith. rnk added a comment. @rsmith has previously advocated for a policy of only permitting conforming language extensions under fms-extensions. These single underscore names are not in the implementors namespace, so he has argued they should be under

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120474/new/ https://reviews.llvm.org/D120474

[PATCH] D120465: [clang][deps] Disable implicit module maps

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273 + // However, some module maps loaded implicitly during the dependency scan can + // describe anti-dependencies. That happens when the current module is marked +

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

bnbarham abandoned this revision. bnbarham added a comment. Herald added a project: All. Rather than trying to fix nested RedirectingFileSystems, I've instead put up a bunch of patches to simplify RedirectingFileSystem. This does mean we can't "chain" remappings any more, but that seems like a

[PATCH] D121427: [lit] add lit_config.substitute to interpolate lit_config.params

sammccall created this revision. sammccall added reviewers: aaron.ballman, hokein. Herald added subscribers: usaxena95, kadircet, arphaman, delcypher. Herald added a project: All. sammccall requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers:

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham added inline comments. Comment at: llvm/include/llvm/Support/Error.h:1284 - StringRef getFileName() { return FileName; } + StringRef getFileName() const { return FileName; } Should this be in a change all by itself? Repository: rG LLVM Github

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham created this revision. bnbarham added reviewers: keith, dexonsmith, JDevlieghere, vsapsai. Herald added a subscriber: carlosgalvezp. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added

[PATCH] D121422: [clang-tools-extra] Reuse llvm_config.use_clang() to set up test environment

sammccall created this revision. sammccall added reviewers: aaron.ballman, hokein. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project:

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; Are you sure you want to change

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} Unfortunately, I don't think it's this easy. The list of

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGd54c4df31470: [clang-format] Fix namespace format when the name is followed by a macro (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D121269?vs=414442=414506#toc

[clang] d54c4df - [clang-format] Fix namespace format when the name is followed by a macro

Author: Zequan Wu Date: 2022-03-10T15:00:32-08:00 New Revision: d54c4df31470044a66605ebb8a2f936e8dd552af URL: https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af DIFF: https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af.diff

[clang-tools-extra] 7f0df31 - [clang-tools-extra] Don't consider python below LLVM_MINIMUM_PYTHON_VERSION. NFC

Author: Sam McCall Date: 2022-03-10T23:57:27+01:00 New Revision: 7f0df31ee3f596c36a0bb6af4248aaf431541e3a URL: https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a DIFF: https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a.diff

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

andrew.w.kaylor added a comment. This example illustrates the problem this patch intends to fix: https://godbolt.org/z/j445sxPMc For Intel microarchitectures before Skylake, the LLVM cost model says that vector fsqrt is slow, so if fast-math is enabled, we'll use an approximation rather than

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG27a574962567: [Sema][Windows] Dont special-case void* in __unaligned conversions. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 27a5749 - [Sema][Windows] Don't special-case void* in __unaligned conversions.

Author: Eli Friedman Date: 2022-03-10T14:49:16-08:00 New Revision: 27a574962567224d3a36a70cf8abf0ad3d751ec5 URL: https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5 DIFF: https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5.diff

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

efriedma updated this revision to Diff 414499. efriedma added a comment. Drop _except; __except is a contextual keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412 Files:

[PATCH] D120857: WIP [randstruct] Add randomize structure layout support

void updated this revision to Diff 414500. void added a comment. Improve bad cast warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h

[clang] 0be56c8 - [clang-format][NFC] Group all C++ passes under isCpp()

Author: owenca Date: 2022-03-10T14:30:30-08:00 New Revision: 0be56c87013b585405209f324cc8dfc5ebde416f URL: https://github.com/llvm/llvm-project/commit/0be56c87013b585405209f324cc8dfc5ebde416f DIFF: https://github.com/llvm/llvm-project/commit/0be56c87013b585405209f324cc8dfc5ebde416f.diff LOG:

[clang-tools-extra] 2d58ba2 - [clang-tools-extra] Remove unused lit features/substitutions. NFCI

Author: Sam McCall Date: 2022-03-10T23:28:43+01:00 New Revision: 2d58ba200a39ddacaa9923cb623321c295ae5949 URL: https://github.com/llvm/llvm-project/commit/2d58ba200a39ddacaa9923cb623321c295ae5949 DIFF: https://github.com/llvm/llvm-project/commit/2d58ba200a39ddacaa9923cb623321c295ae5949.diff

[clang-tools-extra] 6ed2f89 - Fix reference to execute_external leftover in 69924ccf7a328f

Author: Sam McCall Date: 2022-03-10T23:20:03+01:00 New Revision: 6ed2f8902b8f109ead47e20a519860c803900d29 URL: https://github.com/llvm/llvm-project/commit/6ed2f8902b8f109ead47e20a519860c803900d29 DIFF: https://github.com/llvm/llvm-project/commit/6ed2f8902b8f109ead47e20a519860c803900d29.diff

[clang-tools-extra] 69924cc - Remove redundant lit config already handled in llvm_config. NFCI

Author: Sam McCall Date: 2022-03-10T23:11:01+01:00 New Revision: 69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c URL: https://github.com/llvm/llvm-project/commit/69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c DIFF: https://github.com/llvm/llvm-project/commit/69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c.diff

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev updated this revision to Diff 414494. v.g.vassilev added a comment. Order fwd decls alphabetically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/ https://reviews.llvm.org/D121413 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, lhames, sgraenitz. Herald added a project: All. v.g.vassilev requested review of this revision. This patch will allow better incremental adoption of these changes in downstream cling and other users which want to

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

efriedma created this revision. efriedma added reviewers: rnk, mstorsjo. Herald added a subscriber: dexonsmith. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. List derived from https://docs.microsoft.com/en-us/cpp/cpp/keywords-cpp . Not

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane added a comment. @aaron.ballman : if you can add other reviewers or subscribers (particularly those from "VendorA") it would be greatly appreciated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. erichkeane requested review of this revision. Due to various implementation constraints, despite the programmer choosing a 'processor'

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

v.g.vassilev added a comment. Herald added a project: All. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119675/new/ https://reviews.llvm.org/D119675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121352: [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b219bded11: [clang-format] Handle // clang-format off for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e2b219b - [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

Author: owenca Date: 2022-03-10T13:30:53-08:00 New Revision: e2b219bded113160500d1084f87ee11ec926877b URL: https://github.com/llvm/llvm-project/commit/e2b219bded113160500d1084f87ee11ec926877b DIFF: https://github.com/llvm/llvm-project/commit/e2b219bded113160500d1084f87ee11ec926877b.diff LOG:

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:108 + // which one is name. For example, `namespace A B {`. + while (Tok && !Tok->is(tok::l_brace)) { +if (FirstNSTok) {

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15ef06f453c6: Diagnose when `#pragma clang fp eval_method` doesnt have a supported value. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 15ef06f - Diagnose when `#pragma clang fp eval_method` doesn't have a supported value.

Author: Zahira Ammarguellat Date: 2022-03-10T13:19:53-08:00 New Revision: 15ef06f453c6f9513b476e80dd9567d01fc662e8 URL: https://github.com/llvm/llvm-project/commit/15ef06f453c6f9513b476e80dd9567d01fc662e8 DIFF:

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG035441ff3008: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 035441f - [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

Author: Kirill Stoimenov Date: 2022-03-10T21:11:32Z New Revision: 035441ff3008c2a1930363751c6db61b71a5f089 URL: https://github.com/llvm/llvm-project/commit/035441ff3008c2a1930363751c6db61b71a5f089 DIFF: https://github.com/llvm/llvm-project/commit/035441ff3008c2a1930363751c6db61b71a5f089.diff

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { aaron.ballman wrote: > What should happen in a case like this? > ``` > int whatever(float a, float b, float c) { >

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk planned changes to this revision. kwk added a comment. A test if failing. Need to address this first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 ___

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. Thanks for this, I plan on giving it a more thorough review when I can. But the summary led me to a design question: why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but maybe we can chat about that later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121405/new/

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. Thank you for your comments! I've addressed many of them and now address the rest. Comment at: clang/lib/Format/Format.cpp:2759 + IncludeName = + StringRef(Twine("<", IncludeName).concat(Twine(">")).str()); +}

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 414469. kwk marked 2 inline comments as done. kwk added a comment. - Make @ or # not optional again - Remove [\t\n\ \\]* - Properly concat string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { What should happen in a case like this? ``` int whatever(float a, float b, float c) { #pragma

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/eval-method-fast-math.c

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414460. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu updated this revision to Diff 414442. zequanwu marked 7 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 Files:

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), zahiraam wrote: > aaron.ballman wrote: > >

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

aprantl added a comment. Ideally, this would be fixed in GDB. If that's really not feasibly I would rather like to see this as a gdb debugger tuning instead f the default behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121100/new/

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), aaron.ballman wrote: > Shouldn't this be looking

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3373139 , @philnik wrote: > In D121078#3373081 , @SimplyDanny > wrote: > >> I'm happy that you found a reasonable compromise. I like it too. ;) >> >> Now, I ask you to

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), Shouldn't this be looking at

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3373173 , @tstellar wrote: > In D118511#3373082 , @dblaikie > wrote: > >> In D118511#3372728 , @jyknight >> wrote: >> >>> In

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2713-2714 +/// \endcode +extern const internal::VariadicDynCastAllOfMatcher +attributedStmt; + sammccall wrote: > aaron.ballman wrote: > > sammccall wrote: > > >

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

sammccall added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2713-2714 +/// \endcode +extern const internal::VariadicDynCastAllOfMatcher +attributedStmt; + aaron.ballman wrote: > sammccall wrote: > > jdoerfert wrote: > > >

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. In D118511#3373082 , @dblaikie wrote: > In D118511#3372728 , @jyknight > wrote: > >> In D118511#3371432 , @tstellar >> wrote: >> >>> I'm fine

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414424. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2733 +/// \endcode +AST_MATCHER_P(AttributedStmt, isAttr, attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), sammccall wrote: > This definitely seems more

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414416. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3372728 , @jyknight wrote: > In D118511#3371432 , @tstellar > wrote: > >> I'm fine with reverting if you think this is the best solution. I just >> would like to conclude

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. I'm happy that you found a reasonable compromise. I like it too. ;) Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a tiny tweak to the diagnostic. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1493 + "'ignore', 'maytrap' or 'strict'|" + "'source'

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

dblaikie added a comment. Yeah, happy to hear other perspectives - but my rough reaction is similar: putting mangled names in the "name" field seems problematic (consumer wouldn't necessarily know that the name should be demangled, for instance? Maybe?). So at the IR level maybe it's better to

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

dblaikie added a comment. Fixes in LLVM require tests in LLVM - probably taking the clang test and compiling that to llvm IR (include the original C++ source in a comment in the IR test case) and then testing it in LLVM instead of clang. Also looks like the test could be simplified a bit more:

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal created this revision. steakhal added reviewers: aaron.ballman, NoQ, Szelethus, whisperity, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp:33 static constexpr char StdTypeTraitsHeader[] = R"( +#ifndef TYPE_TRAITS_H +#define TYPE_TRAITS_H

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev updated this revision to Diff 414396. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121378/new/ https://reviews.llvm.org/D121378 Files:

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:64 static BoolValue *getHasValue(Value *Val) { - if (auto *OptionalVal

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Diagnose when `#pragma clang fp eval_method` doesn't have a supported value. Currently the compiler is

[PATCH] D120989: Support debug info for alias variable

aprantl added a comment. This looks mostly fine to me, I have a couple of superficial comments inline. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3914 + // imported declaration + auto IE = ImportedDeclCache.find(D->getCanonicalDecl()); Nit: The LLVM

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

jyknight added a comment. In D118511#3371432 , @tstellar wrote: > I'm fine with reverting if you think this is the best solution. I just would > like to conclude soon so I can make the final release candidate. ISTM that reverting the ABI change in the

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Model `make_optional`, optional's default

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

raj.khem added a comment. Herald added a project: All. In D119590#3316050 , @JonChesterfield wrote: > Cross compilers are a hazard here. I'd expect there to be a fairly long list > of magic flags you need to pass to clang to get it to find the right >

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne added a comment. In D120727#3372594 , @mstorsjo wrote: > FWIW I think D116689 interacts with this > somewhat. I think D116689 is useful for > the fixes I want to do wrt

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/DirectiveMap.h:123 +/// The choices are stored in Conditional::Taken nodes. +void chooseConditionalBranches(DirectiveMap &, const TokenStream ); + off-topic: a random idea on the

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 414371. jhuber6 added a comment. Herald added subscribers: abrachet, phosek. Fix architecture parsing and still include the GPU binary so cuobjcopy can use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2685 const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#]?[\t\ ]*(import|include)[^"<]*[\t\n\ \\]*("[^"]+"|<[^>]+>|[^"<>;]+;))";

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2685 const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#]?[\t\ ]*(import|include)[^"<]*[\t\n\ \\]*("[^"]+"|<[^>]+>|[^"<>;]+;))";

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + xbolva00 wrote: > awarzynski wrote: > > xbolva00 wrote: > > > mllvm > > Does it matter? `-mllvm` is consistent with other tests in this directory > > (e.g.

  1   2   >