[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 added a comment. This patch fixes the issue https://github.com/llvm/llvm-project/issues/45485 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 ___ cfe-commits mailing list

[clang] 62bcfcb - [AMDGPU] Add llvm.amdgcn.s.setprio intrinsic

Author: Austin Kerbow Date: 2022-03-12T22:15:42-08:00 New Revision: 62bcfcb5a588e5e844f8e4e42a2e4d15c907a746 URL: https://github.com/llvm/llvm-project/commit/62bcfcb5a588e5e844f8e4e42a2e4d15c907a746 DIFF: https://github.com/llvm/llvm-project/commit/62bcfcb5a588e5e844f8e4e42a2e4d15c907a746.diff

[PATCH] D120976: [AMDGPU] Add llvm.amdgcn.s.setprio intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62bcfcb5a588: [AMDGPU] Add llvm.amdgcn.s.setprio intrinsic (authored by kerbowa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

This revision was automatically updated to reflect the committed changes. Closed by commit rG036088fd6ea2: [MLIR][Python] Add SCFIfOp Python binding (authored by chhzh123, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Passed pre-merge checks. Should be able to be merged. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414900. chhzh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. Noting for myself: Clang's status quo already has behaviours that are similar to P2242R3 in its C++20 mode despite those behaviours being non-conforming and contributing to binary compat breakage with GCC. This patch is not responsible for those

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. How to get this revision committed? I thought it would happen automatically now that it is accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599

[PATCH] D121512: [Support] Change zlib::compress to return void

MaskRay updated this revision to Diff 414896. MaskRay retitled this revision from "[Support] zlib::compress: replace compress2 with iterative deflate" to "[Support] Change zlib::compress to return void". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 414892. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121099/new/ https://reviews.llvm.org/D121099 Files: clang/include/clang/Driver/Options.td

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 414891. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 414890. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/new/ https://reviews.llvm.org/D121097 Files: clang/include/clang/Serialization/ASTWriter.h

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:157 + unsigned HeaderUnit : 3; + unsigned Header : 1; ChuanqiXu wrote: > I prefer `IsHeader` OK. Comment at:

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains updated this revision to Diff 414889. iains marked 6 inline comments as done. iains added a comment. rebased, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 Files:

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

iains added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2978-2980 + /// The parser has begun a translation unit to be compiled as a C++20 + /// Header Unit. + void ActOnStartOfHeaderUnit(); ChuanqiXu wrote: > From the implementation, I think

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

iains updated this revision to Diff 414888. iains marked 4 inline comments as done. iains added a comment. rebased, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121095/new/ https://reviews.llvm.org/D121095 Files:

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9106a07f1fcb: [clang-format][docs] Fix incorrect clang-format 12 option markers (authored by kuzkry, committed by HazardyKnusperkeks). Repository:

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4d68bf65ef: [clang-format] Handle builtins in constraint expression (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D120774?vs=413430=414881#toc Repository: rG

[clang] 9106a07 - [clang-format][docs] Fix incorrect 'clang-format 12' option markers

Author: Krystian Kuzniarek Date: 2022-03-12T22:49:57+01:00 New Revision: 9106a07f1fcb4bd425a3ef2f9f3e2b68bc1ad916 URL: https://github.com/llvm/llvm-project/commit/9106a07f1fcb4bd425a3ef2f9f3e2b68bc1ad916 DIFF:

[clang] 8b4d68b - [clang-format] Handle builtins in constraint expression

Author: Björn Schäpers Date: 2022-03-12T22:44:24+01:00 New Revision: 8b4d68bf65ef145333aae82683b5fcee29b38dc2 URL: https://github.com/llvm/llvm-project/commit/8b4d68bf65ef145333aae82683b5fcee29b38dc2 DIFF:

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

HazardyKnusperkeks added a comment. Your patches are not directly applicable. You have --- clang/include/clang/Format/Format.h +++ clang/include/clang/Format/Format.h instead of --- a/clang/include/clang/Format/Format.h +++ b/clang/include/clang/Format/Format.h which results in $

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 414880. cor3ntin added a comment. - Rebase - Update cxx_status as we are now targeting clang 15 - Test the pre-C++2b warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f320ca4ba15: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie (authored by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414878. keith added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 414872. yonghong-song added a comment. - fix one 'auto' declaration issue - rework on the test with overloadable attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files:

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Thanks, sounds good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D120610

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code for traversing precompiled dependencies is somewhat

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:79 + + auto ReadLabelAttrubutes = [&] { +// Read label attributes, if present. aaron.ballman wrote: > However, I don't think there's a

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other types, when lambdas are instanciated,

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 414868. ArcsinX added a comment. - get attributes location from ParsedAttributesWithRange object - parse subsequent attributes of different kinds in a loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414866. keith added a comment. Herald added a project: All. Update default to latest known CPU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files:

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith added a comment. Herald added subscribers: cfe-commits, carlosgalvezp. Herald added a project: All. Ping, it seems like https://reviews.llvm.org/D101037 is stalled but the docs at this point state py >=3.6 is required for working on llvm so I think we're good here

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. Herald added a project: All. In D109977#3282545 , @MaskRay wrote: > I have tried the latest diff but > `-DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;flang;lldb;lld;compiler-rt;openmp;mlir;cross-project-tests' >

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

mehdi_amini added a comment. Seems like there is a local base commit in your repository: you're not uploading a diff that applies on HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfe58b09df9: [clang-format] Minimize the damage caused by AlignArrayOfStructures when… (authored by MyDeveloperDay). Repository: rG LLVM Github

[clang] adfe58b - [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

Author: mydeveloperday Date: 2022-03-12T17:22:31Z New Revision: adfe58b09df957f8911c5e152daa9564e5931631 URL: https://github.com/llvm/llvm-project/commit/adfe58b09df957f8911c5e152daa9564e5931631 DIFF: https://github.com/llvm/llvm-project/commit/adfe58b09df957f8911c5e152daa9564e5931631.diff

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 414857. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Fixing final review comments prior to commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121069/new/ https://reviews.llvm.org/D121069 Files:

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. I've rebased to the latest commit in the main branch, but the pre-merge checks still failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414852. chhzh123 added a comment. Try rebasing again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur updated this revision to Diff 414848. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414847. chhzh123 added a comment. Rebase 3 commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414845. chhzh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/test/python/dialects/scf.py Index:

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch gets rid of the ridiculous relative path we use to invoke

[clang] 913107f - [clang][deps] Update helper script documentation

Author: Jan Svoboda Date: 2022-03-12T16:55:38+01:00 New Revision: 913107fa1fb1ea680f1f079a1cdfc5f05a7bfb0b URL: https://github.com/llvm/llvm-project/commit/913107fa1fb1ea680f1f079a1cdfc5f05a7bfb0b DIFF: https://github.com/llvm/llvm-project/commit/913107fa1fb1ea680f1f079a1cdfc5f05a7bfb0b.diff

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

jansvoboda11 added a reviewer: Bigcheese. jansvoboda11 added a comment. In case you want to do a post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121516/new/ https://reviews.llvm.org/D121516

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b13f7a2f7f: [clang][deps] Simplify PREFIX definitions in tests (authored by jansvoboda11). Repository: rG LLVM

[clang] c4b13f7 - [clang][deps] Simplify PREFIX definitions in tests

Author: Jan Svoboda Date: 2022-03-12T16:45:09+01:00 New Revision: c4b13f7a2f7f74006f2436ef431093d13d94f1f3 URL: https://github.com/llvm/llvm-project/commit/c4b13f7a2f7f74006f2436ef431093d13d94f1f3 DIFF: https://github.com/llvm/llvm-project/commit/c4b13f7a2f7f74006f2436ef431093d13d94f1f3.diff

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur updated this revision to Diff 414826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur updated this revision to Diff 414825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur updated this revision to Diff 414824. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur added a comment. https://github.com/llvm/llvm-project/issues/54347 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 ___ cfe-commits mailing list

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur created this revision. Herald added a project: All. ecatmur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang correctly rejects as ambiguous: template int f(T&, int); // 1 template int f(T const&, U); // 2 int g(int const& i)

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

jansvoboda11 created this revision. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of outputting the test directory into the JSON result file, parsing it with `FileCheck` and then

[clang] 4d6835f - [clang][deps] Attempt to fix Windows test failure

Author: Jan Svoboda Date: 2022-03-12T12:09:22+01:00 New Revision: 4d6835f96d610c59c6558f571214e6c42097fec9 URL: https://github.com/llvm/llvm-project/commit/4d6835f96d610c59c6558f571214e6c42097fec9 DIFF: https://github.com/llvm/llvm-project/commit/4d6835f96d610c59c6558f571214e6c42097fec9.diff

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf4a31fc0f97: [clang][deps] Remove -fmodules-cache-path= arguments (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cf4a31f - [clang][deps] Remove '-fmodules-cache-path=' arguments

Author: Jan Svoboda Date: 2022-03-12T11:42:07+01:00 New Revision: cf4a31fc0f9745dabbd7d9cba56a6a9045a026d0 URL: https://github.com/llvm/llvm-project/commit/cf4a31fc0f9745dabbd7d9cba56a6a9045a026d0 DIFF: https://github.com/llvm/llvm-project/commit/cf4a31fc0f9745dabbd7d9cba56a6a9045a026d0.diff

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f6af607464e: [clang][deps] Generate -fmodule-file= only for direct dependencies (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] 7f6af60 - [clang][deps] Generate '-fmodule-file=' only for direct dependencies

Author: Jan Svoboda Date: 2022-03-12T11:32:51+01:00 New Revision: 7f6af607464e5bcf2bd8b7bc7724a5985d7a0c34 URL: https://github.com/llvm/llvm-project/commit/7f6af607464e5bcf2bd8b7bc7724a5985d7a0c34 DIFF: https://github.com/llvm/llvm-project/commit/7f6af607464e5bcf2bd8b7bc7724a5985d7a0c34.diff

[clang] a6ef363 - [clang][deps] Disable implicit module maps

Author: Jan Svoboda Date: 2022-03-12T11:07:21+01:00 New Revision: a6ef3635461c7e689972337b281d0052331f6150 URL: https://github.com/llvm/llvm-project/commit/a6ef3635461c7e689972337b281d0052331f6150 DIFF: https://github.com/llvm/llvm-project/commit/a6ef3635461c7e689972337b281d0052331f6150.diff

[PATCH] D120465: [clang][deps] Disable implicit module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ef3635461c: [clang][deps] Disable implicit module maps (authored by jansvoboda11). Changed prior to commit:

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. @MyDeveloperDay Will you please accept this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:578 +break; + LLVM_FALLTHROUGH; owenpan wrote: > Can we remove this empty line? Will do. Comment at: