[PATCH] D121757: [clang-format] Take out common code for parsing blocks

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. Because this patch would impact inserting/removing braces, we must test it against a large codebase. Before I landed `RemoveBracesLLVM` and `InsertBraces`, I had tested them with

[PATCH] D121846: [clang-format] Correctly recognize binary operators in template arguments with parenthesized literals.

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2186 + NextNonParen = NextNonParen->getNextNonComment(); +} +if (NextNonParen && (NextNonParen->Tok.isLiteral() || Remove braces. :)

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

khchen updated this revision to Diff 416057. khchen added a comment. Herald added subscribers: s, arichardson. rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120228/new/ https://reviews.llvm.org/D120228 Files:

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 4 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:133 Left->ParentBracket != tok::less && -(isKeywordWithCondition(*Line.First) || - CurrentToken->getStartOfNonWhitespace()

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 416052. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:947 + /* C# */ \ + KEYWORD(dollar, 0)

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw updated this revision to Diff 416051. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121753/new/ https://reviews.llvm.org/D121753 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. I have updated the patch. Any more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Plan to land tomorrow morning. Test passes on the Debian bot : PASS: LLVM :: Transforms/LowerGlobalDestructors/lower-global-dtors.ll (72299 of 93291) Repository: rG

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. I've added 2 additional calls to `initializeLowerGlobalDtorsLegacyPassPass()`. The one in the constructor of the legacy pass should ensure that the pass is always registered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. I don't have an example module sadly. It was something that I ran into with Swift code import the WinSDK module defined in https://github.com/apple/swift/blob/main/stdlib/public/Platform/winsdk.modulemap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb96464f12c4: Stricter use-after-dtor detection for trivial members. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5ea8e913893: Use-after-dtor detection for trivial base classes. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github

[clang] cb96464 - Stricter use-after-dtor detection for trivial members.

Author: Evgenii Stepanov Date: 2022-03-16T18:20:27-07:00 New Revision: cb96464f12c44320150c48d639070cf0e4fd8bd2 URL: https://github.com/llvm/llvm-project/commit/cb96464f12c44320150c48d639070cf0e4fd8bd2 DIFF:

[clang] c5ea8e9 - Use-after-dtor detection for trivial base classes.

Author: Evgenii Stepanov Date: 2022-03-16T18:20:27-07:00 New Revision: c5ea8e9138931b74b60221f667da304e244dc57d URL: https://github.com/llvm/llvm-project/commit/c5ea8e9138931b74b60221f667da304e244dc57d DIFF:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.cpp:67-68 + +// Undefining a macro invalidates adjacent macros +// from being considered as an enum.

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121815/new/ https://reviews.llvm.org/D121815

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

vitalybuka updated this revision to Diff 416040. vitalybuka added a comment. addressing some @kda comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119300/new/ https://reviews.llvm.org/D119300 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

This revision was automatically updated to reflect the committed changes. Closed by commit rG3587b15abe68: [Clang] [P2025] More exhaustive tests for NRVO (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119927/new/

[clang] 3587b15 - [Clang] [P2025] More exhaustive tests for NRVO

Author: Evgeny Shulgin Date: 2022-03-17T03:58:40+03:00 New Revision: 3587b15abe683f164093f8d057e921f913572007 URL: https://github.com/llvm/llvm-project/commit/3587b15abe683f164093f8d057e921f913572007 DIFF:

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for enum records - Add `EnumConstantRecord` and `EnumRecord` to store API

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. In D119479#3387880 , @zixuw wrote: > @haowei I got a quick fix of completely purging the generator output in the > test case. Could you take a look to have a sanity check before I land the fix > on main? > > diff --git

[PATCH] D119470: [clang-tidy] Don't check decltype return types in `readability-const-return-type`

Izaron marked 3 inline comments as done. Izaron added a comment. > You've submitted some quality patches already, would you be interested in > obtaining commit privileges > (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)? Thanks! I obtained the commit access =) Now I don't

[PATCH] D119470: [clang-tidy] Don't check decltype return types in `readability-const-return-type`

Izaron updated this revision to Diff 416035. Izaron added a comment. Herald added a project: All. Don't warn on non-toplevel-const TypeOfType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119470/new/ https://reviews.llvm.org/D119470 Files:

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

thakis added a comment. In D121233#3384567 , @sammccall wrote: > In D121233#3384495 , @thakis wrote: > >> Is there a reason why this can't be part of clang-tools-extra/test > > This was discussed pretty

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. @haowei Fix landed in 3840082ab509490f16766cd8c155a1cf4b606fec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479

[clang] 3840082 - [FIX][NFC] Fix a test case in clang/SymbolGraph

Author: Zixu Wang Date: 2022-03-16T17:19:35-07:00 New Revision: 3840082ab509490f16766cd8c155a1cf4b606fec URL: https://github.com/llvm/llvm-project/commit/3840082ab509490f16766cd8c155a1cf4b606fec DIFF: https://github.com/llvm/llvm-project/commit/3840082ab509490f16766cd8c155a1cf4b606fec.diff

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. @haowei I got a quick fix of completely purging the generator output in the test case. Could you take a look to have a sanity check before I land the fix on main? diff --git a/clang/test/SymbolGraph/global_record.c b/clang/test/SymbolGraph/global_record.c index

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. In D119479#3387872 , @haowei wrote: > We are seeing test failures after this patch is landed: > > Clang :: SymbolGraph/global_record.c > Script: > -- > : 'RUN: at line 1'; rm -rf >

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. We are seeing test failures after this patch is landed: Clang :: SymbolGraph/global_record.c Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp : 'RUN: at line 2'; split-file

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw updated this revision to Diff 416025. sstwcw added a comment. Use the name spaceRequiredBetween. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https://reviews.llvm.org/D121755 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2851 -addUnwrappedLine(); -++Line->Level; -parseStructuralElement(); HazardyKnusperkeks wrote: > This is completely missing.

[PATCH] D121865: [CodeGen] Inline _byteswap_* builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04ba344176b2: [CodeGen] Inline _byteswap_* builtins. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 04ba344 - [CodeGen] Inline _byteswap_* builtins.

Author: Eli Friedman Date: 2022-03-16T16:18:51-07:00 New Revision: 04ba344176b239c0abc0c9efc8b7524e551e58ed URL: https://github.com/llvm/llvm-project/commit/04ba344176b239c0abc0c9efc8b7524e551e58ed DIFF: https://github.com/llvm/llvm-project/commit/04ba344176b239c0abc0c9efc8b7524e551e58ed.diff

[PATCH] D121865: [CodeGen] Inline _byteswap_* builtins.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Huh. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121865/new/ https://reviews.llvm.org/D121865 ___

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee created this revision. bc-lee added reviewers: arphaman, MaskRay. Herald added a project: All. bc-lee requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extends cc1as to export the build version load command with

[clang] fa331da - [FIX][clang-extract-api] Fix scope naming violation

Author: Zixu Wang Date: 2022-03-16T16:04:44-07:00 New Revision: fa331da8fb7ea915d29e0834c7acc7a01eccb4e6 URL: https://github.com/llvm/llvm-project/commit/fa331da8fb7ea915d29e0834c7acc7a01eccb4e6 DIFF: https://github.com/llvm/llvm-project/commit/fa331da8fb7ea915d29e0834c7acc7a01eccb4e6.diff

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 3 inline comments as done. sstwcw added a comment. About the tokens that were only in one function. question, colon, and TT_ConditionalExpr, are for same thing. question was added before they added TT_ConditionalExpr. It looks like now only TT_ConditionalExpr would be enough.

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 416010. sstwcw edited the summary of this revision. sstwcw added a comment. Add some test cases and use a separate function for the common parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/

[PATCH] D121863: [clang][dataflow] Model the behavior of non-standard optional assignment

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:81 +auto isOptionalValueOrConversionAssignment() { + return cxxOperatorCallExpr( While really like the convenience matchers will give us

[PATCH] D121865: [CodeGen] Inline _byteswap_* builtins.

efriedma created this revision. efriedma added reviewers: rnk, mstorsjo. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. As discussed in D57915 . Fixes https://github.com/llvm/llvm-project/issues/3 .

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with comment (not blocking). Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -verify -triple

[clang] a597d6a - Revert "[OpenMP][FIX] Allow device constructors for AMD GPU"

Author: Johannes Doerfert Date: 2022-03-16T17:35:54-05:00 New Revision: a597d6a780b184539f504392168b004bf392a135 URL: https://github.com/llvm/llvm-project/commit/a597d6a780b184539f504392168b004bf392a135 DIFF:

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. Fixing bot failure right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + } ymandel wrote: > xazax.hun wrote: > > I wonder

[PATCH] D121863: [clang][dataflow] Model the behavior of non-standard optional assignment

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Model nullopt, value, and conversion assignment

[PATCH] D119479: [clang][extract-api] Add global record support

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aab45f43066: [clang][extract-api] Add global record support (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/

[clang] 5aab45f - [clang][extract-api] Add global record support

Author: Zixu Wang Date: 2022-03-16T15:13:55-07:00 New Revision: 5aab45f430669d7d2af51386819d071b26c3c89c URL: https://github.com/llvm/llvm-project/commit/5aab45f430669d7d2af51386819d071b26c3c89c DIFF: https://github.com/llvm/llvm-project/commit/5aab45f430669d7d2af51386819d071b26c3c89c.diff

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. Hi Johannes, assert in two of the tests #7 0x5576b8d055e4 llvm::ConstantExpr::getAddrSpaceCast(llvm::Constant*, llvm::Type*, bool) (/work/omp-vega20-0/openmp-offload-amdgpu-runtime/llvm.build/bin/clang-15+0x1e4b5e4)

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby added a comment. In D121829#3386736 , @paulwalker-arm wrote: > It looks like the issue you fixed for the integer tests also need fixing for > the floating point variants. Yeah, this is what you get when you think you're being really smart

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. Landing this in a moment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b176646134: [OpenMP][FIX] Allow device constructors for AMD GPU (authored by jdoerfert). Changed prior to commit:

[clang] 07b1766 - [OpenMP][FIX] Allow device constructors for AMD GPU

Author: Johannes Doerfert Date: 2022-03-16T17:04:28-05:00 New Revision: 07b176646134c3d88a4cecef5e0058e2de6b2409 URL: https://github.com/llvm/llvm-project/commit/07b176646134c3d88a4cecef5e0058e2de6b2409 DIFF:

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:2762 +// This addresses https://github.com/llvm/llvm-project/issues/38995 +int

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth marked 10 inline comments as done. paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch.c:25 + int x = 0; + if (likely(rando % (outer_loop * inner_loop) == 0)) { // exact-warning-re {{Potential performance regression from use of

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

MyDeveloperDay added a comment. Can you add a summary as to why you are making this change? the code doesn't look the same before/after so whats changing and why? is there no unit tests that perhaps need to be added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen added a comment. @probinson Thanks. No worries. I should've pinged earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118850/new/ https://reviews.llvm.org/D118850 ___ cfe-commits mailing list

[PATCH] D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79f661edc13d: [OpenMP] Initial parsing/sema for the omp teams loop construct (authored by mikerice). Herald added a project: clang. Herald added a

[clang] 79f661e - [OpenMP] Initial parsing/sema for the 'omp teams loop' construct

Author: Mike Rice Date: 2022-03-16T14:39:18-07:00 New Revision: 79f661edc13d389437b83d42f0af04b0615b920e URL: https://github.com/llvm/llvm-project/commit/79f661edc13d389437b83d42f0af04b0615b920e DIFF: https://github.com/llvm/llvm-project/commit/79f661edc13d389437b83d42f0af04b0615b920e.diff

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 415990. paulkirth added a comment. Address comments. Added clang documentation. Fixed various typos. Updated tests per comments for clang and LLVM. Removed dead class definition. Removed clamping from tolerance parser. Repository: rG LLVM Github

[PATCH] D121847: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2371c5a0e06d: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2371c5a - [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

Author: Arthur Eubanks Date: 2022-03-16T14:11:53-07:00 New Revision: 2371c5a0e06d22b48da0427cebaf53a5e5c54635 URL: https://github.com/llvm/llvm-project/commit/2371c5a0e06d22b48da0427cebaf53a5e5c54635 DIFF:

[PATCH] D121847: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121847/new/ https://reviews.llvm.org/D121847 ___

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 415974. zixuw added a comment. Using `SmallString`/`SmallVectorImpl` to pass `USR` into the `add*` APIs still feel weird and unintuitive. And it's still not clear to the caller that `Name` won't be copied but `USR` will. Trying out another approach: still pass

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

ldionne accepted this revision. ldionne added a comment. LGTM, thanks for fixing the documentation quirks in libc++/libunwind! And sorry this went under my Radar last week :-). @tonic Is this OK with you? I don't want to override your "request for changes" by committing this. Repository:

[PATCH] D121847: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

aeubanks created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Includes verifier changes checking the elementtype,

[PATCH] D121846: [clang-format] Correctly recognize binary operators in template arguments with parenthesized literals.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

HazardyKnusperkeks added a comment. Looks basically okay. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2851 -addUnwrappedLine(); -++Line->Level; -parseStructuralElement(); This is completely missing. Didn't it affect anything?

[clang] dbefb7e - [clang-format] Reformat. NFC.

Author: Marek Kurdej Date: 2022-03-16T21:54:11+01:00 New Revision: dbefb7e86f82dcb1302b3d5559f733427d464a87 URL: https://github.com/llvm/llvm-project/commit/dbefb7e86f82dcb1302b3d5559f733427d464a87 DIFF: https://github.com/llvm/llvm-project/commit/dbefb7e86f82dcb1302b3d5559f733427d464a87.diff

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks added a comment. Please add tests in TokenAnnotatorTests for `TT_ConditionLParen`. Comment at: clang/lib/Format/FormatToken.h:521 + /// statement's condition like if or while. + bool isConditionLParen(bool IncludeSpecial) const { +if

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:907 + KEYWORD(infer, 0) \ + KEYWORD(is, ATTR_JS_KEYWORD | ATTR_CSHARP_KEYWORD | ATTR_CSHARP_KEYWORD) \ + KEYWORD(let,

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

void added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LogFunctionsCheck.cpp:51 +void LogFunctionsCheck::check(const MatchFinder::MatchResult ) { + if (FixerKind == LFFK_H) { +const auto *Call = Result.Nodes.getNodeAs("call"); For

[PATCH] D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e8913d775ca: [WebAssembly] Fix names of SIMD instructions containing _zero (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7e8913d - [WebAssembly] Fix names of SIMD instructions containing '_zero'

Author: Thomas Lively Date: 2022-03-16T13:34:57-07:00 New Revision: 7e8913d775ca2959861425dca886f98ac03ab9b4 URL: https://github.com/llvm/llvm-project/commit/7e8913d775ca2959861425dca886f98ac03ab9b4 DIFF: https://github.com/llvm/llvm-project/commit/7e8913d775ca2959861425dca886f98ac03ab9b4.diff

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3069 -bool TokenAnnotator::spaceRequiredBetween(const AnnotatedLine , - const FormatToken , - const

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2161 -if (PrevToken->isOneOf(tok::l_paren, tok::l_square, tok::l_brace, - tok::comma, tok::semi,

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

void added a comment. In D93182#2451509 , @lebedev.ri wrote: > Out of curiocity, are all checkpatch diagnostics (and something else)? > are planned to be ported into being clang-tidy checks? > How many will checks will that be? > I'll be slightly worried

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

HazardyKnusperkeks added a comment. This is an enormous patch. @MyDeveloperDay mentioned different places which could be separate patches, but in addition could the adding of the verilog language be split up, so that one can comprehend the patch in a reasonable time? Comment

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

probinson accepted this revision. probinson added a comment. LGTM, sorry I missed this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118850/new/ https://reviews.llvm.org/D118850 ___ cfe-commits mailing

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added a comment. In D121370#3383574 , @HazardyKnusperkeks wrote: > Some test with a main header and blocks would be nice. This one please. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + }

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rGe0aefb4f9278: [clang][dataflow] Add an API for dataflow models -- reusable analysis… (authored by

[clang] e0aefb4 - [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

Author: Yitzhak Mandelbaum Date: 2022-03-16T19:47:57Z New Revision: e0aefb4f92782f0679470ee3834801977199a1b1 URL: https://github.com/llvm/llvm-project/commit/e0aefb4f92782f0679470ee3834801977199a1b1 DIFF: https://github.com/llvm/llvm-project/commit/e0aefb4f92782f0679470ee3834801977199a1b1.diff

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen added a comment. Herald added a project: All. @aaron.ballman Thanks for taking a look. @probinson Gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118850/new/ https://reviews.llvm.org/D118850

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121796/new/ https://reviews.llvm.org/D121796 ___ cfe-commits mailing list

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

tra added a subscriber: rsmith. tra added a comment. @rsmith - this touches generic Sema functionality and could use your input. Overall, the patch looks OK to me. Comment at: clang/include/clang/Sema/Sema.h:3327-3328 + /// a pointer to the function or lambda decl for the

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

nickdesaulniers added a comment. In D93182#2451509 , @lebedev.ri wrote: > Out of curiocity, are all checkpatch diagnostics (and something else)? > are planned to be ported into being clang-tidy checks? Not at this time, no. > How many will checks will

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 415936. ymandel marked an inline comment as done. ymandel added a comment. removed lattice dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files:

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall updated this revision to Diff 415931. sammccall added a comment. Fix LLVM_ADDITIONAL_TEST_{TARGETS,DEPENDS} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 Files:

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:150-151 +///should relate to each other -- that is, how they should compose. Open +///questions include: Do we want to

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added a comment. This isn't ready for submission, there's some bits that touch the global variables in runtimes/, llvm/runtimes, and compiler-rt/test. Mostly to see the idea. The main point is to allow check-clang-tools to cover the tests in clang-tools-extra without requiring them

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall created this revision. sammccall added reviewers: aaron.ballman, hokein, thakis. Herald added subscribers: usaxena95, kadircet, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov. Herald

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

ymandel updated this revision to Diff 415926. ymandel marked an inline comment as done. ymandel added a comment. adjust API in response to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121796/new/ https://reviews.llvm.org/D121796 Files:

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert created this revision. jdoerfert added a reviewer: JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl, jvesely. Herald added a project: All. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added a comment. In D121712#3383944 , @Trass3r wrote: > Hmm just a few curious questions from the sidelines. > Why a "custom system" instead of something -ftime-trace based? I'm not sure if I understand. -ftime-trace is a one-off. I want to

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 415919. adamcz marked 12 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files:

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3383684 , @keith wrote: > You're right it's version 5 not 4, maybe the issue is that some platforms > (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 > because passing 6 also reproduces,

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron added a comment. @Quuxplusone, thank you for the test idea! I added `test25` that resembles the pattern. Could you please look if we're okay with `test25`? If everything is OK, I could merge the patch myself: I've got repository merge access =) P. S. Sorry for the long delay, I was

  1   2   3   >