[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

4vtomat added a comment. In D122370#3404590 , @MaskRay wrote: > I assume this is to improve test parallelism. Do you have runtime comparison? actually, this is to prevent single file from timeout due to many test cases, such as

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

MaskRay added a comment. I assume this is to improve test parallelism. Do you have runtime comparison? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122370/new/ https://reviews.llvm.org/D122370 ___

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

4vtomat created this revision. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal,

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

arcbbb planned changes to this revision. arcbbb added a comment. Herald added a subscriber: StephenFan. I started a discussion on how RVV clang builtins interact with FENV_ACCESS in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/147 I would drop this patch if those builtins are going

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx"

[clang] 86c1d07 - [clang][AVR] Implement standard calling convention for AVR and AVRTiny

Author: Ben Shi Date: 2022-03-24T03:41:01Z New Revision: 86c1d075bb32101fe1c403e873ce33945bfa9626 URL: https://github.com/llvm/llvm-project/commit/86c1d075bb32101fe1c403e873ce33945bfa9626 DIFF: https://github.com/llvm/llvm-project/commit/86c1d075bb32101fe1c403e873ce33945bfa9626.diff LOG:

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ planned changes to this revision. NoQ added a comment. Ok there's actually a huge bug in this patch, namely we can't say "Assuming..." if there's no state split (i.e., when we know from the start which branch is taken so we don't have to assume). I'll fix. In D122285#3401754

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx"

[clang] d912232 - [CUDA][FIX] Fix name conflict in getNVPTXTargetFeatures

Author: Joseph Huber Date: 2022-03-23T23:07:51-04:00 New Revision: d91223274145a0c33ab01641902650b249921a43 URL: https://github.com/llvm/llvm-project/commit/d91223274145a0c33ab01641902650b249921a43 DIFF: https://github.com/llvm/llvm-project/commit/d91223274145a0c33ab01641902650b249921a43.diff

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx"

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuan-wu added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; It's same name as `Language` variable above, and it cause compile error. @zixuw Maybe the

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rGf74413d16345: [clang-format] Fix invalid code generation with comments in lambda (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f74413d - [clang-format] Fix invalid code generation with comments in lambda

Author: owenca Date: 2022-03-23T19:40:24-07:00 New Revision: f74413d16345c8815c7d1e4676d6aaf732517b8d URL: https://github.com/llvm/llvm-project/commit/f74413d16345c8815c7d1e4676d6aaf732517b8d DIFF: https://github.com/llvm/llvm-project/commit/f74413d16345c8815c7d1e4676d6aaf732517b8d.diff LOG:

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG847466860887: [C++20] [Modules] Make the linkage consistent for template and its (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8474668 - [C++20] [Modules] Make the linkage consistent for template and its

Author: Chuanqi Xu Date: 2022-03-24T10:24:14+08:00 New Revision: 84746686088799ec9e3cc5ea0a64df81423da290 URL: https://github.com/llvm/llvm-project/commit/84746686088799ec9e3cc5ea0a64df81423da290 DIFF: https://github.com/llvm/llvm-project/commit/84746686088799ec9e3cc5ea0a64df81423da290.diff

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a comment. @vsapsai @dblaikie I want to make sure if this one would affect clang modules. Or simply, would the name of clang modules contain `:`? (`:` is the separator of C++20 modules partitions.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D122119#3402168 , @urnathan wrote: > In D122119#3401322 , @ChuanqiXu > wrote: > >> > > > >> I

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG51585aa240de: [clang][AVR] Implement standard calling convention for AVR and AVRTiny (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D120720?vs=415734=417811#toc Repository:

[clang] 51585aa - [clang][AVR] Implement standard calling convention for AVR and AVRTiny

Author: Ben Shi Date: 2022-03-24T02:08:22Z New Revision: 51585aa240de6ef07979345de5406483d7393b7b URL: https://github.com/llvm/llvm-project/commit/51585aa240de6ef07979345de5406483d7393b7b DIFF: https://github.com/llvm/llvm-project/commit/51585aa240de6ef07979345de5406483d7393b7b.diff LOG:

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Thank you @zequanwu, for providing the minimized reproducer! It really made fixing this much easier! :) I've re-landed the change and added a test specifically for this issue: `lower-global-dtors-existing-dos_handle.ll` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120887: The [2/3] Fix mangle problem when variable used in inline asm （Add modifier P for ARR[BaseReg+IndexReg+..]）

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG287dad13abba: [InlineAsm] Fix mangle problem when global variable used in inline asm (authored by xiangzhangllvm). Herald added subscribers:

[clang] 287dad1 - [InlineAsm] Fix mangle problem when global variable used in inline asm

Author: Xiang1 Zhang Date: 2022-03-24T09:41:23+08:00 New Revision: 287dad13abba934db5f4a62a968263eea2693b4f URL: https://github.com/llvm/llvm-project/commit/287dad13abba934db5f4a62a968263eea2693b4f DIFF: https://github.com/llvm/llvm-project/commit/287dad13abba934db5f4a62a968263eea2693b4f.diff

[PATCH] D120886: [Inline asm][1/3] Fix mangle problem when variable used in inline asm (Revert 2 history bugfix patch)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a6b644c7923: [Inline asm] Fix mangle problem when variable used in inline asm. (authored by xiangzhangllvm). Herald added subscribers: cfe-commits,

[clang] 8a6b644 - [Inline asm] Fix mangle problem when variable used in inline asm.

Author: Xiang1 Zhang Date: 2022-03-24T09:41:22+08:00 New Revision: 8a6b644c79234a276fbdc840f7091d490a8cc0d7 URL: https://github.com/llvm/llvm-project/commit/8a6b644c79234a276fbdc840f7091d490a8cc0d7 DIFF: https://github.com/llvm/llvm-project/commit/8a6b644c79234a276fbdc840f7091d490a8cc0d7.diff

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

jrtc27 added a comment. As a developer who often deals with crashes locally this is more annoying; currently I can just point tools at the shell script and C file in /tmp and let them go to work reducing, but now I have to also extract the files CHANGES SINCE LAST ACTION

[clang] 64902d3 - Reland "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

Author: Julian Lettner Date: 2022-03-23T18:36:55-07:00 New Revision: 64902d335c2126e24a9d84b7410924148959e4a9 URL: https://github.com/llvm/llvm-project/commit/64902d335c2126e24a9d84b7410924148959e4a9 DIFF:

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-prefix=FULL +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added a comment. In D121733#3403995 , @rnk wrote: > Ignoring the ".." path components for the moment, is this patch good to go as > is? It doesn't affect that behavior. Besides the test failure, the other thing is considering what to do with

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/GLRParser.cpp:285 +ForestChildren.push_back(PN->Parsed); + const ForestNode = ParsedForest.createSequence( + ReduceSymbolID, RA.ReduceRuleID, ForestChildren.front()->startLoc(),

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added a comment. > Ignoring the ".." path components for the moment, is this patch good to go as > is? It doesn't affect that behavior. This patch still breaks Winx64 `clang-tidy/checkers/google-upgrade-googletest-case.cpp`. The failure log here

[clang] 581dc3c - Revert "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

Author: Zequan Wu Date: 2022-03-23T16:11:54-07:00 New Revision: 581dc3c729c619fe636325a79279fabb2acdc1ce URL: https://github.com/llvm/llvm-project/commit/581dc3c729c619fe636325a79279fabb2acdc1ce DIFF: https://github.com/llvm/llvm-project/commit/581dc3c729c619fe636325a79279fabb2acdc1ce.diff

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

zequanwu added a comment. Herald added a subscriber: pmatos. Hi, this causes crash on Mac building bot. Here is the reduced repro: `opt -lower-global-dtors /tmp/reduced.ll -o /dev/null ` $ cat /tmp/reduced.ll %struct.mach_header = type { i32, i32, i32, i32, i32, i32, i32 }

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/lib/GrammarBNF.cpp:55 }; for (const auto : Specs) { Consider(Spec.Target); hokein wrote:

[PATCH] D121733: Clean pathnames in FileManager.

rnk added a comment. Ignoring the ".." path components for the moment, is this patch good to go as is? It doesn't affect that behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

gulfem added a comment. Newly added tests `ClangScanDeps/cl-output.c` and `ClangScanDeps/cl-xclang.c` started failing in our Mac toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b881168677577537/overview Here's the link to the log:

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d16c23af1da: [OpenMP] Do not create offloading entries for internal or hidden symbols (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0d16c23 - [OpenMP] Do not create offloading entries for internal or hidden symbols

Author: Joseph Huber Date: 2022-03-23T18:27:16-04:00 New Revision: 0d16c23af1da2e7c83c84cf64f8b76947f038044 URL: https://github.com/llvm/llvm-project/commit/0d16c23af1da2e7c83c84cf64f8b76947f038044 DIFF: https://github.com/llvm/llvm-project/commit/0d16c23af1da2e7c83c84cf64f8b76947f038044.diff

[clang] 955cff8 - reland: [AArch64] Add support for -march=native for Apple M1 CPU

Author: Keith Smiley Date: 2022-03-23T15:19:17-07:00 New Revision: 955cff803e081640e149fed0742f57ae1b84db7d URL: https://github.com/llvm/llvm-project/commit/955cff803e081640e149fed0742f57ae1b84db7d DIFF: https://github.com/llvm/llvm-project/commit/955cff803e081640e149fed0742f57ae1b84db7d.diff

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417762. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417761. cor3ntin added a comment. - Added a couple of tests in ASTImporterTest.cpp - Rename elements of LambdaDependencyKind - Fix ActOnStartOfLambdaDefinition to not use a boolean for LambdaDependencyKind. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

JonChesterfield added a comment. Sounds good to me too, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 ___ cfe-commits mailing list

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417756. abrachet added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp clang/test/Driver/crash-diagnostics-dir.c

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417755. hubert.reinterpretcast added a comment. - Adjust per observation: Use DenseMapInfo for the alias pointer value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. In D122335#3403474 , @aaron.ballman wrote: > Yup, I'm okay with that compiler engineer requirement; I think our existing > requirements on Windows already pull in a useful `tar` program even though it > doesn't seem like we

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417754. abrachet added a comment. Herald added a subscriber: arphaman. Fix test failures outside of Driver/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

MyDeveloperDay added a comment. In D121451#3402167 , @curdeius wrote: > In D121451#3401947 , > @MyDeveloperDay wrote: > >> I'm a little uncomfortable with >> >> //# >> >> becoming >> >> // # >> >> At least

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 updated this revision to Diff 417751. jhuber6 added a comment. Adding new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG528e6eba2f79: [clang] Improve diagnostic for reopened inline namespace (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122278?vs=417455=417749#toc Repository: rG LLVM Github

[clang] 528e6eb - [clang] Improve diagnostic for reopened inline namespace

Author: Fabian Wolff Date: 2022-03-23T22:30:45+01:00 New Revision: 528e6eba2f7906d974594b1fc50362dfad239609 URL: https://github.com/llvm/llvm-project/commit/528e6eba2f7906d974594b1fc50362dfad239609 DIFF: https://github.com/llvm/llvm-project/commit/528e6eba2f7906d974594b1fc50362dfad239609.diff

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417746. jyu2 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index:

[clang] fc3cdd0 - Revert "[AArch64] Add support for -march=native for Apple M1 CPU"

Author: Keith Smiley Date: 2022-03-23T14:27:02-07:00 New Revision: fc3cdd0b295a04c38f01b391ae414553963e33b9 URL: https://github.com/llvm/llvm-project/commit/fc3cdd0b295a04c38f01b391ae414553963e33b9 DIFF: https://github.com/llvm/llvm-project/commit/fc3cdd0b295a04c38f01b391ae414553963e33b9.diff

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 added a comment. In D122338#3403414 , @ABataev wrote: > If ParamPositions grows, it means that the item is not found. Is it correct > behavior if the compiler inserts new item in the ParamPositions map? I see. Thanks! Then it seems

[clang] d90a3fc - [Clang] Added testcases for -Wunused-but-set-parameter

Author: Dávid Bolvanský Date: 2022-03-23T22:14:38+01:00 New Revision: d90a3fcacda7257b26ac32350353410f79be6d2b URL: https://github.com/llvm/llvm-project/commit/d90a3fcacda7257b26ac32350353410f79be6d2b DIFF:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer &&

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/

[clang] fcca10c - [AArch64] Add support for -march=native for Apple M1 CPU

Author: Keith Smiley Date: 2022-03-23T14:06:59-07:00 New Revision: fcca10c69aaab539962d10fcc59a5f074b73b0de URL: https://github.com/llvm/llvm-project/commit/fcca10c69aaab539962d10fcc59a5f074b73b0de DIFF: https://github.com/llvm/llvm-project/commit/fcca10c69aaab539962d10fcc59a5f074b73b0de.diff

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG460fc440ad8d: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 460fc44 - [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

Author: Dávid Bolvanský Date: 2022-03-23T22:05:36+01:00 New Revision: 460fc440ad8d41ca2e3882987512989b1c188fbe URL: https://github.com/llvm/llvm-project/commit/460fc440ad8d41ca2e3882987512989b1c188fbe DIFF:

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:3325-3330 + /// getCurFunctionDecl - If parsing a lambda, then return the lambda + /// declaration if \p AllowLambda is

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403698 , @erichkeane wrote: >> I'm sorry I misunderstood what you meant @aaron.ballman. >> >> Can we follow the lead of LLVM IR？it use 'undef' >> for example: >> >> struct T6A { >> unsigned a : 1; >>

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein added a comment. In D122303#3402375 , @sammccall wrote: > The extraction of TestGrammar seems unrelated to the rest of the patch and it > *isn't* actually shared between tests yet, which makes it a bit hard to > review. It is used in our

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein updated this revision to Diff 417731. hokein marked an inline comment as done. hokein added a comment. address comments, remove the extraction of TestGrammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122303/new/

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; aaron.ballman wrote: > LegalizeAdulthood wrote: > > aaron.ballman wrote: > > > LegalizeAdulthood wrote: > > > >

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw added a comment. In D121873#3403082 , @mstorsjo wrote: > This (or some closely related commit?) causes a huge amount of warnings when > building with GCC: > > warning: ‘clang::extractapi::EnumRecord’ has a field >

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

zixuw added a comment. This is much cleaner now. Thanks Daniel! Comment at: clang/include/clang/ExtractAPI/API.h:326 + /// Note: The main use for this is being able to deduplicate strings. llvm::BumpPtrAllocator Allocator; Should we just rename the

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. > I'm sorry I misunderstood what you meant @aaron.ballman. > > Can we follow the lead of LLVM IR？it use 'undef' > for example: > > struct T6A { > unsigned a : 1; > unsigned : 0; > unsigned c : 1; > }; > > @__const.foo.a = private

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403637 , @erichkeane wrote: > In D122248#3403636 , @yihanaa wrote: > >> In D122248#3403518 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3403270 , @aaron.ballman wrote: > I'd like to understand what's happening better rather than land with a > disabled test. Not getting the crash dump in some circumstances could either > be specific to the machine

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto marked 3 inline comments as done. hkmatsumoto added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:921 + if (IsAnd && + match(Cmp0, m_ICmp(Pred0, m_Intrinsic(m_Value(X)), + m_SpecificInt(1))) &&

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403636 , @yihanaa wrote: > In D122248#3403518 , @aaron.ballman > wrote: > >> In D122248#3403478 , @erichkeane >> wrote: >> >>>

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403518 , @aaron.ballman wrote: > In D122248#3403478 , @erichkeane > wrote: > >> If it is ok, I think we should probably change the format of the 'dump' for >> fields.

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. Reading this again, I have a feeling defaulting to newest will come back to bite us (or, well, apple folks.) But we can reevaluate if we get to that. So, LGTM, thanks! Repository: rG LLVM

[clang] 3fb101a - [NFC] Replace a not-null-check && isa with isa_and_nonnull

Author: Erich Keane Date: 2022-03-23T13:09:28-07:00 New Revision: 3fb101a6914b6d0e7a46b425eeafc44578d7ff78 URL: https://github.com/llvm/llvm-project/commit/3fb101a6914b6d0e7a46b425eeafc44578d7ff78 DIFF: https://github.com/llvm/llvm-project/commit/3fb101a6914b6d0e7a46b425eeafc44578d7ff78.diff

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403478 , @erichkeane wrote: > If it is ok, I think we should probably change the format of the 'dump' for > fields. Using the colon to split up the field from the value is unfortunate, > may I suggest replacing it

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer &&

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

erichkeane added a comment. Other than this 1 thing, LGTM. I DO find myself wondering how much of the CXXMethodDecl bit in the branch above is valid for 'naked' as well. If it ISN'T we might consider moving this loop AND that to EmitFunctionPrologue. Comment at:

[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

ekieri created this revision. ekieri added reviewers: bruno, v.g.vassilev, thakis, dexonsmith. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403478 , @erichkeane wrote: > If it is ok, I think we should probably change the format of the 'dump' for > fields. Using the colon to split up the field from the value is unfortunate, > may I suggest

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, efriedma, jyknight, rjmccall. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Naked functions have no prolog, so it's not valid to emit prolog code to

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. If it is ok, I think we should probably change the format of the 'dump' for fields. Using the colon to split up the field from the value is unfortunate, may I suggest replacing it with '=' instead? As well as printing the size after a colon. So for: void

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403459 , @erichkeane wrote: > In D122335#3403453 , @aaron.ballman > wrote: > >> In D122335#3403357 , @erichkeane >> wrote:

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403468 , @aaron.ballman wrote: > In D122248#3403349 , @erichkeane > wrote: > >> In D122248#3403343 , @yihanaa >> wrote: >> >>>

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403349 , @erichkeane wrote: > In D122248#3403343 , @yihanaa wrote: > >> In D122248#3403315 , >> @aaron.ballman wrote: >> >>>

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403453 , @aaron.ballman wrote: > In D122335#3403357 , @erichkeane > wrote: > >> In D122335#3403305 , >> @aaron.ballman wrote:

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

efriedma added a comment. I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully: typedef bool Var; constexpr bool foobool() { return (bool().Var::~Var(), false); } CHANGES SINCE LAST ACTION

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403357 , @erichkeane wrote: > In D122335#3403305 , @aaron.ballman > wrote: > >> In D122335#3403283 , @abrachet >> wrote: >>

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added a comment. If ParamPositions grows, it means that the item is not found. Is it correct behavior if the compiler inserts new item in the ParamPositions map? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto updated this revision to Diff 417705. hkmatsumoto added a comment. Reflect code reviews - Factor out pattern matching code and exit early if it didn't match - Rename foldOrOfCtpop to foldIsPowerOf2OrZero - Rename 2 tests in ispow2.ll to is_pow2_or_zero(_logical) to inform that this

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rGf833aab0d0bf: [clang][extract-api] Enable processing of multiple headers (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f833aab - [clang][extract-api] Enable processing of multiple headers

Author: Daniel Grumberg Date: 2022-03-23T19:05:19Z New Revision: f833aab0d0bf1bd9e9903a1398e429f431532f5f URL: https://github.com/llvm/llvm-project/commit/f833aab0d0bf1bd9e9903a1398e429f431532f5f DIFF: https://github.com/llvm/llvm-project/commit/f833aab0d0bf1bd9e9903a1398e429f431532f5f.diff

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403305 , @aaron.ballman wrote: > In D122335#3403283 , @abrachet > wrote: > >> In D122335#3403281 , >> @hubert.reinterpretcast

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403349 , @erichkeane wrote: > In D122248#3403343 , @yihanaa wrote: > >> In D122248#3403315 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403343 , @yihanaa wrote: > In D122248#3403315 , @aaron.ballman > wrote: > >> In D122248#3403143 , @yihanaa >> wrote: >> >>> 1.

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

lhames added a comment. > I'm currently doing that via MCContext::getGenDwarfForAssembly... This isn't my wheelhouse, but at first glance GenDwarfForAssembly looks like it might control all Dwarf sections (including debug ones). If that's the case you might need to introduce something eh-frame

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403315 , @aaron.ballman wrote: > In D122248#3403143 , @yihanaa wrote: > >> 1. Support zero-width bitfield, named bitfield and unnamed bitfield. >> 2. Add a release notes. >>

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D122271

  1   2   3   4   >