[clang] ee57212 - [C++20] [Modules] Use '-' as the separator of partitions when searching

Author: Chuanqi Xu Date: 2022-03-31T11:21:58+08:00 New Revision: ee572129ae15bc15e34fcae63643d6998352dab3 URL: https://github.com/llvm/llvm-project/commit/ee572129ae15bc15e34fcae63643d6998352dab3 DIFF: https://github.com/llvm/llvm-project/commit/ee572129ae15bc15e34fcae63643d6998352dab3.diff

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee572129ae15: [C++20] [Modules] Use - as the separator of partitions when searching (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

ChuanqiXu updated this revision to Diff 419325. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 Files: clang/include/clang/Basic/Module.h clang/lib/Serialization/ASTWriterDecl.cpp

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu updated this revision to Diff 419324. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/search-partitions.cpp Index:

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

ampandey-AMD updated this revision to Diff 419323. ampandey-AMD added a comment. This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu updated this revision to Diff 419322. ChuanqiXu added a comment. Herald added a subscriber: dexonsmith. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/include/clang/Basic/Module.h

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

ampandey-AMD updated this revision to Diff 419317. ampandey-AMD added a comment. This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

ampandey-AMD created this revision. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. ampandey-AMD requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay, wdng. Herald added a reviewer:

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3416518 , @rengolin wrote: > There is also a test error: > > TEST 'Clang :: Driver/csky-toolchain.c' FAILED > > ... >

[PATCH] D122713: [RISCV] [NFC] Add tests for vector load/store overloaded intrinsics of FP16

Chenbing.Zheng added a comment. In D122713#3417033 , @craig.topper wrote: > These tests files are already too long and have been timing out in > phabricator. @4vtomat has a patch D122370 > to split them up. OK, I

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS added a comment. In D122698#3418018 , @sammccall wrote: > Thanks! I'll look at the changes in the morning, just wanted to mention one > thing > > In D122698#3417946 , @FabioRS wrote: > >> I can not run

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. As discussed in https://github.com/llvm/llvm-project/issues/54654, this needs to be added for SPMDization with this patch. Not sure whether further handling is required. diff --git a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

sammccall added a comment. Thanks! I'll look at the changes in the morning, just wanted to mention one thing In D122698#3417946 , @FabioRS wrote: > I can not run the test the consteval, so it is not in the diff. > > TestTU failed to build (suppress

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw updated this revision to Diff 419298. zixuw added a comment. Remove probably unnecessary includes added automatically by clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 Files:

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add (partial) support for Objective-C category records in ExtractAPI. The current ExtractAPI

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419296. FabioRS added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122698/new/ https://reviews.llvm.org/D122698 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419290. FabioRS marked 14 inline comments as done. FabioRS added a comment. I am not sure about the LangOptions object, the NestedNameSpecifier needs it to correctly print the nested classes-name and not sure about the getEnclosing() too. I can not run the

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

yihanaa added a comment. Thank you for the reviews @erichkeane. I've applied for commit access and commit in 907d3acefc3bdd6eb83f21589c6473ca7e88b3eb . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG907d3acefc3b: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct… (authored by yihanaa). Repository: rG LLVM Github

[clang] 907d3ac - [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

Author: wangyihan Date: 2022-03-31T07:38:37+08:00 New Revision: 907d3acefc3bdd6eb83f21589c6473ca7e88b3eb URL: https://github.com/llvm/llvm-project/commit/907d3acefc3bdd6eb83f21589c6473ca7e88b3eb DIFF: https://github.com/llvm/llvm-project/commit/907d3acefc3bdd6eb83f21589c6473ca7e88b3eb.diff

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. In D122627#3417557 , @aaron.ballman wrote: > Are you sure that's what you want? This returns true for a static C++ member > function, false for a static free function, and false for within an unnamed > namespace, and true

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

sstwcw added a comment. Maybe it's because I removed the final empty line when I pasted the diff as I thought that LF was a line terminator instead of a line separator. I will try using arc from now on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6740fe483e9: [clang-format] Indent import statements in JavaScript. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f6740fe - [clang-format] Indent import statements in JavaScript.

Author: sstwcw Date: 2022-03-30T23:17:27Z New Revision: f6740fe483e9fa0c76aa9f176ff68f51f47a1302 URL: https://github.com/llvm/llvm-project/commit/f6740fe483e9fa0c76aa9f176ff68f51f47a1302 DIFF: https://github.com/llvm/llvm-project/commit/f6740fe483e9fa0c76aa9f176ff68f51f47a1302.diff LOG:

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

thakis added a comment. (I don't think the argument about '\' in include lines applies to this patch (?)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 ___

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

thakis added a comment. As said elsewhere, I think this is too simplistic. It's good to make this dependent on the triple, instead of on the host platform. But we should have a flag that controls which slash direction to use on windows triples, since different people will want different

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:45 +// PPC64: @q = global %struct.Q zeroinitializer, align 16{{$}} +// AIX64: @q = global %struct.Q zeroinitializer, align 1{{$}} _Atomic(Q) q; // expected-no-diagnostics

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef &&

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 419282. void added a comment. Moved the randomization to a better spot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/include/clang/AST/Decl.h

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419281. cor3ntin added a comment. Remote commented-out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files:

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added a comment. This is not quite mature. I think it needs a few more tests, notably codegen tests which I'm not sure how to write properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768

[PATCH] D122768: [Clang] Support capturing structured bindings in lambdas

cor3ntin created this revision. Herald added subscribers: carlosgalvezp, martong, arphaman, zzheng. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao updated this revision to Diff 419277. ayzhao added a comment. Remove errant diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/lib/AST/Expr.cpp

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson. Herald

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:313 +llvm::StringRef DirPath = llvm::sys::path::parent_path(HeaderPath); +if (!HS.getFileMgr().getVirtualFileSystem().getRealPath(DirPath, Path)) + SearchPaths.emplace_back(Path);

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419265. sammccall added a comment. revert to previous version of realpath code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files:

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419262. sammccall added a comment. Revert StdLibLocation to realpath, document why Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files:

[PATCH] D122759: [time-report] Add timers to codegen actions

weiwang updated this revision to Diff 419261. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122759/new/ https://reviews.llvm.org/D122759 Files: clang/include/clang/Frontend/FrontendAction.h

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. (sorry about the long delay, would still love to merge this) Comment at: clang-tools-extra/clangd/index/StdLib.cpp:92 + // The umbrella header is the same for all versions of each language. + // Headers that are unsupported in old lang versions are

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419259. sammccall marked 15 inline comments as done. sammccall added a comment. Herald added a project: All. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 added a comment. The test currently fails because we don't do the stripping when we emit the precompiled header, it will simply be imported using the mangled version and it will not have in the original input info associated with it. I will need to figure out where we emit the PCH

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: asavonic, dexonsmith, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D122611: [clang][extract-api] Add support for macros

dang closed this revision. dang added a comment. 529a0570f7e8c5144bd3ad057e43f00e3af58d1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang closed this revision. dang added a comment. a9909d23e9bb8c4649cba1c14d479c28df4ca185 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

ajohnson-uoregon updated this revision to Diff 419252. ajohnson-uoregon added a comment. Removing specific argument matchers and leaving just hasKernelConfig() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120952/new/

[PATCH] D122611: [clang][extract-api] Add support for macros

thakis added a comment. My windows bot cycled green, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___ cfe-commits mailing list

[PATCH] D122759: [time-report] Add timers to codegen actions

weiwang created this revision. Herald added subscribers: ormris, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122759

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6965-6966 // Parse GNU attributes, if present. MaybeParseGNUAttributes(ParmDeclarator); +MaybeParseHLSLSemantics(DS.getAttributes()); beanz wrote: > aaron.ballman

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

aaron.ballman added a comment. In D122627#3417495 , @beanz wrote: > @aaron.ballman I pushed updates in rGff6696c842ba > . > > The one bit we discussed that I didn't do anything for is

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added a comment. In D120949#3417545 , @ajohnson-uoregon wrote: > Okay, I put the assert back in and made a thing similar to HasSizeMatcher > that works and all the tests pass. > > What do you mean by a release note, in the commit message,

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. @thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me? Repository: rG LLVM Github Monorepo

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 419248. ajohnson-uoregon added a comment. Okay, I put the assert back in and made a thing similar to HasSizeMatcher that works and all the tests pass. What do you mean by a release note, in the commit message, in the docs...? Repository: rG

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 985eaa1 - [clang][extract-api][NFC] Don't remap the generated input buffer in PPOpts

Author: Daniel Grumberg Date: 2022-03-30T20:38:09+01:00 New Revision: 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e URL: https://github.com/llvm/llvm-project/commit/985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e DIFF:

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:275 + State.Env.getValue(*ValueOrPredExpr, SkipPast::None)); + if (ExprValue == nullptr) { +auto = State.Env.createStorageLocation(*ValueOrPredExpr);

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 419243. ymandel added a comment. delete line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane added a comment. I think I'm generally in favor, would still like to see the feedback from the original submitter here to see if there is more work to do in here that would be valuable. Comment at: clang/lib/Sema/SemaChecking.cpp:15471 if (IsUnboundedArray) { +

[PATCH] D122611: [clang][extract-api] Add support for macros

thakis added a comment. Looks like either this or your other commit at the same time broke tests on windows: http://45.33.8.238/win/55345/step_7.txt Please take a look, and revert for now if it takes a while to fix. (Also, please add a "Differential Revision: https://reviews.llvm.org/D122611;

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. In D122748#3417240 , @erichkeane wrote: > That said, we might not want to early-exist here, I think we can just skip > the `IsUnboundedArray` branch? It seems you are right, thanks, fixed. Repository: rG LLVM Github

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. @aaron.ballman I pushed updates in rGff6696c842ba . The one bit we discussed that I didn't do anything for is the template case. Neither clang or the HLSL compiler support parsing Microsoft attributes

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX updated this revision to Diff 419242. ArcsinX added a comment. Check for function type only if IsUnboundedArray is true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 Files:

[clang] ff6696c - Expanding HLSL attribute diagnostics

Author: Chris Bieneman Date: 2022-03-30T14:15:01-05:00 New Revision: ff6696c842bac0b15fc04015b25ead721768eac9 URL: https://github.com/llvm/llvm-project/commit/ff6696c842bac0b15fc04015b25ead721768eac9 DIFF:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 419240. ymandel marked 5 inline comments as done. ymandel added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122756: [clang-format] Fix a crash in qualifier alignment

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Related to

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Herald added a project: All. I added https://github.com/llvm/llvm-project/issues/54654 documenting what I found when testing this patch on amdgpu. @ggeorgakoudis Can you please rebase this patch on top of main? Thanks. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham). Repository: rG LLVM Github Monorepo

[clang] 3fda0ed - [VFS] RedirectingFileSystem only replace path if not already mapped

Author: Ben Barham Date: 2022-03-30T11:52:41-07:00 New Revision: 3fda0edc51fd68192a30e302d45db081bb02d7f9 URL: https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9 DIFF: https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9.diff

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I cannot view the diff between the last two revisions: > Unhandled Exception ("Exception") > Found unknown intradiff source line, expected a line beginning with "+", "-", > or " " (space): \ No newline at end of file

[PATCH] D122611: [clang][extract-api] Add support for macros

dyung added a comment. This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/19441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

efriedma added a comment. > Subscript on svbool_t is not allowed as this doesn't really have meaningful > semantics. Not sure what you mean by this; LLVM supports extractelement on `` vectors. I guess the fact that it's a "vscale x 16" element vector might not be intuitive? Repository: rG

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall updated this revision to Diff 419225. sammccall marked 10 inline comments as done. sammccall added a comment. Herald added a project: All. address comments (sorry for long turnaround) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

erichkeane added subscribers: Fznamznon, erichkeane. erichkeane added a comment. Attn: @Fznamznon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://reviews.llvm.org/D122549

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 419222. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files: clang/test/Frontend/stack-usage-safestack.c

[clang] 73ab5fd - [clang] Fix shared build. NFC.

Author: Michael Liao Date: 2022-03-30T14:05:14-04:00 New Revision: 73ab5fd17b5726543554621410124ebae953dc6b URL: https://github.com/llvm/llvm-project/commit/73ab5fd17b5726543554621410124ebae953dc6b DIFF: https://github.com/llvm/llvm-project/commit/73ab5fd17b5726543554621410124ebae953dc6b.diff

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall updated this revision to Diff 419213. sammccall marked 3 inline comments as done. sammccall added a comment. Herald added a project: All. Oops, this never got landed! Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane added a comment. It seems like this entire section of code was added here: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a @chrish_ericsson_atx should probably take a look at this. That said, we might not want to early-exist here, I think we can

[clang] 529a057 - [clang][extract-api] Add support for macros

Author: Daniel Grumberg Date: 2022-03-30T18:33:10+01:00 New Revision: 529a0570f7e8c5144bd3ad057e43f00e3af58d1b URL: https://github.com/llvm/llvm-project/commit/529a0570f7e8c5144bd3ad057e43f00e3af58d1b DIFF:

[clang] a9909d2 - [clang][extractapi] Tie API and serialization to the FrontendAction

Author: Daniel Grumberg Date: 2022-03-30T18:32:58+01:00 New Revision: a9909d23e9bb8c4649cba1c14d479c28df4ca185 URL: https://github.com/llvm/llvm-project/commit/a9909d23e9bb8c4649cba1c14d479c28df4ca185 DIFF:

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 ___ cfe-commits mailing list

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, erichkeane, abhinavgaba, chrish_ericsson_atx. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang crashes with i386

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 419208. lenary added a comment. - Remove whitespace change in ARMSubtarget - Remove commented-out debug lines in RDFGraph Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 419207. dang marked 3 inline comments as done. dang added a comment. Update with code review feedback and the rebased code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any inputs. This generates a /// single header that

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419205. dang added a comment. Update using the correct patch this time around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0550601d1801: [Clang] Add a compatibiliy warning for non-literals in constexpr. (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[clang] 0550601 - [Clang] Add a compatibiliy warning for non-literals in constexpr.

Author: Corentin Jabot Date: 2022-03-30T19:18:53+02:00 New Revision: 0550601d180111a1c48baf170c2e7e9c7fac28c2 URL: https://github.com/llvm/llvm-project/commit/0550601d180111a1c48baf170c2e7e9c7fac28c2 DIFF:

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added a comment. I thing to support the template case, we would have to modify `TemplateDeclInstantiator::VisitVarDecl` - which seems the best way to have a diagnostic without running through the whole function AST twice. However, there is currently no check of any sort there so it

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary planned changes to this revision. lenary added inline comments. Comment at: llvm/lib/CodeGen/RDFGraph.cpp:1096 RegisterRef RR = PDA.Addr->getRegRef(*this); -#ifndef NDEBUG -// Assert if the register is defined in two or more unrelated defs. -// This could

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary removed a reviewer: kparzysz. lenary added a comment. @kparzysz I have rewritten this to avoid using RDFGraph, so I don't think this needs you to review it any more. Comment at: llvm/test/CodeGen/ARM/aes-erratum-fix.ll:49 + +define <16 x i8> @aese_once_via_val(<16 x

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 419202. lenary added a comment. - Rewrite pass in terms of ReachingDefAnalysis - Split tests into separate commit, for ease of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/

[clang] 61d67c8 - Revert "[ASTMatchers] Output currently matching node on crash"

Author: Nathan James Date: 2022-03-30T18:10:48+01:00 New Revision: 61d67c8eecd2547bc690f9a6bba61b9ba814c71b URL: https://github.com/llvm/llvm-project/commit/61d67c8eecd2547bc690f9a6bba61b9ba814c71b DIFF: https://github.com/llvm/llvm-project/commit/61d67c8eecd2547bc690f9a6bba61b9ba814c71b.diff

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(),

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419197. dang marked 2 inline comments as done. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files:

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

dcandler added a comment. The issue I found was trying to use getDefaultDenormalModeForType during constant folding to account for denormals (https://reviews.llvm.org/D116952). Setting denormal-fp-math to a non-IEEE mode without specifying denormal-fp-math-f32 still results in the

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

uabelho added a comment. In D122471#3416797 , @nikic wrote: > @uabelho Can you please check whether > https://github.com/llvm/llvm-project/commit/d6887256c2cae1b1b721bd47459be6d86003db6f > fixes the problem you're seeing? Hi @nikic Yes, that patch

[PATCH] D122713: [RISCV] [NFC] Add tests for vector load/store overloaded intrinsics of FP16

craig.topper added a comment. These tests files are already too long and have been timing out in phabricator. @4vtomat has a patch D122370 to split them up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 419181. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/docs/MisExpect.rst clang/docs/ReleaseNotes.rst

  1   2   >