[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao marked 2 inline comments as done. rZhBoYao added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2899-2909 +/// C++ [dcl.fct.def.general]p1 +/// function-body: +/// = delete ; +/// = default ; +Delete, +Default, +

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu added a comment. > On the other hand, why not use 16 for both? I am consistent with @aaron.ballman here. Comment at: clang/include/clang/AST/DeclTemplate.h:1156-1157 - TemplateParmPosition(unsigned D, unsigned P) : Depth(D), Position(P) {} + static constexpr

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu updated this revision to Diff 421419. ChuanqiXu added a comment. Address comments: - Add assertions to show the input wouldn't hit the boundaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123298/new/ https://reviews.llvm.org/D123298 Files:

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2899-2909 +/// C++ [dcl.fct.def.general]p1 +/// function-body: +/// = delete ; +/// = default ; +Delete, +Default, + rZhBoYao wrote: > ChuanqiXu wrote: > >

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao marked an inline comment as done. rZhBoYao added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2899-2909 +/// C++ [dcl.fct.def.general]p1 +/// function-body: +/// = delete ; +/// = default ; +Delete, +Default, +

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421416. void added a comment. Fix bad formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h

[clang] 74b56e0 - [NFC] Remove unused variable in CodeGenModules

Author: Chuanqi Xu Date: 2022-04-08T11:52:31+08:00 New Revision: 74b56e02bda09ae735c6aeca583a2078375f2da1 URL: https://github.com/llvm/llvm-project/commit/74b56e02bda09ae735c6aeca583a2078375f2da1 DIFF: https://github.com/llvm/llvm-project/commit/74b56e02bda09ae735c6aeca583a2078375f2da1.diff

[PATCH] D122734: [HIP] Fix mangling number for local struct

yaxunl added a comment. In D122734#3437344 , @tra wrote: > In D122734#3435086 , @yaxunl wrote: > >> This patch takes a similar approach as https://reviews.llvm.org/D69322 has >> done for lambda. When doing host

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/ScopeInfo.h:843 + /// and the capture should not be visible before. + llvm::DenseMap DelayedCaptures; + I hope the comment explains the meaning of unsigned here. If it means index, I think

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. kernels in anonymous name space needs to have unique name to avoid duplicate symbols. Fixes: https://github.com/llvm/llvm-project/issues/54560

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

ChuanqiXu added a comment. I agree this one is better. Comment at: clang/include/clang/Sema/Sema.h:2899-2909 +/// C++ [dcl.fct.def.general]p1 +/// function-body: +/// = delete ; +/// = default ; +Delete, +Default, + Agree to

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically. Please wait for 1~2 weeks to land this in case there are other comments. Comment at: clang/lib/Sema/SemaConcept.cpp:496-497 + + // Attn Reviewers: we

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. MosheBerman requested review of this revision. Herald added a

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421385. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421384. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281 +inline StringRef getTokenName(const Token ) { + return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifier() inline is pretty redundant here. Did you

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. When a "keyword"

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz updated this revision to Diff 421373. beanz added a comment. Updating with edits based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 Files: clang/docs/HLSLSupport.rst

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 421371. njames93 added a comment. Use new tweak InsertionPoint logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Files:

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3437604 , @pcc wrote: >> Note that if additional data has been injected between the KCFI >> type identifier and the start of the function, e.g. by using >> -fpatchable-function-entry, the offset in bytes must be

[clang] 1cee3d9 - DebugInfo: Consider the type of NTTP when simplifying template names

Author: David Blaikie Date: 2022-04-08T00:00:46Z New Revision: 1cee3d9db77b2c62a03efe1cce45f627dcbe6457 URL: https://github.com/llvm/llvm-project/commit/1cee3d9db77b2c62a03efe1cce45f627dcbe6457 DIFF: https://github.com/llvm/llvm-project/commit/1cee3d9db77b2c62a03efe1cce45f627dcbe6457.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith created this revision. rsmith added reviewers: aaron.ballman, rnk. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We still require these functions to be declared before they can be used, but

[PATCH] D119296: KCFI sanitizer

pcc added a comment. > Note that if additional data has been injected between the KCFI > type identifier and the start of the function, e.g. by using > -fpatchable-function-entry, the offset in bytes must be specified > using -fsanitize-kcfi-offset= to avoid errors. The offset > must be the same

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421358. void added a comment. Make the randomize_layout and no_randomize_layout attributes mutually exclutsive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao updated this revision to Diff 421345. rZhBoYao added a comment. Added release note. Also, push to my repo to make sure the release note is correctly rendered: https://github.com/poyaoc97/llvm-project/commit/1167f0fc6b91 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122981/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added a comment. In D121637#3437371 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/55893/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for finding this, not sure

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao updated this revision to Diff 421338. rZhBoYao retitled this revision from "[Clang] Diagnose incomplete return/param types only when function is not deleted" to "[Clang] CWG 1394: Incomplete types as parameters of deleted functions". rZhBoYao edited the summary of this revision.

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz added a comment. I'll do an edit pass tonight and update. I've also gone through and replied to some of the questions and comments inline. Thank you! Comment at: clang/docs/HLSLSupport.rst:22-23 +`_. in all its

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/55893/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122734: [HIP] Fix mangling number for local struct

tra added a comment. In D122734#3435086 , @yaxunl wrote: > This patch takes a similar approach as https://reviews.llvm.org/D69322 has > done for lambda. When doing host compilation for CUDA/HIP on Windows with > MSVC toolchain, mangling number of

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao updated this revision to Diff 421328. rZhBoYao marked 5 inline comments as done. rZhBoYao added a comment. Removed member function test cases and addressed comments, which includes: 1. Sema::SetFunctionBodyKind 2. Change enum names 3. Be clear about delete being C++ specific. CHANGES

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. (@probinson as someone I've disagreed with about this before) Personally I think there's limited value in expressing 'auto' in DWARF at all - we could omit function declarations if the return type is not known (undeduced auto) and wouldn't lose much - basically

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added inline comments. Comment at: clang/docs/HLSLSupport.rst:190 +* RTTI +* Exceptions +* Multiple inheritance How about goto and labels? Irreducible control flow? Are infinite loops valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added a comment. Looks good to me overall, I just left some local comments. Please take my writing suggestions with a pinch of salt, English is my second language. Comment at: clang/docs/HLSLSupport.rst:13 +describes the high level goals of the project, the guiding

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3434733 , @ggeorgakoudis wrote: > In D102107#3417452 , @dhruvachak > wrote: > >> I added https://github.com/llvm/llvm-project/issues/54654 documenting what I >> found

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

erichkeane added a comment. This definitely looks like it is 'nicer' than before, a few smaller/nit-ish comments. Additionally, Phab made a REAL mess of the diff, if you could give a quick summary of what changes were actually made (vs things that were moved slightly and causing massive

[PATCH] D101624: [clang-tidy] Make performance-inefficient-vector-operation work on members

njames93 added a comment. Herald added a project: All. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101624/new/ https://reviews.llvm.org/D101624 ___ cfe-commits mailing list

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 421310. njames93 added a comment. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files:

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked an inline comment as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao updated this revision to Diff 421305. rZhBoYao added a comment. Handling of eagerly parsed deleted or defaulted function must happen AFTER `D.complete(Res);`. A nice looking diff: https://github.com/poyaoc97/llvm-project/commit/dc37a262582f6a2d8143c6f1f586dc657b4b5311 CHANGES SINCE

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked 2 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[clang] da1fc3a - [Driver][NFC] Simplify handling of flags in Options.td

Author: Emil Kieri Date: 2022-04-07T20:38:51+02:00 New Revision: da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9 URL: https://github.com/llvm/llvm-project/commit/da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9 DIFF: https://github.com/llvm/llvm-project/commit/da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9.diff

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1fc3ae955d: [Driver][NFC] Simplify handling of flags in Options.td (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", I'd prefer not to use `dyn_cast` as

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421303. quinnp added a comment. Fixing a set of builtins added by the rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files:

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

erichkeane added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D, rZhBoYao wrote: >

[clang] 50de659 - [clang] Use -triple, not -target for %clang_cc1

Author: Alex Brachet Date: 2022-04-07T18:19:54Z New Revision: 50de659adcc19c4c197ba5e9a7719325af7151ee URL: https://github.com/llvm/llvm-project/commit/50de659adcc19c4c197ba5e9a7719325af7151ee DIFF: https://github.com/llvm/llvm-project/commit/50de659adcc19c4c197ba5e9a7719325af7151ee.diff LOG:

[clang] 3329dae - [clang] Fix macos build broken after D120989

Author: Alex Brachet Date: 2022-04-07T18:17:29Z New Revision: 3329dae5cb8a8c91c518dd87c09e88c4fad507bd URL: https://github.com/llvm/llvm-project/commit/3329dae5cb8a8c91c518dd87c09e88c4fad507bd DIFF: https://github.com/llvm/llvm-project/commit/3329dae5cb8a8c91c518dd87c09e88c4fad507bd.diff LOG:

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked 3 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[clang-tools-extra] d0fcbb3 - [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

Author: Nathan James Date: 2022-04-07T19:13:50+01:00 New Revision: d0fcbb37838a653c1c3f8d6ac83e64714c407b19 URL: https://github.com/llvm/llvm-project/commit/d0fcbb37838a653c1c3f8d6ac83e64714c407b19 DIFF: https://github.com/llvm/llvm-project/commit/d0fcbb37838a653c1c3f8d6ac83e64714c407b19.diff

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0fcbb37838a: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer (authored by njames93). Herald added a project: All. Changed prior to commit:

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

This revision was automatically updated to reflect the committed changes. Closed by commit rG101559225189: [clang][extract-api][NFC] Use dedicated API to check for macro equality (authored by dang). Changed prior to commit: https://reviews.llvm.org/D123295?vs=421147=421290#toc Repository:

[clang] 1015592 - [clang][extract-api][NFC] Use dedicated API to check for macro equality

Author: Daniel Grumberg Date: 2022-04-07T19:08:17+01:00 New Revision: 101559225189e63b7f6236fb944501b1e6b74a87 URL: https://github.com/llvm/llvm-project/commit/101559225189e63b7f6236fb944501b1e6b74a87 DIFF:

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. In D123297#3436867 , @mehdi_amini wrote: > `-mmlir` is fine with me, but note that MLIR has much less global options > than LLVM: you will only get access to context and passmanager options and > not individual passes

[PATCH] D123297: [flang][driver] Add support for -mmlir

mehdi_amini added a comment. `-mmlir` is fine with me, but note that MLIR has much less global options than LLVM: you will only get access to context and passmanager options and not individual passes flags. That's not a criticism :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Neat! I think you've broken the FilesToTokenCache by moving it into the loop, so I'd expect further wins from fixing that. (If you don't see any, something seems wrong: syntax::tokenize

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421286. quinnp added a comment. Rebasing with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D120989: Support debug info for alias variable

thakis added a comment. This breaks tests on mac: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8817534773179515649/+/u/package_clang/stdout?format=raw Script: -- : 'RUN: at line 1'; /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/bin/clang -cc1

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ac84901e9b: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary (authored by psamolysov-intel, committed by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b4ac849 - [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

Author: Pavel Samolysov Date: 2022-04-07T10:38:46-07:00 New Revision: b4ac84901e9b88429e5e51dc0b4a17b8d3e37708 URL: https://github.com/llvm/llvm-project/commit/b4ac84901e9b88429e5e51dc0b4a17b8d3e37708 DIFF:

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Value *Y = +Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3)); return Builder.CreateOr(X, Y); nemanjai wrote: > Nit: I understand that we

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421279. quinnp marked an inline comment as done. quinnp added a comment. Fixing some testcases that broke due to re-ordering IR in my last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. > Are there cases where we emit debug info and we don't have the deduced type? I don't think that would happen for a lambda. https://dwarfstd.org/ShowIssue.php?issue=131217.1 specifically calls out method declarations without definitions, which makes sense to me.

[PATCH] D122008: [flang][driver] Add support for generating executables

tschuett added a comment. In my example, they even promised that the flag will removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 ___ cfe-commits mailing

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. I also very much like the second option. I think it prevents a naive user from stumbling into treacherous territory. Also, as someone who is funded to write tests for flang, making it easier to build executables would expand the options for testing. Currently, we're

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 421270. jhuber6 added a comment. Make `-foffload-new-driver` imply GPU-RDC mode, it won't work otherwise. Also adjust tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In preparation for allowing other

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1-12 // RUN: %clang_cc1 -verify -triple

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers added a comment. Also, for the initial lines of commit messages, please try to make them less ambiguous about which parts of the project they touch. For example `[Clang][Fortify] drop inline decls when redeclared` is more descriptive should this get bucketed with other commits

[clang] 4048aad - [clang][ExtractAPI] Fix declaration fragments for ObjC methods

Author: Zixu Wang Date: 2022-04-07T10:22:41-07:00 New Revision: 4048aad85a843d2b15cb8e60b2ea37f148b7b770 URL: https://github.com/llvm/llvm-project/commit/4048aad85a843d2b15cb8e60b2ea37f148b7b770 DIFF: https://github.com/llvm/llvm-project/commit/4048aad85a843d2b15cb8e60b2ea37f148b7b770.diff

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4048aad85a84: [clang][ExtractAPI] Fix declaration fragments for ObjC methods (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the quick fix! Comment at: clang/lib/CodeGen/CGExpr.cpp:4968-4969 // name to make it clear it's not the actual builtin. -if

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. I think this is reasonable, but could you add a testcase? Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1684 + +if (AT->isDeduced() && ThisPtr->getPointeeCXXRecordDecl()->isLambda()) +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-openmp-driver.cu:1 +// REQUIRES: clang-driver +// REQUIRES: x86-registered-target clang-driver is unneeded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-openmp-driver.cu:10 +// CHECK: "nvptx64-nvidia-cuda" - "clang", inputs: ["[[INPUT:.+]]"], output: "[[PTX_SM_35:.+]]" +// CHECK: "nvptx64-nvidia-cuda" - "NVPTX::Assembler", inputs: ["[[PTX_SM_35]]"], output:

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added a comment. I did some experiments where I did not restrict this to lambdas case and I could not come up with a test case where we emit debug info and do not have the deduced type. Are there cases where we emit debug info and we don't have the deduced type? If not what do we gain

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaebe5fc6e7d8: [clang][extract-api] Process only APIs declared in inputs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] aebe5fc - [clang][extract-api] Process only APIs declared in inputs

Author: Daniel Grumberg Date: 2022-04-07T17:49:05+01:00 New Revision: aebe5fc6e7d8ab99f3796067d430752552932d28 URL: https://github.com/llvm/llvm-project/commit/aebe5fc6e7d8ab99f3796067d430752552932d28 DIFF:

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. The ScudoCUnitTest-mips64el-Test failure looks like a mips64el specific issue. FAILED: lib/scudo/standalone/tests/ScudoCUnitTest-mips64el-Test cd /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests &&

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. In D116203#3436572 , @cjdb wrote: > Having `__remove_cv` do more than it's advertised to do doesn't sound like a > great idea to me. Both libc++ >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. Here are my remarks. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1415-1416 + + Range CoarseLHS = fillGaps(LHS); + Range CoarseRHS = fillGaps(RHS); + Avoid filling the gaps, because it's completely

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik created this revision. shafik added reviewers: aprantl, dblaikie, probinson. Herald added a project: All. shafik requested review of this revision. D70524 added support for auto return types for C++ member functions. I was implementing support on the LLDB

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. In D116203#3435729 , @aaron.ballman wrote: > In D116203#3434761 , @rjmccall > wrote: > >> In D116203#3434515 , @cjdb wrote: >> >>> In

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. Perhaps, a description could be added to this patch before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/D92956 ___

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123295/new/ https://reviews.llvm.org/D123295 ___

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rriddle wrote: > awarzynski wrote: > > awarzynski wrote: > > > rovka

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. Herald added a project: All. @Quuxplusone I can commit this patch on behalf of @fanfuqiang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/D92956

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fe2c77a - [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

Author: Zixu Wang Date: 2022-04-07T09:17:30-07:00 New Revision: fe2c77a0065cda43418d625f0162a974ce8ec1e5 URL: https://github.com/llvm/llvm-project/commit/fe2c77a0065cda43418d625f0162a974ce8ec1e5 DIFF: https://github.com/llvm/llvm-project/commit/fe2c77a0065cda43418d625f0162a974ce8ec1e5.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. Thanks @erichkeane! @jyknight, @hubert.reinterpretcast, @eli.friedman -- I'll likely land this sometime tomorrow unless I hear from you. But if I land it and you still have comments, I'll be happy to address them post commit. CHANGES SINCE LAST ACTION

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

xazax.hun added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6387 +additional information specific to the annotation category. The optional +arguments must be constant expressions of arbitrary type. + Do we want to mention that it is not

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 421232. jhuber6 added a comment. Update with the more generic clang argument handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files:

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1816-1821 + void setLambdaIsDependent(bool IsDependent) { +auto *DD = DefinitionData; +assert(DD && DD->IsLambda && "setting lambda property of non-lambda class"); +auto =

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 421228. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 421227. cor3ntin marked 4 inline comments as done. cor3ntin added a comment. Address ChuanqiXu's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files:

[PATCH] D123297: [flang][driver] Add support for -mmlir

rriddle added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} awarzynski wrote: > awarzynski wrote: > > rovka wrote: > > > rovka

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

tejohnson added a comment. In D123026#3436323 , @psamolysov-intel wrote: > Colleagues, could you help me with landing? @tejohnson has approved the patch > (if I applied the suggestion as it was expected, thank you @tejohnson!) lgtm. I can commit for

  1   2   >