[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { yihanaa wrote: > erichkeane wrote: > > rsmith wrote: > > > yihanaa wrote: > > > > rsmith wrote:

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { erichkeane wrote: > rsmith wrote: > > yihanaa wrote: > > > rsmith wrote: > > > > rsmith wrote:

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu created this revision. zixuan-wu added reviewers: majnemer, kparzysz, ddunbar. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSKY is always in 4-byte align, no matter it's long long type.

[PATCH] D124857: [AIX][PGO] Enable linux style PGO on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2407c13aa4a4: [AIX][PGO] Enable linux style PGO on AIX (authored by w2yehia). Herald added projects: clang, Sanitizers. Herald added subscribers:

[clang] 2407c13 - [AIX][PGO] Enable linux style PGO on AIX

Author: Wael Yehia Date: 2022-05-05T04:10:39Z New Revision: 2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b URL: https://github.com/llvm/llvm-project/commit/2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b DIFF: https://github.com/llvm/llvm-project/commit/2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b.diff LOG:

[PATCH] D124813: [HLSL] Add clang builtin for HLSL.

yonghong-song resigned from this revision. yonghong-song added a comment. please having proper reviewers. Me, @anakryiko @ast are not the right persons to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124813/new/

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58abe36ae765: [clang][dataflow] Add flowConditionIsTautology function (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES

[clang] 58abe36 - [clang][dataflow] Add flowConditionIsTautology function

Author: Eric Li Date: 2022-05-05T03:57:43Z New Revision: 58abe36ae7654987f5af793e3e261ac0b43c870b URL: https://github.com/llvm/llvm-project/commit/58abe36ae7654987f5af793e3e261ac0b43c870b DIFF: https://github.com/llvm/llvm-project/commit/58abe36ae7654987f5af793e3e261ac0b43c870b.diff LOG:

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua marked 4 inline comments as done. li.zhe.hua added a comment. Ah, good catch regarding the flow condition deps not being tracked. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124943/new/

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua updated this revision to Diff 427183. li.zhe.hua added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124943/new/ https://reviews.llvm.org/D124943 Files:

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua added a comment. I'm playing around with a tool to take raw pointers and add a non-null annotation or convert them to references, for code that is assumed to be correct. So in this case, "interesting expression" is anything that would be UB if the pointer was null, e.g.

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:176-177 + /// Returns true if the constraints of the flow condition identified by + /// `Token` is always true. + bool

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 427182. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D104975: Implement P1949

C team. test.cpp: #include int main(int argc, char* argv[]) { auto 휕Ω = 4; std::cout << "휕Ω = " << 휕Ω << std::endl; } $ g++ --version g++ (GCC) 12.0.1 20220504 (prerelease) Copyright (C) 2022 Free Software Foundation, Inc. This is free so

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push craig.topper wrote: > The argument should

[clang] aa25b55 - [X86] Add `void` to void function. NFC

Author: Phoebe Wang Date: 2022-05-05T10:58:46+08:00 New Revision: aa25b55bde87501f72346704136951834140bda8 URL: https://github.com/llvm/llvm-project/commit/aa25b55bde87501f72346704136951834140bda8 DIFF: https://github.com/llvm/llvm-project/commit/aa25b55bde87501f72346704136951834140bda8.diff

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

briantracy marked an inline comment as done. briantracy added a comment. Thank you Mark and Gabor. At your discretion, could you commit this on my behalf? My email is "brian.trac...@gmail.com" and full name is "Brian Tracy". Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp created this revision. porglezomp added reviewers: hokein, sammccall, dexonsmith. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary in order to pick up the default C/C++

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. In D124534#3490732 , @aaron.ballman wrote: > The tests run in -cc1 mode and don't #include anything, so I don't think the > issue is an internally included SDK. I think the issue could be from this: >

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added a comment. @iains ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124149/new/ https://reviews.llvm.org/D124149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. Thank you so much for your clear review! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1023-1024 +// Typoed directive warnings +def TypoedDirective : DiagGroup<"typoed-directive">; + aaron.ballman wrote: > We don't

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

MTC added a comment. In D123924#3482342 , @aaron.ballman wrote: > I don't know enough about this code base to feel comfortable signing off on > it, but the changes look reasonable to me FWIW. Thanks, Aaron! I will find another guy to review the

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

owenpan added a comment. No, because the first part of that test case would cause non-consecutive assignments to be aligned. (See https://github.com/llvm/llvm-project/issues/55265.) Only then would the `if` block be treated as a braced list and get misindented. We should definitely use test

[PATCH] D124611: [RISCV][Clang] add more tests for clang driver. (NFC)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124611/new/ https://reviews.llvm.org/D124611

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It's

[PATCH] D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

sammccall added a comment. Kadir, sending this your way as it looks like you investigated #856. I do plan to flip the global default, but not for libclang and friends :-( I feel like a coward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D104975: Implement P1949

intractabilis added a comment. In D104975#3492099 , @tahonermann wrote: > I am quite sure that gcc will also be implementing P1949 > as adopted for C++23. Yes, you are right, it is available in GCC 12

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The code looks good to me too. I was also wondering what sort of check will need this info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1398 + (sequence "W%u", 0, 7))>; +def FPR8_ARG : RegisterClass<"AArch64", [untyped], 8, (trunc FPR8, 7)> { + let Size = 8; sdesmalen wrote: >

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

xazax.hun added a comment. Overall looks good to me. I am curious what will the strategy be to properly support construction. Do you plan to introduce a customization point to `Env.createValue` to give checks/models a way to set properties up? Or do you have something else in mind?

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. @rupprecht, do you still do integration at Google? This patch might be interesting to try out, since it strengthens some warnings. Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:85-86

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5bb28511f2: Revert Revert [clang][extract-api] Use relative includes (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cb5bb28 - Revert "Revert "[clang][extract-api] Use relative includes""

Author: Zixu Wang Date: 2022-05-04T14:52:45-07:00 New Revision: cb5bb28511f2c7530806af7ef53696deed453ca1 URL: https://github.com/llvm/llvm-project/commit/cb5bb28511f2c7530806af7ef53696deed453ca1 DIFF: https://github.com/llvm/llvm-project/commit/cb5bb28511f2c7530806af7ef53696deed453ca1.diff

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

zixuw added a comment. In D124964#3492423 , @dang wrote: > LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a > string temporary to match against before and now we store it for long enough > to process the match results? Yup,

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a string temporary to match against before and now we store it for long enough to process the match results? Repository:

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like regular assignment, compound assignment operators can

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua created this revision. li.zhe.hua added reviewers: sgatev, ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to 62b2a47

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

zixuw updated this revision to Diff 427140. zixuw added a comment. Whitespace change: clang-format removed an empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124964/new/ https://reviews.llvm.org/D124964 Files:

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

zixuw created this revision. zixuw added reviewers: ributzka, dang, cishida. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reapply the change after fixing sanitizer errors. The original problem was that

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

curdeius added a comment. Just one last thought, shouldn't we have a test case close to what was reported in the issue? I.e. with PP directives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/ https://reviews.llvm.org/D124956

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

curdeius accepted this revision. curdeius added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/ https://reviews.llvm.org/D124956 ___ cfe-commits mailing list

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8d33dbd8a8: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer. (authored by ymandel). Repository: rG LLVM Github

[clang-tools-extra] 9a8d33d - [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

Author: Yitzhak Mandelbaum Date: 2022-05-04T20:56:56Z New Revision: 9a8d33dbd8a851ccb9821d5d1346aa225398cadc URL: https://github.com/llvm/llvm-project/commit/9a8d33dbd8a851ccb9821d5d1346aa225398cadc DIFF: https://github.com/llvm/llvm-project/commit/9a8d33dbd8a851ccb9821d5d1346aa225398cadc.diff

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 427127. steplong added a comment. Error if pragma function/intrinsic is used inside a function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files:

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel marked an inline comment as done. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124952/new/ https://reviews.llvm.org/D124952 ___ cfe-commits mailing list

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel updated this revision to Diff 427126. ymandel added a comment. address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124952/new/ https://reviews.llvm.org/D124952 Files:

[PATCH] D124719: [docs] PCH usage documentation update

tahonermann reopened this revision. tahonermann added a comment. This revision is now accepted and ready to land. Reopening for further discussion or clarification. The changes appear to suggest that a PCH file won't be implicitly used when an explicit include for the corresponding header is

[clang] b1a55d0 - Fix a crash on targets where __bf16 isn't supported

Author: Aaron Ballman Date: 2022-05-04T16:45:59-04:00 New Revision: b1a55d0895249a493da5a442e44ee0a846410e88 URL: https://github.com/llvm/llvm-project/commit/b1a55d0895249a493da5a442e44ee0a846410e88 DIFF: https://github.com/llvm/llvm-project/commit/b1a55d0895249a493da5a442e44ee0a846410e88.diff

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:107 + ASSERT_EQ(Errors.size(), 1U); + // This should match the input;

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5219 +// function. +else if (!CGF.CurFn->getAttributes().hasFnAttr(AttributeNoBuiltin)) return CGCallee::forBuiltin(builtinID, FD); hans wrote: > What if CurFn has the

[PATCH] D104975: Implement P1949

tahonermann added a comment. > I hope at least GCC will not implement this arbitrary restriction on math > symbols. I would argue a partial derivative symbol in C++ has more sense than > a skull emoji. I am quite sure that gcc will also be implementing P1949

[libunwind] 6123e9c - [libunwind] Silence warnings about unused variables. NFC.

Author: Martin Storsjö Date: 2022-05-04T22:55:02+03:00 New Revision: 6123e9c0d03bf1e3f43c3851f4122a7267b33c28 URL: https://github.com/llvm/llvm-project/commit/6123e9c0d03bf1e3f43c3851f4122a7267b33c28 DIFF:

[libunwind] f1f8899 - [libunwind] [CMake] Handle the RelWithDebInfo configuration similarly to Release

Author: Martin Storsjö Date: 2022-05-04T22:55:01+03:00 New Revision: f1f8899a18822ede04d8f90cbdae29d66333d7dc URL: https://github.com/llvm/llvm-project/commit/f1f8899a18822ede04d8f90cbdae29d66333d7dc DIFF:

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi added a comment. In D124687#3486473 , @akyrtzi wrote: > In D124687#3485710 , @tschuett > wrote: > >> Is there overhead in the non dependency scanning mode? > > Good suggestion, I'll do some measurements

[PATCH] D124955: [clang-tidy] Make header-guard check a little looser on comment whitespace

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently it

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 427106. vabridgers added a comment. Address comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files:

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.c:675-676 +// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm" +// CHECK-LD32-SHARED-EXPORTS-NOT: "-X" +// CHECK-LD32-SHARED-EXPORTS-NOT: "32" +// CHECK-LD32-SHARED-EXPORTS: "{{.*}}ld{{(.exe)?}}"

[clang] 2966f0f - Revert "[clang][extract-api] Use relative includes"

Author: Zixu Wang Date: 2022-05-04T12:27:20-07:00 New Revision: 2966f0fa505266735dbc8324b8821b7f0aa901ff URL: https://github.com/llvm/llvm-project/commit/2966f0fa505266735dbc8324b8821b7f0aa901ff DIFF: https://github.com/llvm/llvm-project/commit/2966f0fa505266735dbc8324b8821b7f0aa901ff.diff

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added a subscriber: rjmccall. aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { mboehme wrote: > aaron.ballman wrote: > > mboehme wrote: >

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

sammccall added a comment. OK, so wanting this to be utility makes sense, and maybe/probably it should be the default. I'm still concerned some users will find this a large regression and we won't have a good workaround: - it'll use a lot more battery than before - not everyone will see the

[clang] 342e1c7 - [clang-format] Fix a bug in AlignConsecutiveAssignments

Author: owenca Date: 2022-05-04T12:04:43-07:00 New Revision: 342e1c77c360e745fc6457037e6c1e37b84f2791 URL: https://github.com/llvm/llvm-project/commit/342e1c77c360e745fc6457037e6c1e37b84f2791 DIFF: https://github.com/llvm/llvm-project/commit/342e1c77c360e745fc6457037e6c1e37b84f2791.diff LOG:

[PATCH] D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG342e1c77c360: [clang-format] Fix a bug in AlignConsecutiveAssignments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 427081. shafik removed reviewers: teemperor, jingham, jasonmolenda. shafik added a comment. Herald added a project: All. - Expanded test - applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Messages generated by Transformer rules may have `%` in them,

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3491782 , @akyrtzi wrote: > That said, you may want to consider dynamically switching to background if > running on laptop with battery, or other heuristics, My take on this is that it would be Apple's

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! In D124666#3490871 , @frederic-tingaud-sonarsource wrote: > By the way, in the current state of the code, there is no risk of such >

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 427087. njames93 added a comment. Added release notes. Fix build issues with previous push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/ https://reviews.llvm.org/D124806 Files:

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added a comment. Thanks for the comments! Per our discussion, I'll create a different test case with a pinned target and add the additional test case to be sure we see expected behavior. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 427082. njames93 added a comment. Reimplement matchers as an ASTVisitor instead. This massively simplifies the tracking of nested cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

akyrtzi added a comment. My recommendation is that indexing belongs to 'utility', as @stefanhaller mentioned the user is actively depending on functionality coming from the index. That said, you may want to consider dynamically switching to background if running on laptop with battery, or other

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { rsmith wrote: > yihanaa wrote: > > rsmith wrote: > > > rsmith wrote: > > > > aaron.ballman

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { yihanaa wrote: > rsmith wrote: > > rsmith wrote: > > > aaron.ballman wrote: > > > > yihanaa

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added a comment. In D124715#3490364 , @stefanhaller wrote: > In D124715#3488447 , @sammccall > wrote: > >> (How) does this interact with battery vs mains power on laptops? >> It seems like there's a

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin marked 8 inline comments as done. DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:985 +// CHECK-LD64-SHARED-EXPFULL: "-bM:SRE" +// CHECK-LD64-SHARED-EXPFULL: "-bnoentry" +// CHECK-LD64-SHARED-EXPFULL: "-b64" MaskRay

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. Accidentally added another test case in my local workspace. Removed in 5f841c71fc2cc77c92f526791cd7a938bcac69aa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5f841c7 - [NFC] Remove unfinished test case

Author: Zixu Wang Date: 2022-05-04T10:40:25-07:00 New Revision: 5f841c71fc2cc77c92f526791cd7a938bcac69aa URL: https://github.com/llvm/llvm-project/commit/5f841c71fc2cc77c92f526791cd7a938bcac69aa DIFF: https://github.com/llvm/llvm-project/commit/5f841c71fc2cc77c92f526791cd7a938bcac69aa.diff

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

NoQ added a comment. Yes, we've discussed this before, and I'm very much in favor of this change. This is assertion removal, and the assertion has been really useful back in the day, but the assertion doesn't seem to be realistic to maintain with all the new logic in the constraint solver

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua added a comment. This allows me to query when an expression is always encountered/executed. Alternatively, if I have a set of interesting expressions, I can note the flow condition at every expression, compute the disjunction of the set of flow conditions, and determine if execution

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz updated this revision to Diff 427065. rmaz added a comment. fix windows paths attempt #2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124874/new/ https://reviews.llvm.org/D124874 Files: clang/include/clang/Driver/Options.td

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff changes the serialization of the `ORIGINAL_PCH_DIR` entry in module files to be serialized relative to the module's

[PATCH] D123831: [clang][extract-api] Use relative includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c262fee08b5: [clang][extract-api] Use relative includes (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4c262fe - [clang][extract-api] Use relative includes

Author: Zixu Wang Date: 2022-05-04T10:28:01-07:00 New Revision: 4c262fee08b5383c96857d77eefe80d61c41d2b0 URL: https://github.com/llvm/llvm-project/commit/4c262fee08b5383c96857d77eefe80d61c41d2b0 DIFF: https://github.com/llvm/llvm-project/commit/4c262fee08b5383c96857d77eefe80d61c41d2b0.diff

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 427061. zixuw added a comment. Herald added a subscriber: arphaman. Update test case to use cc1 instead of driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

ymandel added a comment. The code looks good, but what is the intended application? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124943/new/ https://reviews.llvm.org/D124943 ___ cfe-commits mailing

[clang] 859d923 - Fix a failing assertion with vector type initialization

Author: Aaron Ballman Date: 2022-05-04T13:25:21-04:00 New Revision: 859d92394812c0e5e650ab337717719b9687e5ce URL: https://github.com/llvm/llvm-project/commit/859d92394812c0e5e650ab337717719b9687e5ce DIFF: https://github.com/llvm/llvm-project/commit/859d92394812c0e5e650ab337717719b9687e5ce.diff

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:335 + auto Satisfaction = + std::make_unique(Template, TemplateArgs); if (::CheckConstraintSatisfaction(*this, Template, ConstraintExprs, ilya-biryukov wrote: > sammccall

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua created this revision. li.zhe.hua added reviewers: ymandel, sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D124842: [NFC][CUDA][HIP] rework mangling number for aux target

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG62501bc45a2f: [NFC][CUDA][HIP] rework mangling number for aux target (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 62501bc - [NFC][CUDA][HIP] rework mangling number for aux target

Author: Yaxun (Sam) Liu Date: 2022-05-04T13:05:33-04:00 New Revision: 62501bc45a2fb4980725baccf48576cf9b45cd4d URL: https://github.com/llvm/llvm-project/commit/62501bc45a2fb4980725baccf48576cf9b45cd4d DIFF:

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. In D123831#3490684 , @dang wrote: > Since this is a new test can we use the approach in > https://reviews.llvm.org/D124634 to check for diagnostics output. I used FileCheck to check the input buffer dump in this test, but I'll

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c67c3c6789: [clang] Track how headers get included generally during lookup time (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b6c67c3 - [clang] Track how headers get included generally during lookup time

Author: Cyndy Ishida Date: 2022-05-04T09:52:31-07:00 New Revision: b6c67c3c67893d532fe741c508dfa2ac40fae1ad URL: https://github.com/llvm/llvm-project/commit/b6c67c3c67893d532fe741c508dfa2ac40fae1ad DIFF: https://github.com/llvm/llvm-project/commit/b6c67c3c67893d532fe741c508dfa2ac40fae1ad.diff

[PATCH] D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff changes the serialization of the `SUBMODULE_TOPHEADER` entry in module files to be serialized relative to the module's

[clang] 94d36fd - Fix a crash on invalid with _Generic expressions

Author: Aaron Ballman Date: 2022-05-04T12:41:56-04:00 New Revision: 94d36fdbd7d2c6eab250f15f65fd20a6447b92eb URL: https://github.com/llvm/llvm-project/commit/94d36fdbd7d2c6eab250f15f65fd20a6447b92eb DIFF: https://github.com/llvm/llvm-project/commit/94d36fdbd7d2c6eab250f15f65fd20a6447b92eb.diff

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:48 +#pragma clang diagnostic ignored "-Wuninitialized" unsigned int t; return __builtin_ia32_rdsspd(t); So if CET isn't enabled this intrinsic returns a random value instead of 0

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push The argument should also be `(void)`. Comment at:

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3561 << "intrinsic"; return; } hans wrote: > since the above is just a warning, we should probably still call the ActOn.. > method? Hmm, I'm not sure because all the

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 427040. steplong added a comment. Changed std::vector to llvm::SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files:

  1   2   >