[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25374 verifyFormat("if (a) {\n" " b = c >= 0 ? d\n" " : e;\n" Jeroen wrote: > Will it also add braces if they where not there yet?

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

Jeroen added a comment. Will it also add braces if they where not there yet? Comment at: clang/unittests/Format/FormatTest.cpp:25374 verifyFormat("if (a) {\n" " b = c >= 0 ? d\n" " : e;\n" Will it also add braces

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > This method

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} This method decides the file

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:528 + + //FIXME: Hash other interface-specific elements like protocols, etc. + vsapsai wrote: > jansvoboda11 wrote: > > Is this important to implement

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161 if (needsPrologueENDBR(MF, M)) { -auto MBB = MF.begin(); -Changed |= addENDBR(*MBB, MBB->begin()); +if (!ManualENDBR || MF.getFunction().doesCfCheck()) { +

[PATCH] D125149: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is generally a better default for tools

[PATCH] D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG57636c25904e: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125082/new/

[clang] 57636c2 - [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

Author: Petr Hosek Date: 2022-05-06T16:55:05-07:00 New Revision: 57636c25904e05c6b94370c82e52a89f5baf80f1 URL: https://github.com/llvm/llvm-project/commit/57636c25904e05c6b94370c82e52a89f5baf80f1 DIFF: https://github.com/llvm/llvm-project/commit/57636c25904e05c6b94370c82e52a89f5baf80f1.diff

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. tra wrote: > jhuber6 wrote: > > tra wrote: >

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. Strong +1. It would be great to backport it to llvm 14.0.x as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. jhuber6 wrote: > tra wrote: > > We're still using

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. tra wrote: > We're still using the same

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. We're still using the same numeric value for two

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao added a comment. In D122766#3450348 , @dexonsmith wrote: > In D122766#3450298 , @ayzhao wrote: > >> So, the general consensus seems to be that we should use backslashes when >> targeting Windows. >> >> I

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427774. ayzhao added a comment. another missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427773. ayzhao added a comment. missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao updated this revision to Diff 427771. ayzhao added a comment. Implement -ffile-reproducible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D125138: [clang] Add the flag -ffile-reproducible

ayzhao abandoned this revision. ayzhao added a comment. Duplicate of D122766 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125138/new/ https://reviews.llvm.org/D125138

[PATCH] D125138: [clang] Add the flag -ffile-reproducible

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When Clang generates the path prefix (i.e. the path of the directory where the file is) when generating __FILE__,

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reimplement

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 427766. jhuber6 added a comment. removing enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 427764. samitolvanen added a comment. Based on LKML feedback: - Fixed a bug in `Twine` usage. - Changed AArch64 to encode register information into the ESR and dropped `.kcfi_traps` generation for the arch. - Changed X86 to generate valid instructions

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable entry. +

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4cf1c6b8ed: [clang-format][NFC] Make all TokenAnnotator member functions const (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] af4cf1c - [clang-format][NFC] Make all TokenAnnotator member functions const

Author: owenca Date: 2022-05-06T14:46:32-07:00 New Revision: af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7 URL: https://github.com/llvm/llvm-project/commit/af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7 DIFF: https://github.com/llvm/llvm-project/commit/af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7.diff LOG:

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert added inline comments. Comment at: clang/docs/ReleaseNotes.rst:173 effect. - ``-Wmisexpect`` warns when the branch weights collected during profiling Or maybe I should add it here? Not sure why there is a blank line. Repository: rG LLVM

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx accepted this revision. ksyx added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123676/new/ https://reviews.llvm.org/D123676 ___ cfe-commits mailing list

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert updated this revision to Diff 427750. aaronpuchert added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124966/new/ https://reviews.llvm.org/D124966 Files: clang/docs/ReleaseNotes.rst

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec accepted this revision. rampitec added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 ___ cfe-commits mailing list

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert added a comment. In D124966#3497305 , @aaron.ballman wrote: > LGTM! You should probably add a release note for this change so users know > about it. Good point, I'll add a note about compound assignment and increment/decrement. I'll

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

kerbowa updated this revision to Diff 427747. kerbowa added a comment. Herald added a subscriber: jsilvanus. Use i32. Output hex. Fix hazard rec tests for pseudo instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/

[clang-tools-extra] 1eb9748 - Fix check-clang-tools target after 7cc8377f2c572a919ecb

Author: Sam McCall Date: 2022-05-06T23:08:47+02:00 New Revision: 1eb97481ef8b7c8923b29d80b8b018015dd3e27c URL: https://github.com/llvm/llvm-project/commit/1eb97481ef8b7c8923b29d80b8b018015dd3e27c DIFF: https://github.com/llvm/llvm-project/commit/1eb97481ef8b7c8923b29d80b8b018015dd3e27c.diff

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 427741. steplong added a comment. Update patch to accept __attribute__((no_builtin("*")). It adds no-builtins to the function attributes, but it still doesn't affect the calls. The calls in the function still become builtin calls. Repository: rG LLVM

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rG509b631f84e9: [OpenMP] Try to Infer target triples using the offloading architecture (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG8477a0d769a0: [OpenMP] Allow compiling multiple target architectures with OpenMP (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D124721?vs=426521=427734#toc Repository: rG

[clang] 8477a0d - [OpenMP] Allow compiling multiple target architectures with OpenMP

Author: Joseph Huber Date: 2022-05-06T16:57:16-04:00 New Revision: 8477a0d769a0b877f14e3ec3fde576b6a3b173ce URL: https://github.com/llvm/llvm-project/commit/8477a0d769a0b877f14e3ec3fde576b6a3b173ce DIFF: https://github.com/llvm/llvm-project/commit/8477a0d769a0b877f14e3ec3fde576b6a3b173ce.diff

[clang] 509b631 - [OpenMP] Try to Infer target triples using the offloading architecture

Author: Joseph Huber Date: 2022-05-06T16:57:18-04:00 New Revision: 509b631f84e97e717a675a6ef60ae4728bb11551 URL: https://github.com/llvm/llvm-project/commit/509b631f84e97e717a675a6ef60ae4728bb11551 DIFF: https://github.com/llvm/llvm-project/commit/509b631f84e97e717a675a6ef60ae4728bb11551.diff

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

iliya-diyachkov added a comment. @Anastasia, when are you going to add support for v1.5? We would use it in the SPIR-V backend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz updated this revision to Diff 427731. rmaz added a comment. fix for missing temp dir in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/ https://reviews.llvm.org/D124946 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/WorkList.cpp:216-218 // Number of inserted nodes, used to emulate DFS ordering in the priority // queue when insertions are equal. + long Counter = 0;

[PATCH] D124719: [docs] PCH usage documentation update

tahonermann closed this revision. tahonermann added a comment. Re-closing since this review has already landed. @akyrtzi, did you see my last comment? If I don't hear back from you, I'll submit a new doc change that covers both forms of PCH use. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order

martong added a comment. In D123784#3496981 , @xazax.hun wrote: > This approach fixes the worklist for the second phase. Would it be possible > to create a wrapper that reverses the order of any worklist instead of > committing to one and hardcode

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f0e741db97c: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia (authored by phosek). Herald added a subscriber: MaskRay. Herald added

[clang] 7f0e741 - [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

Author: Petr Hosek Date: 2022-05-06T13:27:10-07:00 New Revision: 7f0e741db97c64b4a566d65b878c2e0fe4dabb38 URL: https://github.com/llvm/llvm-project/commit/7f0e741db97c64b4a566d65b878c2e0fe4dabb38 DIFF: https://github.com/llvm/llvm-project/commit/7f0e741db97c64b4a566d65b878c2e0fe4dabb38.diff

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong marked 4 inline comments as done. martong added a comment. Thanks for the review Gabor, I'll update soon and hope I could answer your questions. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:116 + const bool Foreign = false; // From

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. In D120489#3493313 , @martong wrote: > Maybe it is not too late to update the clang/docs/ReleaseNotes.rst? A new > checker is certainly important for the users. Many thanks! Yeah done! Thanks. Repository: rG LLVM Github

[clang] bbd0319 - Update ReleaseNotes.rst

Author: Shivam Date: 2022-05-07T01:20:45+05:30 New Revision: bbd031943a3d1bd72fed362ee3e8456dbb901747 URL: https://github.com/llvm/llvm-project/commit/bbd031943a3d1bd72fed362ee3e8456dbb901747 DIFF: https://github.com/llvm/llvm-project/commit/bbd031943a3d1bd72fed362ee3e8456dbb901747.diff LOG:

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 427716. steplong added a reviewer: aaron.ballman. steplong added a comment. Changed it to use SmallSetVector instead of SmallVector. Had to use an temporary SmallVector in AddRangeBasedNoBuiltin() because I'm not sure how to get a pointer to StringRef.

[clang] b390173 - update the doc for the static analyzer checker

Author: Shivam Date: 2022-05-07T01:19:46+05:30 New Revision: b39017340806ee68b305d5c8330cbc3e1d398a4d URL: https://github.com/llvm/llvm-project/commit/b39017340806ee68b305d5c8330cbc3e1d398a4d DIFF: https://github.com/llvm/llvm-project/commit/b39017340806ee68b305d5c8330cbc3e1d398a4d.diff LOG:

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 427721. ldionne added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/cmake/caches/CrossWinToARMLinux.cmake

[clang] 24e9d90 - Added the brief discription about the new CSA checker.

Author: Shivam Date: 2022-05-07T01:16:22+05:30 New Revision: 24e9d90e65243fd8674bfc264c1c7d27c3cce67c URL: https://github.com/llvm/llvm-project/commit/24e9d90e65243fd8674bfc264c1c7d27c3cce67c DIFF: https://github.com/llvm/llvm-project/commit/24e9d90e65243fd8674bfc264c1c7d27c3cce67c.diff LOG:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource added a comment. Added missing casts in `truncatingToUnsigned` tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 ___ cfe-commits mailing list

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427717. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/test/Analysis/additive-op-on-sym-int-expr.c Index:

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl added a comment. In D124866#3497439 , @tra wrote: >> CUDA/HIP do not have language spec. > > Well. It's not completely true. CUDA programming guide does serve as the > de-facto spec for CUDA. It's far from perfect, but it does mention >

[PATCH] D125120: Initial work on parameter info for function pointers

Qwinci created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. Qwinci requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 427711. python3kgae added a comment. Rebase for fcgl change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td

[clang-tools-extra] ec34de1 - [clang-tidy][NFC] Fix doc typo for bugprone-unchecked-optional-access

Author: Yitzhak Mandelbaum Date: 2022-05-06T19:23:43Z New Revision: ec34de1bfe5501fd3017ff867bc2481dc052788d URL: https://github.com/llvm/llvm-project/commit/ec34de1bfe5501fd3017ff867bc2481dc052788d DIFF: https://github.com/llvm/llvm-project/commit/ec34de1bfe5501fd3017ff867bc2481dc052788d.diff

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable entry. +

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

tra added a comment. > CUDA/HIP do not have language spec. Well. It's not completely true. CUDA programming guide does serve as the de-facto spec for CUDA. It's far from perfect, but it does mention `__noinline__` and `__forceinline__` as function qualifiers:

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1079 + MSFunctionNoBuiltins.insert(MSFunctionNoBuiltins.end(), + NoBuiltins.begin(), NoBuiltins.end()); +} hans wrote: > steplong wrote: > > hans wrote: > > >

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e63a0d479dd: [clang-tidy] New check for safe usage of `std::optional` and like types. (authored by ymandel). Changed prior to commit:

[clang] 7e63a0d - [clang-tidy] New check for safe usage of `std::optional` and like types.

Author: Yitzhak Mandelbaum Date: 2022-05-06T18:50:36Z New Revision: 7e63a0d479dd3ccce20de5cddb0f138b537c08bb URL: https://github.com/llvm/llvm-project/commit/7e63a0d479dd3ccce20de5cddb0f138b537c08bb DIFF: https://github.com/llvm/llvm-project/commit/7e63a0d479dd3ccce20de5cddb0f138b537c08bb.diff

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. @uabelho Could you please apply this change and check if it resolves your crashes? I'm gonna do the same on our side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 ___

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Comment at: clang/include/clang/AST/ASTImporterSharedState.h:43 + /// Set of the newly created declarations. + llvm::DenseSet

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 427701. jhuber6 added a comment. Changing enum values from a bitfield to simple enumeration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files:

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl updated this revision to Diff 427700. yaxunl marked an inline comment as done. yaxunl added a comment. added release note and documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124866/new/ https://reviews.llvm.org/D124866 Files: clang/docs/ReleaseNotes.rst

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/Features.def:274 +// CUDA/HIP Features +FEATURE(cuda_noinline_keyword, true) + aaron.ballman wrote: > yaxunl wrote: > > aaron.ballman wrote: > > > Do the

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

martong marked 4 inline comments as done. martong added a comment. @xazax.hun Hey Gabor, thanks a lot for your time and effort for reviewing this patch set! (And of course thank you for you too @steakhal, but you've already seen most of it.) In D123685#3458329

[PATCH] D124983: [HLSL] add -fcgl option flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa5eb4cfc06: [HLSL] add -fcgl option flag. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3fa5eb4 - [HLSL] add -fcgl option flag.

Author: python3kgae Date: 2022-05-06T11:42:15-07:00 New Revision: 3fa5eb4cfc065b686c03f912e4414fd00a54d04e URL: https://github.com/llvm/llvm-project/commit/3fa5eb4cfc065b686c03f912e4414fd00a54d04e DIFF: https://github.com/llvm/llvm-project/commit/3fa5eb4cfc065b686c03f912e4414fd00a54d04e.diff

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427695. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/test/Analysis/additive-op-on-sym-int-expr.c Index:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427693. tomasz-kaminski-sonarsource added a comment. I have removed the assertions and updated the code to handle both extensions of reductions of bitwith from RHS to ResultType. Expanded test, to cover the above scenarios. CHANGES

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58-70 + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable entry. +enum OffloadVarEntryKindFlag : uint32_t { + /// Mark the entry as a global variable.

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You should probably add a release note for this change so users know about it. (Do we need to update any documentation from this?) Repository: rG LLVM Github Monorepo

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added a comment. In D123471#3497224 , @jhuber6 wrote: > It's a little tough, I chose that format because it's exactly the same as we > use with OpenMP with a few different flags. I wish whoever initially designed > the struct made the ``reserved``

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

cjdb added a comment. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon added a comment. ping @scanon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124983: [HLSL] add -fcgl option flag.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124983/new/ https://reviews.llvm.org/D124983 ___ cfe-commits mailing list

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Features.def:274 +// CUDA/HIP Features +FEATURE(cuda_noinline_keyword, true) + yaxunl wrote: > aaron.ballman wrote: > > Do the CUDA or HIP specs define `__noinline__` as a keyword

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl updated this revision to Diff 427685. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Aaron's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124866/new/ https://reviews.llvm.org/D124866 Files: clang/include/clang/Basic/Attr.td

[PATCH] D125103: [clangd] Speed up a slow sleeping testcase.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc468635b7dfc: [clangd] Speed up a slow sleeping testcase. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c468635 - [clangd] Speed up a slow sleeping testcase.

Author: Sam McCall Date: 2022-05-06T20:12:17+02:00 New Revision: c468635b7dfcec302f7688f5dcde91913524e355 URL: https://github.com/llvm/llvm-project/commit/c468635b7dfcec302f7688f5dcde91913524e355 DIFF: https://github.com/llvm/llvm-project/commit/c468635b7dfcec302f7688f5dcde91913524e355.diff

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1778-1779 def NoInline : DeclOrStmtAttr { - let Spellings = [GCC<"noinline">, CXX11<"clang", "noinline">, + let Spellings = [Keyword<"__noinline__">,

[PATCH] D125103: [clangd] Speed up a slow sleeping testcase.

sammccall added a comment. In D125103#3497140 , @ilya-biryukov wrote: > Many thanks for improving the running time, this slow test has bugged me > since the day I first ran it. > I'd even be happy to remove it completely. It's slow, possibly flaky, so

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

tra added inline comments. Comment at: clang/include/clang/AST/Type.h:508 + static_cast(LangAS::FirstTargetAddressSpace)); +// When dealing with target AS return true if: +// * A is equal to B, or jchlanda wrote: > tra wrote: > > Is

[PATCH] D125109: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. In D123471#3497169 , @tra wrote: >> Type struct __tgt_offload_entry { >> >> void*addr; // Pointer to the offload entry info. >> // (function or global) >> char*name; // Name of the

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

tra added a reviewer: rsmith. tra added a subscriber: rsmith. tra added a comment. > I don't know how language extensions come about in CUDA or HIP -- is there an > appropriate standards body (or something similar) that's aware of this > extension and supports it? Summoning @rsmith for his

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:789 + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs().hasArg(options::OPT_offload_arch_EQ)); + if (IsOpenMPOffloading) { yaxunl wrote: > probably

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added a comment. > Type struct __tgt_offload_entry { > > void*addr; // Pointer to the offload entry info. > // (function or global) > char*name; // Name of the function or global. > size_t size; // Size of the entry info (0 if it a

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

yaxunl added a comment. could you please add a test to https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/hip-offload-arch.hip to make sure when -fopenmp is specified, no openmp offloading is performed? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added a comment. We probably want testcases for accessing various parts of the stack frame with FP stored in r11; for example, can we correctly access arguments passed on the stack if there's stack realignment? Comment at:

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:789 + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs().hasArg(options::OPT_offload_arch_EQ)); + if (IsOpenMPOffloading) { probably should be

[PATCH] D125103: [clangd] Speed up a slow sleeping testcase.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks for improving the running time, this slow test has bugged me since the day I first ran it. I'd even be happy to remove it completely. It's slow, possibly flaky, so

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

jhuber6 added a comment. In D125092#3497033 , @saiislam wrote: >> Ideally we could just put this on the linker itself, but nvlink doesn't seem >> to support .a files. > > Yes, nvlink does not support archives. So we used a wrapper to extract cubin >

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050

  1   2   3   >