[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3506210 , @balazske wrote: > I found one other place in **LibASTImporter.rst** where `ImportError` is > used. LLDB should be checked too. Yeah , I update the file **LibASTImporter.rst**, I'm not sure if there is

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. Thank you so much for your review! My public email address is: `07softy_br...@icloud.com`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428840. ken-matsui added a comment. Updated the code as reviewed, added a release note, and merged `ext-cpp2b-pp-directive.cpp` & `ext-c2x-pp-directive.c` into `ext-pp-directive.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3504789 , @rnk wrote: > This seems reasonable, but I worry about the consequences of creating lots of > unnamed global variables. What will gdb do with so many unnamed globals? What > will the PDB linker do with all

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:36 +// elfidef: c2x-cpp2b-warning@-12 {{invalid preprocessing directive, did you mean '#elifdef'?}} +// elfindef: c2x-cpp2b-warning@-12 {{invalid preprocessing directive, did you

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428827. ken-matsui added a comment. Remove unused includes in `StringRef.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files:

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. Thank you for your support! I updated the code, so could you please review this patch again? Comment at: llvm/lib/Support/StringRef.cpp:102 +// Find a similar string in `Candidates`. +Optional StringRef::find_similar_str(const std::vector , size_t

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428826. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files:

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

craig.topper added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} There appear to be two installs of ppc_wrapper_files with different components. Is that intentional? Repository: rG LLVM Github

[clang] 9519dac - Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support"

Author: David Tenty Date: 2022-05-11T20:47:48-04:00 New Revision: 9519dacab7b8afd537811fc2abaceb4d14f4e16a URL: https://github.com/llvm/llvm-project/commit/9519dacab7b8afd537811fc2abaceb4d14f4e16a DIFF: https://github.com/llvm/llvm-project/commit/9519dacab7b8afd537811fc2abaceb4d14f4e16a.diff

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 ___ cfe-commits mailing list

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125141/new/ https://reviews.llvm.org/D125141 ___ cfe-commits mailing list

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added inline comments. Comment at: clang/include/clang/AST/Comment.h:303 - -Argument(SourceRange Range, StringRef Text) : Range(Range), Text(Text) { } }; Removing that allows me to build an array without initializing all members right away.

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That's required to support `\n`, but can also used for other commands.

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

aaronpuchert updated this revision to Diff 428800. aaronpuchert added a comment. Add an AST test to check that we parse the arguments correctly. (We don't use them for diagnostics currently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

yln added inline comments. Comment at: compiler-rt/lib/asan/asan_poisoning.cpp:263 +#if SANITIZER_ARM64 + // The ARM64 cookie has a second "size_t" entry so poison it as well + *(reinterpret_cast(s)-1) = kAsanArrayCookieMagic; Comment at:

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:218 + llvm::sys::path::remove_dots(CleanFilename, /*remove_dot_dot=*/false); + Filename = CleanFilename; + kadircet wrote: > this is actually breaking the [contract of >

[PATCH] D125425: Explicitly add -target for Windows builds in file_test_windows.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8016a0e5a56b: Explicitly add -target for Windows builds in file_test_windows.c (authored by ayzhao, committed by aeubanks). Repository: rG LLVM

[clang] 8016a0e - Explicitly add -target for Windows builds in file_test_windows.c

Author: Alan Zhao Date: 2022-05-11T15:05:55-07:00 New Revision: 8016a0e5a56b8afc0f328412adae97369c71af78 URL: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78 DIFF: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78.diff

[PATCH] D125425: Explicitly add -target for Windows builds in file_test_windows.c

ayzhao created this revision. Herald added a subscriber: pengfei. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that the llvm buildbots run the test with

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5219 +// function. +else if (!CGF.CurFn->getAttributes().hasFnAttr(AttributeNoBuiltin)) return CGCallee::forBuiltin(builtinID, FD); steplong wrote: > hans wrote: > > What if

[clang] 52af5df - [Driver][test] run one test in darwin-dsymutil.c for Darwin only

Author: Yuanfang Chen Date: 2022-05-11T14:45:00-07:00 New Revision: 52af5df8aef737b5b609912ea28f79fcb3d9ba22 URL: https://github.com/llvm/llvm-project/commit/52af5df8aef737b5b609912ea28f79fcb3d9ba22 DIFF: https://github.com/llvm/llvm-project/commit/52af5df8aef737b5b609912ea28f79fcb3d9ba22.diff

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. In D124836#3507354 , @nickdesaulniers wrote: > In D124836#3507268 , @void wrote: > >> I'll split off the TableGen changes into a separate patch. It will supersede >> those changes here, so

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The command traits have a member NumArgs for which all the parsing

[PATCH] D125420: [AArch64] Add support for -fzero-call-used-regs

void abandoned this revision. void added a comment. Ugh! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125420/new/ https://reviews.llvm.org/D125420 ___ cfe-commits mailing list

[PATCH] D125420: [AArch64] Add support for -fzero-call-used-regs

void created this revision. void added reviewers: nickdesaulniers, nhaehnle, thakis, jankratochvil. Herald added subscribers: pengfei, hiraditya, kristof.beyls. Herald added a project: All. void requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added a comment. I am not sure if allowing clang to accept newlines is a good idea. It seems like clang wants to know what type of message is being outputted. For example whether this is a remark, warning, etc. but allowing for a diagnostic to output their own newline makes it

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6398f3f2e904: [clang] Add the flag -ffile-reproducible (authored by ayzhao, committed by hans). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6398f3f - [clang] Add the flag -ffile-reproducible

Author: Alan Zhao Date: 2022-05-11T23:04:36+02:00 New Revision: 6398f3f2e9045cb38c73425fcc4dddbfb8933a57 URL: https://github.com/llvm/llvm-project/commit/6398f3f2e9045cb38c73425fcc4dddbfb8933a57 DIFF: https://github.com/llvm/llvm-project/commit/6398f3f2e9045cb38c73425fcc4dddbfb8933a57.diff

[PATCH] D125406: [OpenMP] Fix mangling for linear parameters with negative stride

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG772b0c44a429: [OpenMP] Fix mangling for linear parameters with negative stride (authored by mikerice). Herald added a project: clang. Herald added a

[clang] 772b0c4 - [OpenMP] Fix mangling for linear parameters with negative stride

Author: Mike Rice Date: 2022-05-11T14:02:09-07:00 New Revision: 772b0c44a4296a34cbc072c2a7cf294410d07a1a URL: https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a DIFF: https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a.diff

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added a comment. In D124836#3507268 , @void wrote: > I'll split off the TableGen changes into a separate patch. It will supersede > those changes here, so it shouldn't delay other reviews here. :-) I'm referring to the changes to

[PATCH] D125414: Revert "[HLSL] add -D option for dxc mode."

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6055837f6d29: Revert [HLSL] add -D option for dxc mode. (authored

[clang] 6055837 - Revert "[HLSL] add -D option for dxc mode."

Author: Xiang Li Date: 2022-05-11T13:57:47-07:00 New Revision: 6055837f6d2941bbc09e44dc88b6a39b934a7453 URL: https://github.com/llvm/llvm-project/commit/6055837f6d2941bbc09e44dc88b6a39b934a7453 DIFF: https://github.com/llvm/llvm-project/commit/6055837f6d2941bbc09e44dc88b6a39b934a7453.diff

[clang] 42a1fb5 - [LinkerWrapper][Fix} Fix bad alignment from extracted archive members

Author: Joseph Huber Date: 2022-05-11T16:56:41-04:00 New Revision: 42a1fb5ca56c494e25419a97057a9526f3e8608d URL: https://github.com/llvm/llvm-project/commit/42a1fb5ca56c494e25419a97057a9526f3e8608d DIFF: https://github.com/llvm/llvm-project/commit/42a1fb5ca56c494e25419a97057a9526f3e8608d.diff

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma created this revision. Herald added subscribers: zzheng, kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. Part of initial Arm64EC patchset. Don't try to duplicate the existing logic; instead, just call the actual code

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

fhahn added a comment. In D124699#3507250 , @qcolombet wrote: > Thanks @thakis ! > > @fhahn are you okay with the clang tests update as well? Yes looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma created this revision. Herald added subscribers: zzheng, kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. Part of initial Arm64EC patchset. For the Arm64EC ABI, ARM64 functions have an alternate name. For C code,

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. I'll split off the TableGen changes into a separate patch. It will supersede those changes here, so it shouldn't delay other reviews here. :-) Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:798 + + if (STI.hasSVE()) { +for (MCRegister

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 428764. void marked 4 inline comments as done. void added a comment. Fix think-o use of HasSVE. Use `--check-prefixes` in the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. Thanks @thakis ! @fhahn are you okay with the clang tests update as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG2db700215a2e: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic (authored by kerbowa). Herald added a subscriber: kosarev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2db7002 - [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

Author: Austin Kerbow Date: 2022-05-11T13:22:51-07:00 New Revision: 2db700215a2eebce7358c0a81a3d52d0a9d4a997 URL: https://github.com/llvm/llvm-project/commit/2db700215a2eebce7358c0a81a3d52d0a9d4a997 DIFF: https://github.com/llvm/llvm-project/commit/2db700215a2eebce7358c0a81a3d52d0a9d4a997.diff

[PATCH] D125414: Revert "[HLSL] add -D option for dxc mode."

python3kgae created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This reverts commit 4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae added a comment. In D125338#3507063 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I'll revert it. Thanks. Repository:

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

dblaikie added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1044 + + // Unfortunately, debug_aranges by default don't inclue global variables. If + // we failed to find the CU using aranges, try and search for variables as Might be

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

aaronpuchert added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113793/new/ https://reviews.llvm.org/D113793 ___ cfe-commits mailing list

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:787 + + const int Length = LastToken->TotalLength; + owenpan wrote: > curdeius wrote: > > Why not like this? > > Why not like this? > > See the assertion on line 781 above. We

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added a comment. In D123878#3506500 , @afanfa wrote: > If possible, I would like to keep some kind of delimiter. I like the idea of > having it at the beginning and at the end of the section. The best option > would be to convince clang to

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:766 + assert(!Tokens.empty()); + const auto *LastToken = Tokens.back().Tok; + assert(LastToken); curdeius wrote: > It might be a matter of taste but adding this variable makes

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

lattner edited reviewers, added: rsmith; removed: lattner. lattner added a comment. I'm not a competent reviewer for this, Richard can you recommend someone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125402/new/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

peterwaller-arm added inline comments. Comment at: llvm/test/CodeGen/AArch64/zero-call-used-regs.ll:259-262 +; SVE-NEXT:pfalse p0.b +; SVE-NEXT:pfalse p1.b +; SVE-NEXT:pfalse p2.b +; SVE-NEXT:pfalse p3.b nickdesaulniers wrote: > N00b question

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM with nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:766 + assert(!Tokens.empty()); + const auto *LastToken = Tokens.back().Tok; + assert(LastToken);

[PATCH] D125338: [HLSL] add -D option for dxc mode.

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added a comment. I still think this would be easier to review if the `isArgumentRegister` tablegen changes were separated out into a distinct parent patch and then the existing x86 implementation updated to use, then this would rebased on top of as a child patch.

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/test/Preprocessor/pragma_microsoft.c:210 +#pragma function(main) // expected-warning {{'main' is not a recognized builtin; consider including }} +#pragma function(// expected-warning

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ca6328637b3: [clang][ppc] Creating Seperate Install Target for PPC htm Headers (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3ca6328 - [clang][ppc] Creating Seperate Install Target for PPC htm Headers

Author: Qiongsi Wu Date: 2022-05-11T14:48:40-04:00 New Revision: 3ca6328637b3f42096c652e4df53282649956bdb URL: https://github.com/llvm/llvm-project/commit/3ca6328637b3f42096c652e4df53282649956bdb DIFF: https://github.com/llvm/llvm-project/commit/3ca6328637b3f42096c652e4df53282649956bdb.diff

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5037 if (auto builtinID = FD->getBuiltinID()) { +std::string AttributeNoBuiltin = "no-builtin-" + FD->getName().str(); std::string FDInlineName = (FD->getName() + ".inline").str();

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 428727. steplong added a comment. - Reject `#pragma alloc_text(a, a` - On Line 1180, I didn't use `ExpectAndConsume()` there because I wanted to accept both identifiers and strings (i.e `pragma alloc_text(a, foo)` and `pragma alloc_text("a", foo)` - It

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

jdoerfert added a comment. In D125378#3506954 , @aaron.ballman wrote: > In D125378#3506446 , @jdoerfert > wrote: > >> What I would suggest, if you want to use C/C++ attributes (which makes sense >> to me), is

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 428731. rsundahl marked 6 inline comments as done. rsundahl added a comment. Update diff back to dc7e02d4b4dc30d44ddebd832719a6e63396e718 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125195/new/

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

aaron.ballman added a comment. In D125378#3506446 , @jdoerfert wrote: > What I would suggest, if you want to use C/C++ attributes (which makes sense > to me), is an attribute that avoids undef or introduces frozen: I would prefer to avoid this approach

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added inline comments. Comment at: clang/docs/ClangOffloadPackager.rst:31-32 +uint32_t Flags; +StringMap StringData; +MemoryBufferRef Image; + }; yaxunl wrote: > jhuber6 wrote: > > yaxunl wrote: > > > This makes the file format depend on

[PATCH] D125396: [clang] Fix KEYALL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84db35594953: [clang] Fix KEYALL (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 84db355 - [clang] Fix KEYALL

Author: Yaxun (Sam) Liu Date: 2022-05-11T14:28:08-04:00 New Revision: 84db35594953a6f7aff7cbc007f1c5d2fd35b1a9 URL: https://github.com/llvm/llvm-project/commit/84db35594953a6f7aff7cbc007f1c5d2fd35b1a9 DIFF:

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.cpp:70-73 +auto ExternCBlockBegin = +SM.getDecomposedExpansionLoc(LinkSpecDecl->getBeginLoc()); +auto

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dae38ebfba0: [HLSL] add -D option for dxc mode. (authored by python3kgae). Changed prior to commit:

[clang] 4dae38e - [HLSL] add -D option for dxc mode.

Author: Xiang Li Date: 2022-05-11T11:26:31-07:00 New Revision: 4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda URL: https://github.com/llvm/llvm-project/commit/4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda DIFF: https://github.com/llvm/llvm-project/commit/4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda.diff

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

yaxunl added inline comments. Comment at: clang/docs/ClangOffloadPackager.rst:31-32 +uint32_t Flags; +StringMap StringData; +MemoryBufferRef Image; + }; jhuber6 wrote: > yaxunl wrote: > > This makes the file format depend on LLVM version and

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal updated this revision to Diff 428724. steakhal added a comment. - Ignore `extern "C++"` blocks; also added a test for this. - Also ignore `LinkageSpecDecl`s without braces. - Clear the `IncludesToBeProcessed` list at the end of each translation unit. Repository: rG LLVM Github

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 428718. rsundahl added a comment. Revert ItaniumCXXABI.cpp for now (unintentional push) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125195/new/ https://reviews.llvm.org/D125195 Files:

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov planned changes to this revision. ppluzhnikov added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:24 + static auto *Mappings = + new std::array, 645>{{ + {"algorithm", ""}, ilya-biryukov wrote: >

Re: [PATCH] D121733: Clean pathnames in FileManager.

Please note that this patch still breaks Winx64 tests, and that I marked it as "further changes required" / not ready for review some time ago. On Wed, May 11, 2022 at 10:37 AM Ilya Biryukov via Phabricator < revi...@reviews.llvm.org> wrote: > ilya-biryukov requested changes to this revision. >

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 428716. rsundahl added a comment. Implement suggestions from reviews. (Incremental update.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125195/new/ https://reviews.llvm.org/D125195 Files:

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

steakhal added a comment. Great content! I've got a long list of nits though. Nothing personal :D Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1453 +const RangeSet *NegatedRange = nullptr; +if (const UnarySymExpr *USE = dyn_cast(Sym)) { +

[PATCH] D121733: Clean pathnames in FileManager.

kadircet added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:218 + llvm::sys::path::remove_dots(CleanFilename, /*remove_dot_dot=*/false); + Filename = CleanFilename; + this is actually breaking the [contract of

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:188 +// Name must be a valid nonterminal symbol name in the grammar. +SymbolID findNonterminal(llvm::StringRef Name, +

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. It seems to not affect a ton of code, so I don't think there's a huge hurry. I would like to hear an answer about the question "what is this for?" though, and your thoughts on how this relates to the goals in

[PATCH] D121733: Clean pathnames in FileManager.

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Please allow some time for the clangd team to review this before landing. Changes to filenames used to cause unintended consequences for us before. We switched to using

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.cpp:70-73 +auto ExternCBlockBegin = +SM.getDecomposedExpansionLoc(LinkSpecDecl->getBeginLoc()); +auto ExternCBlockEnd = +

[PATCH] D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Much of the size of PCH/PCM files comes

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. In D124613#3506740 , @thakis wrote: > Should we revert this, at least for now, until the investigation is complete? I started typing my message before you sent yours so it was not a direct answer. We are

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c1d3cbcb97: [clang][AIX] Dont ignore XCOFF visibility by default (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] d9c1d3c - [clang][AIX] Don't ignore XCOFF visibility by default

Author: David Tenty Date: 2022-05-11T13:27:48-04:00 New Revision: d9c1d3cbcb9751a6a82cc5e4ada0533cbbc79a1a URL: https://github.com/llvm/llvm-project/commit/d9c1d3cbcb9751a6a82cc5e4ada0533cbbc79a1a DIFF: https://github.com/llvm/llvm-project/commit/d9c1d3cbcb9751a6a82cc5e4ada0533cbbc79a1a.diff

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added inline comments. Comment at: clang/docs/ClangOffloadPackager.rst:31-32 +uint32_t Flags; +StringMap StringData; +MemoryBufferRef Image; + }; yaxunl wrote: > This makes the file format depend on LLVM version and potentially standard >

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

yaxunl added inline comments. Comment at: clang/docs/ClangOffloadPackager.rst:31-32 +uint32_t Flags; +StringMap StringData; +MemoryBufferRef Image; + }; This makes the file format depend on LLVM version and potentially standard C++ library version.

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. Thanks a lot for pointing out the reproducer, it made the debug a lot easier. I have pinpointed the problem to an unintended increase in ADL visibility for friend classes. I do have a test-case and fix for that. I'll make a last check tomorrow to

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added a comment. > Any update/further details here? David, apologies for not getting back to you sooner. The context is D105564 which I started working on again recently. I was having difficulties finding a solution that also worked for local lambdas.

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. Given that: - This is not needed for system headers - Before the change, users had to fix their standards-noncompliant code, but with it, users have to change their previously-compiling, standards-compliant code - The change is a no-op for C++20 and up anyways - There's

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee created this revision. nlee added a reviewer: lattner. Herald added a project: All. nlee requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Returning class or struct by value with const qualifier should be avoided since it prevents move

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good to me. I wish some parts would be simpler but it looks like sometimes it is not easy to extend the current code and we might need to do some refactoring at some

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. In D125142#3505767 , @jfb wrote: > I think the most relevant post from @rsmith is: > https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/40 > > He has a prototype:

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The vload*_half* and vstore*_half*

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a super minor nit in a test file. Can you please add a release note for the new diagnostics as well? I'm happy to land this for you when you're ready, but let me

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3506536 , @whisperity wrote: > In D124447#3493996 , @whisperity > wrote: > >> In D124447#3493446 , >> @aaron.ballman wrote: >>

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:116 + const bool Foreign = false; // From CTU. + martong wrote: > martong wrote: > > xazax.hun wrote: > > > I feel that we use different terms for

[PATCH] D125338: [HLSL] add -D option for dxc mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a super minor nit with the test. Comment at: clang/test/Driver/dxc_D.hlsl:14 +// ERROR-NOT: error: \ No newline at end of file You should add the newline back to the end of

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:446 +} +const bool BState = State->contains(D); +if (!BState) { // This is the first time we see this foreign function. xazax.hun wrote: > martong

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:446 +} +const bool BState = State->contains(D); +if (!BState) { // This is the first time we see this foreign function. martong wrote: > xazax.hun

  1   2   3   >