[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. nice cleanup! Comment at: llvm/lib/Analysis/ConstantFolding.cpp:2884 if (IntrinsicID == Intrinsic::smul_fix_sat) { - APInt Max =

[PATCH] D125593: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Good finding! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125593/new/ https://reviews.llvm.org/D125593 ___ cfe-commits

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 429410. cjdb added a comment. makes `__is_destructible` and `__is_nothrow_destructible` `KEYCXX` instead of `KEYMS` (attention @aaron.ballman) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/

[PATCH] D125593: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM

owenpan updated this revision to Diff 429406. owenpan added a comment. Fixed a bug and added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125593/new/ https://reviews.llvm.org/D125593 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek added a comment. D125597 should address the build error in compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added a comment. In D123878#3507378 , @vangthao wrote: > I am not sure if allowing clang to accept newlines is a good idea. It seems > like clang wants to know what type of message is being outputted. For example > whether this is a

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG512273833136: [clang-tidy] Support expressions of literals in modernize-macro-to-enum (authored by LegalizeAdulthood). Repository: rG LLVM Github

[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

efriedma added subscribers: reames, efriedma. efriedma added inline comments. Comment at: llvm/lib/IR/ConstantRange.cpp:724 auto BW = getBitWidth(); -APInt Min = APInt::getMinValue(BW).zextOrSelf(ResultBitWidth); -APInt Max =

[PATCH] D125593: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay added a comment. I'll wait a bit before pushing to check whether that further opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D125510: [clang-format][NFC] Format unit tests with insert/remove braces

This revision was automatically updated to reflect the committed changes. Closed by commit rG2601355dc982: [clang-format][NFC] Format unit tests with insert/remove braces (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2601355 - [clang-format][NFC] Format unit tests with insert/remove braces

Author: owenca Date: 2022-05-13T16:16:20-07:00 New Revision: 2601355dc9822f8e04ad73212ed62e601e4f0368 URL: https://github.com/llvm/llvm-project/commit/2601355dc9822f8e04ad73212ed62e601e4f0368 DIFF: https://github.com/llvm/llvm-project/commit/2601355dc9822f8e04ad73212ed62e601e4f0368.diff LOG:

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4205f4a - [Cuda] Add the features using the last argument

Author: Joseph Huber Date: 2022-05-13T18:05:02-04:00 New Revision: 4205f4aba4aff74fa7681c3f991ef5fdaed48d35 URL: https://github.com/llvm/llvm-project/commit/4205f4aba4aff74fa7681c3f991ef5fdaed48d35 DIFF: https://github.com/llvm/llvm-project/commit/4205f4aba4aff74fa7681c3f991ef5fdaed48d35.diff

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae created this revision. python3kgae added reviewers: thakis, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is to avoid

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2191 CGM.CreateRuntimeFunction(FTy, "__asan_poison_cxx_array_cookie"); +// CGF.Builder.CreateCall(F, NumElementsPtr.getRawPointer(CGF)); CGF.Builder.CreateCall(F,

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 429353. LegalizeAdulthood added a comment. Update documentation from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files:

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 429352. rsundahl added a comment. This update corrects merge conflicts in Build #104091 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125195/new/ https://reviews.llvm.org/D125195 Files:

[clang] af845d7 - [Clang] Fix DriverKit tests on Linux

Author: Egor Zhdan Date: 2022-05-13T22:10:13+01:00 New Revision: af845d7e437a0380f65db841f2917f3c1a95ecf5 URL: https://github.com/llvm/llvm-project/commit/af845d7e437a0380f65db841f2917f3c1a95ecf5 DIFF: https://github.com/llvm/llvm-project/commit/af845d7e437a0380f65db841f2917f3c1a95ecf5.diff

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

pcc added a comment. In D120727#3512177 , @paulkirth wrote: > Hi, we're seeing some failures in Fuchsia's Clang CI. Our runtimes build > seems to be unable to find `cxxabi.h`. > > The failing bot can be found here: >

[clang] 7dc23ab - [CUDA] Add a flag to manually specify the target feature to use with CUDA

Author: Joseph Huber Date: 2022-05-13T16:30:58-04:00 New Revision: 7dc23abbd3b298016cc6ae49a124f414e76903b6 URL: https://github.com/llvm/llvm-project/commit/7dc23abbd3b298016cc6ae49a124f414e76903b6 DIFF: https://github.com/llvm/llvm-project/commit/7dc23abbd3b298016cc6ae49a124f414e76903b6.diff

[PATCH] D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation.

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14222 + TabAlignment.UseTab = FormatStyle::UT_ForIndentation; + TabAlignment.AlignConsecutiveDeclarations.Enabled = true; + TabAlignment.PointerAlignment = FormatStyle::PAS_Left;

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. In D125429#3511648 , @aaronpuchert wrote: > And it appears that `unsigned long` does not have a clear favorite here. Found it on StackOverflow:

[PATCH] D125580: Resolve overload ambiguity on Mac OS when printing size_t in diagnostics

aaronpuchert created this revision. aaronpuchert added reviewers: aeubanks, rsmith. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Precommit builds cover Linux and Windows, but this ambiguity

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:3495-3496 + + { int a[T(__is_same(make_signed_t, int))]; } + { int a[T(__is_same(make_signed_t, int))]; } + { int a[T(__is_same(make_signed_t, const int))]; } cjdb wrote: > rsmith

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4155 +#undef TRANSFORM_TYPE_TRAIT_DEF + if (!ParseTypeTransformTypeSpecifier(DS)) +goto ParseIdentifier; rsmith wrote: > The name signature you're using for this function is

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added a comment. Thanks for working on this. A couple comments. There are no testcases. Please add testcases. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend unrelated change? Comment

[PATCH] D121911: [Clang] Add DriverKit support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f04e703bff3: [Clang] Add DriverKit support (authored by egorzhdan). Changed prior to commit:

[clang] 2f04e70 - [Clang] Add DriverKit support

Author: Egor Zhdan Date: 2022-05-13T20:34:57+01:00 New Revision: 2f04e703bff3d9858f53225fa7c780b240c3e247 URL: https://github.com/llvm/llvm-project/commit/2f04e703bff3d9858f53225fa7c780b240c3e247 DIFF: https://github.com/llvm/llvm-project/commit/2f04e703bff3d9858f53225fa7c780b240c3e247.diff

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

shraiysh added a comment. Minor nits about documentation. LGTM given that verifier and assembly format will be added soon for each of these as a separate patch soon. Please wait for atleast one more +1. The OpenMP IRBuilder work does not have to wait for this patch to merge. You can start

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 ___ cfe-commits mailing list

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3512341 , @aaron.ballman wrote: > I think the current behavior today makes sense but we should see if we can > improve it to make *more* sense. With `-Wstrict-prototypes`, we should > complain about the block

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 429320. steplong added a comment. - Clang-formatted. It didn't like the empty line before the bracket in clang/test/CodeGen/msvc_pragma_alloc_text.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125011/new/

[PATCH] D125521: [Diagnostic] Warn if the size argument of memset is character literal zero

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125521/new/ https://reviews.llvm.org/D125521

[PATCH] D125333: [OpenMP] Use the new OpenMP device static library when doing LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG4638ae3a8575: [OpenMP] Use the new OpenMP device static library when doing LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf757f89806e: [OpenMP] Dont set device runtime debugging flags if using -nogpulib (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125265: [OpenMP] Don't include the device wrappers if -nostdinc is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG5189f634a113: [OpenMP] Dont include the device wrappers if -nostdinc is used (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG002a63f937d9: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4638ae3 - [OpenMP] Use the new OpenMP device static library when doing LTO

Author: Joseph Huber Date: 2022-05-13T14:38:55-04:00 New Revision: 4638ae3a8575d988df856116102c1ccd15583c00 URL: https://github.com/llvm/llvm-project/commit/4638ae3a8575d988df856116102c1ccd15583c00 DIFF: https://github.com/llvm/llvm-project/commit/4638ae3a8575d988df856116102c1ccd15583c00.diff

[clang] af757f8 - [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'

Author: Joseph Huber Date: 2022-05-13T14:38:43-04:00 New Revision: af757f89806e03229837425b77839498db470ef8 URL: https://github.com/llvm/llvm-project/commit/af757f89806e03229837425b77839498db470ef8 DIFF: https://github.com/llvm/llvm-project/commit/af757f89806e03229837425b77839498db470ef8.diff

[clang] 5189f63 - [OpenMP] Don't include the device wrappers if -nostdinc is used

Author: Joseph Huber Date: 2022-05-13T14:38:39-04:00 New Revision: 5189f634a113b06fc2f2e8c6c021c0083f59bfb8 URL: https://github.com/llvm/llvm-project/commit/5189f634a113b06fc2f2e8c6c021c0083f59bfb8 DIFF: https://github.com/llvm/llvm-project/commit/5189f634a113b06fc2f2e8c6c021c0083f59bfb8.diff

[clang] 002a63f - [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP

Author: Joseph Huber Date: 2022-05-13T14:38:35-04:00 New Revision: 002a63f937d91c0aad192f2d4997317fb277b32a URL: https://github.com/llvm/llvm-project/commit/002a63f937d91c0aad192f2d4997317fb277b32a DIFF: https://github.com/llvm/llvm-project/commit/002a63f937d91c0aad192f2d4997317fb277b32a.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511855 , @aaron.ballman wrote: > In D122895#3511646 , @dexonsmith > wrote: > >> void f1(void (^block)()); >> >> void f2(void) { >> f1(^(int x) { /* do

[libunwind] 0a22dfc - [runtimes][NFC] Remove dead code for Standalone builds

Author: Louis Dionne Date: 2022-05-13T14:37:24-04:00 New Revision: 0a22dfcb11c05cbd4f654c8ef1868a4bc6085140 URL: https://github.com/llvm/llvm-project/commit/0a22dfcb11c05cbd4f654c8ef1868a4bc6085140 DIFF: https://github.com/llvm/llvm-project/commit/0a22dfcb11c05cbd4f654c8ef1868a4bc6085140.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511682 , @aaron.ballman wrote: > In D122895#3511632 , @jyknight > wrote: > >> The warnings for this case aren't great: >> >> int foo(); >> >> int >> foo(int

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/test/CodeGen/Thumb/frame-access.ll:41 +; CHECK-ATPCS: ldrr0, [sp, #32] +; CHECK-AAPCS: ldrr0, [r11, #8] ; CHECK-NEXT: strr3, [sp] `ldr r0, [r11, #8]` is not a valid Thumb1 instruction. Repository:

[PATCH] D125570: [CMake] Disable libedit in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG534f66042001: [CMake] Disable libedit in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 534f660 - [CMake] Disable libedit in Fuchsia toolchain

Author: Petr Hosek Date: 2022-05-13T10:47:12-07:00 New Revision: 534f6604200137bd4d84d3c91ea7f68bf132197d URL: https://github.com/llvm/llvm-project/commit/534f6604200137bd4d84d3c91ea7f68bf132197d DIFF: https://github.com/llvm/llvm-project/commit/534f6604200137bd4d84d3c91ea7f68bf132197d.diff

[PATCH] D125570: [CMake] Disable libedit in Fuchsia toolchain

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125570/new/ https://reviews.llvm.org/D125570

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

aprantl added a comment. I think this mostly looks good. I left comment about the test inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.h:536 + /// Create and attach debuginfo to a the provided string literal GV. + void AddStringLiteralDebugInfo(llvm::GlobalVariable *GV, StringRef Name, I would appreciate a comment

[PATCH] D125570: [CMake] Disable libedit in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: paulkirth. Herald added subscribers: abrachet, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't need libedit in our toolchain build.

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

paulkirth added a comment. Hi, we're seeing some failures in Fuchsia's Clang CI. Our runtimes build seems to be unable to find `cxxabi.h`. The failing bot can be found here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814278370664903633/overview

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { tianshilei1992 wrote: > Why would we want a dedicated function since it is only called once?

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

yln added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2349 + if (!cookieOffset.isZero()) +cookiePtr = CGF.Builder.CreateConstInBoundsByteGEP(cookiePtr, cookieOffset); Variable names should start with uppercase:

[libunwind] 6716e20 - [libunwind] Remove -Wsign-conversion warning

Author: Louis Dionne Date: 2022-05-13T13:25:28-04:00 New Revision: 6716e2055ddeac304f47adc5ae39086381016ba7 URL: https://github.com/llvm/llvm-project/commit/6716e2055ddeac304f47adc5ae39086381016ba7 DIFF: https://github.com/llvm/llvm-project/commit/6716e2055ddeac304f47adc5ae39086381016ba7.diff

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 429285. koops added a comment. Took care of the clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/LanguageExtensions.rst:275 + // On amdgcn target + #if __has_target_feature("s-memtime-inst") +x = __builtin_amdgcn_s_memtime(); tra wrote: > Do you have a better

[PATCH] D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation.

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:14222 + TabAlignment.UseTab = FormatStyle::UT_ForIndentation; + TabAlignment.AlignConsecutiveDeclarations.Enabled =

[PATCH] D125555: [clang] Add __has_target_feature

tra added inline comments. Comment at: clang/docs/LanguageExtensions.rst:275 + // On amdgcn target + #if __has_target_feature("s-memtime-inst") +x = __builtin_amdgcn_s_memtime(); Do you have a better example? This particular case could've been handled by

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429276. hctim added a comment. Remove test based on removed invariant (DIGlobalVariables no longer need a name). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429275. porglezomp added a comment. I haven't used arc in a little while and am having trouble sorry for the emails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429274. porglezomp added a comment. Arcanist accidentally threw away the first commit in the sequence... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 Files:

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429273. porglezomp added a comment. Herald added a subscriber: mgorny. Add changes suggested by Duncan to make CLANG_DEFAULT_STD_C more misuse-resistant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

khchen added a comment. Do we need to have some tests in `clang/test/PCH/` for new #pragma? Comment at: clang/lib/Sema/SemaLookup.cpp:932 + if (DeclareRVVBuiltins) { +if (GetRVVBuiltinInfo(*this, R, II, PP)) { + return true; Don’t Use

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. It seems like we cannot use the sorting I did. The warning within the `mylib.h` header will have a different FileID than the original TU. Consequently, the `upper_bound()` `lower_bound()`

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl updated this revision to Diff 429265. yaxunl added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12/new/ https://reviews.llvm.org/D12 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Lex/Preprocessor.h

[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

foad created this revision. foad added reviewers: lattner, RKSimon, lebedev.ri, spatel. Herald added subscribers: kosarev, jsilvanus, hsmhsm, jeroen.dobbelaere, frasercrmck, ecnelises, martong, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o,

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511646 , @dexonsmith wrote: > In D122895#3511611 , @dexonsmith > wrote: > >> Previously, `-Wstrict-prototypes` was useful for preventing actual bugs in >> code. > >

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl created this revision. yaxunl added reviewers: rsmith, aaron.ballman, tra. Herald added a project: All. yaxunl requested review of this revision. Depending on whether a target feature is enabled or not, programs may choose different algorithm or different builtin functions to use. Instead

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 429261. steplong added a comment. - Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125011/new/ https://reviews.llvm.org/D125011 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:446 +} +const bool BState = State->contains(D); +if (!BState) { // This is the first time we see this foreign function. martong wrote: > xazax.hun

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov added a comment. In D103096#3502955 , @martong wrote: > Ping Thank you, folk, for taking you time. I'll surely make corresponding changes according ещ your suggestions and notify you then. Sorry, @martong, for the late response. I'm

[PATCH] D125493: [clang][OpenMP] Fix declare simd use on in-class member template function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d67c8a51d61: [OpenMP] Fix declare simd use on in-class member template function (authored by mikerice). Herald added a project: clang. Herald added

[clang] 0d67c8a - [OpenMP] Fix declare simd use on in-class member template function

Author: Mike Rice Date: 2022-05-13T08:24:55-07:00 New Revision: 0d67c8a51d61cb0fac91f265a424767f072c7d5c URL: https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c DIFF: https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c.diff

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. Thanks Kito. This all LGTM except some warnings need to fix. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:384 +return PD; // Handle primitive type

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

thakis added a comment. https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1 fixed the build, thanks! No opinion off the top of my head on changing the signature. Might be a good idea, maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rGa1025e6ffe9b: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] e8cae48 - Revert "[clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks"

Author: Balazs Benics Date: 2022-05-13T17:07:58+02:00 New Revision: e8cae487022c2216182ae1ec24f248f287a614b7 URL: https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7 DIFF: https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7.diff

[clang] a1025e6 - [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

Author: Balazs Benics Date: 2022-05-13T17:07:58+02:00 New Revision: a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2 URL: https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2 DIFF: https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2.diff

[PATCH] D125463: [analyzer][NFC] Tighten some of the SValBuilder return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5ffc1ed8b62: [analyzer][NFC] Tighten some of the SValBuilder return types (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D125463?vs=428918=429244#toc Repository: rG LLVM

[clang] d5ffc1e - [analyzer][NFC] Tighten some of the SValBuilder return types

Author: Balazs Benics Date: 2022-05-13T17:04:34+02:00 New Revision: d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f URL: https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f DIFF: https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f.diff

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/76033/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3ea55da88a: [clang-tidy] modernize-deprecated-headers check should respect extern C blocks (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 7e3ea55 - [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

Author: Balazs Benics Date: 2022-05-13T16:54:13+02:00 New Revision: 7e3ea55da88a9d7feaa22f29d51f89fd0152a189 URL: https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189 DIFF: https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a comment. In D122895#3511649 , @aaron.ballman wrote: > In D122895#3511611 , @dexonsmith > wrote: > >> Sure, I'm all for adding a new warning for users that want a pedantic >> warning. Can it

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511632 , @jyknight wrote: > The warnings for this case aren't great: > > int foo(); > > int > foo(int arg) { > return 5; > } Yeah, that's not ideal, I'm looking into it to see if I can improve

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:242 + // Find last push instruction for GPRCS2 - spilling of high registers + // (r8-r11) could consist of multiple tPUSH and tMOVr

[PATCH] D125333: [OpenMP] Use the new OpenMP device static library when doing LTO

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125333/new/ https://reviews.llvm.org/D125333

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511611 , @dexonsmith wrote: > Sure, I'm all for adding a new warning for users that want a pedantic > warning. Can it be put behind a separate flag, such as > `-Wstrict-prototypes-pedantic`, which isn't

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. So we have overloads inline const StreamingDiagnostic <<(const StreamingDiagnostic , int I); inline const StreamingDiagnostic <<(const StreamingDiagnostic , int64_t I); inline const StreamingDiagnostic <<(const StreamingDiagnostic , unsigned I); inline

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a comment. In D122895#3511611 , @dexonsmith wrote: > Previously, `-Wstrict-prototypes` was useful for preventing actual bugs in > code. For example, it's important to have a warning that catches code like this: void f1(void

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 429237. pratlucas added a comment. Adding frame access test coverage, adding check for FrameSetup flag and adjusting calculation of FP value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

jyknight added a comment. The warnings for this case aren't great: int foo(); int foo(int arg) { return 5; } results in: /tmp/test.c:1:5: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:268 + QualType Ty = C.getSVal(Arg).getType(C.getASTContext()); + reportBug(Ty.getAsString(), C); +} martong

[clang] 25862f5 - Try to disambiguate between overloads on Mac

Author: Aaron Puchert Date: 2022-05-13T16:29:02+02:00 New Revision: 25862f53cce966cef2957825095861dec631d4f1 URL: https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1 DIFF: https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1.diff

[clang] d364307 - Remove a stale FIXME comment; NFC

Author: Aaron Ballman Date: 2022-05-13T10:23:47-04:00 New Revision: d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5 URL: https://github.com/llvm/llvm-project/commit/d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5 DIFF: https://github.com/llvm/llvm-project/commit/d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5.diff

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. minor nits; Thanks Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:258 + static inline llvm::SMTExprRef fromUnary(llvm::SMTSolverRef , +

  1   2   >