[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

lattner added a comment. I'm not a competent reviewer for the patch, but +1 on aligning with GCC behavior here. I don't recall the motivation for the original patch (apologies again for the terrible commit message). This approach makes a lot of sense to me. Repository: rG LLVM Github

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca27f3e3b26e: [Clang][OpenMP] Support for omp nothing (authored by koops, committed by Chi-Chun, Chen chichunchen...@gmail.com). Repository: rG

[clang] ca27f3e - [Clang][OpenMP] Support for omp nothing

Author: Sunil Kuravinakop Date: 2022-05-24T23:59:31-05:00 New Revision: ca27f3e3b26ed5389d4a361f274e3be516eb282d URL: https://github.com/llvm/llvm-project/commit/ca27f3e3b26ed5389d4a361f274e3be516eb282d DIFF:

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG232bf8189ef7: [OpenMP] atomic compare fail : Parser AST support (authored by koops, committed by Chi-Chun, Chen chichunchen...@gmail.com). Herald

[clang] 232bf81 - [OpenMP] atomic compare fail : Parser & AST support

Author: Sunil Kuravinakop Date: 2022-05-24T23:56:42-05:00 New Revision: 232bf8189ef7d574a468bd5bfd1e84e962f7f16e URL: https://github.com/llvm/llvm-project/commit/232bf8189ef7d574a468bd5bfd1e84e962f7f16e DIFF:

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie added a comment. Herald added a project: All. In D102122#3344317 , @dblaikie wrote: > I don't recall all the context, but did try discussing this with the > committee folks and got a variety of strong opinions/wasn't sure whether > there was a

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 431871. dblaikie added a comment. Herald added a subscriber: MaskRay. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files:

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie updated this revision to Diff 431869. dblaikie added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. @rsmith I had a few responses to your last round of review here - could you have a look through them/see if this is the right way to go, or if more refactoring would be suitable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126334: Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

This revision was automatically updated to reflect the committed changes. Closed by commit rGe59f648d698e: Move GCC-compatible pod-packing change to v15/old behavior available at v14 and… (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e59f648 - Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

Author: David Blaikie Date: 2022-05-25T03:03:27Z New Revision: e59f648d698efe58b96e9b6224449b2b8cfa872a URL: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a DIFF: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a.diff

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1ffba8d5286: [C++20] [Coroutines] Conform the updates for CWG issue 2585 (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES

[clang] a1ffba8 - [C++20] [Coroutines] Conform the updates for CWG issue 2585

Author: Chuanqi Xu Date: 2022-05-25T10:31:26+08:00 New Revision: a1ffba8d528681d55c901a997beedbc69946eb90 URL: https://github.com/llvm/llvm-project/commit/a1ffba8d528681d55c901a997beedbc69946eb90 DIFF: https://github.com/llvm/llvm-project/commit/a1ffba8d528681d55c901a997beedbc69946eb90.diff

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

ChuanqiXu added a comment. > I think I have a preference to move it to CodeGenCXX anyway however, since > we're actually testing the code-generated output (this is not novel, we DO > often use CodeGen tests to make sure proper overloads/etc get called). It makes sense. Done. Thanks for

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

ChuanqiXu updated this revision to Diff 431861. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126187/new/ https://reviews.llvm.org/D126187 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

peixin added a comment. In D125788#3535199 , @sscalpone wrote: > My proposal is: > > If the compiler compiles it, it ought to run. > If the compiler can't compile it, it ought to clearly say why. > > 1. All tests of legal Fortran that compile & link must

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 431853. MatzeB marked an inline comment as done. MatzeB added a comment. Enable LTO by default and fix a whole bunch of LTO tests because of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3535905 , @jhuber6 wrote: > I can't think of a way to generate these new symbols, we'd need to somehow > have a list of all the static entries that need new symbols and then modify > the object file after its been

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:395 + +unsigned GetMCUEEPROMSize(StringRef MCUName) { + for (const auto : MCUInfo) Add three helper functions for the newly added fields. CHANGES SINCE LAST ACTION

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:441 +if (!llvm::sys::fs::can_execute(FullPath)) + D.Diag(diag::err_drv_invalid_linker_name) << Linker; +else We report an error if the linker specified via `-fuse-ld`

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. @arphaman Thanks for the quick action. The tests pass on a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/1493, so that's probably why there was trouble reproducing. I think we could revert 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rsmith added a comment. Herald added a project: All. I've not looked at the test changes in any detail; please let me know if there's anything in there that deserves special attention. Comment at: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp:567-577 -if

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:122 + if (Opts.HLSL) +Includes.push_back("hlsl.h"); Anastasia wrote: > Is this header expected to be large? You might want to flag up in the > description of the review and

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

ltertan added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:455 + << "-maltivec"; + + // Cannot allow soft-float with Altivec. Do we also need to return from here? Comment at:

[PATCH] D126347: [pseudo] WIP: GSS Node refcount (smart pointers)

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Here is the version

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3535830 , @tra wrote: > I'm still itching to figure out a way to avoid CUID altogether and with the > new driver it may be possible. I would be 100% in favor of working around this if possible, it's proving to be

[PATCH] D126346: [Clang] Make PIC check comprehensive with respect to relocation models.

ZhiyaoMa98 created this revision. ZhiyaoMa98 added reviewers: rsmith, llvm-commits. Herald added a project: All. ZhiyaoMa98 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing if branch for "ropi", "rwpi" and "ropi-rwpi" relocation

[PATCH] D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion

bruno created this revision. bruno added reviewers: alanphipps, vsk, zequanwu. Herald added subscribers: hoy, modimo, wenlei, hiraditya. Herald added a project: All. bruno requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. In D124751#3529652 , @MaskRay wrote: > In D124751#3513513 , @python3kgae > wrote: > >> In D124751#3513283 , @MaskRay >> wrote: >> >>> Is

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. I'm still itching to figure out a way to avoid CUID altogether and with the new driver it may be possible. CUID serves two purposes: a) avoid name conflicts during device-side linking ("must be globally unique" part) b) allow host to refer to something in the GPU executable

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ff4f2dfea63: [clang-tidy] Fix #55134 (regression introduced by 5da7c04) (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 9ff4f2d - [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

Author: Salman Javed Date: 2022-05-25T11:30:58+12:00 New Revision: 9ff4f2dfea632d63e3a57a88a2faa634aae5c772 URL: https://github.com/llvm/llvm-project/commit/9ff4f2dfea632d63e3a57a88a2faa634aae5c772 DIFF: https://github.com/llvm/llvm-project/commit/9ff4f2dfea632d63e3a57a88a2faa634aae5c772.diff

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen updated this revision to Diff 431825. ychen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126341/new/ https://reviews.llvm.org/D126341 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen created this revision. ychen added reviewers: rnk, rsmith, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By the standard https://eel.is/c++draft/basic.start#dynamic-1, implicitly

[PATCH] D126334: Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

MatzeB accepted this revision. MatzeB added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126334/new/ https://reviews.llvm.org/D126334

[PATCH] D126337: [pseudo] WIP: GSS node refcounting (dumb pointers)

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This adds a refcount to

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc

[PATCH] D126334: Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

dblaikie created this revision. dblaikie added a reviewer: tstellar. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since this didn't make it into the v14 release - anyone requesting the v14 ABI

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 431812. python3kgae added a comment. Treat entry functions as in extern C scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752 Files: clang/lib/AST/Decl.cpp

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. A Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { jhuber6 wrote: > tra wrote: > > jhuber6 wrote: > > > tra wrote: > > >

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 431810. hctim added a comment. Remove extra creation path, turns out it's a duplicate of elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files:

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { tra wrote: > jhuber6 wrote: > > tra wrote: > > > > However, [CUID]

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431805. salman-javed-nz added a comment. Added release note. (Also taking the opportunity to run the patch through the pre-merge build bot one last time.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny marked 2 inline comments as done. jdenny added a comment. Thanks. Will try to push tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126323/new/ https://reviews.llvm.org/D126323 ___ cfe-commits mailing list

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny updated this revision to Diff 431804. jdenny added a comment. Fixed a bug in the new tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126323/new/ https://reviews.llvm.org/D126323 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/nesting_of_regions.cpp

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126323/new/ https://reviews.llvm.org/D126323

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

nathanchance added a comment. @amyk Thank you a lot for the fix! I'll pull it down and verify everything is fixed tonight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125506/new/ https://reviews.llvm.org/D125506

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, >

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic);

[PATCH] D125814: Improve the strict prototype diagnostic behavior

dexonsmith resigned from this revision. dexonsmith added a comment. (I’ll be happy with whatever you two sort out here!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125814/new/ https://reviews.llvm.org/D125814 ___ cfe-commits mailing list

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic);

[PATCH] D125814: Improve the strict prototype diagnostic behavior

jyknight added a comment. Good improvement, but an additional change to wording for just the zero-arg non-prototype function declaration case could help a lot. The fact that zero-arg it's only being warned about because of the "...because of" note isn't particularly clear -- especially when

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic);

[PATCH] D126314: [clang][dataflow] Relax `Environment` comparison operation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f93bbb9cd7c: [clang][dataflow] Relax `Environment` comparison operation. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2f93bbb - [clang][dataflow] Relax `Environment` comparison operation.

Author: Yitzhak Mandelbaum Date: 2022-05-24T20:58:18Z New Revision: 2f93bbb9cd7c20ea1a273cf652d852d4b641f94a URL: https://github.com/llvm/llvm-project/commit/2f93bbb9cd7c20ea1a273cf652d852d4b641f94a DIFF: https://github.com/llvm/llvm-project/commit/2f93bbb9cd7c20ea1a273cf652d852d4b641f94a.diff

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic);

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/

[clang] 1b34f1e - [clang][test] mark tests added in ee8524087c78 as unsupported on AIX

Author: Alex Lorenz Date: 2022-05-24T13:39:37-07:00 New Revision: 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 URL: https://github.com/llvm/llvm-project/commit/1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 DIFF: https://github.com/llvm/llvm-project/commit/1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.diff

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

nickdesaulniers added a comment. Diff 431607 boots for me in QEMU (triple checked that CONFIG_CC_HAS_SLS=y AND CONFIG_SLS=y were set this time ;) ). Comment at: clang/docs/ReleaseNotes.rst:371 +- Support ``-mharden-sls=all`` for X86. + pengfei wrote: >

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders created this revision. wanders added reviewers: lattner, jyknight, rsmith. wanders added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a subscriber: cfe-commits. A variable with `weak`

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan I'm going to disable these tests for `aix` for now to unblock the bot as they're still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny created this revision. jdenny added reviewers: jdoerfert, ABataev. jdenny added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:9118 + ProcessDeclAttributeOptions Options; + Options.IncludeCXX11Attributes = AL.isCXX11Attribute(); + ProcessDeclAttribute(*this, nullptr, ASDecl, AL, Options);

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb9e0f5ebb9: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to… (authored by ymandel). Repository: rG LLVM Github

[clang] 6eb9e0f - [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

Author: Yitzhak Mandelbaum Date: 2022-05-24T20:13:55Z New Revision: 6eb9e0f5ebb94cccf52ea27aa342001b84c1c8b1 URL: https://github.com/llvm/llvm-project/commit/6eb9e0f5ebb94cccf52ea27aa342001b84c1c8b1 DIFF: https://github.com/llvm/llvm-project/commit/6eb9e0f5ebb94cccf52ea27aa342001b84c1c8b1.diff

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added inline comments. Herald added a project: All. Comment at: clang/lib/AST/ASTContext.cpp:11551-11552 +if (Unqualified && !Ctx.hasSameType(X, Y)) { + assert(Ctx.hasSameUnqualifiedType(X, Y)); + auto XQuals = X.getCVRQualifiers(), YQuals =

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

nhaehnle added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1393-1394 +def int_threadlocal_address : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty], +[IntrNoMem, IntrWillReturn]>; + Whether IntrNoMem is truly

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { jhuber6 wrote: > tra wrote: > > > However, [CUID] is not always

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. My proposal is: If the compiler compiles it, it ought to run. If the compiler can't compile it, it ought to clearly say why. 1. All tests of legal Fortran that compile & link must also execute correctly (which excludes tests that expect to catch a problem at runtime)

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

nhaehnle added a comment. You can use the "Edit Related Revisions" option in the right-hand side menu of Phabricator to link this revision with the others of the series. I can't really speak for the Clang parts, but the LLVM parts looks reasonable to me modulo some detail comments.

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

MichielDerhaeg updated this revision to Diff 431768. MichielDerhaeg marked an inline comment as done. MichielDerhaeg added a comment. - add target requirement to lit test - move condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125974/new/

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of `index-concept-kind.cpp` does not have any concepts output:

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

ymandel added a comment. In D126316#3535057 , @tschuett wrote: > or `min(MaxAverageVisitsPerBlock * BlockStates.size(), 2^16);` Good idea, thx. In D126316#3535077 , @xazax.hun wrote: > An alternative approach

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

ymandel updated this revision to Diff 431761. ymandel added a comment. Reinstated absolute limit of 2^16. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126316/new/ https://reviews.llvm.org/D126316 Files:

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Sure, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

xazax.hun added a comment. An alternative approach is to maintain separate counters for back edges and bail if those reach a certain limit. But this global limit is way simpler, so it looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

tschuett added a comment. or `min(MaxAverageVisitsPerBlock * BlockStates.size(), 2^16);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126316/new/ https://reviews.llvm.org/D126316 ___ cfe-commits

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. Hi, these tests fail on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/1489 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:336 + static constexpr uint32_t MaxAverageVisitsPerBlock = 4; + const uint32_t MaxIterations = MaxAverageVisitsPerBlock * BlockStates.size(); uint32_t Iterations =

[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

ymandel created this revision. ymandel added reviewers: xazax.hun, li.zhe.hua, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the maximum number of iterations of the

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:17 +static const char *CxxBNF = +#include "CXXBNF.inc" +; sammccall wrote: > this is worth a try, but I think (some versions of?) MSVC don't like long > string literals. > >

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein updated this revision to Diff 431746. hokein marked 3 inline comments as done. hokein added a comment. rebase, and emit string chunks rather than a long raw string literal (to make msvc happy) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:10 +// C forbids comma operator in initializing expressions. +#define BAD_OP 1, 2 + LegalizeAdulthood wrote: > aaron.ballman wrote: > > Can you

[PATCH] D126314: [clang][dataflow] Relax `Environment` comparison operation.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, li.zhe.hua. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Ignore `MemberLocToStruct` in environment

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. mizvekov published this revision for review. mizvekov added reviewers: bruno, mgorny, Ericson2314, sgraenitz, stephenneuendorffer. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { tra wrote: > > However, [CUID] is not always availible. > > The

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:9118 + ProcessDeclAttributeOptions Options; + Options.IncludeCXX11Attributes = AL.isCXX11Attribute(); + ProcessDeclAttribute(*this, nullptr, ASDecl, AL, Options);

[PATCH] D126183: Implement soft reset of the diagnostics engine.

rsmith added a comment. I don't think we can live with the `#define private public` approach, not least because this violates the ODR and might lead to compile failures using modules as a result. As an alternative, how about: - Adding a `friend void DiagnosticTestHelper();` declaration to

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { > However, [CUID] is not always availible. The question is -- when

[PATCH] D126093: Sema: adjust assertion to account for deduced types

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGb159108bc5eb: Sema: adjust assertion to account for deduced types (authored by compnerd). Changed prior to commit:

[clang] b159108 - Sema: adjust assertion to account for deduced types

Author: Saleem Abdulrasool Date: 2022-05-24T17:49:44Z New Revision: b159108bc5ebd7f37373896ece1da8f49612f7a6 URL: https://github.com/llvm/llvm-project/commit/b159108bc5ebd7f37373896ece1da8f49612f7a6 DIFF: https://github.com/llvm/llvm-project/commit/b159108bc5ebd7f37373896ece1da8f49612f7a6.diff

[clang] 3723868 - [OpenMP] Fix file arguments for embedding bitcode in the linker wrapper

Author: Joseph Huber Date: 2022-05-24T13:45:52-04:00 New Revision: 3723868d9e07de5d4a7468a4c2c74fc8517afc14 URL: https://github.com/llvm/llvm-project/commit/3723868d9e07de5d4a7468a4c2c74fc8517afc14 DIFF: https://github.com/llvm/llvm-project/commit/3723868d9e07de5d4a7468a4c2c74fc8517afc14.diff

[PATCH] D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba937112fa6: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator (authored by mikerice). Herald added a project: clang. Herald

[clang] 9ba9371 - [OpenMP] Add parsing/sema support for omp_all_memory reserved locator

Author: Mike Rice Date: 2022-05-24T10:28:59-07:00 New Revision: 9ba937112fa6d4076e4a98b587a334786b6c0d9c URL: https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c DIFF: https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c.diff

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae added inline comments. Comment at: clang/lib/AST/Mangle.cpp:138 + // HLSL shader entry function never need to be mangled. + if (getASTContext().getLangOpts().HLSL && D->hasAttr()) Anastasia wrote: > Does HLSL shader entry inherits the same

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

tra added a comment. I would suggest separating it into separate LLVM and MLIR patches. LLVM changes look OK to me. No idea about MLIR. we would probably want to lower fp16 fdiv the same way in LLVM, too, but that would also have to be a separate patch. Repository: rG LLVM Github Monorepo

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

aaron.ballman added a comment. Thank you for your work on this, I generally like this new approach and think we're heading in the right direction. Comment at: clang/include/clang/Sema/DeclSpec.h:1853-1856 /// Attrs - Attributes. ParsedAttributes Attrs; +

[PATCH] D126274: [clangd] Handle '--' in QueryDriverDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rG175833ed6f62: [clangd] Handle -- in QueryDriverDatabase (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126274/new/

  1   2   3   >