[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:450 + // Cannot allow VSX with no Altivec. + if (llvm::is_contained(FeaturesVec, "-hard-float") && Comments in reverse order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan added a comment. Can you update the diff with context? See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365

[PATCH] D126438: [clang-format] Fix an invalid code generation in RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D102122: Support warn_unused_result on typedefs

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2943 +def WarnUnusedResultClang : InheritableAttr { + let Spellings = [CXX11<"clang", "warn_unused_result">]; + let Subjects = SubjectList<[ObjCMethod, Enum, Record, FunctionLike, TypedefName]>;

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. Recommend that you contact NAG for more info on the test suite. Here's the only reference that I could find: https://fortran-lang.discourse.group/t/fortran-compiler-testing-framework/1573/10 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126247: `readability-indentifier-naming` resolution order and examples

KazNX updated this revision to Diff 432159. KazNX added a comment. Updated to address feedback. - Typo corrections. - Additional declarations. - Changed source reference URL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126247/new/

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string , const Twine , +const Twine = "", const Twine = "", egorzhdan wrote: > MaskRay wrote: > > This

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rsmith added a comment. > The underlying problem is basically wg21.link/cwg362 which has no concensus > yet. CWG362 has a clear consensus and has been closed with that consensus for 18 years. The consensus, per that issue, is: > We discussed this and agreed that **we really do mean the the

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 updated this revision to Diff 432146. jhuber6 added a comment. Add test for #line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125904/new/ https://reviews.llvm.org/D125904 Files: clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3537947 , @rnk wrote: > I'm somewhat supportive of the goal here, but I think there are still some > underlying issues. > > First, why should these guarantees be limited to instantiations and not > inline variables?

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + dblaikie wrote: > probinson wrote: > > Does this mean `-fclang-abi-compat` will override the PS4/Darwin special > > case? I think

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string , const Twine , +const Twine = "", const Twine = "", MaskRay wrote: > This can use

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. In D125904#3538742 , @jhuber6 wrote: > In D125904#3538714 , @tra wrote: > >> It would be great to have some compile-time checks for that, if possible. >> Otherwise it will only manifest at

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3538714 , @tra wrote: > It would be great to have some compile-time checks for that, if possible. > Otherwise it will only manifest at run-time and the end user will have no > clue what's going on. Not sure how we

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

rsmith added a comment. I'm very happy with how this patch is looking. Comment at: clang/include/clang/Sema/DeclSpec.h:1926-1928 +assert(llvm::all_of(DeclarationAttrs, [](const ParsedAttr ) { + return AL.isStandardAttributeSyntax(); +})); rsmith

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string , const Twine , +const Twine = "", const Twine = "", This can use `llvm::sys::path::append`

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. In D125904#3538163 , @yaxunl wrote: > I am OK with this patch. OK. > That said, this patch provided a default CUID that do not depend on driver, > which is its advantage. It should be OK for most usecases. I agree with this part.

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

mikerice added a comment. In D126331#3538670 , @jdoerfert wrote: > Cool! Can we have that for begin declare variant too :D ? I'll take a look when I get a moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

rsmith added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1926-1928 +assert(llvm::all_of(DeclarationAttrs, [](const ParsedAttr ) { + return AL.isStandardAttributeSyntax(); +})); I think I recall seeing OpenMP pragma attributes

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

jdoerfert added a comment. Cool! Can we have that for begin declare variant too :D ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126331/new/ https://reviews.llvm.org/D126331 ___ cfe-commits mailing

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie added a comment. Sorry, with all the layers in the previous messages I'm not sure what the summary is. Sounds like the summary is "this is OK to continue work in the direction of supporting [[clang::warn_unused_result]] (only that spelling) for typedefs in C and C++ (for compatibility

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 432131. dblaikie added a comment. Separate out clang:warn_unused_result so typedef support can be added to only that spelling. This has one lingering issue (because it still currently instantiates both the clang:warn_unused_result as the same *Attr class

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3538380 , @ldionne wrote: > We've started having several internal user complaints because their system > headers are suddenly triggering a warning for using ``. This seems > to be caused by the fact that

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

steakhal added a comment. Thanks for the quick response! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:127 + +public: bool isPosteriorlyOverconstrained() const { This shouldnt be the way. Consider fwd declaring and making

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:407 for (const FieldDecl *Field : getAccessibleObjectFields(Type)) { assert(Field != nullptr); Why not use `getObjectFields` here too?

[PATCH] D126413: [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5520c5839016: [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33b598a808b9: [clang][dataflow] Relax assert on existence of `this` pointee storage (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo

[clang] 5520c58 - [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas

Author: Eric Li Date: 2022-05-25T20:58:02Z New Revision: 5520c5839016d1d98d8e01789eb17c910381bd6f URL: https://github.com/llvm/llvm-project/commit/5520c5839016d1d98d8e01789eb17c910381bd6f DIFF: https://github.com/llvm/llvm-project/commit/5520c5839016d1d98d8e01789eb17c910381bd6f.diff LOG:

[clang] 33b598a - [clang][dataflow] Relax assert on existence of `this` pointee storage

Author: Eric Li Date: 2022-05-25T20:58:02Z New Revision: 33b598a808b9ef1a019e798f19855f203e09ad48 URL: https://github.com/llvm/llvm-project/commit/33b598a808b9ef1a019e798f19855f203e09ad48 DIFF: https://github.com/llvm/llvm-project/commit/33b598a808b9ef1a019e798f19855f203e09ad48.diff LOG:

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. ping I think the assertion is assuming `StmtExpr` is created only for GNU statement expressions, but it's created for asm statements too (see https://github.com/llvm/llvm-project/commit/3050d9bdb84e322e122219d54aedfe2d8ef7c51c). Repository: rG LLVM Github Monorepo

[PATCH] D126413: [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas

li.zhe.hua updated this revision to Diff 432124. li.zhe.hua added a comment. Address reviewer comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126413/new/ https://reviews.llvm.org/D126413 Files:

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

li.zhe.hua updated this revision to Diff 432119. li.zhe.hua added a comment. Accidentally a word... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126405/new/ https://reviews.llvm.org/D126405 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

li.zhe.hua updated this revision to Diff 432117. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126405/new/ https://reviews.llvm.org/D126405 Files:

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, li.zhe.hua. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The API for `AggregateStorageLocation` does not

[PATCH] D126419: [clang][dataflow] Improve handling of constructor initializers.

ymandel created this revision. ymandel added reviewers: sgatev, li.zhe.hua, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, we assert that `CXXCtorInitializer`s are

[PATCH] D126413: [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1526 + int Foo = Bar; + // [[p]] +}(); please use

[PATCH] D126398: [Clang] Introduce `--offload-link` option to perform offload device linking

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7c8c4d8cf07: [Clang] Introduce `--offload-link` option to perform offload device linking (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b7c8c4d - [Clang] Introduce `--offload-link` option to perform offload device linking

Author: Joseph Huber Date: 2022-05-25T16:30:53-04:00 New Revision: b7c8c4d8cf07d2e9e8cd157bccc8bd9e7c76415a URL: https://github.com/llvm/llvm-project/commit/b7c8c4d8cf07d2e9e8cd157bccc8bd9e7c76415a DIFF: https://github.com/llvm/llvm-project/commit/b7c8c4d8cf07d2e9e8cd157bccc8bd9e7c76415a.diff

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added inline comments. Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory -

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:282 auto *ThisPointeeLoc = Env.getThisPointeeStorageLocation(); -assert(ThisPointeeLoc != nullptr); +if (ThisPointeeLoc == nullptr) + return;

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. We've started having several internal user complaints because their system headers are suddenly triggering a warning for using ``. This seems to be caused by the fact that `#warning` is surfaced to users even when the `#warning` is present in a system header (which

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Please wait for at least one more "accept". thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126405/new/

[PATCH] D126413: [clang][dataflow] Fix incorrect CXXThisExpr pointee for lambdas

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When constructing the

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. +1 @kiranchandramohan I have access to the NAG Fortran compiler and find it very helpful for checking standard conformance. I was unaware of the NAG test suite and don't see any mention of it online. Is it an official product that can be purchased? Repository: rG

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 432091. dblaikie added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102122/new/ https://reviews.llvm.org/D102122 Files: clang/include/clang/Basic/Attr.td clang/lib/AST/Expr.cpp

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2547 if (Constraint->encodesFalseRange()) return State->assume(DefinedVal, false); I am wondering, that maybe it would be better to check for

[PATCH] D126332: [clang] Fix the begin location of concepts specialization expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79e09af1d6e1: [clang] Fix the begin location of concepts specialization expression (authored by arphaman). Herald added a project: clang. Herald

[clang] 79e09af - [clang] Fix the begin location of concepts specialization expression

Author: Alex Lorenz Date: 2022-05-25T12:39:21-07:00 New Revision: 79e09af1d6e11b05c6484868f15a9a2db298699c URL: https://github.com/llvm/llvm-project/commit/79e09af1d6e11b05c6484868f15a9a2db298699c DIFF: https://github.com/llvm/llvm-project/commit/79e09af1d6e11b05c6484868f15a9a2db298699c.diff

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

yaxunl added a comment. In D125904#3537952 , @tra wrote: > How much work would it take to add cuid generation in the new driver, similar > to what the old driver does, using the same logic, however imperfect it is? > I'd be OK with that as a possibly

[PATCH] D126405: [clang][dataflow] Relax assert on existence of `this` pointee storage

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support for unions is incomplete

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added inline comments. Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory -

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3538064 , @stephenneuendorffer wrote: > LGTM... Does LLVM_TOOLS_BINARY_DIR include CMAKE_CFG_INTDIR? Is this > actually NFC? On a normal build where the CMakelists in the llvm subdir is used as the top level one,

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 432074. csigg added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. > This change in itself reduced the run-time of the analysis to 16 seconds, on > my machine. However, the repetition of States should still be addressed. I am > going to upload the upper patch for a starter. Sorry, in that 16s, I measured also the rebuild and linkage

[PATCH] D126369: [LLVM] Add rcp.approx.ftz.f32 intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4bc416418a2: [LLVM] Add rcp.approx.ftz.f32 intrinsic (authored by csigg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c4bc416 - [LLVM] Add rcp.approx.ftz.f32 intrinsic

Author: Christian Sigg Date: 2022-05-25T21:05:20+02:00 New Revision: c4bc416418a2d8a86b699060efa47515de5ffbb6 URL: https://github.com/llvm/llvm-project/commit/c4bc416418a2d8a86b699060efa47515de5ffbb6 DIFF:

[PATCH] D126369: [LLVM] Add rcp.approx.ftz.f32 intrinsic

csigg added a comment. Thanks Artem. I think I should be able to land it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126369/new/ https://reviews.llvm.org/D126369 ___ cfe-commits mailing list

[PATCH] D126398: [Clang] Introduce `--offload-link` option to perform offload device linking

jhuber6 updated this revision to Diff 432071. jhuber6 added a comment. Removing `-dlink` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126398/new/ https://reviews.llvm.org/D126398 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D126398: [Clang] Introduce `-dlink` option to perform offload device linking

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:825-826 + HelpText<"Use the new offloading linker to perform the link job.">; +def device_link : Flag<["-"], "dlink">, Group, + Alias; def Xlinker : Separate<["-"], "Xlinker">,

[PATCH] D126170: C++ DR2394: Const-default-constructible for members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG997b072e10d2: C++ DR2394: Const-default-constructible for members. (authored by jyknight). Changed prior to commit:

[clang] 997b072 - C++ DR2394: Const-default-constructible for members.

Author: James Y Knight Date: 2022-05-25T14:20:11-04:00 New Revision: 997b072e10d2be09c0e1a5bf4d6b92e2da3b8cc6 URL: https://github.com/llvm/llvm-project/commit/997b072e10d2be09c0e1a5bf4d6b92e2da3b8cc6 DIFF:

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

stephenneuendorffer added a comment. LGTM... Does LLVM_TOOLS_BINARY_DIR include CMAKE_CFG_INTDIR? Is this actually NFC? Comment at: clang/utils/hmaptool/CMakeLists.txt:1 -set(CLANG_HMAPTOOL hmaptool) Unused elsewhere, I assume? Repository: rG LLVM

[PATCH] D126398: [Clang] Introduce `-dlink` option to perform offload device linking

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:825-826 + HelpText<"Use the new offloading linker to perform the link job.">; +def device_link : Flag<["-"], "dlink">, Group, + Alias; def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput,

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added a comment. This Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory -

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

tchatow added a comment. No, I'll need someone to commit it on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.llvm.org/D125848 ___ cfe-commits mailing list

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. Thanks Balazs for the report. Here is my analysis. Looks like during the recursive simplification, `reAssume` produces `State`s that had been created by a previous `reAssume`. Before this change, to stop the recursion it was enough to to check if the `OldState`

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

ahatanak added a comment. ping. Does debug info need information on deduction guides? I think it's safe to skip deduction guides as they are used only for template argument deduction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125839/new/

[PATCH] D126398: [Clang] Introduce `-dlink` option to perform offload device linking

jhuber6 updated this revision to Diff 432060. jhuber6 added a comment. Changing to use `--offload-link` and use `-dlink` as an alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126398/new/ https://reviews.llvm.org/D126398 Files:

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

hokein added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126397/new/ https://reviews.llvm.org/D126397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks a lot! Do you have commit rights or need some help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.llvm.org/D125848

[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874 - if (SimpleBlock && !KeepBraces) { + auto RemoveBraces = [=]() mutable { +if (KeepBraces ||

[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874 - if (SimpleBlock && !KeepBraces) { + auto RemoveBraces = [=]() mutable { +if (KeepBraces || !SimpleBlock) curdeius wrote: > Are there many captures here? Wouldn't it

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3537952 , @tra wrote: > How much work would it take to add cuid generation in the new driver, similar > to what the old driver does, using the same logic, however imperfect it is? > I'd be OK with that as a possibly

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. Could you lay out the expected interaction between "STDC FENV_ACCESS", "clang fp exceptions", "float_control", and "fenv_access"? If there's some way to map everything to "#pragma clang fp", please lay that out; if that isn't possible, please explain why. As far as

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() ||

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + probinson wrote: > Does this mean `-fclang-abi-compat` will override the PS4/Darwin special > case? I think we don't want to do

[PATCH] D126398: [Clang] Introduce `-dl` option to perform offload device linking

jhuber6 added a comment. In D126398#3537942 , @tra wrote: > Naming, as usual, is hard. I would prefer a more explicit `--offload-link` > which would be in line with other --offload* options we have by now. > `-dl` is cryptic for uninitiated and is

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. How much work would it take to add cuid generation in the new driver, similar to what the old driver does, using the same logic, however imperfect it is? I'd be OK with that as a possibly permanent solution. I'm somewhat wary of temporary solutions as they tend to become

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rnk added a subscriber: alexander-shaposhnikov. rnk added a comment. I'm somewhat supportive of the goal here, but I think there are still some underlying issues. First, why should these guarantees be limited to instantiations and not inline variables? Such as: int f(); inline int gv1 =

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4baae166ce33: [pseudo] Fix pseudo-gen usage when cross-compiling (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126397/new/

[clang-tools-extra] 4baae16 - [pseudo] Fix pseudo-gen usage when cross-compiling

Author: Shoaib Meenai Date: 2022-05-25T11:08:21-07:00 New Revision: 4baae166ce33ac763bfc1813cf56b8d26e07fb1f URL: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f DIFF: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f.diff

[PATCH] D126398: [Clang] Introduce `-dl` option to perform offload device linking

tra added a comment. > Currently, we infer the usage of the device linker by the user > specifying an offloading toolchain, e.g. (--offload-arch=...) or > (-fopenmp-targets=...), but this shouldn't be strictly necessary. Yup. Whether we want to perform device link or not is orthogonal to those

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432051. python3kgae added a comment. Herald added a subscriber: MaskRay. Add hlsl-no-stdinc to not include the hlsl header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/

[PATCH] D125814: Improve the strict prototype diagnostic behavior

jyknight accepted this revision. jyknight added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:3959 + // it's a user-visible declaration. There is one exception to this: + // when the new declaration is

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG504736cedff3: [clang][extract-api] Dont emit symbols prefixed with an underscore (authored by dang). Repository: rG LLVM Github Monorepo CHANGES

[clang] 504736c - [clang][extract-api] Don't emit symbols prefixed with an underscore

Author: Daniel Grumberg Date: 2022-05-25T19:02:18+01:00 New Revision: 504736cedff39d46fffc1293a35602ba140b19a8 URL: https://github.com/llvm/llvm-project/commit/504736cedff39d46fffc1293a35602ba140b19a8 DIFF:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall added a comment. Please go ahead and land this, the remaining open comment doesn't really matter. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) +

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3537872 , @tra wrote: > Is this patch in its current form blocking any of your other work? no-cuid > approach, even if we figure out how to do it, will likely take some time. Do > you need an interim solution until

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. Is this patch in its current form blocking any of your other work? no-cuid approach, even if we figure out how to do it, will likely take some time. Do you need an interim solution until then? In D125904#3537385 , @jhuber6 wrote:

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. In D123235#3537820 , @aaron.ballman wrote: > In D123235#3537636 , @aaron.ballman > wrote: > >> Please revert the changes while investigating how to resolve the crashes >> though.

[clang] 9368bf9 - Removing this as part of the revert done in 69da3b6aead2e7a18a2578aad661d6d36b8d30cf

Author: Aaron Ballman Date: 2022-05-25T13:45:17-04:00 New Revision: 9368bf9023eee0dc6fcfa007e157fe30e1540fcc URL: https://github.com/llvm/llvm-project/commit/9368bf9023eee0dc6fcfa007e157fe30e1540fcc DIFF: https://github.com/llvm/llvm-project/commit/9368bf9023eee0dc6fcfa007e157fe30e1540fcc.diff

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3537675 , @aaron.ballman wrote: > Adding the language WG as a reviewer in case others have opinions. > >> The underlying problem is basically wg21.link/cwg362 which has no concensus >> yet. > > According to >

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3537843 , @sammccall wrote: > Thank you! I have been banging my head against this, I'm not entirely sure > why this works and my version doesn't. Ah, sorry for the duplicated work :( Thanks for the review!

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! I have been banging my head against this, I'm not entirely sure why this works and my version doesn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this has sat for long enough and my LGTM will have to suffice. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. In D123235#3537636 , @aaron.ballman wrote: > Please revert the changes while investigating how to resolve the crashes > though. I just noticed that you needed someone to commit on your behalf for this, so I went ahead

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3f85390bde: [OpenMP] Add diagnostic for unterminated omp [begin] declare target (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] 69da3b6 - Revert "[OpenMP] atomic compare fail : Parser & AST support"

Author: Aaron Ballman Date: 2022-05-25T13:34:34-04:00 New Revision: 69da3b6aead2e7a18a2578aad661d6d36b8d30cf URL: https://github.com/llvm/llvm-project/commit/69da3b6aead2e7a18a2578aad661d6d36b8d30cf DIFF: https://github.com/llvm/llvm-project/commit/69da3b6aead2e7a18a2578aad661d6d36b8d30cf.diff

[clang] ba3f853 - [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

Author: Mike Rice Date: 2022-05-25T10:34:07-07:00 New Revision: ba3f85390bde10eab1cbdb68f744b8f5ab31859b URL: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b DIFF: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b.diff

  1   2   >