[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3546173 , @efriedma wrote: >> setRoundingMode definitely should not call getAllowFEnvAccess() and it does >> not > > Yes, it does? > > // C2x: 7.6.2p3 If the FE_DYNAMIC mode is specified and FENV_ACCESS is >

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

v.g.vassilev added a comment. This patch fixes our test case which we intended to fix with: From 17e94a6a2adc3eb8d5fcc532eb1f3e57cc59b0fd Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Mon, 23 May 2022 21:36:43 + Subject: [PATCH] Fix type printing to not include the suffix

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7572 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what implied by the " + "-fno-lax-vector-conversions option">,

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433011. junaire added a comment. Remove a NFC change to make review easier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files:

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433009. junaire added a comment. Improve code a little bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG563cc3fda9a2: [Clang][CSKY] Add support about CSKYABIInfo (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/

[clang] 563cc3f - [Clang][CSKY] Add support about CSKYABIInfo

Author: Zi Xuan Wu (Zeson) Date: 2022-05-31T10:53:30+08:00 New Revision: 563cc3fda9a2a35582d274e1d2d66687ecf2fc77 URL: https://github.com/llvm/llvm-project/commit/563cc3fda9a2a35582d274e1d2d66687ecf2fc77 DIFF:

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433008. junaire added a comment. Also remove PTU in PTU list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu accepted this revision as: ChuanqiXu. ChuanqiXu added a comment. This revision is now accepted and ready to land. This change LGTM and I prefer the change than D74130 since this one is much more comprehensible. Repository: rG LLVM Github Monorepo

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433006. python3kgae added a comment. Add new line at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3545779 , @Anastasia wrote: > From the current change it seems to me that what you need to be testing is a > just that the frontend options are being passed correctly? This should then > be a driver test with

[PATCH] D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126669/new/ https://reviews.llvm.org/D126669

Re: Call for an assistance pushing patch review forward

Beyond that it may be useful to look at who's been contributing to the code you're trying to change and consider cc'ing them on the review. (if they can't help, maybe they can point you to someone who can) On Fri, May 27, 2022 at 2:23 PM stryku_t via cfe-commits wrote: > > Hi Paul, > > Thank you

[PATCH] D126681: [HIP] Fix static lib name on windows

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. clang by default assumes static library name to be xxx.lib when -lxxx is specified on Windows with MSVC environment, instead of

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3532811 , @dblaikie wrote: > Ping @aprantl thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jhuber6 added a comment. Also I probably should've discussed this earlier, but another potential solution is to use the binary format that we use to embed the object files for the images as well. This is

[PATCH] D126674: [clang] NFC: introduce test for D126620

This revision was automatically updated to reflect the committed changes. Closed by commit rGc825abd6b019: [clang] NFC: introduce test for D126620 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126674/new/

[clang] c825abd - [clang] NFC: introduce test for D126620

Author: Matheus Izvekov Date: 2022-05-30T22:45:57+02:00 New Revision: c825abd6b0198fb088d9752f556a70705bc99dfd URL: https://github.com/llvm/llvm-project/commit/c825abd6b0198fb088d9752f556a70705bc99dfd DIFF:

[PATCH] D126674: [clang] NFC: introduce test for D126620

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126674/new/ https://reviews.llvm.org/D126674

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rnk. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. Some amount of differences between defines when creating and using a PCH were intentionally allowed in

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 432974. mizvekov retitled this revision from "WIP" to "[clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy". mizvekov edited the summary of this revision. mizvekov added a comment.

[PATCH] D126671: cmake: fix clang standalone build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG93319128d0d4: cmake: fix clang standalone build (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9331912 - cmake: fix clang standalone build

Author: Matheus Izvekov Date: 2022-05-30T21:56:38+02:00 New Revision: 93319128d0d4eda22ce8d531ba668cb8c7c8c8e8 URL: https://github.com/llvm/llvm-project/commit/93319128d0d4eda22ce8d531ba668cb8c7c8c8e8 DIFF:

[PATCH] D126674: [clang] NFC: introduce test for D126620

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126674 Files:

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae added a comment. In D125052#3546205 , @thakis wrote: > Reverted in c4eb8035ed6647e58d4c5161f393e9220f7402cf > for now. Hi thakis, The issue could be fixed by

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld created this revision. Hahnfeld added a reviewer: sylvestre.ledru. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Hahnfeld requested

[PATCH] D126337: [pseudo] WIP: GSS node refcounting (dumb pointers)

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:118 +CheckRefcounts(); +for (const auto *Head : NewHeads) { AddSteps(Head, Terminal.symbol()); > The freelist works well (on AST.cpp, 35K nodes created but only 74

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3545937 , @Ericson2314 wrote: > There is a lot of cruft behind the signs. I would just use > `LLVM_TOOLS_INSTALL_DIR` then which is exported to get this unblocked, and > I'll rebase D117977

[PATCH] D126671: cmake: fix clang standalone build

mizvekov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D126308 broke building clang standalone, as

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

thakis added a comment. Reverted in c4eb8035ed6647e58d4c5161f393e9220f7402cf for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052

[clang] c4eb803 - Revert "[HLSL] Enable vector types for hlsl."

Author: Nico Weber Date: 2022-05-30T14:11:07-04:00 New Revision: c4eb8035ed6647e58d4c5161f393e9220f7402cf URL: https://github.com/llvm/llvm-project/commit/c4eb8035ed6647e58d4c5161f393e9220f7402cf DIFF: https://github.com/llvm/llvm-project/commit/c4eb8035ed6647e58d4c5161f393e9220f7402cf.diff

[PATCH] D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp

DanielMcIntosh-IBM added a comment. In D126669#3546172 , @MaskRay wrote: > This change is fine (if I were adding the tests in the first place, I'd add > -c or -S), but I'd like to understand why you have such a toolchain not > supporting linking. >

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126566/new/ https://reviews.llvm.org/D126566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. > setRoundingMode definitely should not call getAllowFEnvAccess() and it does > not Yes, it does? // C2x: 7.6.2p3 If the FE_DYNAMIC mode is specified and FENV_ACCESS is "off", // the translator may assume that the default rounding mode is in effect. if (FPR ==

[PATCH] D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp

MaskRay added a comment. This change is fine (if I were adding the tests in the first place, I'd add -c or -S), but I'd like to understand why you have such a toolchain not supporting linking. Such special requirements make me feel odd. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

DanielMcIntosh-IBM added inline comments. Comment at: clang/test/Driver/modules.cpp:79-86 +// RUN: %clang++ -fcxx-modules -std=c++17 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX17-MODULES +// CHECK-CXX17-MODULES: "-fcxx-modules" +// RUN: %clang++ -fcxx-modules

[PATCH] D126669: Remove dependence on linking support from clang/test/Driver/modules.cpp

DanielMcIntosh-IBM created this revision. DanielMcIntosh-IBM added reviewers: MaskRay, ChuanqiXu, iains, jansvoboda11, Bigcheese, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. DanielMcIntosh-IBM requested review of this revision. Herald added a project: clang. Herald

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3540780 , @aaron.ballman wrote: > In D120244#3540746 , @aaron.ballman > wrote: > >> I'll roll back the `#warning` use and report back when that's done. > > I've rolled it

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3defc23488e: [ODRHash][NFC] Add missing select case for `ODRMismatchDecl`. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES

[clang] f3defc2 - [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

Author: Volodymyr Sapsai Date: 2022-05-30T10:07:03-07:00 New Revision: f3defc23488eb29c69d2a33c0c5b652c874fb0f3 URL: https://github.com/llvm/llvm-project/commit/f3defc23488eb29c69d2a33c0c5b652c874fb0f3 DIFF:

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

thakis added a comment. Looks like this breaks tests on Mac/arm: http://45.33.8.238/macm1/36297/step_7.txt Please take a look and revert for now if it takes a while to fix. (Maybe the test just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

DanielMcIntosh-IBM added inline comments. Comment at: clang/test/Driver/modules.cpp:79-86 +// RUN: %clang++ -fcxx-modules -std=c++17 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX17-MODULES +// CHECK-CXX17-MODULES: "-fcxx-modules" +// RUN: %clang++ -fcxx-modules

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. In D126481#3545350 , @martong wrote: > This part of the SValBuilder is responsible for **constant folding**. We need > this constant

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently warns on definitions downgraded to declarations with a const modifier, but not for a constexpr

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 432947. python3kgae marked an inline comment as done. python3kgae added a comment. Code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe576280380d3: [HLSL] Enable vector types for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e576280 - [HLSL] Enable vector types for hlsl.

Author: Xiang Li Date: 2022-05-30T09:05:29-07:00 New Revision: e576280380d3f5221cfcc14e9fabeacc8506a43c URL: https://github.com/llvm/llvm-project/commit/e576280380d3f5221cfcc14e9fabeacc8506a43c DIFF: https://github.com/llvm/llvm-project/commit/e576280380d3f5221cfcc14e9fabeacc8506a43c.diff

[PATCH] D124918: [clang-tidy] Add a new check for non-trivial unused variables.

veluca93 marked 2 inline comments as done. veluca93 added a comment. @LegalizeAdulthood friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124918/new/ https://reviews.llvm.org/D124918 ___

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added a comment. There is a lot of cruft behind the signs. I would just use `LLVM_TOOLS_INSTALL_DIR` then which is exported to get this unblocked, and I'll rebase D117977 to try to clean these things up later. Repository: rG LLVM Github

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

svenvh created this revision. svenvh added reviewers: Anastasia, stuart. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. For newer OpenCL extensions

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 432930. balazske added a comment. applied the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files:

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 432929. balazske added a comment. added option to allow read-only of `errno` other small change in the test checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150

[PATCH] D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

jdenny added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126619/new/ https://reviews.llvm.org/D126619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e3cb737417: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d2e3cb7 - [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

Author: Joel E. Denny Date: 2022-05-30T11:02:20-04:00 New Revision: d2e3cb737417a2e5ffad34f666fa8510e88e8bc2 URL: https://github.com/llvm/llvm-project/commit/d2e3cb737417a2e5ffad34f666fa8510e88e8bc2 DIFF: https://github.com/llvm/llvm-project/commit/d2e3cb737417a2e5ffad34f666fa8510e88e8bc2.diff

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Please make sure to reflect in your commit message that you are adding the clang internal headers too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. From the current change it seems to me that what you need to be testing is a just that the frontend options are being passed correctly? This should then be a driver test with `-###` checking for the options to be set for the frontend invocation... Repository: rG

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2606 + if (getLangOpts().HLSL && TargetDecl) { +if (const FunctionDecl *FD = dyn_cast_or_null(TargetDecl)) + getHLSLRuntime().addHLSLFunctionAttributes(FuncAttrs, RetAttrs, FD);

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

hans added a comment. This didn't fix the mac/arm64 llvm builds for Chromium. I think it's because we don't set CMAKE_CROSSCOMPILING, so I'll try doing that as a work-around. (crbug.com/1330304). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

PRESIDENT810 created this revision. PRESIDENT810 added reviewers: klimek, arphaman, johannes. Herald added a project: All. PRESIDENT810 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes

[clang] be3fc66 - Revert "[clang][test] mark tests added in ee8524087c78 as unsupported on AIX"

Author: Jake Egan Date: 2022-05-30T09:35:26-04:00 New Revision: be3fc66f83b08a03ef3bc849ca3b37ff11e09199 URL: https://github.com/llvm/llvm-project/commit/be3fc66f83b08a03ef3bc849ca3b37ff11e09199 DIFF: https://github.com/llvm/llvm-project/commit/be3fc66f83b08a03ef3bc849ca3b37ff11e09199.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 432900. upsj marked an inline comment as done. upsj added a comment. Thanks Nathan, that was exactly it. I thought I looked at getTypePtr() directly, but I must have been mistaken. After a small fix (only adding inlay hints until the first unexpanded pack

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 432894. csigg added a comment. Fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen added a comment. This patch follows from some discussion on D124998 as well as the need for more bits to represent future function type attributes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen created this revision. sdesmalen added reviewers: aaron.ballman, erichkeane, efriedma. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The FunctionTypeExtraBitfields is currently only

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3545410 , @nikic wrote: > It looks like this change breaks the standalone build for clang. From what I > can see, while LLVM_TOOLS_BINARY_DIR and LLVM_TOOLS_INSTALL_DIR are exported > in

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson planned changes to this revision. royjacobson added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:1901 + for (auto* Decl : R) { +auto* DD = dyn_cast(Decl); +if (DD && DD->isEligibleOrSelected()) erichkeane wrote: > What cases happen

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 432881. csigg added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 432880. csigg added a comment. Herald added a subscriber: mgorny. Make fdiv rewrite an NVVM transform pass instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

nikic added a comment. It looks like this change breaks the standalone build for clang. From what I can see, while LLVM_TOOLS_BINARY_DIR and LLVM_TOOLS_INSTALL_DIR are exported in llvm/cmake/modules/LLVMConfig.cmake.in, LLVM_UTILS_INSTALL_DIR is not, resulting in an "install PROGRAMS given no

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. Still need to implement funcrefs support as function arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos updated this revision to Diff 432876. pmatos added a comment. Rebased the work on D126535 . Added support for funcrefs as return values. Still having problems with funcrefs as function arguments though. So, further work is required. Not ready for review.

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3542917 , @efriedma wrote: > I mean that ActOnPragmaFEnvAccess shouldn't call > hasRoundingModeOverride()/setRoundingModeOverride(), and setRoundingMode > shouldn't call getAllowFEnvAccess(). setRoundingMode

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong marked an inline comment as done. martong added a comment. In D126481#3542919 , @ASDenysPetrov wrote: > @martong As you said, my solution D103096 > suppose to pass these and more other tests cases. So how it

[clang] a5cf17f - [OpenCL] Expose wg collective functions for CL3 SPIR targets

Author: Sven van Haastregt Date: 2022-05-30T10:48:49+01:00 New Revision: a5cf17f8ae752f1b62b40b907bfee4faa3600b21 URL: https://github.com/llvm/llvm-project/commit/a5cf17f8ae752f1b62b40b907bfee4faa3600b21 DIFF:

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank you all for your comments and apologies for going radio silent - I was away for a few days. I've identified 2 threads emerging from your comments: **1. flang vs flang-new** @sscalpone, if I understand correctly, you are suggesting that any tool named `flang`

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 432871. csigg added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

[PATCH] D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files.

fakepaper56 added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126634/new/ https://reviews.llvm.org/D126634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

stasm added a comment. Herald added a project: All. I'm still interested in seeing this fixed. Would it help if I rebased this change and addressed the outstanding review comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116638/new/ https://reviews.llvm.org/D116638

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 updated this revision to Diff 432868. gamesh411 added a comment. Remove literal checking from the matcher for memset as well There is no change in the result set on open source projects even without restricting the matches to literals. IMO this is more in line with the rule as it's

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 ___ cfe-commits mailing

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 updated this revision to Diff 432866. gamesh411 added a comment. fix Release Notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186 Files:

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

mgabka added inline comments. Comment at: clang/test/CodeGen/aarch64-attr-mode-complex.c:11 +// CHECK: define{{.*}} { half, half } @c16_test([2 x half] noundef [[C16A:%.*]]) +// CHECK-NEXT: entry: +// CHECK-NEXT: [[C16B:%.*]] = extractvalue [2 x half] [[C16A]], 0

[PATCH] D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files.

khchen created this revision. khchen added a reviewer: kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D126633: [pseudo] Use the pseudoCXX library in fuzzer.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Get rid of the tedious grammar

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. In D124690#3542961 , @nridge wrote: > I would try using getPointeeTypeAsWritten() > > instead and see if that helps.

[clang-tools-extra] a5ddd4a - [pseudo] Remove an unnecessary nullable check diagnostic in the bnf

Author: Haojian Wu Date: 2022-05-30T09:04:47+02:00 New Revision: a5ddd4a23858044beb3c04ebc6b965760eb7c125 URL: https://github.com/llvm/llvm-project/commit/a5ddd4a23858044beb3c04ebc6b965760eb7c125 DIFF: https://github.com/llvm/llvm-project/commit/a5ddd4a23858044beb3c04ebc6b965760eb7c125.diff

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg added inline comments. Comment at: mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp:158 +// by the same divisor. +struct ExpandDivF16 : public ConvertOpToLLVMPattern { + using ConvertOpToLLVMPattern::ConvertOpToLLVMPattern; herhut wrote: > This

[clang] 738c20e - [NFC] Use %clang instead of %clang++ in tests

Author: Chuanqi Xu Date: 2022-05-30T14:38:46+08:00 New Revision: 738c20e6df01217b6364c3b75d0ced6b6fb6277e URL: https://github.com/llvm/llvm-project/commit/738c20e6df01217b6364c3b75d0ced6b6fb6277e DIFF: https://github.com/llvm/llvm-project/commit/738c20e6df01217b6364c3b75d0ced6b6fb6277e.diff

[clang] a544710 - [Driver] Enable to use C++20 standalne by -fcxx-modules

Author: Chuanqi Xu Date: 2022-05-30T14:19:56+08:00 New Revision: a544710cd43ba9f7729a613c58729f146e792a8e URL: https://github.com/llvm/llvm-project/commit/a544710cd43ba9f7729a613c58729f146e792a8e DIFF: https://github.com/llvm/llvm-project/commit/a544710cd43ba9f7729a613c58729f146e792a8e.diff