[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. Thanks for the ping. It's unfortunate that this didn't work out as intended. It's certainly fine though (for our purposes) to go back to the way things were before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ added a comment. Sounds great! I have a nitpick but other than that I think this fix is good to go. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3841 +/// matches if ObjCMessageExpr's callee declaration matches +/// It looks like

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some compiler provided type traits like __has_trivial_constructor have been documented as deprecated for quite

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 442431. kito-cheng added a comment. Changes: Restore the patch, I just accidentally updated wrong revision here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 442429. kito-cheng added a comment. Changes: - Less invasive way to fix this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files:

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:82-83 +if (Size <= Line.Level) + IndentForLevel.insert(IndentForLevel.end(), Line.Level - Size + 1, +UnknownIndent ? -1 : Indent); }

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

owenpan updated this revision to Diff 442427. owenpan added a comment. Use `resize()` instead of `insert()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129105/new/ https://reviews.llvm.org/D129105 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6532 + const Expr *XCE = ConceptX->getConstraintExpr(); + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl wihtout constraint expression?");

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 442425. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_differ.cpp

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. Given @rsmith and @iains is busy and this revision is relatively small, innocent and looks good to me, I plan to land this in Friday in case there is no further comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nathanchance added a comment. I ended up reducing something down anyways. At the parent commit of dc969061c68e62328607d68215ed8b9ef4a1e4b1 , there is no crash. _Bool fpsimd_context_busy; enum { false, true }

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442419. tingwang added a comment. Update according to comments: (1) Merged cleanupAssoc() into genAssocMeta(), and renamed genAssocMeta() to EmitAssociatedMetadata(). (2) Removed "-debug-info-kind=limited" from all test cases. Repository: rG LLVM Github

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +genAssocMeta(); shchenz wrote: > Seems this dos not follow other functions call's style. Can we call a >

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0880b9d52620: [Clang][unittests] Silence trucation warning with MSVC 2022 (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0880b9d - [Clang][unittests] Silence trucation warning with MSVC 2022

Author: Alexandre Ganea Date: 2022-07-05T20:31:54-04:00 New Revision: 0880b9d52620ca3c46456095f6040a2e4de6c871 URL: https://github.com/llvm/llvm-project/commit/0880b9d52620ca3c46456095f6040a2e4de6c871 DIFF:

[clang] 18f230a - [Clang] Silence warning when building with MSVC 2022

Author: Alexandre Ganea Date: 2022-07-05T20:31:54-04:00 New Revision: 18f230a89aa234ac58be4fb8cee2bfa95ea67be4 URL: https://github.com/llvm/llvm-project/commit/18f230a89aa234ac58be4fb8cee2bfa95ea67be4 DIFF:

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. It looks like my inline comment wasn't submitted (didn't click the submit button in the bottom). Here's my old comment. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) {

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

aganea added a comment. Thanks all for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 442416. daiyousei-qz marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG92edd74b37c7: Allow non-variadic functions to be attributed with `__attribute__((format))` (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 92edd74 - Allow non-variadic functions to be attributed with `__attribute__((format))`

Author: Félix Cloutier Date: 2022-07-05T17:26:11-07:00 New Revision: 92edd74b37c7a96b1d47dc67cda7f92b65066025 URL: https://github.com/llvm/llvm-project/commit/92edd74b37c7a96b1d47dc67cda7f92b65066025 DIFF:

[PATCH] D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM; thanks! The IBM OpenMP runtime sets the default thread stack size to 4MiB on AIX as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, daltenty, Jake-Egan, cebowleratibm. Herald added subscribers: ormris, arphaman, steven_wu, hiraditya, kristof.beyls. Herald added a project: All. hubert.reinterpretcast requested review of this

[clang] 9b1cf2e - Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (again).

Author: Lang Hames Date: 2022-07-05T15:20:08-07:00 New Revision: 9b1cf2e2b2a8ca2bc10894d569a653429b989dd0 URL: https://github.com/llvm/llvm-project/commit/9b1cf2e2b2a8ca2bc10894d569a653429b989dd0 DIFF: https://github.com/llvm/llvm-project/commit/9b1cf2e2b2a8ca2bc10894d569a653429b989dd0.diff

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf553287b5889: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++ (authored by anton-afanasyev). Changed prior to commit:

[clang] f553287 - [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

Author: Anton Afanasyev Date: 2022-07-06T00:52:26+03:00 New Revision: f553287b588916de09c66e3e32bf75e5060f967f URL: https://github.com/llvm/llvm-project/commit/f553287b588916de09c66e3e32bf75e5060f967f DIFF:

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

anton-afanasyev added a comment. In D129065#3631052 , @jrtc27 wrote: > Commit subject/body should say C++ in it Sure, updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129065/new/

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. In D128927#3622793 , @ldionne wrote: > @mstorsjo I might need some assistance figuring out what to do with the > Windows parts of this change. I can try to have a look in a couple days or so - I'm vacationing and have been

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. Posted an update in rGa6e63e35ede4 , which removes the not-fully-implemented RTTI bits, and adds an extra test case to cover instantiation errors. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108469: Improve handling of static assert messages.

tahonermann added a comment. Herald added a reviewer: NoQ. I missed my opportunity to review while being on vacation last week. I reviewed to keep myself informed; spotted a typo. Comment at: llvm/lib/Support/Unicode.cpp:272 +/// Unicode code points of the Cf category are

[clang] a6e63e3 - [NFC][HLSL] Add tests for vector alias. Remove dead code.

Author: Chris Bieneman Date: 2022-07-05T16:32:59-05:00 New Revision: a6e63e35ede4b9f23b58437263eaac9a2926c9bf URL: https://github.com/llvm/llvm-project/commit/a6e63e35ede4b9f23b58437263eaac9a2926c9bf DIFF:

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier updated this revision to Diff 442396. fcloutier added a comment. There was a merge conflict on the release notes, updating the differential to get a CI build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:62-70 while (IndentForLevel.size() <= Line.Level) IndentForLevel.push_back(-1); if (Line.InPPDirective) { unsigned IndentWidth = (Style.PPIndentWidth >= 0) ?

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

tstellar added a comment. I similar RFC for this was proposed here: https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:46 + assert(Begin > 0); + const Token = Tokens.tokens()[Begin - 1]; + if (const Token *Right = Left.pair())

[clang-tools-extra] 40af95d - [clang-tools-extra] Fix a link in ReleaseNotes.rst

Author: Dmitri Gribenko Date: 2022-07-05T23:09:55+02:00 New Revision: 40af95d80bcb526ec7b025eb677f64bfdd083e96 URL: https://github.com/llvm/llvm-project/commit/40af95d80bcb526ec7b025eb677f64bfdd083e96 DIFF:

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nathanchance added a comment. Should dc969061c68e62328607d68215ed8b9ef4a1e4b1 be reverted as well? I just bisected an assertion failure while building the Linux kernel for arm64 to that change: clang:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG05130a6ba7d9: new clang-tidy checker for assignments within condition clause of if statement (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 05130a6 - new clang-tidy checker for assignments within condition clause of if statement

Author: Dmitri Gribenko Date: 2022-07-05T23:04:12+02:00 New Revision: 05130a6ba7d9974136388c1fbe63125596325d2e URL: https://github.com/llvm/llvm-project/commit/05130a6ba7d9974136388c1fbe63125596325d2e DIFF:

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void,

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar created this revision. tstellar added reviewers: MaskRay, h-vetinari. Herald added subscribers: StephenFan, fedor.sergeev, mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

thieta accepted this revision. thieta added a comment. Thanks for switching to pragma! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 ___ cfe-commits mailing

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

tahonermann added a comment. Just stopping by to say, thank you @cor3ntin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128762/new/ https://reviews.llvm.org/D128762 ___ cfe-commits mailing list

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 marked an inline comment as not done. psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaCXX/attr-format.cpp:76 + format("bare string"); + format("%s", 123); // expected-warning{{format specifies type 'char *' but

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added inline comments. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are encouraged to ship the + experimental library now that the compiler provides an ergonomic way to use it. Mordante wrote:

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 442378. ldionne marked 2 inline comments as done. ldionne added a comment. Address review comments and try to fix some CI issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

aaron.ballman added a comment. Giving the posthumous review my LGTM so it's clear. :-) Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:41-44 + auto *UsingDecl = UsingDirectiveDecl::Create( + AST, AST.getTranslationUnitDecl(), SourceLocation(), SourceLocation(), +

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:82-83 +if (Size <= Line.Level) + IndentForLevel.insert(IndentForLevel.end(), Line.Level - Size + 1, +UnknownIndent ? -1 : Indent); }

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:62-70 while (IndentForLevel.size() <= Line.Level) IndentForLevel.push_back(-1); if (Line.InPPDirective) { unsigned IndentWidth =

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier added inline comments. Comment at: clang/test/SemaCXX/attr-format.cpp:76 + format("bare string"); + format("%s", 123); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}} + format("%s %s %u %d %i %p\n", "hello", s, 10u, x, y,

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier updated this revision to Diff 442373. fcloutier marked 2 inline comments as done. fcloutier added a comment. Address documentation comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/ https://reviews.llvm.org/D112579

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

arnamoy10 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain`

jrtc27 added a comment. Commit subject/body should say C++ in it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129065/new/ https://reviews.llvm.org/D129065 ___ cfe-commits mailing list

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please run clang-format, rebase and re-upload. It doesn't apply cleanly to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

Kai added a comment. Some more nits, otherwise LGTM. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11150 + +const uint64_t XORWord = 0x; // XORing with 0b111...111 will never + // result in the original

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

tahonermann added a comment. @jolanta.jensen, I was on vacation last week and missed my opportunity to comment on this. I know the change has already landed, but I added a few comments anyway. Comment at: clang/include/clang/Basic/TargetInfo.h:226-227 + unsigned

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG312116748890: [pseudo] Add error-recovery framework brace-based recovery (authored by sammccall).

[clang-tools-extra] 3121167 - [pseudo] Add error-recovery framework & brace-based recovery

Author: Sam McCall Date: 2022-07-05T20:49:41+02:00 New Revision: 31211674889095299eb817d7be034fde23f7b00a URL: https://github.com/llvm/llvm-project/commit/31211674889095299eb817d7be034fde23f7b00a DIFF: https://github.com/llvm/llvm-project/commit/31211674889095299eb817d7be034fde23f7b00a.diff

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:41-44 + auto *UsingDecl = UsingDirectiveDecl::Create( + AST, AST.getTranslationUnitDecl(), SourceLocation(), SourceLocation(), + NestedNameSpecifierLoc(), SourceLocation(),

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall marked 5 inline comments as done. sammccall added a comment. Thanks in particular for flagging the issue with duplicate forest nodes, you've found a hole in the model. That said, I've left a big FIXME and I think we should patch it later. Comment at:

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. @aganea Thank you for fixing this. `TestValues` structure impies to hold a set of values which can do some kind of convertions including truncations. This is what tests are

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442368. pscoro added a comment. removed commented code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added a comment. Hi @LegalizeAdulthood, @NoQ, @gribozavr2, @Eugene.Zelenko, Is there any further issue I should address for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

aganea updated this revision to Diff 442366. aganea added a comment. Use `#pragma` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 Files: clang/unittests/StaticAnalyzer/RangeSetTest.cpp Index:

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman added a comment. In D112579#3630647 , @fcloutier wrote: > I'm afraid that's also not possible: `D` is a `Decl`, so it doesn't have > `getType()`. `Decl` is the tightest-fitting superclass of `BlockDecl`, > `FunctionDecl` and

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442358. dodohand added a comment. somehow, clang-format needed to be re-run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

My plan is to do that for all papers once past plenary to keep consistency with cxx_status. On Tue, Jul 5, 2022 at 6:13 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added reviewers: tahonermann, clang-language-wg. > aaron.ballman added inline comments. > >

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

aaron.ballman added a comment. In D128012#3630680 , @beanz wrote: > @aaron.ballman, I just had a total brain-asleep moment, and pushed this > without realizing that I had feedback from you. Are you okay with me > addressing that most-commit or would

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 updated this revision to Diff 442356. jhuber6 added a comment. Addressing some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 Files: clang/test/Driver/linker-wrapper-image.c

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

thieta added a comment. Isn't it better to silence this warning with a pragma instead of disabling it for the whole file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152

[PATCH] D128923: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb1bf1b1761: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0bb1bf1 - [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

Author: Joseph Huber Date: 2022-07-05T13:43:51-04:00 New Revision: 0bb1bf1b1761a9070540df0ae0e51bc1bfb80ccd URL: https://github.com/llvm/llvm-project/commit/0bb1bf1b1761a9070540df0ae0e51bc1bfb80ccd DIFF: https://github.com/llvm/llvm-project/commit/0bb1bf1b1761a9070540df0ae0e51bc1bfb80ccd.diff

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

arsenm added inline comments. Comment at: clang/test/SemaOpenCL/builtins-amdgcn-error.cl:70 +{ + __builtin_amdgcn_sched_group_barrier(x, 0, 1); // expected-error {{argument to '__builtin_amdgcn_sched_group_barrier' must be a constant integer}} +} Test error

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

aganea created this revision. aganea added reviewers: ASDenysPetrov, thieta, hans. Herald added subscribers: steakhal, mgorny. Herald added a project: All. aganea requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm seeing the following

[PATCH] D128923: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128923/new/ https://reviews.llvm.org/D128923

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128850/new/ https://reviews.llvm.org/D128850 ___ cfe-commits mailing list

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

rui.zhang added a comment. I like the direction where this change is leading to and hope there is some way to land it incrementally. Since BuiltinType has the above mentioned concern on `void *`, how about we focus on `RecordType` pointers as a first step instead? Are there any pitfalls if we

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 442343. abidmalikwaterloo added a comment. Removed unrelated changes in CMakefile.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 Files:

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked 2 inline comments as done. Closed by commit rG2df120784af4: [analyzer] Fix assertion in simplifySymbolCast (authored by martong). Repository: rG LLVM

[clang] 2df1207 - [analyzer] Fix assertion in simplifySymbolCast

Author: Gabor Marton Date: 2022-07-05T19:00:23+02:00 New Revision: 2df120784af40c9cfebaf2a505a5ebe74c51b44a URL: https://github.com/llvm/llvm-project/commit/2df120784af40c9cfebaf2a505a5ebe74c51b44a DIFF: https://github.com/llvm/llvm-project/commit/2df120784af40c9cfebaf2a505a5ebe74c51b44a.diff

[PATCH] D128068: [analyzer] Do not emit redundant SymbolCasts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d7fa481cf4d: [analyzer] Do not emit redundant SymbolCasts (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5d7fa48 - [analyzer] Do not emit redundant SymbolCasts

Author: Gabor Marton Date: 2022-07-05T18:42:34+02:00 New Revision: 5d7fa481cf4d36e14345b1c3ebc951edda0b40b1 URL: https://github.com/llvm/llvm-project/commit/5d7fa481cf4d36e14345b1c3ebc951edda0b40b1 DIFF: https://github.com/llvm/llvm-project/commit/5d7fa481cf4d36e14345b1c3ebc951edda0b40b1.diff

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442340. dodohand added a comment. Updated to merge successfully into latest version of main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added a comment. Thanks! I'll commit this for you once you upload a refreshed patch (that applies to the main branch cleanly). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_basic_types.h:30 #ifdef __HLSL_ENABLE_16_BIT -typedef int16_t int16_t2 __attribute__((ext_vector_type(2))); -typedef int16_t int16_t3 __attribute__((ext_vector_type(3))); -typedef int16_t int16_t4

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @gribozavr2, I don't have commit access... I'll address the merge issue ASAP though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand marked 4 inline comments as done. dodohand added a comment. Addressed comments from gribozavr2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442338. dodohand added a comment. Addressing comments from @gribozavr2 identifying comments needing update/removal/improvement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. @aaron.ballman, I just had a total brain-asleep moment, and pushed this without realizing that I had feedback from you. Are you okay with me addressing that most-commit or would you prefer a revert? Huge apologies... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128068: [analyzer] Do not emit redundant SymbolCasts

martong added a comment. In D128068#3594171 , @steakhal wrote: >> We can't just do that check in `evalCast` because there are many additonal >> logic before we'd end up in `makeNonLoc`. > > I'm not exactly up to date. Could you please extend the summary

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier added a comment. I'm afraid that's also not possible: `D` is a `Decl`, so it doesn't have `getType()`. `Decl` is the tightest-fitting superclass of `BlockDecl`, `FunctionDecl` and `ObjCMethodDecl` (because `BlockDecl` is a direct subclass of it). One option could be to cast the

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-assignment-in-if-condition.cpp:84 + +// Add something that doesn't trigger the check here. +void awesome_f2(int arg) { CHANGES SINCE LAST ACTION

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8dbc6ffea93: [HLSL] Add ExternalSemaSource vector alias (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b8dbc6f - [HLSL] Add ExternalSemaSource & vector alias

Author: Chris Bieneman Date: 2022-07-05T11:30:29-05:00 New Revision: b8dbc6ffea93976dc0d8569c9d23e9c21e33e317 URL: https://github.com/llvm/llvm-project/commit/b8dbc6ffea93976dc0d8569c9d23e9c21e33e317 DIFF:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with a few minor edits. Do you have commit access? Comment at: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp:19-21 +void

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @alexfh , @aaron.ballman, Could one of you have a look at this? I'd like to get it moving toward resolution and don't know who else ought to do a review... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3630584 , @Codesbyusman wrote: > Yes I am looking into the DiagnosticParseKinds.td Excellent, thank you! In D129048#3630589 , @Codesbyusman wrote: > Yes I am looking

  1   2   3   >