[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. In D129832#3654066 , @MaskRay wrote: > In D129832#3654040 , @vitalybuka > wrote: > >> problem with included files that we don't know which non-inlined version of >> the function

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay added a comment. In D129832#3654040 , @vitalybuka wrote: > problem with included files that we don't know which non-inlined version of > the function will endup in the binary > so using this option, user may unintentionally disable

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D125291#3651640 , @nhaehnle wrote: > I can't judge the Clang changes. Now the clang part is moved to D129833 . > On the LLVM side, can you also

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu updated this revision to Diff 444880. ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. Address comments and remove verifier due to the automatic merging for constant expression I mentioned above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. problem with included files that we don't know which non-inlined version of the function will endup in the binary so using this option, user may unintentionally disable instrumentation on all included headers, even when included from a different place Repository:

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. Also -stdlib=libc++ is the default on OpenBSD and FreeBSD so you can probably leave that out and I think you can remove --gcc-toolchain="". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650590 , @3405691582 wrote: > As mentioned, this replicates https://reviews.llvm.org/D126289 for OpenBSD > which fixes #28283. That particular issue caused a build problem in Swift's > use of VFS in which I verified

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay created this revision. MaskRay added reviewers: Sanitizers, hctim, kstoimenov, vitalybuka. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a subscriber: teemperor. JDevlieghere added a comment. In D112374#3653702 , @mizvekov wrote: > @JDevlieghere I spent a lot of time trying to get this test running on my > machine to no avail. I think lldb build and test setup is quite

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chapuni added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index == FDSz && It causes a

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3653895 , @jrtc27 wrote: > Does GCC allow this or not? Because this strikes me as a bad idea at first > sight… GCC can deduce from -mcpu but not -mabi. > riscv64-unknown-linux-gnu-gcc a.c -mabi=ilp32 > cc1: error:

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3651771 , @erichkeane wrote: > I guess I don't have a good idea why this attribute would cause ODR issues? > It would seem that if it appeared in 2 different TUs that we could just > 'pick' whichever we wanted,

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

jrtc27 added a comment. Does GCC allow this or not? Because this strikes me as a bad idea at first sight… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___

[PATCH] D54214: [RISCV] Set triple based on -march flag

zixuan-wu added a comment. Herald added subscribers: sunshaoce, pcwang-thead, eopXD, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, MaskRay, arichardson. Herald added a project: All. In D54214#1737255 , @simoncook wrote: >

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu created this revision. zixuan-wu added reviewers: simoncook, lenary, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c51f02effdb: [clang] Implement ElaboratedType sugaring for types written bare (authored by mizvekov). Changed prior to

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

jackhong12 accepted this revision. jackhong12 added a comment. I think we can also add new test cases in `clang/unittests/Format/TokenAnnotatorTest.cpp`. Tokens = annotate("int i = int{42} * 34;"); ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ychen added inline comments. Comment at: llvm/docs/LangRef.rst:24541 + + declare ptr @llvm.threadlocal.address(ptr) nounwind readnone willreturn + Like @jyknight already did, any idea what it would take to change the parameter type from pointer to token?

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. In D112374#3651218 , @mizvekov wrote: > Can you confirm that this `NoPrincipalGetURI` matcher would, in clang version > without this patch here, fail to match if you had rewritten the `GetUri` > method to use a qualified name?

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere I spent a lot of time trying to get this test running on my machine to no avail. I think lldb build and test setup is quite convoluted, fragile and antiquated. It uses many deprecated CMake features, It fails to properly link to system libraries it needs

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444844. vangthao added a comment. Change `auto &` to `auto Argument`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files:

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar updated this revision to Diff 444843. tstellar added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 Files: clang/docs/ReleaseNotes.rst

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

dblaikie added a comment. In D125693#3648942 , @krisb wrote: > In D125693#3644029 , @dblaikie > wrote: > >> In D125693#3641742 , @krisb wrote: >> >>> @dblaikie, could

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444834. python3kgae added a comment. Remove DXCJoinedOrSeparateConflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444830. python3kgae marked an inline comment as done. python3kgae added a comment. Merge change from Chris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG80dec2ecfffe: [Clang] Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 80dec2e - [Clang] Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

Author: Shafik Yaghmour Date: 2022-07-14T16:09:52-07:00 New Revision: 80dec2ecfffe30f86ecfeec8f553b16bb992c48b URL: https://github.com/llvm/llvm-project/commit/80dec2ecfffe30f86ecfeec8f553b16bb992c48b DIFF:

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

efriedma added a comment. `atomicrmw add [...] sync_seq_cst` is supposed to be equivalent to `fence seq_cst; atomicrmw add seq_cst; fence seq_cst`, I think. The extra fences aren't necessary for most uses of `__sync_*`, but the difference is theoretically visible for exotic synchronization

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. This change works and avoids the duplicated group. The duplicated group results in the help spew duplicating the group heading, which is undesirable. diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 444173. royjacobson added a comment. royjacobson updated this revision to Diff 19. royjacobson retitled this revision from "[WIP][Clang] Implement P0848 (Conditionally Trivial Special

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1207 + auto EmitResourceUsageRemark = [&](StringRef RemarkName, + StringRef RemarkLabel, auto &) { +// Add an indent for every line besides the

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 444820. njames93 added a comment. More code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706 Files: clang-tools-extra/clang-tidy/GlobList.cpp

[PATCH] D129742: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ab7307177c3: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

jyknight added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65697 is the relevant discussion thread that added these to GCC. I personally never found it very convincing, even back in 2015 when they first made the change. And, now, 7 years later, I'd be even more reluctant to add

[clang] 6ab7307 - [clang-format] Fix invalid-code-generation by RemoveBracesLLVM

Author: owenca Date: 2022-07-14T15:19:57-07:00 New Revision: 6ab7307177c336d7ca5910fc434c012f35245fd1 URL: https://github.com/llvm/llvm-project/commit/6ab7307177c336d7ca5910fc434c012f35245fd1 DIFF: https://github.com/llvm/llvm-project/commit/6ab7307177c336d7ca5910fc434c012f35245fd1.diff LOG:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, beanz wrote: > Do we need this group

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, Do we need this group or can it just be `cl_Group`? Repository: rG LLVM Github

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444803. python3kgae marked an inline comment as done. python3kgae added a comment. Add CLDXCOption flag and share option with CL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb032e3ff6121: [analyzer] Evaluate construction of non-POD type arrays (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository:

[clang] b032e3f - [analyzer] Evaluate construction of non-POD type arrays

Author: isuckatcs Date: 2022-07-14T23:30:21+02:00 New Revision: b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2 URL: https://github.com/llvm/llvm-project/commit/b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2 DIFF: https://github.com/llvm/llvm-project/commit/b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2.diff

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3653216 , @ckissane wrote: > In D128465#3653051 , @jasonmolenda > wrote: > >> In D128465#3652525 , @ckissane >> wrote: >> >>>

[PATCH] D129048: Rewording the "static_assert" to static assertion

ldionne added a comment. Most of the libc++ CI testing happens on BuildKite, and we only trigger the libc++ buildkite pipeline if files in `libcxx/` (and a few others) have changed. This wasn't the case here. If you want to re-land without breaking libc++, you'd have to go through libc++'s

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3653051 , @jasonmolenda wrote: > In D128465#3652525 , @ckissane > wrote: > >> In D128465#3651025 , @aemerson >> wrote: >> >>> I

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

jrtc27 added a comment. I can't obviously see a description of what the additional barriers implied by the sync variants is (which should be in an update to LangRef at the very least, if not also in the summary itself). Inferring it from the AArch64 assembly is also difficult, and the RISC-V

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

tahonermann added a comment. >> Additionally, the type of a character constant in C is int. > > This means that char32_t c4 = U'\U00064321'; is invalid in C No. A character constant that does not have an encoding prefix has type `int` in C. Character constants that have an encoding prefix have

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad updated this revision to Diff 444791. brad added a comment. Disable -pie when using -r. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 Files: clang/lib/Driver/ToolChains/Ananas.cpp

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dbfc4fc065d: [clang] Document -femit-compact-unwind option in the User’s Manual (authored by int3). Changed prior to commit:

[clang] 7dbfc4f - [clang] Document -femit-compact-unwind option in the User’s Manual

Author: Jez Ng Date: 2022-07-14T16:50:36-04:00 New Revision: 7dbfc4fc065d7f1bd85988351399c7fd2db1ec53 URL: https://github.com/llvm/llvm-project/commit/7dbfc4fc065d7f1bd85988351399c7fd2db1ec53 DIFF: https://github.com/llvm/llvm-project/commit/7dbfc4fc065d7f1bd85988351399c7fd2db1ec53.diff LOG:

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Looks very promising. Comment at: clang/include/clang/Format/Format.h:396 + /// \version 15 + RequiresExpressionIndentationKind RequiresExpressionIndentation; + Please resort. Comment at:

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 444787. vsapsai added a comment. Rebase and unhoist `ComputeTemplateParameterListODRHash`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files:

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 444786. njames93 added a comment. Added functionality for Checking equivalence to a StringRef without having to build the Glob. These features are ground work for upcoming patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. I did verify that `-fvisibility=hidden` still devirtualizes, and same with `-Wl,--lto-whole-program-visibility`, but not if both are missing Comment at: llvm/lib/LTO/LTOBackend.cpp:595 + updatePublicTypeTestCalls(Mod,

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. As the name of the tool becomes somewhat public and stable at this point, feel free to suggest shorter/neater names in D129798 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project:

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added projects: LLVM,

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project:

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3652525 , @ckissane wrote: > In D128465#3651025 , @aemerson > wrote: > >> I just reverted this in 6e6be5f9504d >>

[clang] a629ec2 - [test] Fix D129789 for 32bit platforms

Author: Vitaly Buka Date: 2022-07-14T12:44:15-07:00 New Revision: a629ec2f47a64b1a5b33dbcedf1efc6989f97641 URL: https://github.com/llvm/llvm-project/commit/a629ec2f47a64b1a5b33dbcedf1efc6989f97641 DIFF: https://github.com/llvm/llvm-project/commit/a629ec2f47a64b1a5b33dbcedf1efc6989f97641.diff

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1207 + auto EmitResourceUsageRemark = [&](StringRef RemarkName, + StringRef RemarkLabel, auto &) { +// Add an indent for every line besides the line

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444765. usaxena95 added a comment. Removed changes from previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 444764. vaibhav.y added a comment. Gate death tests on `NDEBUG` and available of `GTEST_HAS_DEATH_TEST` This should fix recent pre-merge failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444761. cassanova edited the summary of this revision. cassanova added a comment. Removed the cxx_proto.proto file since we include the headers that it generates from the clang side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova marked an inline comment as done. cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// JDevlieghere wrote: >

[PATCH] D129594: [InstrProf] Add options to profile function groups

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://reviews.llvm.org/D129594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444759. vangthao added a comment. Change "Kernel Name" to "Function Name" and rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files:

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">,

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/UsersManual.rst:853 + * ``no-compact-unwind`` - Only emit DWARF unwind when compact unwind encodings +aren't available. This is the

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444755. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 ___ cfe-commits mailing list

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444753. ldionne added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne marked an inline comment as done. ldionne added a comment. In D121141#3652616 , @MaskRay wrote: > LGTM. > > It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC > and may have opinions on the option name. Interesting!

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

ASDenysPetrov updated this revision to Diff 444752. ASDenysPetrov added a comment. Fixed a typo that caused `constraint_manager_negate.c` and `unary-sym-expr.c` tests crashes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129678/new/ https://reviews.llvm.org/D129678 Files:

[PATCH] D129594: [InstrProf] Add options to profile function groups

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf58684f2720: [InstrProf] Add options to profile function groups (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/

[clang] af58684 - [InstrProf] Add options to profile function groups

Author: Ellis Hoag Date: 2022-07-14T11:41:30-07:00 New Revision: af58684f272046f293a9f469f03d23bd2b138349 URL: https://github.com/llvm/llvm-project/commit/af58684f272046f293a9f469f03d23bd2b138349 DIFF: https://github.com/llvm/llvm-project/commit/af58684f272046f293a9f469f03d23bd2b138349.diff

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. @aemerson can you let me know if https://reviews.llvm.org/D129786 works on MacOS? I am continuing work on that revision because this one has a lot of outdated unrelated history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. @aaron.ballman The culprit turned out to be the difference in release flags on the build server vs my environment. I had unfortunately run the configuration command once in `Debug` mode, and hadn't re-configured. Not a bright moment :) The `ASSERT_DEATH` tests that

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140bfdca60ae: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[clang] 140bfdc - [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

Author: Nick Desaulniers Date: 2022-07-14T11:25:24-07:00 New Revision: 140bfdca60ae8b1b2ad115846379e3c9ca914bfb URL: https://github.com/llvm/llvm-project/commit/140bfdca60ae8b1b2ad115846379e3c9ca914bfb DIFF:

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN:

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

shafik updated this revision to Diff 444744. shafik added a comment. Adding release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129591/new/ https://reviews.llvm.org/D129591 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444743. nickdesaulniers added a comment. - resort langref, oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added a comment. Thanks for the review! Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444742. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - rename md idententifier, sort langref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

int3 updated this revision to Diff 444740. int3 retitled this revision from "[clang] Document -femit-compact-unwind flag in the User’s Manual" to "[clang] Document -femit-compact-unwind option in the User’s Manual". int3 added a comment. option Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3652739 , @hctim wrote: > In D129048#3652689 , @aaron.ballman > wrote: > >> In D129048#3652679 , @hctim wrote: >> >>> Looks

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. In D129048#3652689 , @aaron.ballman wrote: > In D129048#3652679 , @hctim wrote: > >> Looks like unfortunately this breaks all lots of libcxx tests - which were >> picked up by our

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2e01bdcc214: [test][CodeGen] Dont miss lifetime markers in lifetime tests (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[clang] a2e01bd - [test][CodeGen] Don't miss lifetime markers in lifetime tests

Author: Vitaly Buka Date: 2022-07-14T11:14:07-07:00 New Revision: a2e01bdcc21429d92cd785053f7cc9f72f1d212a URL: https://github.com/llvm/llvm-project/commit/a2e01bdcc21429d92cd785053f7cc9f72f1d212a DIFF: https://github.com/llvm/llvm-project/commit/a2e01bdcc21429d92cd785053f7cc9f72f1d212a.diff

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444737. vitalybuka added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:848 + + When to emit DWARF unwind (EH frame) info. This is a Mach-O-specific flag. + I think flag applies to these boolean options. This is an option, not a flag. Repository: rG LLVM

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(, 1); vitalybuka wrote: > StephenFan wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > > > Please check for lifetime markers, I assume case 2

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444735. vitalybuka added a comment. remove debug changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3652679 , @hctim wrote: > Looks like unfortunately this breaks all lots of libcxx tests - which were > picked up by our sanitizer buildbots: Thanks for letting us know. Do you happen to know if there's any

[clang] 041d401 - Revert "Rewording "static_assert" diagnostics"

Author: Mitch Phillips Date: 2022-07-14T10:59:20-07:00 New Revision: 041d4012e4c0898bb4e31ffb75655d8163e3ee89 URL: https://github.com/llvm/llvm-project/commit/041d4012e4c0898bb4e31ffb75655d8163e3ee89 DIFF:

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. Looks like unfortunately this breaks all lots of libcxx tests - which were picked up by our sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/85/builds/9157 Should be reproducible with just `cmake -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" && make check-cxx`.

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

MaskRay added a comment. `-r -pie` feels like an error to me. `gcc -dumpspecs` uses `%{static|shared|r:;!no-pie:-pie}`, which means `-r` overrides `-pie`. Either match the behavior if report an error. If reporting an error adds too much complexity, just match the behavior. We just shouldn't let

  1   2   3   >