[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. I've added a C++20 Named Modules tests for this (and some trivial change) in D130614 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu created this revision. ChuanqiXu added a reviewer: ilya-biryukov. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found this one when I try to add a C++20 Modules example for D130585

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. Ping @serge-sans-paille @sammccall - does this seem reasonable, and would you like to tweak the name of the tool before cementing it into a public cmake option (that at least I would be setting while cross compiling)? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129311: [clang-format] Update return code

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks for the explanations! LGTM. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M',

[PATCH] D130600: [clang][dataflow] Handle return statements

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:338-339 +if (Loc == nullptr) { + // The outermost context does not set a storage location for `return`, so + // in that case we just ignore `return` statements. + return;

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447928. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clangd/Protocol.cpp

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:232 +while (T != Tokens.end() && T->Kind == tok::comment && + LastComment->Line == T->Line + 1) { + LastComment = T; hokein wrote: > this seems

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447926. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files:

[clang] 1f8ae9d - Inline function calls.

Author: Weverything Date: 2022-07-26T21:12:28-07:00 New Revision: 1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb URL: https://github.com/llvm/llvm-project/commit/1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb DIFF: https://github.com/llvm/llvm-project/commit/1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb.diff

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ChuanqiXu added a comment. In D130585#3680189 , @ilya-biryukov wrote: > I wonder whether the right fix for this should generalize to `Mergeable`. > The fact that `Mergeable::getFirstDecl` checks if the decl is coming from the > AST file before looking

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

zixuan-wu added inline comments. Herald added subscribers: pcwang-thead, luke957, StephenFan, MaskRay, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbaf681b0f1: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX (authored by lkail). Repository: rG LLVM Github Monorepo

[clang] 1cbaf68 - [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

Author: Kai Luo Date: 2022-07-27T01:56:25Z New Revision: 1cbaf681b0f1e7257e7e2a63d290a20216668f17 URL: https://github.com/llvm/llvm-project/commit/1cbaf681b0f1e7257e7e2a63d290a20216668f17 DIFF: https://github.com/llvm/llvm-project/commit/1cbaf681b0f1e7257e7e2a63d290a20216668f17.diff LOG:

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

vsapsai added a comment. In D128695#3675112 , @ChuanqiXu wrote: > I see. It looks like the tricks in `.git-blame-ignore-revs` doesn't work for > this kind of move. I admit I don't look these changes in details. But as long > as it is helpful for future

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep added a comment. In D130593#3681126 , @xazax.hun wrote: > While separate call strings are properly isolated from each other, repeated > analysis of the same call is not:| > > while (...) > { > foo(...); > } > > In the above code

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:110 + /// Assigns `Loc` as the storage location of `return`. + /// gribozavr2 wrote: > Done. Comment at:

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 447906. samestep added a comment. Address Dmitri's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files:

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10797 +Out< ssquare08 wrote: > > jhuber6 wrote: > > > `CGM.printPostfixForExternalizedDecl` should ideally give the same output > > > on the host and device, but it's somewhat limited

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/test/OpenMP/declare_target_only_one_side_compilation.cpp:61 // DEVICE-DAG: @G1 = {{.*}}global i32 0, align 4 -// DEVICE-DAG: @_ZL2G2 = internal {{.*}}global i32 0, align 4 +// DEVICE-DAG: @_ZL2G2 = {{.*}}global i32 0, align 4

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added a comment. In D130306#3680942 , @chapuni wrote: > A few variables cause warinings in -Asserts. Thanks for pointing this out! How should I address this? Should I just inline the definitions of those variables into the `assert`s

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 updated this revision to Diff 447901. ssquare08 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Adding a test and fixing This adds a new runtime test and also address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. OK. Now I've reverted mostly to the old indentation, preserving some of the quirks. Hope it is easier to review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447899. vsapsai added a comment. - Revert indentation for the second and subsequent lines in lambda-now-method calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added a comment. In D121997#3676972 , @alanphipps wrote: > Should there be an aarch64 guard on the test? There exist downstream Arm > compilers that don't support Arm64 and fail. I know other tests explicitly > state "REQUIRES:

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 447894. lamb-j added a comment. Updating driver cmake to correctly build shared library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files:

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447892. vsapsai added a comment. - Replicate some creative old indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files:

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 447890. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay added inline comments. Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18-19 + +; CHECK-NOT: (csect: .data) +; CHECK: g O .data {{.*}} var + hubert.reinterpretcast wrote: > Unfortunately (without the change)

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447882. vsapsai added a comment. - Who could have suspected that some lambdas were double-indented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

hubert.reinterpretcast added a comment. With respect to the compiler changes: they look good. I checked, and the injected options being passed to the linker are added before user-specified ones (and that is good). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

hubert.reinterpretcast added a comment. Tests require fixing. Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18-19 + +; CHECK-NOT: (csect: .data) +; CHECK: g O .data {{.*}} var + Unfortunately (without the change)

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

dblaikie added a comment. > During a build on Debian 11/sparc64, several binaries fail to link with > > /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x23 What's the linker doing parsing DWARF? Any idea what feature this is? And why is it SPARC-specific? Or is it

[PATCH] D130593: [clang][dataflow] Separate context by frame

xazax.hun added a comment. While separate call strings are properly isolated from each other, repeated analysis of the same call is not:| while (...) { foo(...); } In the above code snippet, we will end up analyzing foo with leftover state from the previous iteration. The analysis

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 447854. ziqingluo-90 added a comment. The `callee` ASTMatcher overloading patch has landed in LLVM repo. I update this patch to use `callee` for matching objective-C message callee methods. CHANGES SINCE LAST ACTION

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

chapuni added a comment. A few variables cause warinings in -Asserts. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:216 + assert(FuncDecl != nullptr); + const auto *Body = FuncDecl->getBody(); + assert(Body != nullptr); It is used

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic marked 2 inline comments as done. jpenix-quic added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:52 +options::OPT_fno_automatic, +options::OPT_fconvert_EQ}); } awarzynski

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:168 +bool guardPreviousTokenNotIdentifier(const GuardParams ) { + if (P.LookaheadIndex < 2) +return

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 447838. jpenix-quic added a comment. Added changes to address feedback about missing braces and where I am adding options::OPT_fconvert_EQ (and removing the extra formatting change). Also removes an unnecessary include I had mistakenly added. CHANGES

[PATCH] D130600: [clang][dataflow] Handle return statements

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:110 + /// Assigns `Loc` as the storage location of `return`. + /// Comment at:

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D130593

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

jrbyrnes added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128158/new/ https://reviews.llvm.org/D128158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); dgoldman wrote: > sammccall wrote: > > kadircet wrote: > > > let's just pass

[PATCH] D130516: [Support] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004 // consumers will not want its contents. + llvm::compression::CompressionAlgorithm CompressionScheme = + llvm::compression::ZlibCompressionAlgorithm(); +

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

akyrtzi added a comment. In D130443#3680753 , @thakis wrote: > Looks like this doesn't build: http://45.33.8.238/linux/82380/step_4.txt Sorry about that, fixed here: https://github.com/llvm/llvm-project/commit/c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 447825. shafik marked an inline comment as done. shafik added a comment. - Changed wording for diagnostic and updated the places where it was used and checked in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

thakis added a comment. Looks like this doesn't build: http://45.33.8.238/linux/82380/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130443/new/ https://reviews.llvm.org/D130443 ___

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dfaecc4c244: [CGDebugInfo] Access the current working directory from the `VFS` (authored by akyrtzi). Repository: rG LLVM Github Monorepo

[clang] 8dfaecc - [CGDebugInfo] Access the current working directory from the `VFS`

Author: Argyrios Kyrtzidis Date: 2022-07-26T13:48:39-07:00 New Revision: 8dfaecc4c24494337933aff9d9166486ca0949f1 URL: https://github.com/llvm/llvm-project/commit/8dfaecc4c24494337933aff9d9166486ca0949f1 DIFF:

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. In D128490#3670543 , @ChuanqiXu wrote: > For these indentation changes, maybe it is a good idea to edit the > `.git-blame-ignore-revs` files in the root path. That is a good idea. I'm thinking about a different option: I make

[clang-tools-extra] 0734c02 - [clang-tidy] Avoid extra parentheses around MemberExpr

Author: Danny Mösch Date: 2022-07-26T22:36:00+02:00 New Revision: 0734c02b34e49568d278dce7ca4b818fc465853d URL: https://github.com/llvm/llvm-project/commit/0734c02b34e49568d278dce7ca4b818fc465853d DIFF: https://github.com/llvm/llvm-project/commit/0734c02b34e49568d278dce7ca4b818fc465853d.diff

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG0734c02b34e4: [clang-tidy] Avoid extra parentheses around MemberExpr (authored by SimplyDanny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Thanks @stella.stamenova for looking into this. I agree the `extend_path` should go back so it properly becomes the install dir. I can't think why I removed it in the first place! The point was to not export the other var, and indeed having that one properly

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein added a comment. In D130511#3679161 , @sammccall wrote: > TL;DR: I suspect this is valid but guarding `nested-name-specifier := :: > [guard=PrevNotIdentifier]` may be equivalent and clearer. Yeah, that's better! Repository: rG LLVM Github

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein updated this revision to Diff 447815. hokein added a comment. refine the patch: guard the "::" nested-name-specifier rule instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130511/new/ https://reviews.llvm.org/D130511 Files:

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

HazardyKnusperkeks added a comment. In D126845#3675721 , @sstwcw wrote: > Are there any problems with this revision? The ones that depend on it are > approved. Sorry, last time you updated I had no time, and then I forgot. Repository: rG LLVM

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447813. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. In D117977#3680655 , @stella.stamenova wrote: > This change broke the `LLVMConfig` generation and now when including `llvm` > through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no > longer have

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. This change broke the `LLVMConfig` generation and now when including `llvm` through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no longer have the correct paths. For example, before this change: set(LLVM_TOOLS_BINARY_DIR

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep updated this revision to Diff 447808. samestep added a comment. Use operator[] instead of try_emplace for C++14 compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm.org/D130593 Files:

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

MaskRay added a comment. This needs a test. For now you can use `linux-ld.c` which has some sparc tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130569/new/ https://reviews.llvm.org/D130569 ___

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ https://reviews.llvm.org/D129596

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:634 + // LLVM support for atomics on 32-bit SPARC V8+ is incomplete, so + // forcibly link with libatomic as a workaround. `// TODO ...` and attach a bug link

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 447803. vsapsai added a comment. Use `diagnoseSubMismatchMethodParameters` both for Obj-C and C++ methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130325/new/ https://reviews.llvm.org/D130325 Files:

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

SimplyDanny added a comment. alexfh, aaron.ballman, njames93, LegalizeAdulthood Could anyone give some feedback, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ https://reviews.llvm.org/D129596

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson added a comment. In D128750#3663161 , @ychen wrote: > In D128750#3662898 , @royjacobson > wrote: > >> but in your example with T/U/V we have 3 template parameters that we could >> reorder in 6

[PATCH] D129211: [Clang][Doc] Update the release note for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG114df244ec50: [Clang][Doc] Update the release note for clang (authored by tianshilei1992). Changed prior to commit:

[clang] 114df24 - [Clang][Doc] Update the release note for clang

Author: Shilei Tian Date: 2022-07-26T15:39:21-04:00 New Revision: 114df244ec50ce0145702974335965c3aa2c3dcc URL: https://github.com/llvm/llvm-project/commit/114df244ec50ce0145702974335965c3aa2c3dcc DIFF: https://github.com/llvm/llvm-project/commit/114df244ec50ce0145702974335965c3aa2c3dcc.diff

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:370 +def note_constexpr_unscoped_enum_out_of_range : Note< + "store of value outside of the range of unscoped enum, valid values %0 to %1">; def

[PATCH] D129211: [Clang][Doc] Update the release note for clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129211/new/ https://reviews.llvm.org/D129211

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94f6653150: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads (authored by SimplyDanny). Changed prior to commit:

[clang-tools-extra] 4e94f66 - [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

Author: Danny Mösch Date: 2022-07-26T21:22:18+02:00 New Revision: 4e94f6653150511de434fa7e29b684ae7f0e52b6 URL: https://github.com/llvm/llvm-project/commit/4e94f6653150511de434fa7e29b684ae7f0e52b6 DIFF: https://github.com/llvm/llvm-project/commit/4e94f6653150511de434fa7e29b684ae7f0e52b6.diff

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 3 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:201 if opts.diff: -print_diff(old_tree, new_tree) - elif opts.diffstat: -print_diffstat(old_tree, new_tree) - else: -

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

nemanjai added a comment. In D129855#3667191 , @MaskRay wrote: > In D129855#3662457 , @quinnp wrote: > >> In D129855#3657006 , @MaskRay >> wrote: >> >>> This is not

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 447785. shafik marked 3 inline comments as done. shafik added a comment. - Added documentation for `getValueRange(...)` - Added new tests to cover fix introduced by D130301 CHANGES SINCE LAST ACTION

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. Awesome! Thanks Daniel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130583/new/ https://reviews.llvm.org/D130583

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM. Thanks Daniel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130581/new/ https://reviews.llvm.org/D130581

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4638d7a - Revert "[clang-offload-bundler] Library-ize ClangOffloadBundler"

Author: Lambert, Jacob Date: 2022-07-26T11:22:31-07:00 New Revision: 4638d7a28f62d2869a7394b009439a72c04c5b72 URL: https://github.com/llvm/llvm-project/commit/4638d7a28f62d2869a7394b009439a72c04c5b72 DIFF:

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); sammccall wrote: > kadircet wrote: > > let's just pass the TUPath from

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447771. dgoldman marked 5 inline comments as done. dgoldman added a comment. Minor fixes for review (some still pending based on discussion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/

[PATCH] D130591: [pseudo] Use the TokenIndex for the lookahead in GuardParams

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:970-980 +if (LHSExpr->EvaluateAsInt(IntExprResult, *Context)) { + // Evaluating value. + BoolExpr = RHSExpr; +} +else if

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think this patch is in a good state. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule {

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG300fbf56f89a: [clang][dataflow] Analyze calls to in-TU functions (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 300fbf5 - [clang][dataflow] Analyze calls to in-TU functions

Author: Sam Estep Date: 2022-07-26T17:54:27Z New Revision: 300fbf56f89aebbe2ef9ed490066bab23e5356d1 URL: https://github.com/llvm/llvm-project/commit/300fbf56f89aebbe2ef9ed490066bab23e5356d1 DIFF: https://github.com/llvm/llvm-project/commit/300fbf56f89aebbe2ef9ed490066bab23e5356d1.diff LOG:

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 447758. samestep added a comment. Use different name for TransferOptions field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files:

[PATCH] D130493: Disable stack-sizes section by default for PS4.

MaggieYi updated this revision to Diff 447756. MaggieYi added a comment. Use `Args.addOptInFlag` instead of `Args.hasFlag`, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130493/new/ https://reviews.llvm.org/D130493 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 447757. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere, ormris. Forgot to define `CLANG_INSTALL_LIBDIR_BASENAME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] cc9aa15 - Revert "[clang][dataflow] Analyze calls to in-TU functions"

Author: Sam Estep Date: 2022-07-26T17:30:09Z New Revision: cc9aa157a83a4da52f9749807429205583d815da URL: https://github.com/llvm/llvm-project/commit/cc9aa157a83a4da52f9749807429205583d815da DIFF: https://github.com/llvm/llvm-project/commit/cc9aa157a83a4da52f9749807429205583d815da.diff LOG:

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa2b83d07eca: [clang][dataflow] Analyze calls to in-TU functions (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fa2b83d - [clang][dataflow] Analyze calls to in-TU functions

Author: Sam Estep Date: 2022-07-26T17:27:19Z New Revision: fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317 URL: https://github.com/llvm/llvm-project/commit/fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317 DIFF: https://github.com/llvm/llvm-project/commit/fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317.diff LOG:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, compnerd, phosek. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov added a comment. I wonder whether the right fix for this should generalize to `Mergeable`. The fact that `Mergeable::getFirstDecl` checks if the decl is coming from the AST file before looking up its primary merged decl is probably a performance optimization, not a deliberate

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

hiraditya added a comment. Thanks for clarifying! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130374/new/ https://reviews.llvm.org/D130374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 447750. samestep added a comment. Be explicit when constructing TransferOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files:

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a subscriber: Michael137. aprantl added a comment. Sorry for the silence — I was out on vacation. @Michael137 has recently started looking into improving support for C++ lambdas in LLDB. Michael, would you be interested in taking a fresh look at this and figure out what the

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Otherwise we get invalid results for ODR checks. See changed test for an example: despite the fact that we

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8348c4095600: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8348c40 - [clang-offload-bundler] Library-ize ClangOffloadBundler

Author: Jacob Lambert Date: 2022-07-26T10:05:22-07:00 New Revision: 8348c4095600ec2c0beee293267832799d2ebee3 URL: https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3 DIFF: https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3.diff

  1   2   3   >