[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we run into a first usage or definition of a mangled name, and there's a

[clang] 3da1395 - [CodeGen][NFC] Use isa_and_nonnull instead of explicit check

Author: Jun Zhang Date: 2022-07-31T13:03:24+08:00 New Revision: 3da13953834eb31b41949e92886f6fb7f3fd63fc URL: https://github.com/llvm/llvm-project/commit/3da13953834eb31b41949e92886f6fb7f3fd63fc DIFF: https://github.com/llvm/llvm-project/commit/3da13953834eb31b41949e92886f6fb7f3fd63fc.diff

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

This revision was automatically updated to reflect the committed changes. Closed by commit rGb508c5649f5e: [MLIR] Add a utility to sort the operands of commutative ops (authored by srishti-pm, committed by Mogball). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/QualTypeNames.cpp:455 + if (const auto *UT = QT->getAs()) { +return getFullyQualifiedType(UT->getUnderlyingType(), Ctx, +

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier created this revision. Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny. Herald added a reviewer: aaron.ballman. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. GabrielRavier

[PATCH] D130826: [clang-tools-extra] Fixed a number of typos

GabrielRavier created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar, kbarton, nemanjai. Herald added a project: All. GabrielRavier requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. https://lab.llvm.org/buildbot/#/builders/98/builds/22588 fuschia build bot is happy with this change and I don't see new build breakages so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130788/new/

[PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. In D130689#3686716 , @thieta wrote: > You can already test this with `-DCMAKE_CXX_STANDARD=17` afaik. I wonder how > many bot owners would actually test this if we made another flag available. Thanks, that works. Our linux and

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f2e24e48fd: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON. (authored by sunho). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] a8f2e24 - [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

Author: Sunho Kim Date: 2022-07-31T05:42:57+09:00 New Revision: a8f2e24e48fddb3707301c9d24cc50ab778d4fda URL: https://github.com/llvm/llvm-project/commit/a8f2e24e48fddb3707301c9d24cc50ab778d4fda DIFF: https://github.com/llvm/llvm-project/commit/a8f2e24e48fddb3707301c9d24cc50ab778d4fda.diff

[PATCH] D129799: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake setting to avoid building when cross compiling

mstorsjo added a comment. In D129799#3689044 , @trcrsired wrote: > Hi i have a question. Does llvm provide a general toggle to set all those > things with a directory? It becomes unmanagable since the end of llvm 15 for > Canadian compilation. > > like

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb marked 13 inline comments as done. cjdb added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1755-1756 + Tok.setKind(tok::identifier); + Diag(Tok, diag::ext_keyword_as_ident) + << Tok.getIdentifierInfo()->getName() << 0; + goto

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 448806. cjdb added a subscriber: rsmith. cjdb added a comment. I think this covers all the feedback @rsmith has provided, though my treatment of `BuildPointerType` and `BuildReferenceType` might be wrong. Hopefully `__make_signed` and `__make_unsigned` are

[PATCH] D130822: Fixed loads of typos

GabrielRavier added a comment. Well, I assumed if I split it up per project I would have been told to merge all the patches into a big one to avoid having a bunch of small ones essentially all doing the same thing, but then again this also makes sense, I'll split it up.

[PATCH] D130822: Fixed loads of typos

philnik added a comment. Could you split this up per project? Large patches like this are really hard to review, since there is no single person/small group that can approve everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130822/new/

[PATCH] D130822: Fixed loads of typos

clementval requested changes to this revision. clementval added inline comments. This revision now requires changes to proceed. Comment at: flang/docs/Extensions.md:157 with each other. -* Values for whole anonymous parent components in structure constructors (e.g.,

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

thakis added a comment. In D130058#3687868 , @aaron.ballman wrote: > In D130058#3687680 , @thakis wrote: > >> Hello, this breaks a bunch of existing code over here (and I imagine >> elsewhere). > > Do you have

[PATCH] D129799: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake setting to avoid building when cross compiling

trcrsired added a comment. Hi i have a question. Does llvm provide a general toggle to set all those things with a directory? It becomes unmanagable since the end of llvm 15. like LLVM_NATIVE_TOOL_DIR some thing like that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. @Purva-Chaudhari can you rebase this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

kerbowa marked an inline comment as done. kerbowa added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:314 + +bool SchedGroup::isFull() const { + return MaxSize && Collection.size() >= *MaxSize; uabelho wrote: > Compiling with gcc, I get

[clang] 91d9b7b - DependencyScanningTool.h - fix Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2022-07-30T11:00:35+01:00 New Revision: 91d9b7b407947a958ea31746e20424ba7c446f15 URL: https://github.com/llvm/llvm-project/commit/91d9b7b407947a958ea31746e20424ba7c446f15 DIFF: https://github.com/llvm/llvm-project/commit/91d9b7b407947a958ea31746e20424ba7c446f15.diff

[clang] b3fd44d - Sema.h - fix Wdocumentation warnings. NFC.

Author: Simon Pilgrim Date: 2022-07-30T11:00:16+01:00 New Revision: b3fd44dd6adbd53b43893e5379be8eefde36c701 URL: https://github.com/llvm/llvm-project/commit/b3fd44dd6adbd53b43893e5379be8eefde36c701 DIFF: https://github.com/llvm/llvm-project/commit/b3fd44dd6adbd53b43893e5379be8eefde36c701.diff

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-pointer-as-values.cpp:16 +void range_for() { + int np_local0[2] = {1, 2}; + int *p_local0[2] = {_local0[0], _local0[1]}; the tests must be exanded

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added a comment. What's the plan with this, a fix wouod likely need to be backportsd for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 ___

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

uabelho added a comment. In D129242#3687968 , @sunho wrote: > https://reviews.llvm.org/D130788 this is the patch fyi. Great, the patch works for us. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128569: Start support for HLSL `RWBuffer`

uabelho added a comment. Hello, Compiling with gcc I get the following warning with this patch: [1832/2330] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/HLSLExternalSemaSource.cpp.o In file included from ../../clang/include/clang/Sema/ExternalSemaSource.h:15,