[clang] c44c718 - [clang][dataflow] Make the type of the post visit callback consistent

Author: Stanislav Gatev Date: 2022-08-03T05:58:38Z New Revision: c44c71843f3eca71ef109d2e0730722a6d8e5675 URL: https://github.com/llvm/llvm-project/commit/c44c71843f3eca71ef109d2e0730722a6d8e5675 DIFF: https://github.com/llvm/llvm-project/commit/c44c71843f3eca71ef109d2e0730722a6d8e5675.diff

[PATCH] D131039: [clang][dataflow] Add cache of `ControlFlowContext`s for function decls.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:34 + /// Builds a ControlFlowContext from an AST node. `D` is the function in which + /// `S` resides. All arguments must be non-null. static llvm::Expected

[PATCH] D131024: Fix assert in the call to isOpenMPRebuildMemberExpr

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131024/new/ https://reviews.llvm.org/D131024

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef &&

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t iana wrote: > iana wrote: > > What are you seeing that's defining

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:5502 MarshallingInfoFlag>; +def fexperimental_sanitize_metadata_covered +: Flag<["-"], "fexperimental-sanitize-metadata-covered">, Let CC1 options use the same spelling

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449517. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added a comment. The previous version of this patch checked constant string literals before checking various types of statements, while the current version only checks for compile-time evaluation literals after function calls, and now other regression tests remain as they are.

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449511. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449510. inclyc added a comment. Now only checks functions calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

FreddyYe added a comment. In D130964#3694540 , @bkramer wrote: > In D130964#3694473 , @rjmccall > wrote: > >> How are you actually implementing `__bf16` on these targets? There isn't >> even hardware support

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

pengfei added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. We support `float` -> `bf16` in `AVX512BF16`.

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

ymandel accepted this revision. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131021/new/ https://reviews.llvm.org/D131021 ___ cfe-commits mailing list

[PATCH] D131039: [clang][dataflow] Add cache of `ControlFlowContext`s for function decls.

ymandel created this revision. ymandel added reviewers: xazax.hun, samestep, sgatev, gribozavr. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

iana added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t iana wrote: > What are you seeing that's defining `__int_least64_t`

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

iana added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t What are you seeing that's defining `__int_least64_t` and all these

[PATCH] D124435: [X86] Always extend the integer parameters in callee

jyknight added a comment. Thinking more about the naming issue, I think the real issue is that the proposed options are an implementation detail, not what we should expose to users. I realize that the non-boolean option was proposed by rjmmccall before, but I'd suggest that we go back to

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis updated this revision to Diff 449469. ellis added a comment. Rebase and rename `omitprofile` => `skipprofile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 Files: clang/docs/UsersManual.rst

[PATCH] D131012: No longer place const volatile global variables in a read only section

anakryiko added a comment. This will severly break BPF users, as we have a heavy reliance on `const volatile` variables being allocated to `.rodata`, which are passed to BPF verifier in Linux kernel as read-only values. This is critical for BPF Complie Once - Run Everywhere approach of writing

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. > Yes, I can continue to trim down the implementation! I agree with your > sentiment. Thanks! This update helps - though I think we'll still want to further isolate the different pieces of this change/reduce this further. > I agree with some of this, I have some

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis updated this revision to Diff 449463. ellis added a comment. Rename `omitprofile` => `skipprofile` since this seems slightly better to me. Of course I'm still open to more suggestions. Also, fix the `profile-function-groups.c` test. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

MaskRay accepted this revision. MaskRay added a comment. I'll assume that you have done `ninja docs-clang-html`:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130794/new/ https://reviews.llvm.org/D130794

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc updated this revision to Diff 449458. ddcc added a comment. Drop changes to CUDA/HIP/OpenMP headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130800/new/ https://reviews.llvm.org/D130800 Files: clang/lib/Headers/float.h

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:381 // decltype is only available in C++11 and above. -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L // __hip_promote tra wrote: > HIP headers are

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

sgatev added a comment. In D131014#3694852 , @samestep wrote: > Seems reasonable  I'm curious though, why does this not require > `clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp` to > be updated? It does, thanks! Fixed.

[PATCH] D129118: CommandLine: add and use cl::SubCommand::get{All,TopLevel}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7872cdce110: CommandLine: add and use cl::SubCommand::get{All,TopLevel} (authored by nhaehnle). Changed prior to commit:

[clang] f7872cd - CommandLine: add and use cl::SubCommand::get{All, TopLevel}

Author: Nicolai Hähnle Date: 2022-08-02T23:49:16+02:00 New Revision: f7872cdce1102a5c12633dad462a1d9763a578d3 URL: https://github.com/llvm/llvm-project/commit/f7872cdce1102a5c12633dad462a1d9763a578d3 DIFF:

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

sgatev updated this revision to Diff 449449. sgatev added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131014/new/

[PATCH] D131024: Fix assert in the call to isOpenMPRebuildMemberExpr

jyu2 created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This is to fix

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

samestep added a comment. Seems reasonable  I'm curious though, why does this not require `clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp` to be updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131014/new/

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

sgatev updated this revision to Diff 449436. sgatev added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131021/new/ https://reviews.llvm.org/D131021 Files:

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2, wyt. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Rename

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130794/new/ https://reviews.llvm.org/D130794

[PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:51-56 +add_custom_target(fuzz-lldb-expression + COMMENT "Running the LLDB expression evaluator fuzzer..." + WORKING_DIRECTORY

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

aaron.ballman added a comment. Thank you for working on this, this is heading in the right direction! Please be sure to also add a release note so users know about the new functionality. Comment at: clang/lib/Sema/SemaChecking.cpp:8509 + if (E->EvaluateAsRValue(Result,

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95a92995d45f: Adds the NSDateFormatter checker to clang-tidy

[clang-tools-extra] 95a9299 - Adds the NSDateFormatter checker to clang-tidy

Author: Rashmi Mudduluru Date: 2022-08-02T13:57:44-07:00 New Revision: 95a92995d45fc6fada43ecd91eba3e7aea90487a URL: https://github.com/llvm/llvm-project/commit/95a92995d45fc6fada43ecd91eba3e7aea90487a DIFF:

[PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a project: clang. Herald added subscribers: lldb-commits,

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449421. ckissane added a comment. - compression api: greatly simplify implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

tra added a subscriber: yaxunl. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:14 +#ifndef __cplusplus +#error CUDA header must be used from C++ +#endif Nit: the error message sounds a bit odd. Perhaps rephrase it as `This

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aaron.ballman added subscribers: mikerice, ABataev. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3694684 , @tahonermann wrote: > Accepting again. New changes suggested by Aaron are a clear improvement. > Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed > Serial Bus? Law School

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. Thank you for adding the docs! I'm not well-versed enough in hot/cold behavior and PGO to comment on the documentation accuracy, so I'm hopeful someone can sign off on that bit. Comment at: clang/include/clang/Basic/Attr.td:1077 - let

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

tahonermann accepted this revision. tahonermann added a comment. Accepting again. New changes suggested by Aaron are a clear improvement. Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed Serial Bus? Law School Student Body? Lone Star Symphonic Band? Maybe just call it

[clang-tools-extra] 54110b8 - Fix use-after-free in clang-apply-replacements

Author: Ben Langmuir Date: 2022-08-02T13:34:20-07:00 New Revision: 54110b8aa01073c428c636951511c2dc710c4a32 URL: https://github.com/llvm/llvm-project/commit/54110b8aa01073c428c636951511c2dc710c4a32 DIFF: https://github.com/llvm/llvm-project/commit/54110b8aa01073c428c636951511c2dc710c4a32.diff

[PATCH] D131017: Fix use-after-free in clang-apply-replacements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54110b8aa010: Fix use-after-free in clang-apply-replacements (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > there didn't already exist a PS4 lit feature that I could mark as unsupported. ? I believe `UNSUPPORTED: ps4` should work, because UNSUPPORTED will look at the default target triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:96 /// /// `Type` must not be null. StorageLocation (QualType Type); This is inconsistent with the change introduced by this patch.

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

benlangmuir added a comment. @fmayer thanks, fix is: https://reviews.llvm.org/D131017 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934 ___ cfe-commits mailing

[PATCH] D131017: Fix use-after-free in clang-apply-replacements

benlangmuir created this revision. benlangmuir added reviewers: bnbarham, fmayer. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Accidentally introduced a dangling StringRef in

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane updated this revision to Diff 449404. erichkeane added a comment. Add underlying type to TokenKey, plus did all of Aaron's review comments. In general, I think we dont' have a good definition of Extension vs Enabled here, and someone should probably think that through. I'll review

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) +CmdArgs.push_back("-mindirect-branch-cs-prefix"); This is not needed with the TableGen CC1Option change.

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM once nits are fixed (take or leave them). Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND:

[PATCH] D131012: No longer place const volatile global variables in a read only section

aaron.ballman updated this revision to Diff 449405. aaron.ballman added a comment. Rebased to get precommit CI to look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131012/new/ https://reviews.llvm.org/D131012 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc updated this revision to Diff 449403. ddcc added a comment. Error out on undef __cplusplus in CUDA headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130800/new/ https://reviews.llvm.org/D130800 Files:

[PATCH] D131012: No longer place const volatile global variables in a read only section

aaron.ballman added a comment. In D131012#3694502 , @rjmccall wrote: > I think this is fine for the ABI; the section is generally a > definition-specific property and doesn't affect use sites. > > Do we also need to check for volatile fields of records?

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND: aaron.ballman wrote: > Should this

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

fmayer added a comment. This CL seems to have an MSAN violation: https://lab.llvm.org/buildbot/#/builders/74/builds/12529/steps/11/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3693458 , @probinson wrote: > There is now cross-project-tests which would seem to be the appropriate place > for a test that wants to run both clang and lld. Thanks for pointing that out. I'll look into moving the

[PATCH] D131012: No longer place const volatile global variables in a read only section

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've asked some of my colleagues who work on libabigail their thoughts on the implications of this change. Due to timezones, it may take some time to

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. I think this looks good. It took me a while to appreciate the new approach; I miss some of the compactness of the previous presentation, but this approach looks more likely to

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:400-401 +CXX20_KEYWORD(concept , 0) +CXX20_KEYWORD(requires , 0) // Not a CXX20_KEYWORD because it is disabled by -fno-char8_t. KEYWORD(char8_t

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:37 -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L #define __DELETE =delete tra wrote: > Are there actual use cases where CUDA headers are

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; erichkeane wrote: > shafik wrote: > > erichkeane wrote: > > > I don't think this is the correct answer. Even though the other

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

sgatev updated this revision to Diff 449398. sgatev added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131014/new/ https://reviews.llvm.org/D131014 Files:

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2, samestep. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Make the type

[PATCH] D131012: No longer place const volatile global variables in a read only section

rjmccall added a comment. I think this is fine for the ABI; the section is generally a definition-specific property and doesn't affect use sites. Do we also need to check for volatile fields of records? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu added a comment. In D130510#3693494 , @aaron.ballman wrote: > In D130510#3692654 , @rtrieu wrote: > >> Because of this, warnings should treat dependent expressions as non-constant >> even when they can

[PATCH] D131012: No longer place const volatile global variables in a read only section

erichkeane added a comment. The code changes look perfectly fine to me, but I'm hopeful someone else has something to say about how acceptable/ABI related this is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131012/new/

[PATCH] D131012: No longer place const volatile global variables in a read only section

aaron.ballman created this revision. aaron.ballman added reviewers: nickdesaulniers, erichkeane, rjmccall, efriedma. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The C standard hints in a footnote attached to C17 6.7.3p5 that `const`

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

rjmccall added a comment. How are you actually implementing `__bf16` on these targets? There isn't even hardware support for conversions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130964/new/ https://reviews.llvm.org/D130964

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added a comment. It looks like you haven't implemented the target-specific logic for this yet. I cannot let you commit until you do that, because you will be breaking the ABI on Apple platforms. Comment at: clang/include/clang/Basic/CodeGenOptions.h:150 +

[PATCH] D130516: [llvm] compression classes

ckissane added a comment. In D130516#3694422 , @dblaikie wrote: > The current code here still seems more complicated than I'd prefer - looks > like currently the size/speed/default levels are currently unused, so maybe > we can omit those for now,

[PATCH] D131004: [clang] Add FileEntryRef::getNameAsRequested()

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks  Comment at: clang/unittests/Basic/FileManagerTest.cpp:381 EXPECT_TRUE(F1->isSameRef(*F1Again)); - EXPECT_TRUE(F1->isSameRef(*F1Redirect)); +

[PATCH] D130516: [llvm] compression classes

MaskRay added a comment. In D130516#3694366 , @dblaikie wrote: > In D130516#3694151 , @MaskRay wrote: > >> In D130516#3688236 , @dblaikie >> wrote: >> >>> In

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. > I think I have worked out something that is the best of both worlds: I think @MaskRay's main concern, which I share to a degree, is that there's a lot of code/complexity here that doesn't currently seem warranted by the size of the problem. So adding more

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. The current code here still seems more complicated than I'd prefer - looks like currently the size/speed/default levels are currently unused, so maybe we can omit those for now, knowing they will be added? And the CompressionKind with all its operator overloads seems

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, usama54321, steakhal, vsavchenko, martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a

[PATCH] D130516: [llvm] compression classes

ckissane added a comment. In D130516#3694366 , @dblaikie wrote: > In D130516#3694151 , @MaskRay wrote: > >> In D130516#3688236 , @dblaikie >> wrote: >> >>> In

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449375. ckissane added a comment. - CompressionKind: clean up param names to == op Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. In D130516#3694151 , @MaskRay wrote: > In D130516#3688236 , @dblaikie > wrote: > >> In D130516#3688123 , @MaskRay >> wrote: >> >>> I'd like to

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. @martong > Now I'm working on the next patch and you'll see a motivation soon. Here is the motivation but it still causes some tests failure D131006 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG508c431ed9ab: [SemaCXX] Validate destructor is valid for dependent classes (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 508c431 - [SemaCXX] Validate destructor is valid for dependent classes

Author: Roy Jacobson Date: 2022-08-02T21:50:54+03:00 New Revision: 508c431ed9ab6d2074f1c68e3ee6b245ece57d5a URL: https://github.com/llvm/llvm-project/commit/508c431ed9ab6d2074f1c68e3ee6b245ece57d5a DIFF: https://github.com/llvm/llvm-project/commit/508c431ed9ab6d2074f1c68e3ee6b245ece57d5a.diff

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG92c1bc61586c: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 92c1bc6 - [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

Author: Yuanfang Chen Date: 2022-08-02T11:49:01-07:00 New Revision: 92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0 URL: https://github.com/llvm/llvm-project/commit/92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0 DIFF: https://github.com/llvm/llvm-project/commit/92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0.diff

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, tahonermann, shafik, Codesbyusman. Herald added a project: All. erichkeane requested review of this revision. The getKeywordStatus function is a horrible mess of inter-dependent 'if' statements that depend significantly

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449365. ckissane added a comment. - trim down compression api: remove supported() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; shafik wrote: > erichkeane wrote: > > I don't think this is the correct answer. Even though the other use of > > this

[PATCH] D131004: [clang] Add FileEntryRef::getNameAsRequested()

benlangmuir created this revision. benlangmuir added a reviewer: bnbarham. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As progress towards having FileManager::getFileRef() return the path

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; erichkeane wrote: > I don't think this is the correct answer. Even though the other use of this > seems to 'work',

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449355. ckissane added a comment. - make a zlib corruption check specific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

MaskRay added a comment. In D130516#3688236 , @dblaikie wrote: > In D130516#3688123 , @MaskRay wrote: > >> I'd like to make a few arguments for the current namespace+free function >> design, as opposed to the

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449346. ckissane added a comment. - feat compression "enum" with methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

royjacobson updated this revision to Diff 449344. royjacobson edited the summary of this revision. royjacobson added a comment. Add newline and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130936/new/

[PATCH] D126749: [RISCV][Clang] Support policy functions for Vector Mask Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb99d4b11d84: [RISCV][Clang] Support policy functions for Vector Mask Instructions. (authored by khchen). Repository: rG LLVM Github Monorepo

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdffdca85ec2d: [RISCV][Clang] Support policy functions for Vector Reduction (authored by khchen). Changed prior to commit:

[PATCH] D126746: [RISCV][Clang] Support policy functions for Vector Comparison Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caf2cc05c02: [RISCV][Clang] Support policy functions for Vector Comparison (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES

  1   2   >