[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131272/new/ https://reviews.llvm.org/D131272

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong updated this revision to Diff 450468. ShawnZhong added a comment. - Added CodeGen tests. - Fixed failed tests that assigned 1 to `int:1`. - Modified the Sema test to use `int:` instead of `signed char:1`. - Added release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; tianshilei1992 wrote: > ABataev

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 updated this revision to Diff 450469. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131272/new/ https://reviews.llvm.org/D131272 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rG786b503f66b1: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior. (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 786b503 - [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

Author: Jun Zhang Date: 2022-08-06T11:36:02+08:00 New Revision: 786b503f66b1a35f79312203fcb533ad27511982 URL: https://github.com/llvm/llvm-project/commit/786b503f66b1a35f79312203fcb533ad27511982 DIFF: https://github.com/llvm/llvm-project/commit/786b503f66b1a35f79312203fcb533ad27511982.diff

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13532 -if (DestType->isEnumeralType()) { +if (Info.Ctx.getLangOpts().CPlusPlus && DestType->isEnumeralType()) { const EnumType *ET = dyn_cast(DestType.getCanonicalType());

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, thakis, smeenai, tahonermann. Herald added a project: All. shafik requested review of this revision. In D130058 we diagnose the undefined behavior of setting the value outside the

[clang] 7b12e56 - [test/Modules/cxx20-export-import.cpp] Pre-clean the modules cache directory of the test, NFC

Author: Argyrios Kyrtzidis Date: 2022-08-05T17:27:43-07:00 New Revision: 7b12e561ac7aa9604022d56c8561bd472e78f2ed URL: https://github.com/llvm/llvm-project/commit/7b12e561ac7aa9604022d56c8561bd472e78f2ed DIFF:

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. This is looking pretty close to what I've been picturing - the only thing remaining is that I think we could get rid of `CompressionKind` and access the `CompressionAlgorithm` directly - basically the contents of `CompressionKind::operator->` could be a free/public

[clang] 3fbbf28 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV=OFF after 6635f48e4aba

Author: Nico Weber Date: 2022-08-05T19:50:23-04:00 New Revision: 3fbbf28173406ed74c9791d172fff5c5b1aab823 URL: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823 DIFF: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823.diff

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth created this revision. paulkirth added a reviewer: tejohnson. Herald added subscribers: ormris, okura, kuter, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added projects:

[PATCH] D130858: [HLSL] emit-obj when set output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG549542b494f4: [HLSL] emit-obj when set output. (authored by python3kgae). Changed prior to commit:

[clang] 549542b - [HLSL] emit-obj when set output.

Author: Xiang Li Date: 2022-08-05T16:27:17-07:00 New Revision: 549542b494f4c84bead744ed91ea81236e4aaa63 URL: https://github.com/llvm/llvm-project/commit/549542b494f4c84bead744ed91ea81236e4aaa63 DIFF: https://github.com/llvm/llvm-project/commit/549542b494f4c84bead744ed91ea81236e4aaa63.diff

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b52341116b7: [CUDA] Fix output name being replaced in device-only mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131278/new/

[clang] 3b52341 - [CUDA] Fix output name being replaced in device-only mode

Author: Joseph Huber Date: 2022-08-05T19:08:41-04:00 New Revision: 3b52341116b794e53dec2fd07e568884e5a0b8bb URL: https://github.com/llvm/llvm-project/commit/3b52341116b794e53dec2fd07e568884e5a0b8bb DIFF: https://github.com/llvm/llvm-project/commit/3b52341116b794e53dec2fd07e568884e5a0b8bb.diff

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

w2yehia added inline comments. Herald added a project: All. Comment at: libcxx/trunk/include/istream:1222 { -this->setstate(ios_base::badbit); +__state |= ios_base::badbit; return -1; Hi @ldionne,

[PATCH] D131124: [Serialization] Remove `ORIGINAL_PCH_DIR` record

This revision was automatically updated to reflect the committed changes. Closed by commit rG6635f48e4aba: [Serialization] Remove `ORIGINAL_PCH_DIR` record (authored by akyrtzi). Changed prior to commit: https://reviews.llvm.org/D131124?vs=449808=450439#toc Repository: rG LLVM Github

[clang] 6635f48 - [Serialization] Remove `ORIGINAL_PCH_DIR` record

Author: Argyrios Kyrtzidis Date: 2022-08-05T15:40:33-07:00 New Revision: 6635f48e4aba499a7a31c6346cb1351437d36055 URL: https://github.com/llvm/llvm-project/commit/6635f48e4aba499a7a31c6346cb1351437d36055 DIFF:

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > jhuber6 wrote: > > tra wrote: > > > Ideally we want to test that the output file actually survives the

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" jhuber6 wrote: > tra wrote: > > Ideally we want to test that the output file actually survives the > > compilation.

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp:14 #include "clang/ASTMatchers/ASTMatchers.h" +#include "llvm/Support/Casting.h" Typically don't need this include. Comment at:

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450430. abrahamcd added a comment. Adds non-dependent base class test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files:

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. I just searched again and found https://reviews.llvm.org/D91930. But seems like it never got updated with the latest code contained in here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. Herald added a project: All. Trass3r edited the summary of this revision. Trass3r edited projects, added clang-tools-extra; removed All. Trass3r edited subscribers, added: sammccall;

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw created this revision. brettw added a reviewer: phosek. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Struct/class data members did not have the comments associated with them. This

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450407. abrahamcd added a comment. Checks for `clear()` in base classes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files:

[PATCH] D130858: [HLSL] emit-obj when set output.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130858/new/ https://reviews.llvm.org/D130858 ___

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Asserted locally the test passes. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6921 HelpText<"Entry point name">; +def dxc_P : Option<["--", "/", "-"], "P", KIND_SEPARATE>, + Group, Flags<[DXCOption, NoXarchOption]>, This is the same

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I don't have any concerns, this seems reasonable to me. Since Jan offered to test it, please wait to hear back before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450401. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.compression-class-simple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450392. ckissane added a comment. - fix InputSection decompress issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > Ideally we want to test that the output file actually survives the > compilation. It's traky to do

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I can confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131278/new/ https://reviews.llvm.org/D131278

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" Ideally we want to test that the output file actually survives the compilation. It's traky to do for in-tree tests as

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3703024 , @jansvoboda11 wrote: > Do you think it would make sense to introduce a command-line flag that would > control this behavior? Hmm - I don’t think it’d be necessary. If using the gcc style PCH directory, I

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 450377. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase and fix merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

scanon added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 450364. thieta added a comment. Fixed spelling error and added links to C++ standard libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files:

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

iliya-diyachkov accepted this revision. iliya-diyachkov added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130768/new/ https://reviews.llvm.org/D130768 ___

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > vitalybuka wrote: > > > maybe we should pop

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 450359. JonasToth added a comment. - improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 Files:

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

jansvoboda11 added a comment. Do you think it would make sense to introduce a command-line flag that would control this behavior? Also, I'd like to test this patch internally to see if it affects anything on our end. I should be able to do so next week. Repository: rG LLVM Github Monorepo

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 450358. JonasToth added a comment. - add test with typedef - [docs] improve documentation for misc-const-correctness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793

[clang-tools-extra] 13bc713 - fixes clang-tidy/checks/list.rst: a line was accidentally removed in 95a92995d45fc6fada43ecd91eba3e7aea90487a

Author: Rashmi Mudduluru Date: 2022-08-05T12:36:03-07:00 New Revision: 13bc71310920dced155328e25aa382dc2bb1ef9f URL: https://github.com/llvm/llvm-project/commit/13bc71310920dced155328e25aa382dc2bb1ef9f DIFF:

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice to have some tests for this, but since it's just forwarding arguments to `FileManager` I'm also fine with this as is. Repository: rG LLVM Github Monorepo

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. Any progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb89cc0ddbd9: [clang][modules] Dont depend on sharing FileManager during module build (authored by benlangmuir). Repository: rG LLVM Github

[clang] fb89cc0 - [clang][modules] Don't depend on sharing FileManager during module build

Author: Ben Langmuir Date: 2022-08-05T12:24:40-07:00 New Revision: fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411 URL: https://github.com/llvm/llvm-project/commit/fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411 DIFF: https://github.com/llvm/llvm-project/commit/fb89cc0ddbd9a588ee15148451e7d0bcbc1ef411.diff

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

benlangmuir updated this revision to Diff 450356. benlangmuir added a comment. Split out the FileManager change into https://reviews.llvm.org/D131273 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131076/new/ https://reviews.llvm.org/D131076 Files:

[PATCH] D131273: [clang] Fix redirection behaviour for cached FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGd038bb196c51: [clang] Fix redirection behaviour for cached FileEntryRef (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131273/new/

[clang] d038bb1 - [clang] Fix redirection behaviour for cached FileEntryRef

Author: Ben Langmuir Date: 2022-08-05T12:23:38-07:00 New Revision: d038bb196c51dcf80cbe771f4229b4e227c6c5b6 URL: https://github.com/llvm/llvm-project/commit/d038bb196c51dcf80cbe771f4229b4e227c6c5b6 DIFF: https://github.com/llvm/llvm-project/commit/d038bb196c51dcf80cbe771f4229b4e227c6c5b6.diff

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel updated this revision to Diff 450353. ymandel added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131280/new/ https://reviews.llvm.org/D131280 Files: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > vitalybuka wrote: > > maybe we should pop everything up to "pc"

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added a comment. In D103562#3702962 , @smd wrote: > Hi folks, > > I've been working on support hwasan for risc-v and I believe I've found an > issue with the existing lit tests this commit causes. > Tests stack-{oob,uar,uas}.c check for correct

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

smd added a comment. Hi folks, I've been working on support hwasan for risc-v and I believe I've found an issue with the existing lit tests this commit causes. Tests stack-{oob,uar,uas}.c check for correct backtrace being printed. From the code and comments the idea is to not to print any

[PATCH] D131265: Fixed sm version for .and bmma operator.

tra added a comment. Looks like the tests needed to be updated (and I've found one bug which explains how we've missed this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131265/new/ https://reviews.llvm.org/D131265

[PATCH] D131265: Fixed sm version for .and bmma operator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e0e5568a6a8: [CUDA] Fixed sm version constrain for __bmma_m8n8k128_mma_and_popc_b1. (authored by JackAKirk, committed by tra). Changed prior to

[clang] 3e0e556 - [CUDA] Fixed sm version constrain for __bmma_m8n8k128_mma_and_popc_b1.

Author: Jack Kirk Date: 2022-08-05T12:14:06-07:00 New Revision: 3e0e5568a6a8c744d26f79a1e55360fe2655867c URL: https://github.com/llvm/llvm-project/commit/3e0e5568a6a8c744d26f79a1e55360fe2655867c DIFF: https://github.com/llvm/llvm-project/commit/3e0e5568a6a8c744d26f79a1e55360fe2655867c.diff

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel created this revision. ymandel added reviewers: samestep, xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch evolves the cache of

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450345. ckissane added a comment. - format error string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:220 + +// Const subscript operators return copies of elements, non-const return a +// reference so that they are assignable. python3kgae wrote: > If we reuse this function

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1474-1475 + if (!CompressionScheme) { +Error("compression class " + + (CompressionScheme->Name + " is not available").str()); return nullptr;

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450343. ckissane added a comment. - remove OptionalCompressionKind noneIfUnsupported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. In D130372#3699036 , @martong wrote: > LGTM! Nice work! Thank you. I prefer to load this along with the motivation part D131006 . CHANGES SINCE LAST ACTION

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

tra added a comment. In D128441#3702816 , @jhuber6 wrote: > Is it spitting it out as `foo123.cubin` instead? That's the output name it passes to `ptxas`, but it's treated as a temporary file and is removed at the end, so the user gets nothing.

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 created this revision. jhuber6 added a reviewer: tra. Herald added subscribers: mattd, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When performing device only compilation,

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

abrahamcd added a comment. In D131084#3697211 , @vaibhav.y wrote: > Submitting for review: > > Some notes: > > There are a couple of ways I think we can acheive this, per the spec: > > 1. The reportingDescriptor (rule) objects can be given a default >

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik planned changes to this revision. philnik added a comment. This is useless until we have some `no_unique_address` in clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874

[PATCH] D131277: clang: fix typo availbility

sloorush created this revision. Herald added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. sloorush requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #56787. Fixing the spelling of availability. I am

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450338. ckissane added a comment. - cleanup some compression nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka added a subscriber: smd. vitalybuka added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +

[PATCH] D131268: [HLSL] Generate buffer subscript operators

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:220 + +// Const subscript operators return copies of elements, non-const return a +// reference so that they are assignable. If we reuse this function for

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 added a comment. In D128441#3702800 , @tra wrote: > This change breaks `clang++ --cuda-device-only` compilation. Clang does not > create any output in this case. Reverting the change fixes the problem. > > Reproducible with: > > echo

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; ABataev wrote: > Better to make it a property of MappedVars. Also, are there any

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

tra added a comment. This change breaks `clang++ --cuda-device-only` compilation. Clang does not create any output in this case. Reverting the change fixes the problem. Reproducible with: echo '__global__ void k(){}' | bin/clang++ --offload-arch=sm_70 -x cuda - --cuda-device-only -v -c

[PATCH] D130516: [llvm] compression classes

dblaikie added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

ldionne added a comment. @leonardchan Does this fix the Fuchsia issues you were seeing? I think I understand what went wrong and I think this version of the patch should address the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

ldionne created this revision. ldionne added a reviewer: leonardchan. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Newer SDKs don't even provide libstdc++ headers, so it's effectively never

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk added a comment. In D131265#3702594 , @tra wrote: > Good catch. LGTM. Thanks. If you could land it for me that would be much appreciated. I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131273: [clang] Fix redirection behaviour for cached FileEntryRef

benlangmuir created this revision. benlangmuir added a reviewer: bnbarham. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 6a79e2ff1989b

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; Better to make it a property of MappedVars. Also, are there any issues if just restore it

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

aaron.ballman added a comment. In D131213#3702707 , @iana wrote: > In D131213#3702699 , @ddcc wrote: > >> I missed line 19, yeah that makes sense. @iana is that ok with you? > > Ah, I didn't see that either. Can

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

iana added a comment. In D131213#3702699 , @ddcc wrote: > I missed line 19, yeah that makes sense. @iana is that ok with you? Ah, I didn't see that either. Can we just lose the `defined` on line 26 then? It's redundant and little confusing.

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

ddcc added a comment. I missed line 19, yeah that makes sense. @iana is that ok with you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131213/new/ https://reviews.llvm.org/D131213 ___ cfe-commits

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: pengfei, guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D126291: [flang][Driver] Update link job on windows

amyk added a comment. Hi, I have come across a failure involving `flang/test/Driver/linker-flags.f90` that occurs when the default linker is lld. I have opened an external issue for it here: https://github.com/llvm/llvm-project/issues/56955 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131076: [clang][modules] Don't depend on sharing FileManager during module build

benlangmuir updated this revision to Diff 450313. benlangmuir added a comment. Herald added a subscriber: ormris. Attempt to fix test failure seen on Windows. It revealed two bugs - Avoid reusing the FileManager at the top-level in clang-scan-deps to make the test behave as expected - Make the

[PATCH] D131265: Fixed sm version for .and bmma operator.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Good catch. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131265/new/ https://reviews.llvm.org/D131265

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz created this revision. beanz added reviewers: bogner, aaron.ballman, python3kgae, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. In HLSL buffer types support array subscripting syntax for

[PATCH] D130907: [Clang] Use pragma FENV_ROUND to reset rounding mode settings.

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:398 +// If dynamic rounding mode is specified in absence of FENV_ACCESS, treat it +// as setting default rounding mode. +FpPragmaStack.CurrentValue.clearConstRoundingModeOverride();

[PATCH] D131143: [Clang] Interaction of FP pragmas and function template instantiation

sepavloff added a comment. In D131143#3700373 , @efriedma wrote: >> In the case is explicit instantiation there is apparent connection >> between a point in source code and instantiated function. It can >> support interaction of pragmas that act in that

[PATCH] D131143: [Clang] Interaction of FP pragmas and function template instantiation

rjmccall added a comment. I completely agree with Eli. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131143/new/ https://reviews.llvm.org/D131143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >