[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3698798 , @sberg wrote: > I'm surprised that [...] > causes a warning? I would have expected it to be suppressed in this case, as > with the lax `-fstrict-flex-arrays=0` default, and only to hit with the > stricter

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. In D132640#3757395 , @njames93 wrote: > In D132640#3757277 , @corona10 > wrote: > >> @njames93 Can we land this patch before it occurs conflicting with other >> changes? > > Yes, sorry

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 456545. VincentWu marked an inline comment as done. VincentWu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. clear patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

tonic added a comment. Moving to GitHub PRs is the path forward. Let's save ourselves some work and add them now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

njames93 added a comment. In D132640#3757277 , @corona10 wrote: > @njames93 Can we land this patch before it occurs conflicting with other > changes? Yes, sorry do you have commit access. If you don't what is your GitHub name and email that I should

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} tahonermann wrote: > erichkeane wrote: > > tbaeder wrote: > > > erichkeane wrote:

[clang] 740a75c - Fix assumption that Clang version number is numeric.

Author: Richard Smith Date: 2022-08-29T21:42:11-07:00 New Revision: 740a75c9d6adf8a26ebd13fc1d3460c728550624 URL: https://github.com/llvm/llvm-project/commit/740a75c9d6adf8a26ebd13fc1d3460c728550624 DIFF: https://github.com/llvm/llvm-project/commit/740a75c9d6adf8a26ebd13fc1d3460c728550624.diff

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456542. VincentWu marked 6 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka updated this revision to Diff 456541. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132909/new/ https://reviews.llvm.org/D132909 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka updated this revision to Diff 456540. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132907/new/ https://reviews.llvm.org/D132907 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 456535. dongjunduo added a comment. Rewrite comments and commit log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 456533. dongjunduo added a comment. Replace -ftime-trace with -ftime-trace= also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files:

[clang] d9d7e12 - [test][msan] Use -DAG to match Debug Info

Author: Vitaly Buka Date: 2022-08-29T20:32:41-07:00 New Revision: d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1 URL: https://github.com/llvm/llvm-project/commit/d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1 DIFF: https://github.com/llvm/llvm-project/commit/d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1.diff

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Depends on: D132907

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen requested review of this revision. ychen added a comment. @royjacobson: really appreciate it if you could take another look. @mizvekov: I saw you mentioned in the Discourse that you want to review template-related stuff and you have been actively working in that area, do you mind having a

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:570 +clang_std_values = ('98', '11', '14', '17', '20', '2b') +def add_stdcxx(s): +t = s[8:] aaron.ballman wrote: >

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 456528. ychen added a comment. This revision is now accepted and ready to land. - handle constrained placeholder [pack] types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/

[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

ChuanqiXu added a comment. In D129833#3755135 , @nikic wrote: > In D129833#3727881 , @ChuanqiXu > wrote: > >> And I am working on adding Align properties. But I meet problems since the >> alignment of

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. @njames93 Can we land this patch before it occurs conflicting with other changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D132352#3755355 , @nikic wrote: > Okay, this is a bit tricky because we have three different things: > > 1. The noread_thread_id attribute, the lack of which was causing issues

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/exception-spec-decay.cpp:1 -// RUN: %clang_cc1 -fcxx-exceptions -fexceptions %s -triple=i686-unknown-linux -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %stdcxx_98- -fcxx-exceptions -fexceptions

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 456524. MaskRay marked 6 inline comments as done. MaskRay added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files:

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto : C.getJobs()) { Whitney wrote: > dongjunduo

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto : C.getJobs()) { dongjunduo wrote: > Whitney wrote: > > dongjunduo wrote: > > > Whitney wrote: > >

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto : C.getJobs()) { Whitney wrote: > dongjunduo

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. In D128490#3689958 , @ChuanqiXu wrote: > LGTM then. Thanks for the review! Sorry for not answering earlier, I was on vacation. Now I'll rebase the change and will test it again before committing. Repository: rG LLVM Github

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 456520. jhuber6 added a comment. Remove unused code gen option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 420209b - [test][msan] Add missing Debug Info check from dtor test

Author: Vitaly Buka Date: 2022-08-29T18:55:24-07:00 New Revision: 420209bb6d092bd4735c24726b934a1e4637f04d URL: https://github.com/llvm/llvm-project/commit/420209bb6d092bd4735c24726b934a1e4637f04d DIFF: https://github.com/llvm/llvm-project/commit/420209bb6d092bd4735c24726b934a1e4637f04d.diff

[PATCH] D132906: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is a special member function before attempting to call DefineDefaultedFunction(...)

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman. Herald added a project: All. shafik requested review of this revision. In `Sema::CheckCompletedCXXClass(...)` It used a lambda `CheckForDefaultedFunction` the `CXXMethodDecl` passed to `CheckForDefaultedFunction`

[PATCH] D132905: [clang-format] Fix a bug in inserting braces at trailing comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the style

[clang] 582ec4b - [test][msan] Don't ignore prefix of sanitizer_dtor_callback

Author: Vitaly Buka Date: 2022-08-29T18:26:04-07:00 New Revision: 582ec4b0aa55bff84490e1c89e55066bf6603212 URL: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212 DIFF: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212.diff

[clang] c7df82e - [test][msan] Don't ignore the suffix if use-after-dtor callback

Author: Vitaly Buka Date: 2022-08-29T18:10:57-07:00 New Revision: c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59 URL: https://github.com/llvm/llvm-project/commit/c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59 DIFF: https://github.com/llvm/llvm-project/commit/c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59.diff

[clang] 9c29bdf - [test][msan] Remov unneeded CHECK-NOT

Author: Vitaly Buka Date: 2022-08-29T17:49:44-07:00 New Revision: 9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763 URL: https://github.com/llvm/llvm-project/commit/9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763 DIFF: https://github.com/llvm/llvm-project/commit/9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763.diff

[clang] ed4e95c - [test][msan] Add more Debug Info use-after-dtor tests

Author: Vitaly Buka Date: 2022-08-29T17:49:44-07:00 New Revision: ed4e95c1f68abe8fffe8b54139d268924d554381 URL: https://github.com/llvm/llvm-project/commit/ed4e95c1f68abe8fffe8b54139d268924d554381 DIFF: https://github.com/llvm/llvm-project/commit/ed4e95c1f68abe8fffe8b54139d268924d554381.diff

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

This revision was automatically updated to reflect the committed changes. akyrtzi marked an inline comment as done. Closed by commit rG33162a81d4c9: [driver] Additional ignoring of module-map related flags, if modules are… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES

[clang] 33162a8 - [driver] Additional ignoring of module-map related flags, if modules are disabled

Author: Argyrios Kyrtzidis Date: 2022-08-29T17:38:00-07:00 New Revision: 33162a81d4c93a53ef847d3601b0b03830937d3c URL: https://github.com/llvm/llvm-project/commit/33162a81d4c93a53ef847d3601b0b03830937d3c DIFF:

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack. erichkeane wrote: > This

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack. This pattern with the init +

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov retitled this revision from "WIP: [clang] Improve diagnostics for expansion length mismatch" to "[clang] Improve diagnostics for expansion length mismatch". mizvekov updated this revision to Diff 456495. mizvekov marked 5 inline comments as done. mizvekov requested review of this

[PATCH] D128095: WIP: [clang] Improve diagnostics for expansion length mismatch

mizvekov retitled this revision from "[clang] Improve diagnostics for expansion length mismatch" to "WIP: [clang] Improve diagnostics for expansion length mismatch". mizvekov updated this revision to Diff 456494. mizvekov planned changes to this revision. Repository: rG LLVM Github Monorepo

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb18f26567be: [llvm-profdata] Handle internal linkage functions in profile supplementation (authored by xur). Herald added a project: clang.

[clang] db18f26 - [llvm-profdata] Handle internal linkage functions in profile supplementation

Author: Rong Xu Date: 2022-08-29T16:15:12-07:00 New Revision: db18f26567be47ec1da7fba48179a3001f0d34ab URL: https://github.com/llvm/llvm-project/commit/db18f26567be47ec1da7fba48179a3001f0d34ab DIFF: https://github.com/llvm/llvm-project/commit/db18f26567be47ec1da7fba48179a3001f0d34ab.diff LOG:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jdoerfert added a comment. If you want to overwrite them, weak/linkonce will work (no _odr). Private/internal will not be overwritten but existing uses will keep the private/internal version, IIRC. I assume you want the former. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/test/Driver/modules.m:81 // RUN: %clang -fno-modules -fmodules-validate-system-headers -### %s 2>&1 | FileCheck -check-prefix=VALIDATE_SYSTEM_FLAG %s // VALIDATE_SYSTEM_FLAG-NOT:

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi updated this revision to Diff 456483. akyrtzi added a comment. Merge the new `RUN` line together with the prior 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132801/new/ https://reviews.llvm.org/D132801 Files:

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel updated this revision to Diff 456480. rymiel added a comment. Add extra tests for spacing options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp

[clang] 79fe9aa - [Driver] Fix & re-enable DriverKit test

Author: Julian Lettner Date: 2022-08-29T15:05:22-07:00 New Revision: 79fe9aaf6a7b13e23492e900c7ff5b9659df5544 URL: https://github.com/llvm/llvm-project/commit/79fe9aaf6a7b13e23492e900c7ff5b9659df5544 DIFF:

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

vsapsai added inline comments. Comment at: clang/CODE_OWNERS.TXT:128 +H: Bigcheese +D: Modules & Serialization I can also help with Modules & Serialization. Maybe more with deserialization and incorporating the deserialized AST with existing AST.

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

efriedma added a comment. I'm not really happy with the way this implicitly ties the implementation of this function to the implementation of TargetMachine::useEmulatedTLS(). I'd prefer to just make clang always explicitly compute whether EmullatedTLS is enabled, then always set

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

chrish_ericsson_atx added a comment. This change affected analyzer findings for C language source as well. Mostly true positives, but there is one false positive we know about. I filed https://github.com/llvm/llvm-project/issues/57434 to track that new false positive. Repository: rG LLVM

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:785 + - Consecutive + - AcrossEmptyLines + - AcrossComments may be AcrossEmptyLines should be a number (to mean the number of empty lines) Comment at:

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

cor3ntin added a comment. @aaron.ballman i am not worried about performance. The old table was fairly compact - as it described large ranges - so a drop in the ocean in terms of binary size. And we only need to check them for the case where we are only going to emit a warning or an error

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10961 verifyFormat("return (my_int)aaa;"); + verifyFormat("throw (my_int)aaa;"); verifyFormat("#define x ((int)-1)"); Can we add a test that covers the setting of

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D132877#3756458 , @cor3ntin wrote: > I am strongly against this change. If we do want to do this, we need to > restore the original tables from c++11 and check against

[PATCH] D132713: [clang-tidy] Skip union-like classes in use-equals-default

alexander-shaposhnikov added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132713/new/ https://reviews.llvm.org/D132713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

tahonermann added a comment. I don't have a strong opinion regarding when, or if, the diagnostic is reverted to an always-error. It looks like gcc is not even planning to diagnose identifiers that are ill-formed according to the new rules by default. With regard to Corentin's opposition to the

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

xur added a comment. I agreed with Teresa: adding an optional string is better than using a separated metadata here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306

[PATCH] D132874: [clang] Don't emit debug vtable information for consteval functions

shafik added subscribers: aprantl, shafik. shafik added a comment. Maybe @aprantl you want to take a look at this. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1761 - if (Method->isVirtual()) { + if (Method->isVirtual() && !Method->isConsteval()) { if

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

zequanwu added a comment. It's causing chromium test failure. [ RUN ] PartitionAllocPCScanTest.StackScanning ../../base/allocator/partition_allocator/starscan/pcscan_unittest.cc:682: Failure Value of: IsInFreeList(root().ObjectToSlotStart(dangling_reference)) Actual: true

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 456450. jhuber6 added a comment. Changing to private linkage. For OpenMP we could either make this use `weak_odr` so we have a single definition surviving until link time for us to use. Or we could change OpenMP to link in the bitcode libraries per-TU via

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

efriedma added a comment. I'd prefer to use an approach with less moving parts: the bitcode should contain enough information to generate code without specifying anything on the command-line that wouldn't normally be passed to the linker. Among other issues, it's hard to understand the

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} erichkeane wrote: > tbaeder wrote: > > erichkeane wrote: > > > Is there

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, yaxunl wrote: >

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, yaxunl wrote: >

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, jhuber6 wrote: >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:797 +AlignConsecutiveMacros: + Enabled: true + AcrossEmptyLines: true MyDeveloperDay wrote: > why do we need Enabled? > > isn't it just > > ``` > false:

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

efriedma added a comment. I'm not really a fan of the argument of "this was accepted as a DR, therefore new versions of clang have to reject code that old versions accepted". Regardless of what the C++ committee does, our commitment to our users is to ensure that code written against

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. In D131979#3756067 , @yihanaa wrote: > In D131979#3756006 , @rjmccall > wrote: > >> In D131979#3753358 , @yihanaa >> wrote: >> >>> In

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

cor3ntin added a comment. I am strongly against this change. If we do want to do this, we need to restore the original tables from c++11 and check against them not to extend the set to something much wider than was supported before c++23. It should be fairly easy to extract those tables from

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, yaxunl wrote: > This

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 456441. jhuber6 added a comment. Updating. I realized all of the math-related ones are already covered by driver options for AMDGPU passing the appropriate fp contract to the frontend. This patch gets rid of most of that handling and just uses those

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

thieta added a comment. Hmm. 15.0.0 is just a week away - I am not planning any more RCs unless we hit something critical. What's the risk of taking this specific change at this point? Would it make more sense to wait for 15.0.1? (I am guessing it's better if it goes into 15.0.0 or not in 15.x

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG288576f474f2: [PS4][driver] make -fjmc work with LTO driver linking stage (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132592: [Clang] Implement function attribute nouwtable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70248bfdea6c: [Clang] Implement function attribute nouwtable (authored by ychen). Changed prior to commit:

[clang] 288576f - [PS4][driver] make -fjmc work with LTO driver linking stage

Author: Yuanfang Chen Date: 2022-08-29T12:12:19-07:00 New Revision: 288576f474f260c77beb6f5d1029101626f776f0 URL: https://github.com/llvm/llvm-project/commit/288576f474f260c77beb6f5d1029101626f776f0 DIFF: https://github.com/llvm/llvm-project/commit/288576f474f260c77beb6f5d1029101626f776f0.diff

[clang] 70248bf - [Clang] Implement function attribute nouwtable

Author: Yuanfang Chen Date: 2022-08-29T12:12:19-07:00 New Revision: 70248bfdea6c70008ca42bf03bb28ebdee252744 URL: https://github.com/llvm/llvm-project/commit/70248bfdea6c70008ca42bf03bb28ebdee252744 DIFF: https://github.com/llvm/llvm-project/commit/70248bfdea6c70008ca42bf03bb28ebdee252744.diff

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

owenpan accepted this revision. owenpan added a comment. In D132762#3756072 , @rymiel wrote: > Add a few token annotator tests Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D132877#3756328 , @efriedma wrote: > If we don't specifically call out the deprecation period in the diagnostic, > usage will grow beyond what we expect. (Most people

[clang] ce6989f - Revert "[Driver] Fix & re-enable DriverKit test"

Author: Julian Lettner Date: 2022-08-29T11:59:01-07:00 New Revision: ce6989fd8a9fb2608f670de023fdd4611f47b811 URL: https://github.com/llvm/llvm-project/commit/ce6989fd8a9fb2608f670de023fdd4611f47b811 DIFF:

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

erichkeane added a comment. In D132877#3756328 , @efriedma wrote: > If we don't specifically call out the deprecation period in the diagnostic, > usage will grow beyond what we expect. (Most people don't read the release > notes; they'll just see it's

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

efriedma added a comment. If we don't specifically call out the deprecation period in the diagnostic, usage will grow beyond what we expect. (Most people don't read the release notes; they'll just see it's possible to turn off the error message, and turn it off.) If we're okay with people

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

ychen updated this revision to Diff 456427. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131820/new/ https://reviews.llvm.org/D131820 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. I think that may be a better approach. Let me investigate a bit and see what the exact tradeoffs are. If anyone else has a suggestion or thought on another way to handle this, I'm all ears. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

ychen updated this revision to Diff 456426. ychen added a comment. - use `--target` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131820/new/ https://reviews.llvm.org/D131820 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

MaskRay added inline comments. Comment at: clang/test/Driver/ps4-ps5-linker-jmc.c:3 + +// RUN: %clang -target x86_64-scei-ps4 -fjmc %s -### 2>&1 | FileCheck --check-prefixes=CHECK-PS4,CHECK-PS4-LIB %s +// RUN: %clang -target x86_64-scei-ps4 -flto=thin -fjmc %s -### 2>&1 |

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. In D131306#3756153 , @paulkirth wrote: > In D131306#3756087 , @tejohnson > wrote: > >> Well I was thinking the extra field would be optional as well and could be >> removed. But

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman added subscribers: thieta, tstellar. aaron.ballman added a comment. CC @tstellar and @thieta for any early backporting concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132877/new/ https://reviews.llvm.org/D132877

[clang-tools-extra] 7df0f0b - [clang-tidy] Fixing a bug in `InfiniteLoopCheck` that raises false alarms on finite loops

Author: ziqingluo-90 Date: 2022-08-29T11:18:44-07:00 New Revision: 7df0f0b410674437f0b56262043e22b177709161 URL: https://github.com/llvm/llvm-project/commit/7df0f0b410674437f0b56262043e22b177709161 DIFF: https://github.com/llvm/llvm-project/commit/7df0f0b410674437f0b56262043e22b177709161.diff

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7df0f0b41067: [clang-tidy] Fixing a bug in `InfiniteLoopCheck` that raises false alarms on… (authored by ziqingluo-90).

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman created this revision. aaron.ballman added reviewers: tahonermann, cor3ntin, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. WG21 P1949 and WG14 N2836 were both adopted

[PATCH] D132874: [clang] Don't emit debug vtable information for consteval functions

luken-google added reviewers: aaron.ballman, ilya-biryukov. luken-google added a comment. Note that there's still an underlying issue where the linker complains of missing vtable information for both Base and Derived, which I'm treating as a separate issue and will either file or de-dup against

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added a comment. There's no way the calling convention can change based on whether you're calling a function vs. a function pointer. I can't explain why MSVC is generating different code. I think we should just ignore it, at least for now. Repository: rG LLVM Github Monorepo

[PATCH] D132874: [clang] Don't emit debug vtable information for consteval functions

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55065 Repository: rG LLVM Github Monorepo

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

ychen updated this revision to Diff 456415. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131820/new/ https://reviews.llvm.org/D131820 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#3756087 , @tejohnson wrote: > Well I was thinking the extra field would be optional as well and could be > removed. But understood that this requires more changes (although maybe not > if it is optional, and after

[PATCH] D132791: Fix formatting in release notes

aaronpuchert closed this revision. aaronpuchert added a comment. Landed in 0c5ce1d7fba38948c27ed6b875f962cd60895574 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda marked an inline comment as done. arda added inline comments. Comment at: llvm/lib/Bitcode/Writer/EmbedBitcodePass.cpp:26 + +PreservedAnalyses EmbedBitcodePass::run(Module , ModuleAnalysisManager ) { + if (M.getGlobalVariable("llvm.embedded.module", true))

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. In D131979#3753706 , @yihanaa wrote: > Keep same behavior with current clang, don't emit an error when 1st arg is > volatile qualified. > > Ignore the implicit cast from user-written-type to 'const void *' on the 1st > arg,

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 456403. ychen added a comment. - add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files: clang/docs/ReleaseNotes.rst

  1   2   3   >