[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-runtime-flags.c:101 +// RUN: %clang -### --target=x86_64-windows-msvc -fms-runtime-lib=static \ +// RUN: -fms-omit-default-lib-name -- %s 2>&1 | FileCheck \ +// RUN: -check-prefix=CHECK-MTZl %s

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:2226 +def fms_omit_default_lib : Joined<["-"], "fms-omit-default-lib">, + Group, Flags<[NoXarchOption, CoreOption]>;

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

This revision was automatically updated to reflect the committed changes. Closed by commit rG327141fb1d8c: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 327141f - [C++] [Coroutines] Prefer aligned (de)allocation for coroutines -

Author: Chuanqi Xu Date: 2022-09-22T11:28:29+08:00 New Revision: 327141fb1d8ca35b323107a43d57886eb77e7384 URL: https://github.com/llvm/llvm-project/commit/327141fb1d8ca35b323107a43d57886eb77e7384 DIFF: https://github.com/llvm/llvm-project/commit/327141fb1d8ca35b323107a43d57886eb77e7384.diff

[PATCH] D133807: Update Unicode to 15.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc932cef32aa4: Update Unicode to 15.0 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. Tested with our internal workloads and things look fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By draft of C23 (https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2912.pdf), the description for isless macro under 7.12.17.3

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcd' (Compressed Double-Precision Floating-Point Instructions)">; +def HasStdExtZcd : Predicate<"Subtarget->hasStdExtZcf()">, +

[PATCH] D134176: Add MC support of RISCV Zcf Extension

craig.topper added a comment. Need to add zcf command lines to compress-rv32f.s Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcf' (Compressed Single-Precision Floating-Point Instructions)">; +def HasStdExtZcf :

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:47 // CHECK-NOT: __riscv_zicbom // CHECK-NOT: __riscv_zicboz Need to update this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added a comment. Need to add Zcd command lines to compress-rv32d.s Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:881 let Predicates = [HasStdExtC, HasStdExtD] in { def : CompressPat<(FLD FPR64:$rd, SP:$rs1, uimm9_lsb000:$imm),

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:368 +def HasStdExtZcb : Predicate<"Subtarget->hasStdExtZcb()">, + AssemblerPredicate<(all_of FeatureExtZcb), + "'Zcb' (Shortened format for basic

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

cfang accepted this revision. cfang added a comment. This revision is now accepted and ready to land. LGTM Should the module flag name be amdgpu_code_object_version or amdhsa_code_object_version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134355/new/

[PATCH] D133815: [analyzer] Support implicit parameters in path note

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d97aac80b8: [analyzer] Support implicit parameter self in path note (authored by jkorous). Herald added a project: clang. Herald added a

[clang] 85d97aa - [analyzer] Support implicit parameter 'self' in path note

Author: Jan Korous Date: 2022-09-21T17:26:09-07:00 New Revision: 85d97aac80b8e7689a6d957441054aa817bbb192 URL: https://github.com/llvm/llvm-project/commit/85d97aac80b8e7689a6d957441054aa817bbb192 DIFF: https://github.com/llvm/llvm-project/commit/85d97aac80b8e7689a6d957441054aa817bbb192.diff

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462042. akhuang marked an inline comment as done. akhuang added a comment. Change name of flag, and alias /Zl to this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang added a comment. In D133959#3793283 , @hans wrote: > Could the new flag be marked as an Alias in the tablegen, so that we don't > need to do any code changes for it? It appears before _SLASH_Zl in the file so we'd have to move it out of place.

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added a comment. In D133983#3805761 , @aaron.ballman wrote: > There are no tests for applying this to a global variable, so those should be > added. The global variable in the Subjects is wrong. It should be Field. Support for semantic on

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462039. python3kgae marked 4 inline comments as done. python3kgae added a comment. Add type check for dispatch thread id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/

[clang] 8edeedf - [test] Fix CodeGen/arm-crc32.c to not write an output to CWD

Author: Fangrui Song Date: 2022-09-21T16:13:25-07:00 New Revision: 8edeedfb21a4a2c07536e1026a3f67d77e57b144 URL: https://github.com/llvm/llvm-project/commit/8edeedfb21a4a2c07536e1026a3f67d77e57b144 DIFF: https://github.com/llvm/llvm-project/commit/8edeedfb21a4a2c07536e1026a3f67d77e57b144.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462032. ayzhao added a comment. rebase + upload; also friendly ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4bcaab9600: Remove the unused/undefined `_cmd` parameter in `objc_direct` methods. (authored by mwyman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] aa4bcaa - Remove the unused/undefined `_cmd` parameter in `objc_direct` methods.

Author: Michael Wyman Date: 2022-09-21T15:37:48-07:00 New Revision: aa4bcaab9600b42165587ec6f135399ff933bd14 URL: https://github.com/llvm/llvm-project/commit/aa4bcaab9600b42165587ec6f135399ff933bd14 DIFF: https://github.com/llvm/llvm-project/commit/aa4bcaab9600b42165587ec6f135399ff933bd14.diff

[PATCH] D134394: Update docs about [[likely]] vs. PGO

hans created this revision. hans added reviewers: Mordante, aaron.ballman. Herald added a subscriber: wenlei. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. It sounds like these attributes do nothing when PGO is enabled, which is actually (or

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. @LegalizeAdulthood, @njames93, is there anything else we should address in this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Please make sure to mark comments as "Done" in phab to help reviewers skip over stale feedback. Comment at: clang/lib/CodeGen/CGExpr.cpp:5055-5059 +

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

Bigcheese added a comment. I think this is fine, but I need to think more about the ModuleDepCollector.cpp change. Comment at: clang/lib/Lex/ModuleMap.cpp:1275 // specified module? - (void) Headers[Header.Entry]; + (void) Headers[Header.Entry].push_back(KH);

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

serge-sans-paille updated this revision to Diff 462009. serge-sans-paille added a comment. Address reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134362/new/ https://reviews.llvm.org/D134362 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGExpr.cpp

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. Thank you again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mbenfield updated this revision to Diff 462007. mbenfield added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 Files:

[PATCH] D133807: Update Unicode to 15.0

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thank you, Corentin, and apologies for the delayed review. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mizvekov added a comment. In D134381#3806929 , @mbenfield wrote: > I'll add a couple simple tests. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381

[libunwind] a315338 - [libunwind] Handle G in personality string

Author: Florian Mayer Date: 2022-09-21T14:13:32-07:00 New Revision: a3153381af48b2e704750255a704748a13c4c4de URL: https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de DIFF: https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de.diff

[clang] 23e4299 - [Driver] Add --gcc-install-dir=

Author: Fangrui Song Date: 2022-09-21T14:11:15-07:00 New Revision: 23e4299261d90ae5040766eceeeb11e1e2d46d5b URL: https://github.com/llvm/llvm-project/commit/23e4299261d90ae5040766eceeeb11e1e2d46d5b DIFF: https://github.com/llvm/llvm-project/commit/23e4299261d90ae5040766eceeeb11e1e2d46d5b.diff

[PATCH] D133329: [Driver] Add --gcc-install-dir=

This revision was automatically updated to reflect the committed changes. Closed by commit rG23e4299261d9: [Driver] Add --gcc-install-dir= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mbenfield added a comment. I'll add a couple simple tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 ___ cfe-commits mailing list

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3806667 , @owenpan wrote: > In D134329#3805704 , @sstwcw wrote: > >> Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? > > I was going to take care

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak @rjmccall I think the decision tree goes 1. Do we change the existing visibility behavior of objc methods? Yes / No 2. If we leave hidden as the default do we change the behavior for objc_direct? Yes / No 3. If we leave objc_direct as hidden by default do we

[PATCH] D134379: [clangd] IncludeCleaner: handle using namespace

ArcsinX added a comment. In D134379#3806664 , @sammccall wrote: > Is test.h meaningfully used in that example? > Yes, the code is going to fail to compile without it, but it seems like the > "spirit" of IWYU would say to delete both the include and the

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

tschuett added a comment. `VScaleForTuning` is 1 for N2 and V2. It is 2 for V1. I though the V2 is more like the V1 than the N2? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: ahatanak. plotfi added a comment. @ahatanak @mwyman @rjmccall @dmaclach I am going to work on a version of this patch where the visibility can be encoded into the objc_direct attribute. Does that seem reasonable to do from here? Repository: rG LLVM Github

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mizvekov added a comment. This is OK, within existing practice, but it's unfortunate that we have no tests at all for any of these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Let's tackle the config changes independently and not block this on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/

[clang] e347c0f - [clang-format][NFC] Reformat the clang/unittests/Format directory

Author: owenca Date: 2022-09-21T13:26:59-07:00 New Revision: e347c0fc9bf8a9c415ca09887bf707e718b8fb1c URL: https://github.com/llvm/llvm-project/commit/e347c0fc9bf8a9c415ca09887bf707e718b8fb1c DIFF: https://github.com/llvm/llvm-project/commit/e347c0fc9bf8a9c415ca09887bf707e718b8fb1c.diff LOG:

[PATCH] D134384: [clangd] Add support for HeaderInsertion in .clangd config file

qchateau created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add ability to configure header

[PATCH] D134222: [clang][deps] Report module map describing compiled module

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134222/new/ https://reviews.llvm.org/D134222

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

mbenfield created this revision. mbenfield added a reviewer: mizvekov. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mbenfield requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is now an

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 461990. python3kgae added a comment. Add Issue link for FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130033/new/ https://reviews.llvm.org/D130033 Files: clang/include/clang/Basic/Attr.td

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3806760 , @Mordante wrote: > In D126907#3805606 , @erichkeane > wrote: > >> Now fully runs libcxx modules configuration as well, and passes the >> minimization examples

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3805606 , @erichkeane wrote: > Now fully runs libcxx modules configuration as well, and passes the > minimization examples from @wlei . > > @wlei and anyone else: can you please try running this against your >

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:6195 + + assert(false && "Unhandled Mode"); + return "clang"; If the switch covers all enum members, we typically use llvm_unreachable to work around a GCC -Wswitch warning. Clang

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 461987. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130033/new/ https://reviews.llvm.org/D130033 Files: clang/include/clang/Basic/Attr.td

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3285f9a2392f: [Clang] Support case and default labels at end of compound statement (authored by Izaron). Repository: rG LLVM Github Monorepo

[clang] 3285f9a - [Clang] Support case and default labels at end of compound statement

Author: Evgeny Shulgin Date: 2022-09-21T19:37:22Z New Revision: 3285f9a2392fd6bc79241b1e97b124079553e48d URL: https://github.com/llvm/llvm-project/commit/3285f9a2392fd6bc79241b1e97b124079553e48d DIFF: https://github.com/llvm/llvm-project/commit/3285f9a2392fd6bc79241b1e97b124079553e48d.diff

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added a comment. > Sometimes we will emit the alias here but later the function will be inlined > or eliminated by DCE. If the alias is externally visible, it can't be eliminated; the compiler can't tell whether the symbol is referenced. If the alias isn't externally visible, it's

[clang] b63b4d8 - Add tests & update the C99 DR statuses for dr315 and dr316

Author: Aaron Ballman Date: 2022-09-21T15:33:03-04:00 New Revision: b63b4d89663c240a77675d233652dcc854a85bb7 URL: https://github.com/llvm/llvm-project/commit/b63b4d89663c240a77675d233652dcc854a85bb7 DIFF: https://github.com/llvm/llvm-project/commit/b63b4d89663c240a77675d233652dcc854a85bb7.diff

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. In D131465#3804893 , @glandium wrote: > This didn't change the default for msvc targets, was that expected? I think it is expected (but I did not know when I made the change)

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. Will wait until EOD before committing this unless others have more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 ___

[clang] 52d7ce0 - [HLSL] Allow SV_GroupIndex for lib profile.

Author: Xiang Li Date: 2022-09-21T12:29:58-07:00 New Revision: 52d7ce0cc1a57123ee27a0bff0530f89cab99ab7 URL: https://github.com/llvm/llvm-project/commit/52d7ce0cc1a57123ee27a0bff0530f89cab99ab7 DIFF: https://github.com/llvm/llvm-project/commit/52d7ce0cc1a57123ee27a0bff0530f89cab99ab7.diff

[PATCH] D134326: [HLSL] Allow SV_GroupIndex for lib profile.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52d7ce0cc1a5: [HLSL] Allow SV_GroupIndex for lib profile. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

awarzynski added a comment. I've skimmed through - these fixes make sense to me. Thank you for the quick summary! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 461979. mitchell-stellar added a comment. Do not limit columns and added nested test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134207/new/ https://reviews.llvm.org/D134207

[PATCH] D88299: [clang-format] Add MacroUnexpander.

owenpan added a comment. @klimek np! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d621398626a: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3534 + nextToken(); + assert(FormatTok->is(tok::l_paren)); parseParens(); Redundant as it's asserted at the start of `parseParens()` below? Repository: rG

[clang] 3d62139 - [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

Author: owenca Date: 2022-09-21T12:02:49-07:00 New Revision: 3d621398626a972313dfc8c22a7f124c2138f0f5 URL: https://github.com/llvm/llvm-project/commit/3d621398626a972313dfc8c22a7f124c2138f0f5 DIFF: https://github.com/llvm/llvm-project/commit/3d621398626a972313dfc8c22a7f124c2138f0f5.diff LOG:

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3805704 , @sstwcw wrote: > Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? I was going to take care of them after this patch. Thanks for asking though. Repository: rG LLVM Github

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5057 +if (FD->hasAttr()) + FDInlineName = FD->getAttr()->getLabel().str(); +else This is throwing away the ".inline" suffix? Is that intentional? CHANGES SINCE LAST ACTION

[clang] 1ae5310 - Changing some strange code into an assert; NFC

Author: Aaron Ballman Date: 2022-09-21T14:59:51-04:00 New Revision: 1ae5310ebbecadab52c1b7fc29596ac5b61795a3 URL: https://github.com/llvm/llvm-project/commit/1ae5310ebbecadab52c1b7fc29596ac5b61795a3 DIFF: https://github.com/llvm/llvm-project/commit/1ae5310ebbecadab52c1b7fc29596ac5b61795a3.diff

[PATCH] D134379: [clangd] IncludeCleaner: handle using namespace

sammccall added a comment. Is test.h meaningfully used in that example? Yes, the code is going to fail to compile without it, but it seems like the "spirit" of IWYU would say to delete both the include and the using directive. My concern about marking it used is that namespaces are typically

[clang] efd97c7 - [libclang] Fix -Wswitch after D129883

Author: Fangrui Song Date: 2022-09-21T11:55:14-07:00 New Revision: efd97c716b36ff266ffa1ec1b7a3c4a3f28917b9 URL: https://github.com/llvm/llvm-project/commit/efd97c716b36ff266ffa1ec1b7a3c4a3f28917b9 DIFF: https://github.com/llvm/llvm-project/commit/efd97c716b36ff266ffa1ec1b7a3c4a3f28917b9.diff

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

This revision was automatically updated to reflect the committed changes. Closed by commit rG069ecd0c6e2c: [ARM] Check target feature support for __builtin_arm_crc* (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/

[clang] 069ecd0 - [ARM] Check target feature support for __builtin_arm_crc*

Author: Fangrui Song Date: 2022-09-21T11:50:15-07:00 New Revision: 069ecd0c6e2c9d5c457159d7326f31cba174e47c URL: https://github.com/llvm/llvm-project/commit/069ecd0c6e2c9d5c457159d7326f31cba174e47c DIFF: https://github.com/llvm/llvm-project/commit/069ecd0c6e2c9d5c457159d7326f31cba174e47c.diff

[PATCH] D134379: [clangd] IncludeCleaner: handle using namespace

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kbobyrev. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461971. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay added a comment. In D134127#3805748 , @dmgreen wrote: > Whether you do that here or in another patch, the change LGTM. Thanks:) I'll learn more about arm_acle.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461970. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov updated this revision to Diff 461968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 461967. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files:

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 461966. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. It was a small battle to get the tests past the windows bots, but they eventually succeeded: https://lab.llvm.org/buildbot/#/builders/216/builds/10125 I pushed the following additional patches while trying to fix the tests for windows: -

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added a comment. In D129883#3806552 , @kazu wrote: > In D129883#3806507 , @python3kgae > wrote: > >> In D129883#3806393 , @kazu wrote: >> >>> This patch

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 461960. mgorny added a comment. Simplify getting driver mode — it turns out it's set for us already! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/include/clang/Driver/Driver.h

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D134337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621 ___ cfe-commits mailing

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

kazu added a comment. In D129883#3806507 , @python3kgae wrote: > In D129883#3806393 , @kazu wrote: > >> This patch seems to cause several warnings: >> >> clang/include/clang/AST/Decl.h:4696:15: error:

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

shafik added inline comments. Comment at: clang/test/Sema/c2x-auto.c:49 +auto b = 9; +auto c = a + b; + } aaron.ballman wrote: > to268 wrote: > > shafik wrote: > > > When I made the comment about the example from the proposal, this was > > > what I was

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added reviewers: sammccall, rjmccall, efriedma. aaron.ballman added a comment. In D133289#3784117 , @aaron.ballman wrote: > One thought that occurred to me is that the way C has this specified is > awfully effectively the same way

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

dblaikie added a comment. Looks pretty good to me - few things to clean up/simplify. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1331-1333 + if (isa(DC)) { +Flags = getAccessFlag(Ty->getDecl()->getAccess(), cast(DC)); + }

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz updated this revision to Diff 461955. barcisz added a comment. Tests for the utility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 Files: clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added a comment. In D129883#3806393 , @kazu wrote: > This patch seems to cause several warnings: > > clang/include/clang/AST/Decl.h:4696:15: error: 'getSourceRange' overrides a > member function but is not marked 'override'

[clang] a7e3de2 - [NFC] Fix build error ignored by MSVC.

Author: Xiang Li Date: 2022-09-21T10:57:43-07:00 New Revision: a7e3de2450f5b62e7dfe8999443f15be5dfec0b0 URL: https://github.com/llvm/llvm-project/commit/a7e3de2450f5b62e7dfe8999443f15be5dfec0b0 DIFF: https://github.com/llvm/llvm-project/commit/a7e3de2450f5b62e7dfe8999443f15be5dfec0b0.diff

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. First, for the mechanical part of the change, this code implement multiple constructors:   Info() = default;   Info(InfoType IT) : IT(IT) {}   Info(InfoType IT, SymbolID USR) : USR(USR), IT(IT) {}   Info(InfoType IT, SymbolID USR,

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. > but in AArch64TargetParser.def, marking them v8.6 brings in support for the > SM4 cryptographic hash and we don't actually have that Huh, I don't understand why, does that ring a bell? Looks like

[PATCH] D133371: [clang-tidy][WIP] create API for extracting option types.

njames93 updated this revision to Diff 461950. njames93 added a comment. Add a test to demonstraight behaviour Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133371/new/ https://reviews.llvm.org/D133371 Files:

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

ab added inline comments. Herald added a subscriber: StephenFan. Herald added a project: All. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:52 + AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | + AArch64::AEK_SM4 |

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:642 + +for (const auto *Init : Ctor->inits()) { + const FieldDecl *Member = Init->getMember(); aaron.ballman wrote: > Do we

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added a comment. In D129883#3806393 , @kazu wrote: > This patch seems to cause several warnings: > > clang/include/clang/AST/Decl.h:4696:15: error: 'getSourceRange' overrides a > member function but is not marked 'override'

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

Izaron updated this revision to Diff 461942. Izaron added a comment. Add helper method `DiagnoseLabelAtEndOfCompoundStatement` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134207/new/ https://reviews.llvm.org/D134207 Files:

  1   2   3   >