[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + VisitorData *Data = (VisitorData *)d; PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]", anderslanglands wrote:

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

courbet added a subscriber: titeup. courbet added a comment. In D97854#3944804 , @olologin wrote: > @courbet > Hi, sorry for pinging you. > Is this review stalled? Is there a reason for this? Judging by paper this > sanitizer looks promising. I was

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477393. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

xen0n added a comment. otherwise LGTM Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added a comment. Re the whitespace - yeah that's me running clang-format on the whole function rather than just the lines I changed. I'll see if I can split those out. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); +

[clang] 16bf359 - Add MC support of RISCV Zcf Extension

Author: WuXinlong Date: 2022-11-23T15:09:02+08:00 New Revision: 16bf359a3faa2456947a9d78266b11359a3c5ec6 URL: https://github.com/llvm/llvm-project/commit/16bf359a3faa2456947a9d78266b11359a3c5ec6 DIFF: https://github.com/llvm/llvm-project/commit/16bf359a3faa2456947a9d78266b11359a3c5ec6.diff

[PATCH] D134176: Add MC support of RISCV Zcf Extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG16bf359a3faa: Add MC support of RISCV Zcf Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

smeenai added a comment. We're seeing a CMake error after this: CMake Error at /data/users/smeenai/Source/tcdev/external/llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:368 (add_library): Error evaluating generator expression: $ Objects of target

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

thevinster added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" Were you planning to

[libclc] b264787 - libclc: Use cmake files instead of llvm-config

Author: Tom Stellard Date: 2022-11-22T22:57:46-08:00 New Revision: b264787453fd93e55154b98d18739ecb383d9b4c URL: https://github.com/llvm/llvm-project/commit/b264787453fd93e55154b98d18739ecb383d9b4c DIFF: https://github.com/llvm/llvm-project/commit/b264787453fd93e55154b98d18739ecb383d9b4c.diff

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477382. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w:

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added a comment. In D134859#3943926 , @tbaeder wrote: > FYI, I noticed the way the floating values are serialized doesn't work if the > `APFloat` heap-allocated anything; those values aren't preserved through > (de)serialization of course. >

[PATCH] D138520: [clangd] Make decision forest model optional

thesamesam added a comment. Works on PPC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

qiucf updated this revision to Diff 477375. qiucf added a comment. Change error message regarding `__float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138105/new/ https://reviews.llvm.org/D138105 Files:

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

ChuanqiXu added a comment. In D137770#3945095 , @spartacoos wrote: > Hi @nridge @ChuanqiXu, I've been dealing with some issues trying to get > modules working with clangd only to end up hacking some flimsy solutions > which inevitably breakdown under

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. Ping.. Do we still prefer to specify target triple explicitly to make a check? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___ cfe-commits mailing list

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth reopened this revision. paulkirth added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-doc/single-file-public.cpp:9 +// for a name with a 40-char USR name. +// RUN: find %t -regex

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477363. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay marked an inline comment as done. MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 ___ cfe-commits mailing list

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling added a comment. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1513 + + register int res __asm__("$a0"); + register int __flags __asm__("$a0") = flags; SixWeining wrote: > I'm not sure if this is necessary. Maybe `int res;` is

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

koakuma added a comment. In D138532#3945422 , @MaskRay wrote: > I think we usually follow GCC instead of other targets. GCC enables it by default too, for example see https://godbolt.org/z/brPMKnM17 (That link also has comparison with clang with

[PATCH] D138489: [tsan] Add tsan support for loongarch64

MaskRay added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:269 val = FIRST_32_SECOND_64(1152, 1776); +#elif SANITIZER_LOONGARCH64 + val = 1936; We should add new code in this fallback function. The generic code

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG987b49395c60: [PPC] Undefine __ppc64__ to match GCC (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D137511?vs=473543=477348#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] 987b493 - [PPC] Undefine __ppc64__ to match GCC

Author: Fangrui Song Date: 2022-11-22T17:01:39-08:00 New Revision: 987b49395c604c794bee4439af4d3a47b4b58276 URL: https://github.com/llvm/llvm-project/commit/987b49395c604c794bee4439af4d3a47b4b58276 DIFF: https://github.com/llvm/llvm-project/commit/987b49395c604c794bee4439af4d3a47b4b58276.diff

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

MaskRay added a comment. > Enable frame pointer optimization by default to match it with other targets. I think we usually follow GCC instead of other targets. I am unfamiliar with sparc. Can you show an example where `-fomit-frame-pointer`/`-fno-omit-frame-pointer` demonstrate a codegen

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks so much for fixing up the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137511/new/

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added a comment. In D137217#3945366 , @glandium wrote: > Almost there, but not quite: > > [task 2022-11-22T23:55:36.341Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: > error: no matching function for call to

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

koakuma created this revision. koakuma added reviewers: arsenm, MaskRay, brad, dcederman. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. koakuma requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Almost there, but not quite: [task 2022-11-22T23:55:36.341Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: error: no matching function for call to object of type '(lambda at

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8efcb96e6db: [AVR][Clang] Implement __AVR_HAVE_*__ macros (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a8efcb9 - [AVR][Clang] Implement __AVR_HAVE_*__ macros

Author: Ayke van Laethem Date: 2022-11-23T01:21:09+01:00 New Revision: a8efcb96e6db91d1bcc5e56e08814330dbdbfccb URL: https://github.com/llvm/llvm-project/commit/a8efcb96e6db91d1bcc5e56e08814330dbdbfccb DIFF:

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

rnk added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) This is too narrow, there are lots

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:727 + if (signature.isInstanceMethod()) +opts |= static_cast(FnInfoOpts::IsInstanceMethod); + if (signature.isChainCall()) We could avoid static_cast by defining the standard flag

[clang] cf624b2 - [SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes

Author: Roman Lebedev Date: 2022-11-23T02:38:25+03:00 New Revision: cf624b23bc5d5a6161706d1663def49380ff816a URL: https://github.com/llvm/llvm-project/commit/cf624b23bc5d5a6161706d1663def49380ff816a DIFF: https://github.com/llvm/llvm-project/commit/cf624b23bc5d5a6161706d1663def49380ff816a.diff

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3945136 , @glandium wrote: > Still broken: > > task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ > --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS

[PATCH] D135411: Add generic KCFI operand bundle lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rGcacd3e73d7f8: Add generic KCFI operand bundle lowering (authored by samitolvanen). Changed prior to commit: https://reviews.llvm.org/D135411?vs=476615=477315#toc Repository: rG LLVM Github Monorepo

[clang] cacd3e7 - Add generic KCFI operand bundle lowering

Author: Sami Tolvanen Date: 2022-11-22T23:01:18Z New Revision: cacd3e73d7f87ef3593443271ab3f170d0360934 URL: https://github.com/llvm/llvm-project/commit/cacd3e73d7f87ef3593443271ab3f170d0360934 DIFF: https://github.com/llvm/llvm-project/commit/cacd3e73d7f87ef3593443271ab3f170d0360934.diff

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477312. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Teach CodeGen to squash contiguous top-level stmt decl blocks into a single `llvm::Function`. Rebase. CHANGES SINCE LAST ACTION

[PATCH] D134176: Add MC support of RISCV Zcf Extension

VincentWu updated this revision to Diff 477307. VincentWu added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://reviews.llvm.org/D134176 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Still broken: task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/gold

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

spartacoos added a comment. Hi @nridge @ChuanqiXu, I've been dealing with some issues trying to get modules working with clangd only to end up hacking some flimsy solutions which inevitably breakdown under some edge cases, those problems led me to this thread

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:975 // done on PreLink stage. -if (!IsThinLTOPostLink) +if (!IsThinLTOPostLink) { addSanitizers(TargetTriple, CodeGenOpts, LangOpts, PB);

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

daltenty added a comment. In D130327#3944591 , @vsapsai wrote: > In D130327#3944188 , @NancyWang > wrote: > >> @vsapsai hi Volodymyr Sapsai , test case >> clang/test/Modules/hidden-duplicates.m is failing

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 requested changes to this revision. Skylion007 added a comment. This revision now requires changes to proceed. Typo Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:227 + + auto const IsMoveAssingable = cxxOperatorCallExpr( +

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

akhuang updated this revision to Diff 477289. akhuang marked 4 inline comments as done. akhuang added a comment. add to test case, modify name mangling, change fn info opts enum type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

bd1976llvm added a comment. In D138463#3944124 , @compnerd wrote: > The change itself seems fine, but the CI failure seems related to this change. Thanks. There's been renewed interest in using DLLs with C++ interfaces so we should, hopefully, be able

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3944952 , @glandium wrote: > This broke the gold plugin: > > [task 2022-11-22T21:03:29.486Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: > error: no matching function for call to

[clang] 84be92d - Reland "[LTO][COFF] Use bitcode file names in lto native object file names."

Author: Zequan Wu Date: 2022-11-22T13:46:42-08:00 New Revision: 84be92d26fcb1ddad533c0c614a79a81c59f795d URL: https://github.com/llvm/llvm-project/commit/84be92d26fcb1ddad533c0c614a79a81c59f795d DIFF: https://github.com/llvm/llvm-project/commit/84be92d26fcb1ddad533c0c614a79a81c59f795d.diff

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

bd1976llvm updated this revision to Diff 477287. bd1976llvm edited the summary of this revision. bd1976llvm added a comment. Fix for test failure on *nix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138463/new/ https://reviews.llvm.org/D138463 Files:

[clang] 3410808 - Revert "Reland "[LTO][COFF] Use bitcode file names in lto native object file names.""

Author: Roman Lebedev Date: 2022-11-23T00:40:12+03:00 New Revision: 34108082947c964ae9bbfcd9808f2fd31c0d672f URL: https://github.com/llvm/llvm-project/commit/34108082947c964ae9bbfcd9808f2fd31c0d672f DIFF: https://github.com/llvm/llvm-project/commit/34108082947c964ae9bbfcd9808f2fd31c0d672f.diff

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. This broke the gold plugin: [task 2022-11-22T21:03:29.486Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: error: no matching function for call to 'localCache' [task 2022-11-22T21:03:29.486Z] Cache = check(localCache("ThinLTO",

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added a comment. @thesamesam, could you test it on PPC32, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny created this revision. mgorny added reviewers: thesamesam, sammccall, thakis, MaskRay. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project:

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

MaskRay added a comment. Hi @nemanjai , I think there is no relevant `__ppc64__` in llvm-project now. (The libc++ change has landed and `third_party/benchmark` has a non-interesting use as that code has `defined(__powerpc64__)` as well). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b888caf - XFAIL hidden-duplicates.m for AIX and zOS

Author: Nancy Wang Date: 2022-11-22T16:26:06-05:00 New Revision: b888cafcbc0a16f68bc0ebea495920b952290ea2 URL: https://github.com/llvm/llvm-project/commit/b888cafcbc0a16f68bc0ebea495920b952290ea2 DIFF: https://github.com/llvm/llvm-project/commit/b888cafcbc0a16f68bc0ebea495920b952290ea2.diff

[PATCH] D137343: [clang] add -Wvla-stack-allocation

inclyc added a comment. We may need a release note here so users know about the new changes to -Wvla. See `clang/docs/ReleaseNotes.rst`! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 﫢

stephanemoore added a comment. The false positives from this check are causing some disruption for XCTest framework users after some changes that we believe happened in Xcode 14. It would be nice if we could land some form of fix soon. I am happy to discuss options and iterate as needed.

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ec79afd8993: [Sema] check InitListExpr format strings like {foo} (authored by inclyc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2ec79af - [Sema] check InitListExpr format strings like {"foo"}

Author: Yingchi Long Date: 2022-11-23T04:58:19+08:00 New Revision: 2ec79afd89932f0d5a9c44050e7b6dc08ff51699 URL: https://github.com/llvm/llvm-project/commit/2ec79afd89932f0d5a9c44050e7b6dc08ff51699 DIFF: https://github.com/llvm/llvm-project/commit/2ec79afd89932f0d5a9c44050e7b6dc08ff51699.diff

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc updated this revision to Diff 477279. inclyc added a comment. Address comments - add a test to coverage warnings if appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137839/new/ https://reviews.llvm.org/D137839 Files:

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D137839#3944574 , @inclyc wrote: > Do we need release notes here? This patch is just an improvement to >

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab1a5991fe76: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES

[clang] ab1a599 - Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

Author: Mitch Phillips Date: 2022-11-22T12:08:30-08:00 New Revision: ab1a5991fe765d71c0f3262f25726d6b4d66a545 URL: https://github.com/llvm/llvm-project/commit/ab1a5991fe765d71c0f3262f25726d6b4d66a545 DIFF:

[PATCH] D137942: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)

sgraenitz added a comment. The Buildbot has detected a failed build on builder sanitizer-aarch64-linux-bootstrap-ubsan while building clang,compiler-rt. I will investigate tomorrow and reverted the change in the meantime. Full error output: TEST 'Clang ::

[clang] a37807a - Revert "[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)"

Author: Stefan Gränitz Date: 2022-11-22T20:51:09+01:00 New Revision: a37807ac8a3e9d2880a483940dcd33194f354bf8 URL: https://github.com/llvm/llvm-project/commit/a37807ac8a3e9d2880a483940dcd33194f354bf8 DIFF:

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

olologin added a comment. @courbet Hi, sorry for pinging you. Is this review stalled? Judging by paper this sanitizer looks promising. I was recently planning to try out NSAN on huge codebase. Is there anything wrong with this review? Just curious. Maybe I could help with something but I doubt

[PATCH] D138426: Fix #58958 on github

krsch added a comment. Please commit it yourself as I don't have a commit access. This is my first patch here. In D138426#3944472 , @dblaikie wrote: > Do you need me to commit this for you, or can you commit it yourself? Repository: rG LLVM Github

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Relanded here to match api changes at https://reviews.llvm.org/D135590 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/

[clang] 387620a - Reland "[LTO][COFF] Use bitcode file names in lto native object file names."

Author: Zequan Wu Date: 2022-11-22T11:26:18-08:00 New Revision: 387620aa8cea33174b6c1fb80c1af713fee732ac URL: https://github.com/llvm/llvm-project/commit/387620aa8cea33174b6c1fb80c1af713fee732ac DIFF: https://github.com/llvm/llvm-project/commit/387620aa8cea33174b6c1fb80c1af713fee732ac.diff

[PATCH] D138073: [clang-doc] Move file layout to the generators.

thakis added a comment. In D138073#3944730 , @paulkirth wrote: > @thakis thanks for the report. I've reverted for now. @brettw can you take a > look? I'm a bit surprised that passed on the Linux and windows bot, but > failed on Mac. Probably a BSD

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. @thakis thanks for the report. I've reverted for now. @brettw can you take a look? I'm a bit surprised that passed on the Linux and windows bot, but failed on Mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 48bb147 - Revert "[clang-doc] Move file layout to the generators."

Author: Paul Kirth Date: 2022-11-22T19:14:54Z New Revision: 48bb1471122d156bc0c4feaabc32de4487024ca5 URL: https://github.com/llvm/llvm-project/commit/48bb1471122d156bc0c4feaabc32de4487024ca5 DIFF: https://github.com/llvm/llvm-project/commit/48bb1471122d156bc0c4feaabc32de4487024ca5.diff LOG:

[PATCH] D138073: [clang-doc] Move file layout to the generators.

thakis added a comment. This breaks tests on mac: http://45.33.8.238/macm1/49211/step_8.txt (and possibly win; that's still cycling.) Please take a look and revert for now if it takes a while to fix. (Also,  Mr W!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. The itanium ABI represents the PMF as a pair of pointers. As such the structure cannot be passed through a single

[clang] eef5405 - Revert "[LTO][COFF] Use bitcode file names in lto native object file names."

Author: Zequan Wu Date: 2022-11-22T10:55:05-08:00 New Revision: eef5405f74ae208e3e2eb7daacecac923d7338f2 URL: https://github.com/llvm/llvm-project/commit/eef5405f74ae208e3e2eb7daacecac923d7338f2 DIFF: https://github.com/llvm/llvm-project/commit/eef5405f74ae208e3e2eb7daacecac923d7338f2.diff

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

Fznamznon added a comment. In D137044#3944010 , @jonpa wrote: > In D137044#3943829 , @Fznamznon > wrote: > >> In D137044#3943680 , @jonpa wrote: >> >>> In

[clang] 0ffcd24 - [Driver][Test] Fix pic.c when CLANG_DEFAULT_PIE_ON_LINUX set to OFF

Author: Mariya Podchishchaeva Date: 2022-11-22T13:38:18-05:00 New Revision: 0ffcd243a42bff13966e455582d2db6c337628a2 URL: https://github.com/llvm/llvm-project/commit/0ffcd243a42bff13966e455582d2db6c337628a2 DIFF:

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. In D130327#3944188 , @NancyWang wrote: > @vsapsai hi Volodymyr Sapsai , test case > clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX > box >

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm added a comment. In D138473#3944586 , @yaxunl wrote: > Are you sure these functions are equivalent? we do not have a comprehensive > test for these functions regarding accuracy. These are ultimately simple bit extracts. The library

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

thakis added a comment. This doesn't build: http://45.33.8.238/win/70474/step_4.txt http://45.33.8.238/linux/92146/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

yaxunl added a comment. Are you sure these functions are equivalent? we do not have a comprehensive test for these functions regarding accuracy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473 ___

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a469fc5727: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[clang-tools-extra] f8a469f - [clang-doc] Move file layout to the generators.

Author: Brett Wilson Date: 2022-11-22T10:27:29-08:00 New Revision: f8a469fc572778d05b72f34a772082cf3abd3cda URL: https://github.com/llvm/llvm-project/commit/f8a469fc572778d05b72f34a772082cf3abd3cda DIFF: https://github.com/llvm/llvm-project/commit/f8a469fc572778d05b72f34a772082cf3abd3cda.diff

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc added a comment. Do we need release notes here? This patch is just an improvement to https://reviews.llvm.org/D130906 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137839/new/ https://reviews.llvm.org/D137839

[PATCH] D138458: [Clang][Driver] Add KCFI to SupportsCoverage

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a3d6ce956c4: [Clang][Driver] Add KCFI to SupportsCoverage (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138458/new/

[clang] 5a3d6ce - [Clang][Driver] Add KCFI to SupportsCoverage

Author: Sami Tolvanen Date: 2022-11-22T18:20:04Z New Revision: 5a3d6ce956c44384920557b455b4db2bb0ab2fad URL: https://github.com/llvm/llvm-project/commit/5a3d6ce956c44384920557b455b4db2bb0ab2fad DIFF: https://github.com/llvm/llvm-project/commit/5a3d6ce956c44384920557b455b4db2bb0ab2fad.diff

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG531ed6d5aa65: [LTO][COFF] Use bitcode file names in lto native object file names. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D137217?vs=477014=477246#toc Repository:

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin created this revision. yronglin added reviewers: rjmccall, asl, efriedma. Herald added a subscriber: kristof.beyls. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. please make the title of the commit say what the commit is actually doing rather than only reference a bug number, the bug number should be in the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 477241. francii added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/ZOS.cpp

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:962-963 + } else if (const auto *Ctor = dyn_cast(Initializer)) { +const ArrayType *AT = Ctor->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems =

[PATCH] D138394: HIP: Directly call fma builtins

arsenm updated this revision to Diff 477238. arsenm added a comment. Catch another hidden in another header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138394/new/ https://reviews.llvm.org/D138394 Files: clang/lib/Headers/__clang_hip_cmath.h clang/lib/Headers/__clang_hip_math.h

[PATCH] D138509: clang/HIP: Add another math header test

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield, b-sumner. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This needs more exhaustive checks for the other things here; for now just test the ones directly calling

[clang] b805853 - [Hexagon] Make local array static in getIntrinsicForHexagonNonClangBuiltin

Author: Krzysztof Parzyszek Date: 2022-11-22T09:48:01-08:00 New Revision: b805853ccb4785811c04f27862a77eb9c8c286f7 URL: https://github.com/llvm/llvm-project/commit/b805853ccb4785811c04f27862a77eb9c8c286f7 DIFF:

[PATCH] D138426: Fix #58958 on github

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Do you need me to commit this for you, or can you commit it yourself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >